pr-manager-helper: fix memory leak on event

[Qemu-devel] [PATCH] pr-manager-helper: fix memory leak on event

Paolo Bonzini posted 1 patch 7 years, 4 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180704120412.19020-1-pbonzini@redhat.com

Test checkpatch passed

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

Test s390x failed

scsi/pr-manager-helper.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[Qemu-devel] [PATCH] pr-manager-helper: fix memory leak on event

Posted by Paolo Bonzini 7 years, 4 months ago

Reported by Coverity.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 scsi/pr-manager-helper.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scsi/pr-manager-helper.c b/scsi/pr-manager-helper.c
index 519a296905..3027dde60d 100644
--- a/scsi/pr-manager-helper.c
+++ b/scsi/pr-manager-helper.c
@@ -46,6 +46,7 @@ static void pr_manager_send_status_changed_event(PRManagerHelper *pr_mgr)
     if (id) {
         qapi_event_send_pr_manager_status_changed(id, !!pr_mgr->ioc,
                                                   &error_abort);
+        g_free(id);
     }
 }
 
-- 
2.17.1

Re: [Qemu-devel] [PATCH] pr-manager-helper: fix memory leak on event

Posted by Philippe Mathieu-Daudé 7 years, 4 months ago

On 07/04/2018 09:04 AM, Paolo Bonzini wrote:
> Reported by Coverity.
> 

Fixes: Coverity CID 1393785 (Resource leak)

> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  scsi/pr-manager-helper.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scsi/pr-manager-helper.c b/scsi/pr-manager-helper.c
> index 519a296905..3027dde60d 100644
> --- a/scsi/pr-manager-helper.c
> +++ b/scsi/pr-manager-helper.c
> @@ -46,6 +46,7 @@ static void pr_manager_send_status_changed_event(PRManagerHelper *pr_mgr)
>      if (id) {
>          qapi_event_send_pr_manager_status_changed(id, !!pr_mgr->ioc,
>                                                    &error_abort);
> +        g_free(id);
>      }
>  }
>  
>