qmp: Fixes and cleanups around OOB commands

[Qemu-devel] [PATCH 27/32] qmp: Add some comments around null responses

Posted by Markus Armbruster 7 years, 7 months ago

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 qapi/qmp-dispatch.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
index 761812e924..6f2d466596 100644
--- a/qapi/qmp-dispatch.c
+++ b/qapi/qmp-dispatch.c
@@ -133,6 +133,7 @@ static QObject *do_qmp_dispatch(QmpCommandList *cmds, QObject *request,
     } else if (cmd->options & QCO_NO_SUCCESS_RESP) {
         g_assert(!ret);
     } else if (!ret) {
+        /* TODO turn into assertion */
         ret = QOBJECT(qdict_new());
     }
 
@@ -176,6 +177,7 @@ QDict *qmp_dispatch(QmpCommandList *cmds, QObject *request,
         rsp = qdict_new();
         qdict_put_obj(rsp, "return", ret);
     } else {
+        /* Can only happen for commands with QCO_NO_SUCCESS_RESP */
         rsp = NULL;
     }
 
-- 
2.17.1

Re: [Qemu-devel] [PATCH 27/32] qmp: Add some comments around null responses

Posted by Eric Blake 7 years, 7 months ago

On 07/02/2018 11:22 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   qapi/qmp-dispatch.c | 2 ++
>   1 file changed, 2 insertions(+)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

> diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
> index 761812e924..6f2d466596 100644
> --- a/qapi/qmp-dispatch.c
> +++ b/qapi/qmp-dispatch.c
> @@ -133,6 +133,7 @@ static QObject *do_qmp_dispatch(QmpCommandList *cmds, QObject *request,
>       } else if (cmd->options & QCO_NO_SUCCESS_RESP) {
>           g_assert(!ret);
>       } else if (!ret) {
> +        /* TODO turn into assertion */
>           ret = QOBJECT(qdict_new());
>       }
>   
> @@ -176,6 +177,7 @@ QDict *qmp_dispatch(QmpCommandList *cmds, QObject *request,
>           rsp = qdict_new();
>           qdict_put_obj(rsp, "return", ret);
>       } else {
> +        /* Can only happen for commands with QCO_NO_SUCCESS_RESP */
>           rsp = NULL;
>       }
>   
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org