block/qcow2.h | 1 - include/block/dirty-bitmap.h | 2 +- block.c | 11 ++++-- block/dirty-bitmap.c | 36 +++++++----------- block/qcow2-bitmap.c | 16 ++++++++ block/qcow2.c | 86 ++++++++++++++++++++++++++++++++---------- migration/block-dirty-bitmap.c | 10 ++++- tests/qemu-iotests/169 | 70 +++++++++++++++++++++++++++++++++- tests/qemu-iotests/169.out | 4 +- 9 files changed, 182 insertions(+), 54 deletions(-)
Hi all. To continue talk about correct loading of persistent bitmaps here is a patch (04), with some surrounding. Patch 04 contains new (and I hope, more clean) logic of bitmaps loading/inactivation/invalidation/migration, with the whole description. Let me not duplicate it here, you can safely start reading from 04 commit message and internal big comment. Vladimir Sementsov-Ogievskiy (6): iotests: 169: drop deprecated 'autoload' parameter block/qcow2: improve error message in qcow2_inactivate bloc/qcow2: drop dirty_bitmaps_loaded state variable dirty-bitmaps: clean-up bitmaps loading and migration logic iotests: improve 169 iotests: 169: add cases for source vm resuming block/qcow2.h | 1 - include/block/dirty-bitmap.h | 2 +- block.c | 11 ++++-- block/dirty-bitmap.c | 36 +++++++----------- block/qcow2-bitmap.c | 16 ++++++++ block/qcow2.c | 86 ++++++++++++++++++++++++++++++++---------- migration/block-dirty-bitmap.c | 10 ++++- tests/qemu-iotests/169 | 70 +++++++++++++++++++++++++++++++++- tests/qemu-iotests/169.out | 4 +- 9 files changed, 182 insertions(+), 54 deletions(-) -- 2.11.1
On 06/26/2018 09:50 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi all. > > To continue talk about correct loading of persistent bitmaps here is > a patch (04), with some surrounding. > > Patch 04 contains new (and I hope, more clean) logic of bitmaps > loading/inactivation/invalidation/migration, with the whole description. > Let me not duplicate it here, you can safely start reading from 04 > commit message and internal big comment. > > Vladimir Sementsov-Ogievskiy (6): > iotests: 169: drop deprecated 'autoload' parameter > block/qcow2: improve error message in qcow2_inactivate > bloc/qcow2: drop dirty_bitmaps_loaded state variable > dirty-bitmaps: clean-up bitmaps loading and migration logic > iotests: improve 169 > iotests: 169: add cases for source vm resuming > > block/qcow2.h | 1 - > include/block/dirty-bitmap.h | 2 +- > block.c | 11 ++++-- > block/dirty-bitmap.c | 36 +++++++----------- > block/qcow2-bitmap.c | 16 ++++++++ > block/qcow2.c | 86 ++++++++++++++++++++++++++++++++---------- > migration/block-dirty-bitmap.c | 10 ++++- > tests/qemu-iotests/169 | 70 +++++++++++++++++++++++++++++++++- > tests/qemu-iotests/169.out | 4 +- > 9 files changed, 182 insertions(+), 54 deletions(-) > Does this effectively supersede "[PATCH] block/qcow2: fix logic around dirty_bitmaps_loaded"? (I'll review it in just a moment, regardless, but I'm trying to keep my notes tidy.) --js
26.06.2018 21:22, John Snow wrote: > > On 06/26/2018 09:50 AM, Vladimir Sementsov-Ogievskiy wrote: >> Hi all. >> >> To continue talk about correct loading of persistent bitmaps here is >> a patch (04), with some surrounding. >> >> Patch 04 contains new (and I hope, more clean) logic of bitmaps >> loading/inactivation/invalidation/migration, with the whole description. >> Let me not duplicate it here, you can safely start reading from 04 >> commit message and internal big comment. >> >> Vladimir Sementsov-Ogievskiy (6): >> iotests: 169: drop deprecated 'autoload' parameter >> block/qcow2: improve error message in qcow2_inactivate >> bloc/qcow2: drop dirty_bitmaps_loaded state variable >> dirty-bitmaps: clean-up bitmaps loading and migration logic >> iotests: improve 169 >> iotests: 169: add cases for source vm resuming >> >> block/qcow2.h | 1 - >> include/block/dirty-bitmap.h | 2 +- >> block.c | 11 ++++-- >> block/dirty-bitmap.c | 36 +++++++----------- >> block/qcow2-bitmap.c | 16 ++++++++ >> block/qcow2.c | 86 ++++++++++++++++++++++++++++++++---------- >> migration/block-dirty-bitmap.c | 10 ++++- >> tests/qemu-iotests/169 | 70 +++++++++++++++++++++++++++++++++- >> tests/qemu-iotests/169.out | 4 +- >> 9 files changed, 182 insertions(+), 54 deletions(-) >> > > Does this effectively supersede "[PATCH] block/qcow2: fix logic around > dirty_bitmaps_loaded"? > > (I'll review it in just a moment, regardless, but I'm trying to keep my > notes tidy.) > > --js Yes, "fix logic" should be dropped. -- Best regards, Vladimir
Hi, what about this? I'll be on vacation next two weeks. Best regards, Vladimir. ________________________________ От: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Отправлено: 26 июня 2018 г. 16:50:29 Кому: qemu-devel@nongnu.org; qemu-block@nongnu.org Копия: dgilbert@redhat.com; quintela@redhat.com; stefanha@redhat.com; jsnow@redhat.com; famz@redhat.com; mreitz@redhat.com; kwolf@redhat.com; Vladimir Sementsov-Ogievskiy; Denis Lunev Тема: [PATCH 0/6] fix persistent bitmaps migration logic Hi all. To continue talk about correct loading of persistent bitmaps here is a patch (04), with some surrounding. Patch 04 contains new (and I hope, more clean) logic of bitmaps loading/inactivation/invalidation/migration, with the whole description. Let me not duplicate it here, you can safely start reading from 04 commit message and internal big comment. Vladimir Sementsov-Ogievskiy (6): iotests: 169: drop deprecated 'autoload' parameter block/qcow2: improve error message in qcow2_inactivate bloc/qcow2: drop dirty_bitmaps_loaded state variable dirty-bitmaps: clean-up bitmaps loading and migration logic iotests: improve 169 iotests: 169: add cases for source vm resuming block/qcow2.h | 1 - include/block/dirty-bitmap.h | 2 +- block.c | 11 ++++-- block/dirty-bitmap.c | 36 +++++++----------- block/qcow2-bitmap.c | 16 ++++++++ block/qcow2.c | 86 ++++++++++++++++++++++++++++++++---------- migration/block-dirty-bitmap.c | 10 ++++- tests/qemu-iotests/169 | 70 +++++++++++++++++++++++++++++++++- tests/qemu-iotests/169.out | 4 +- 9 files changed, 182 insertions(+), 54 deletions(-) -- 2.11.1
On 07/12/2018 03:00 PM, Vladimir Sementsov-Ogievskiy wrote: > Hi, what about this? > I'll be on vacation next two weeks. > Best regards, Vladimir. By the end of today. If there are fixes necessary I will take over the series if necessary so you can enjoy your vacation, if that's OK with you? --js > ------------------------------------------------------------------------ > *От:* Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> > *Отправлено:* 26 июня 2018 г. 16:50:29 > *Кому:* qemu-devel@nongnu.org; qemu-block@nongnu.org > *Копия:* dgilbert@redhat.com; quintela@redhat.com; stefanha@redhat.com; > jsnow@redhat.com; famz@redhat.com; mreitz@redhat.com; kwolf@redhat.com; > Vladimir Sementsov-Ogievskiy; Denis Lunev > *Тема:* [PATCH 0/6] fix persistent bitmaps migration logic > > Hi all. > > To continue talk about correct loading of persistent bitmaps here is > a patch (04), with some surrounding. > > Patch 04 contains new (and I hope, more clean) logic of bitmaps > loading/inactivation/invalidation/migration, with the whole description. > Let me not duplicate it here, you can safely start reading from 04 > commit message and internal big comment. > > Vladimir Sementsov-Ogievskiy (6): > iotests: 169: drop deprecated 'autoload' parameter > block/qcow2: improve error message in qcow2_inactivate > bloc/qcow2: drop dirty_bitmaps_loaded state variable > dirty-bitmaps: clean-up bitmaps loading and migration logic > iotests: improve 169 > iotests: 169: add cases for source vm resuming > > block/qcow2.h | 1 - > include/block/dirty-bitmap.h | 2 +- > block.c | 11 ++++-- > block/dirty-bitmap.c | 36 +++++++----------- > block/qcow2-bitmap.c | 16 ++++++++ > block/qcow2.c | 86 > ++++++++++++++++++++++++++++++++---------- > migration/block-dirty-bitmap.c | 10 ++++- > tests/qemu-iotests/169 | 70 +++++++++++++++++++++++++++++++++- > tests/qemu-iotests/169.out | 4 +- > 9 files changed, 182 insertions(+), 54 deletions(-) > > -- > 2.11.1 >
12.07.2018 23:25, John Snow wrote: > > On 07/12/2018 03:00 PM, Vladimir Sementsov-Ogievskiy wrote: >> Hi, what about this? >> I'll be on vacation next two weeks. >> Best regards, Vladimir. > By the end of today. > > If there are fixes necessary I will take over the series if necessary so > you can enjoy your vacation, if that's OK with you? yes, I just mean that I can discuss it only on this week. Of course, you can discuss/fix/merge it without me, I hope my comments and commit messages are exhaustive. > > --js > >> ------------------------------------------------------------------------ >> *От:* Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> >> *Отправлено:* 26 июня 2018 г. 16:50:29 >> *Кому:* qemu-devel@nongnu.org; qemu-block@nongnu.org >> *Копия:* dgilbert@redhat.com; quintela@redhat.com; stefanha@redhat.com; >> jsnow@redhat.com; famz@redhat.com; mreitz@redhat.com; kwolf@redhat.com; >> Vladimir Sementsov-Ogievskiy; Denis Lunev >> *Тема:* [PATCH 0/6] fix persistent bitmaps migration logic >> >> Hi all. >> >> To continue talk about correct loading of persistent bitmaps here is >> a patch (04), with some surrounding. >> >> Patch 04 contains new (and I hope, more clean) logic of bitmaps >> loading/inactivation/invalidation/migration, with the whole description. >> Let me not duplicate it here, you can safely start reading from 04 >> commit message and internal big comment. >> >> Vladimir Sementsov-Ogievskiy (6): >> iotests: 169: drop deprecated 'autoload' parameter >> block/qcow2: improve error message in qcow2_inactivate >> bloc/qcow2: drop dirty_bitmaps_loaded state variable >> dirty-bitmaps: clean-up bitmaps loading and migration logic >> iotests: improve 169 >> iotests: 169: add cases for source vm resuming >> >> block/qcow2.h | 1 - >> include/block/dirty-bitmap.h | 2 +- >> block.c | 11 ++++-- >> block/dirty-bitmap.c | 36 +++++++----------- >> block/qcow2-bitmap.c | 16 ++++++++ >> block/qcow2.c | 86 >> ++++++++++++++++++++++++++++++++---------- >> migration/block-dirty-bitmap.c | 10 ++++- >> tests/qemu-iotests/169 | 70 +++++++++++++++++++++++++++++++++- >> tests/qemu-iotests/169.out | 4 +- >> 9 files changed, 182 insertions(+), 54 deletions(-) >> >> -- >> 2.11.1 >> -- Best regards, Vladimir
On 06/26/2018 09:50 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi all. > > To continue talk about correct loading of persistent bitmaps here is > a patch (04), with some surrounding. > > Patch 04 contains new (and I hope, more clean) logic of bitmaps > loading/inactivation/invalidation/migration, with the whole description. > Let me not duplicate it here, you can safely start reading from 04 > commit message and internal big comment. > > Vladimir Sementsov-Ogievskiy (6): > iotests: 169: drop deprecated 'autoload' parameter > block/qcow2: improve error message in qcow2_inactivate > bloc/qcow2: drop dirty_bitmaps_loaded state variable > dirty-bitmaps: clean-up bitmaps loading and migration logic > iotests: improve 169 > iotests: 169: add cases for source vm resuming > > block/qcow2.h | 1 - > include/block/dirty-bitmap.h | 2 +- > block.c | 11 ++++-- > block/dirty-bitmap.c | 36 +++++++----------- > block/qcow2-bitmap.c | 16 ++++++++ > block/qcow2.c | 86 ++++++++++++++++++++++++++++++++---------- > migration/block-dirty-bitmap.c | 10 ++++- > tests/qemu-iotests/169 | 70 +++++++++++++++++++++++++++++++++- > tests/qemu-iotests/169.out | 4 +- > 9 files changed, 182 insertions(+), 54 deletions(-) > Does this effectively supersede "[PATCH] block/qcow2: fix logic around dirty_bitmaps_loaded"? (I'll review it in just a moment, regardless, but I'm trying to keep my notes tidy.) --js
© 2016 - 2025 Red Hat, Inc.