[Qemu-devel] [PATCH 0/2] dirty bitmap fixes

Vladimir Sementsov-Ogievskiy posted 2 patches 7 years, 4 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180625165745.25259-1-vsementsov@virtuozzo.com
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test s390x passed
include/block/dirty-bitmap.h   |  1 +
block/dirty-bitmap.c           | 12 +++++++++---
migration/block-dirty-bitmap.c |  4 ++--
3 files changed, 12 insertions(+), 5 deletions(-)
[Qemu-devel] [PATCH 0/2] dirty bitmap fixes
Posted by Vladimir Sementsov-Ogievskiy 7 years, 4 months ago
Vladimir Sementsov-Ogievskiy (2):
  block/dirty-bitmap: add bdrv_enable_dirty_bitmap_locked
  dirty-bitmap: fix double lock on bitmap enabling

 include/block/dirty-bitmap.h   |  1 +
 block/dirty-bitmap.c           | 12 +++++++++---
 migration/block-dirty-bitmap.c |  4 ++--
 3 files changed, 12 insertions(+), 5 deletions(-)

-- 
2.11.1


Re: [Qemu-devel] [PATCH 0/2] dirty bitmap fixes
Posted by John Snow 7 years, 4 months ago

On 06/25/2018 12:57 PM, Vladimir Sementsov-Ogievskiy wrote:
> Vladimir Sementsov-Ogievskiy (2):
>   block/dirty-bitmap: add bdrv_enable_dirty_bitmap_locked
>   dirty-bitmap: fix double lock on bitmap enabling
> 
>  include/block/dirty-bitmap.h   |  1 +
>  block/dirty-bitmap.c           | 12 +++++++++---
>  migration/block-dirty-bitmap.c |  4 ++--
>  3 files changed, 12 insertions(+), 5 deletions(-)
> 

ACK,

though it looks really odd that we've got enable/disable but only one
corresponding _locked version.

I have a patch somewhere in my local files to create a combined
_set_disabled() that would cut the number of functions we have by a
little bit.

I'll take this first though, as an iotest fix.

--js

Re: [Qemu-devel] [PATCH 0/2] dirty bitmap fixes
Posted by John Snow 7 years, 4 months ago

On 06/25/2018 12:57 PM, Vladimir Sementsov-Ogievskiy wrote:
> Vladimir Sementsov-Ogievskiy (2):
>   block/dirty-bitmap: add bdrv_enable_dirty_bitmap_locked
>   dirty-bitmap: fix double lock on bitmap enabling
> 
>  include/block/dirty-bitmap.h   |  1 +
>  block/dirty-bitmap.c           | 12 +++++++++---
>  migration/block-dirty-bitmap.c |  4 ++--
>  3 files changed, 12 insertions(+), 5 deletions(-)
> 

Thanks, applied to my bitmaps tree:

https://github.com/jnsnow/qemu/commits/bitmaps
https://github.com/jnsnow/qemu.git

--js