On 21.06.2018 20:02, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/i2c/omap_i2c.c | 23 +++++++++++++++--------
> 1 file changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/hw/i2c/omap_i2c.c b/hw/i2c/omap_i2c.c
> index 26e3e5ebf6..e6f34fe31f 100644
> --- a/hw/i2c/omap_i2c.c
> +++ b/hw/i2c/omap_i2c.c
> @@ -17,6 +17,7 @@
> * with this program; if not, see <http://www.gnu.org/licenses/>.
> */
> #include "qemu/osdep.h"
> +#include "qemu/log.h"
> #include "hw/hw.h"
> #include "hw/i2c/i2c.h"
> #include "hw/arm/omap.h"
> @@ -339,14 +340,17 @@ static void omap_i2c_write(void *opaque, hwaddr addr,
> }
> break;
> }
> - if ((value & (1 << 15)) && !(value & (1 << 10))) { /* MST */
> - fprintf(stderr, "%s: I^2C slave mode not supported\n",
> - __func__);
> + if ((value & (1 << 15)) && !(value & (1 << 10))) {
> + /* MST */
> + qemu_log_mask(LOG_UNIMP, "%s: I^2C slave mode not supported\n",
> + __func__);
> break;
> }
> - if ((value & (1 << 15)) && value & (1 << 8)) { /* XA */
> - fprintf(stderr, "%s: 10-bit addressing mode not supported\n",
> - __func__);
> + if ((value & (1 << 15)) && value & (1 << 8)) {
> + /* XA */
> + qemu_log_mask(LOG_UNIMP,
> + "%s: 10-bit addressing mode not supported\n",
> + __func__);
> break;
> }
> if ((value & (1 << 15)) && value & (1 << 0)) { /* STT */
> @@ -392,8 +396,11 @@ static void omap_i2c_write(void *opaque, hwaddr addr,
> s->stat |= 0x3f;
> omap_i2c_interrupts_update(s);
> }
> - if (value & (1 << 15)) /* ST_EN */
> - fprintf(stderr, "%s: System Test not supported\n", __func__);
> + if (value & (1 << 15)) {
> + /* ST_EN */
> + qemu_log_mask(LOG_UNIMP,
> + "%s: System Test not supported\n", __func__);
> + }
> break;
>
> default:
Could you please leave the comments at the end of the if-statement lines?
Thomas