[Qemu-devel] [PATCH 1/3] device-crash-test: No need for sys.path hack

Eduardo Habkost posted 3 patches 7 years, 7 months ago
[Qemu-devel] [PATCH 1/3] device-crash-test: No need for sys.path hack
Posted by Eduardo Habkost 7 years, 7 months ago
The device-crash-test script is already inside the 'scripts'
directory, there's no need to add the directory manually to
sys.path.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 scripts/device-crash-test | 1 -
 1 file changed, 1 deletion(-)

diff --git a/scripts/device-crash-test b/scripts/device-crash-test
index e6c233e9bf..52a2a613d4 100755
--- a/scripts/device-crash-test
+++ b/scripts/device-crash-test
@@ -35,7 +35,6 @@ import random
 import argparse
 from itertools import chain
 
-sys.path.append(os.path.join(os.path.dirname(__file__), '..', 'scripts'))
 from qemu import QEMUMachine
 
 logger = logging.getLogger('device-crash-test')
-- 
2.18.0.rc1.1.g3f1ff2140


Re: [Qemu-devel] [PATCH 1/3] device-crash-test: No need for sys.path hack
Posted by Daniel P. Berrangé 7 years, 7 months ago
On Mon, Jun 18, 2018 at 07:51:29PM -0300, Eduardo Habkost wrote:
> The device-crash-test script is already inside the 'scripts'
> directory, there's no need to add the directory manually to
> sys.path.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  scripts/device-crash-test | 1 -
>  1 file changed, 1 deletion(-)


Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|