1 | The following changes since commit 2ab09bf2f9f55b9fb8d2de6eb2ba2a8570e268e2: | 1 | The following changes since commit ca61fa4b803e5d0abaf6f1ceb690f23bb78a4def: |
---|---|---|---|
2 | 2 | ||
3 | Merge remote-tracking branch 'remotes/kraxel/tags/usb-20180612-pull-request' into staging (2018-06-12 15:34:34 +0100) | 3 | Merge remote-tracking branch 'remotes/quic/tags/pull-hex-20211006' into staging (2021-10-06 12:11:14 -0700) |
4 | 4 | ||
5 | are available in the git repository at: | 5 | are available in the Git repository at: |
6 | 6 | ||
7 | git://github.com/codyprime/qemu-kvm-jtc.git tags/block-pull-request | 7 | https://gitlab.com/stefanha/qemu.git tags/block-pull-request |
8 | 8 | ||
9 | for you to fetch changes up to b61acdecbf19c3c5a327baec1e8e4c06d0da68b7: | 9 | for you to fetch changes up to 1cc7eada97914f090125e588497986f6f7900514: |
10 | 10 | ||
11 | block: Ignore generated job QAPI files (2018-06-13 10:51:49 -0400) | 11 | iothread: use IOThreadParamInfo in iothread_[set|get]_param() (2021-10-07 15:29:50 +0100) |
12 | 12 | ||
13 | ---------------------------------------------------------------- | 13 | ---------------------------------------------------------------- |
14 | Block patch for .gitignore | 14 | Pull request |
15 | |||
15 | ---------------------------------------------------------------- | 16 | ---------------------------------------------------------------- |
16 | 17 | ||
17 | Eric Blake (1): | 18 | Stefano Garzarella (2): |
18 | block: Ignore generated job QAPI files | 19 | iothread: rename PollParamInfo to IOThreadParamInfo |
20 | iothread: use IOThreadParamInfo in iothread_[set|get]_param() | ||
19 | 21 | ||
20 | .gitignore | 4 ++++ | 22 | iothread.c | 28 +++++++++++++++------------- |
21 | 1 file changed, 4 insertions(+) | 23 | 1 file changed, 15 insertions(+), 13 deletions(-) |
22 | 24 | ||
23 | -- | 25 | -- |
24 | 2.13.6 | 26 | 2.31.1 |
25 | 27 | ||
26 | 28 | ||
29 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Stefano Garzarella <sgarzare@redhat.com> | ||
1 | 2 | ||
3 | Commit 1793ad0247 ("iothread: add aio-max-batch parameter") added | ||
4 | a new parameter (aio-max-batch) to IOThread and used PollParamInfo | ||
5 | structure to handle it. | ||
6 | |||
7 | Since it is not a parameter of the polling mechanism, we rename the | ||
8 | structure to a more generic IOThreadParamInfo. | ||
9 | |||
10 | Suggested-by: Kevin Wolf <kwolf@redhat.com> | ||
11 | Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> | ||
12 | Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> | ||
13 | Message-id: 20210727145936.147032-2-sgarzare@redhat.com | ||
14 | Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> | ||
15 | --- | ||
16 | iothread.c | 14 +++++++------- | ||
17 | 1 file changed, 7 insertions(+), 7 deletions(-) | ||
18 | |||
19 | diff --git a/iothread.c b/iothread.c | ||
20 | index XXXXXXX..XXXXXXX 100644 | ||
21 | --- a/iothread.c | ||
22 | +++ b/iothread.c | ||
23 | @@ -XXX,XX +XXX,XX @@ static void iothread_complete(UserCreatable *obj, Error **errp) | ||
24 | typedef struct { | ||
25 | const char *name; | ||
26 | ptrdiff_t offset; /* field's byte offset in IOThread struct */ | ||
27 | -} PollParamInfo; | ||
28 | +} IOThreadParamInfo; | ||
29 | |||
30 | -static PollParamInfo poll_max_ns_info = { | ||
31 | +static IOThreadParamInfo poll_max_ns_info = { | ||
32 | "poll-max-ns", offsetof(IOThread, poll_max_ns), | ||
33 | }; | ||
34 | -static PollParamInfo poll_grow_info = { | ||
35 | +static IOThreadParamInfo poll_grow_info = { | ||
36 | "poll-grow", offsetof(IOThread, poll_grow), | ||
37 | }; | ||
38 | -static PollParamInfo poll_shrink_info = { | ||
39 | +static IOThreadParamInfo poll_shrink_info = { | ||
40 | "poll-shrink", offsetof(IOThread, poll_shrink), | ||
41 | }; | ||
42 | -static PollParamInfo aio_max_batch_info = { | ||
43 | +static IOThreadParamInfo aio_max_batch_info = { | ||
44 | "aio-max-batch", offsetof(IOThread, aio_max_batch), | ||
45 | }; | ||
46 | |||
47 | @@ -XXX,XX +XXX,XX @@ static void iothread_get_param(Object *obj, Visitor *v, | ||
48 | const char *name, void *opaque, Error **errp) | ||
49 | { | ||
50 | IOThread *iothread = IOTHREAD(obj); | ||
51 | - PollParamInfo *info = opaque; | ||
52 | + IOThreadParamInfo *info = opaque; | ||
53 | int64_t *field = (void *)iothread + info->offset; | ||
54 | |||
55 | visit_type_int64(v, name, field, errp); | ||
56 | @@ -XXX,XX +XXX,XX @@ static bool iothread_set_param(Object *obj, Visitor *v, | ||
57 | const char *name, void *opaque, Error **errp) | ||
58 | { | ||
59 | IOThread *iothread = IOTHREAD(obj); | ||
60 | - PollParamInfo *info = opaque; | ||
61 | + IOThreadParamInfo *info = opaque; | ||
62 | int64_t *field = (void *)iothread + info->offset; | ||
63 | int64_t value; | ||
64 | |||
65 | -- | ||
66 | 2.31.1 | ||
67 | |||
68 | diff view generated by jsdifflib |
1 | From: Eric Blake <eblake@redhat.com> | 1 | From: Stefano Garzarella <sgarzare@redhat.com> |
---|---|---|---|
2 | 2 | ||
3 | Commit bf42508f introduced new generated files; make sure they | 3 | Commit 0445409d74 ("iothread: generalize |
4 | don't get accidentally committed from an in-tree build. | 4 | iothread_set_param/iothread_get_param") moved common code to set and |
5 | get IOThread parameters in two new functions. | ||
5 | 6 | ||
6 | Signed-off-by: Eric Blake <eblake@redhat.com> | 7 | These functions are called inside callbacks, so we don't need to use an |
7 | Reviewed-by: Jeff Cody <jcody@redhat.com> | 8 | opaque pointer. Let's replace `void *opaque` parameter with |
8 | Reviewed-by: Max Reitz <mreitz@redhat.com> | 9 | `IOThreadParamInfo *info`. |
9 | Message-id: 20180531212435.165261-1-eblake@redhat.com | 10 | |
10 | Signed-off-by: Jeff Cody <jcody@redhat.com> | 11 | Suggested-by: Kevin Wolf <kwolf@redhat.com> |
12 | Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> | ||
13 | Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> | ||
14 | Message-id: 20210727145936.147032-3-sgarzare@redhat.com | ||
15 | Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> | ||
11 | --- | 16 | --- |
12 | .gitignore | 4 ++++ | 17 | iothread.c | 18 ++++++++++-------- |
13 | 1 file changed, 4 insertions(+) | 18 | 1 file changed, 10 insertions(+), 8 deletions(-) |
14 | 19 | ||
15 | diff --git a/.gitignore b/.gitignore | 20 | diff --git a/iothread.c b/iothread.c |
16 | index XXXXXXX..XXXXXXX 100644 | 21 | index XXXXXXX..XXXXXXX 100644 |
17 | --- a/.gitignore | 22 | --- a/iothread.c |
18 | +++ b/.gitignore | 23 | +++ b/iothread.c |
19 | @@ -XXX,XX +XXX,XX @@ | 24 | @@ -XXX,XX +XXX,XX @@ static IOThreadParamInfo aio_max_batch_info = { |
20 | /qapi/qapi-commands-common.[ch] | 25 | }; |
21 | /qapi/qapi-commands-crypto.[ch] | 26 | |
22 | /qapi/qapi-commands-introspect.[ch] | 27 | static void iothread_get_param(Object *obj, Visitor *v, |
23 | +/qapi/qapi-commands-job.[ch] | 28 | - const char *name, void *opaque, Error **errp) |
24 | /qapi/qapi-commands-migration.[ch] | 29 | + const char *name, IOThreadParamInfo *info, Error **errp) |
25 | /qapi/qapi-commands-misc.[ch] | 30 | { |
26 | /qapi/qapi-commands-net.[ch] | 31 | IOThread *iothread = IOTHREAD(obj); |
27 | @@ -XXX,XX +XXX,XX @@ | 32 | - IOThreadParamInfo *info = opaque; |
28 | /qapi/qapi-events-common.[ch] | 33 | int64_t *field = (void *)iothread + info->offset; |
29 | /qapi/qapi-events-crypto.[ch] | 34 | |
30 | /qapi/qapi-events-introspect.[ch] | 35 | visit_type_int64(v, name, field, errp); |
31 | +/qapi/qapi-events-job.[ch] | 36 | } |
32 | /qapi/qapi-events-migration.[ch] | 37 | |
33 | /qapi/qapi-events-misc.[ch] | 38 | static bool iothread_set_param(Object *obj, Visitor *v, |
34 | /qapi/qapi-events-net.[ch] | 39 | - const char *name, void *opaque, Error **errp) |
35 | @@ -XXX,XX +XXX,XX @@ | 40 | + const char *name, IOThreadParamInfo *info, Error **errp) |
36 | /qapi/qapi-types-common.[ch] | 41 | { |
37 | /qapi/qapi-types-crypto.[ch] | 42 | IOThread *iothread = IOTHREAD(obj); |
38 | /qapi/qapi-types-introspect.[ch] | 43 | - IOThreadParamInfo *info = opaque; |
39 | +/qapi/qapi-types-job.[ch] | 44 | int64_t *field = (void *)iothread + info->offset; |
40 | /qapi/qapi-types-migration.[ch] | 45 | int64_t value; |
41 | /qapi/qapi-types-misc.[ch] | 46 | |
42 | /qapi/qapi-types-net.[ch] | 47 | @@ -XXX,XX +XXX,XX @@ static bool iothread_set_param(Object *obj, Visitor *v, |
43 | @@ -XXX,XX +XXX,XX @@ | 48 | static void iothread_get_poll_param(Object *obj, Visitor *v, |
44 | /qapi/qapi-visit-common.[ch] | 49 | const char *name, void *opaque, Error **errp) |
45 | /qapi/qapi-visit-crypto.[ch] | 50 | { |
46 | /qapi/qapi-visit-introspect.[ch] | 51 | + IOThreadParamInfo *info = opaque; |
47 | +/qapi/qapi-visit-job.[ch] | 52 | |
48 | /qapi/qapi-visit-migration.[ch] | 53 | - iothread_get_param(obj, v, name, opaque, errp); |
49 | /qapi/qapi-visit-misc.[ch] | 54 | + iothread_get_param(obj, v, name, info, errp); |
50 | /qapi/qapi-visit-net.[ch] | 55 | } |
56 | |||
57 | static void iothread_set_poll_param(Object *obj, Visitor *v, | ||
58 | const char *name, void *opaque, Error **errp) | ||
59 | { | ||
60 | IOThread *iothread = IOTHREAD(obj); | ||
61 | + IOThreadParamInfo *info = opaque; | ||
62 | |||
63 | - if (!iothread_set_param(obj, v, name, opaque, errp)) { | ||
64 | + if (!iothread_set_param(obj, v, name, info, errp)) { | ||
65 | return; | ||
66 | } | ||
67 | |||
68 | @@ -XXX,XX +XXX,XX @@ static void iothread_set_poll_param(Object *obj, Visitor *v, | ||
69 | static void iothread_get_aio_param(Object *obj, Visitor *v, | ||
70 | const char *name, void *opaque, Error **errp) | ||
71 | { | ||
72 | + IOThreadParamInfo *info = opaque; | ||
73 | |||
74 | - iothread_get_param(obj, v, name, opaque, errp); | ||
75 | + iothread_get_param(obj, v, name, info, errp); | ||
76 | } | ||
77 | |||
78 | static void iothread_set_aio_param(Object *obj, Visitor *v, | ||
79 | const char *name, void *opaque, Error **errp) | ||
80 | { | ||
81 | IOThread *iothread = IOTHREAD(obj); | ||
82 | + IOThreadParamInfo *info = opaque; | ||
83 | |||
84 | - if (!iothread_set_param(obj, v, name, opaque, errp)) { | ||
85 | + if (!iothread_set_param(obj, v, name, info, errp)) { | ||
86 | return; | ||
87 | } | ||
88 | |||
51 | -- | 89 | -- |
52 | 2.13.6 | 90 | 2.31.1 |
53 | 91 | ||
54 | 92 | diff view generated by jsdifflib |