[Qemu-devel] [PULL 0/3] Miscellaneous patches for 2018-06-13

Markus Armbruster posted 3 patches 18 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180613131045.17379-1-armbru@redhat.com
Test checkpatch failed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test s390x passed
Makefile                      |  3 ---
hw/ide/ahci.c                 |  2 +-
hw/ppc/spapr_ovec.c           | 12 ++++++------
hw/usb/dev-smartcard-reader.c |  2 +-
qom/object.c                  | 10 +++++-----
scripts/coverity-model.c      | 12 ++++++++++++
util/qht.c                    |  2 +-
7 files changed, 26 insertions(+), 17 deletions(-)

[Qemu-devel] [PULL 0/3] Miscellaneous patches for 2018-06-13

Posted by Markus Armbruster 18 weeks ago
The following changes since commit 2ab09bf2f9f55b9fb8d2de6eb2ba2a8570e268e2:

  Merge remote-tracking branch 'remotes/kraxel/tags/usb-20180612-pull-request' into staging (2018-06-12 15:34:34 +0100)

are available in the Git repository at:

  git://repo.or.cz/qemu/armbru.git tags/pull-misc-2018-06-13

for you to fetch changes up to 719a30776b94d3da8c613e5047414f483d40256d:

  Purge uses of banned g_assert_FOO() (2018-06-13 13:47:35 +0200)

----------------------------------------------------------------
Miscellaneous patches for 2018-06-13

----------------------------------------------------------------
Markus Armbruster (2):
      Revert "Makefile: add target to print generated files"
      Purge uses of banned g_assert_FOO()

Paolo Bonzini (1):
      coverity-model: replay data is considered trusted

 Makefile                      |  3 ---
 hw/ide/ahci.c                 |  2 +-
 hw/ppc/spapr_ovec.c           | 12 ++++++------
 hw/usb/dev-smartcard-reader.c |  2 +-
 qom/object.c                  | 10 +++++-----
 scripts/coverity-model.c      | 12 ++++++++++++
 util/qht.c                    |  2 +-
 7 files changed, 26 insertions(+), 17 deletions(-)

-- 
2.17.1


Re: [Qemu-devel] [PULL 0/3] Miscellaneous patches for 2018-06-13

Posted by no-reply@patchew.org 18 weeks ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180613131045.17379-1-armbru@redhat.com
Subject: [Qemu-devel] [PULL 0/3] Miscellaneous patches for 2018-06-13

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
5cb103bc21 Purge uses of banned g_assert_FOO()
3aa2ecc4d4 coverity-model: replay data is considered trusted
572b561a1a Revert "Makefile: add target to print generated files"

=== OUTPUT BEGIN ===
Checking PATCH 1/3: Revert "Makefile: add target to print generated files"...
Checking PATCH 2/3: coverity-model: replay data is considered trusted...
ERROR: suspect code indent for conditional statements (5, 9)
#28: FILE: scripts/coverity-model.c:110:
+     if (replay_file) {
+         uint8_t c;

total: 1 errors, 0 warnings, 18 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/3: Purge uses of banned g_assert_FOO()...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PULL 0/3] Miscellaneous patches for 2018-06-13

Posted by Markus Armbruster 18 weeks ago
no-reply@patchew.org writes:

> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:

Quick respin coming.

Re: [Qemu-devel] [PULL 0/3] Miscellaneous patches for 2018-06-13

Posted by Peter Maydell 18 weeks ago
On 13 June 2018 at 14:10, Markus Armbruster <armbru@redhat.com> wrote:
> The following changes since commit 2ab09bf2f9f55b9fb8d2de6eb2ba2a8570e268e2:
>
>   Merge remote-tracking branch 'remotes/kraxel/tags/usb-20180612-pull-request' into staging (2018-06-12 15:34:34 +0100)
>
> are available in the Git repository at:
>
>   git://repo.or.cz/qemu/armbru.git tags/pull-misc-2018-06-13
>
> for you to fetch changes up to 719a30776b94d3da8c613e5047414f483d40256d:
>
>   Purge uses of banned g_assert_FOO() (2018-06-13 13:47:35 +0200)
>
> ----------------------------------------------------------------
> Miscellaneous patches for 2018-06-13
>
> ----------------------------------------------------------------
> Markus Armbruster (2):
>       Revert "Makefile: add target to print generated files"
>       Purge uses of banned g_assert_FOO()
>
> Paolo Bonzini (1):
>       coverity-model: replay data is considered trusted
>

Applied, thanks.

-- PMM