[Qemu-devel] [PATCH 0/2] scsi: remove legacy esp_init() function

Mark Cave-Ayland posted 2 patches 18 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180613094727.11326-1-mark.cave-ayland@ilande.co.uk
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test s390x passed
hw/mips/mips_jazz.c   | 19 ++++++++++++++++---
hw/scsi/esp.c         | 30 ------------------------------
include/hw/scsi/esp.h |  5 -----
3 files changed, 16 insertions(+), 38 deletions(-)

[Qemu-devel] [PATCH 0/2] scsi: remove legacy esp_init() function

Posted by Mark Cave-Ayland 18 weeks ago
Something else that came out of reviewing Laurent's q800 patchset: after my
SPARC cleanups last year, MIPS Jazz is the last remaining user of the legacy
esp_init() function.

Patch 1 switches mips_jazz_init() over to create the ESP device directly
via qdev. Please note that I do not have any MIPS jazz images and so this
is compile-tested only (although passes "make check") and needs an ACK from
someone (Hervé?).

Now that the last user of esp_init() is gone, patch 2 removes the legacy
function and its associated header.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


Mark Cave-Ayland (2):
  hw/mips/jazz: create ESP device directly via qdev
  esp: remove legacy esp_init() function

 hw/mips/mips_jazz.c   | 19 ++++++++++++++++---
 hw/scsi/esp.c         | 30 ------------------------------
 include/hw/scsi/esp.h |  5 -----
 3 files changed, 16 insertions(+), 38 deletions(-)

-- 
2.11.0


Re: [Qemu-devel] [PATCH 0/2] scsi: remove legacy esp_init() function

Posted by Mark Cave-Ayland 16 weeks ago
On 13/06/18 10:47, Mark Cave-Ayland wrote:

> Something else that came out of reviewing Laurent's q800 patchset: after my
> SPARC cleanups last year, MIPS Jazz is the last remaining user of the legacy
> esp_init() function.
> 
> Patch 1 switches mips_jazz_init() over to create the ESP device directly
> via qdev. Please note that I do not have any MIPS jazz images and so this
> is compile-tested only (although passes "make check") and needs an ACK from
> someone (Hervé?).
> 
> Now that the last user of esp_init() is gone, patch 2 removes the legacy
> function and its associated header.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> 
> 
> Mark Cave-Ayland (2):
>    hw/mips/jazz: create ESP device directly via qdev
>    esp: remove legacy esp_init() function
> 
>   hw/mips/mips_jazz.c   | 19 ++++++++++++++++---
>   hw/scsi/esp.c         | 30 ------------------------------
>   include/hw/scsi/esp.h |  5 -----
>   3 files changed, 16 insertions(+), 38 deletions(-)

Ping? Is anyone able to test the MIPS jazz board with these patches at all?


ATB,

Mark.

Re: [Qemu-devel] [PATCH 0/2] scsi: remove legacy esp_init() function

Posted by Hervé Poussineau 16 weeks ago
Le 27/06/2018 à 22:01, Mark Cave-Ayland a écrit :
> On 13/06/18 10:47, Mark Cave-Ayland wrote:
> 
>> Something else that came out of reviewing Laurent's q800 patchset: after my
>> SPARC cleanups last year, MIPS Jazz is the last remaining user of the legacy
>> esp_init() function.
>>
>> Patch 1 switches mips_jazz_init() over to create the ESP device directly
>> via qdev. Please note that I do not have any MIPS jazz images and so this
>> is compile-tested only (although passes "make check") and needs an ACK from
>> someone (Hervé?).
>>
>> Now that the last user of esp_init() is gone, patch 2 removes the legacy
>> function and its associated header.
>>
>> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>>
>>
>> Mark Cave-Ayland (2):
>>    hw/mips/jazz: create ESP device directly via qdev
>>    esp: remove legacy esp_init() function
>>
>>   hw/mips/mips_jazz.c   | 19 ++++++++++++++++---
>>   hw/scsi/esp.c         | 30 ------------------------------
>>   include/hw/scsi/esp.h |  5 -----
>>   3 files changed, 16 insertions(+), 38 deletions(-)
> 
> Ping? Is anyone able to test the MIPS jazz board with these patches at all?

Tested-by: Hervé Poussineau <hpoussin@reactos.org>


Re: [Qemu-devel] [PATCH 0/2] scsi: remove legacy esp_init() function

Posted by Paolo Bonzini 16 weeks ago
On 28/06/2018 07:58, Hervé Poussineau wrote:
> Le 27/06/2018 à 22:01, Mark Cave-Ayland a écrit :
>> On 13/06/18 10:47, Mark Cave-Ayland wrote:
>>
>>> Something else that came out of reviewing Laurent's q800 patchset:
>>> after my
>>> SPARC cleanups last year, MIPS Jazz is the last remaining user of the
>>> legacy
>>> esp_init() function.
>>>
>>> Patch 1 switches mips_jazz_init() over to create the ESP device directly
>>> via qdev. Please note that I do not have any MIPS jazz images and so
>>> this
>>> is compile-tested only (although passes "make check") and needs an
>>> ACK from
>>> someone (Hervé?).
>>>
>>> Now that the last user of esp_init() is gone, patch 2 removes the legacy
>>> function and its associated header.
>>>
>>> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>>>
>>>
>>> Mark Cave-Ayland (2):
>>>    hw/mips/jazz: create ESP device directly via qdev
>>>    esp: remove legacy esp_init() function
>>>
>>>   hw/mips/mips_jazz.c   | 19 ++++++++++++++++---
>>>   hw/scsi/esp.c         | 30 ------------------------------
>>>   include/hw/scsi/esp.h |  5 -----
>>>   3 files changed, 16 insertions(+), 38 deletions(-)
>>
>> Ping? Is anyone able to test the MIPS jazz board with these patches at
>> all?
> 
> Tested-by: Hervé Poussineau <hpoussin@reactos.org>
> 
> 

Queued, thanks.

Paolo