[Qemu-devel] [PATCH] configure: Enable out-of-tree acceptance tests

Philippe Mathieu-Daudé posted 1 patch 18 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180612173437.14462-1-f4bug@amsat.org
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test s390x passed
configure | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

[Qemu-devel] [PATCH] configure: Enable out-of-tree acceptance tests

Posted by Philippe Mathieu-Daudé 18 weeks ago
Currently to run Avocado acceptance tests in an out-of-tree
build directory, we need to use the full path to the test:

  build_dir$ avocado run /full/path/to/sources/qemu/tests/acceptance/boot_linux_console.py

This patch adds a symlink in the build tree to simplify the
tests invocation, allowing the same command than in in-tree builds:

  build_dir$ avocado run tests/acceptance/boot_linux_console.py

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
Based-on: 20180530184156.15634-1-crosa@redhat.com

Since RFC: reworded the commit message (Eduardo Habkost)

 configure | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/configure b/configure
index a8c4094c87..d095ed45a4 100755
--- a/configure
+++ b/configure
@@ -7239,9 +7239,11 @@ for rom in seabios vgabios ; do
 done
 
 # set up tests data directory
-if [ ! -e tests/data ]; then
-    symlink "$source_path/tests/data" tests/data
-fi
+for tests_subdir in acceptance data; do
+    if [ ! -e tests/$tests_subdir ]; then
+        symlink "$source_path/tests/$tests_subdir" tests/$tests_subdir
+    fi
+done
 
 # set up qemu-iotests in this build directory
 iotests_common_env="tests/qemu-iotests/common.env"
-- 
2.17.1


Re: [Qemu-devel] [PATCH] configure: Enable out-of-tree acceptance tests

Posted by Eduardo Habkost 18 weeks ago
On Tue, Jun 12, 2018 at 02:34:37PM -0300, Philippe Mathieu-Daudé wrote:
> Currently to run Avocado acceptance tests in an out-of-tree
> build directory, we need to use the full path to the test:
> 
>   build_dir$ avocado run /full/path/to/sources/qemu/tests/acceptance/boot_linux_console.py
> 
> This patch adds a symlink in the build tree to simplify the
> tests invocation, allowing the same command than in in-tree builds:
> 
>   build_dir$ avocado run tests/acceptance/boot_linux_console.py
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Queued on python-next, thanks!

-- 
Eduardo