[Qemu-devel] [PULL 0/8] Linux user for 3.0 patches

Laurent Vivier posted 8 patches 18 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180612105831.25703-1-laurent@vivier.eu
Test checkpatch failed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test s390x passed
Makefile                           |  2 +-
linux-user/alpha/syscall_nr.h      |  6 +++---
linux-user/flatload.c              | 15 +++++++++------
linux-user/hppa/syscall_nr.h       |  2 +-
linux-user/microblaze/syscall_nr.h |  2 +-
linux-user/qemu.h                  |  5 +++++
linux-user/sparc64/syscall_nr.h    |  4 ++--
linux-user/strace.list             |  9 ---------
linux-user/syscall.c               |  5 -----
scripts/qemu-binfmt-conf.sh        | 18 +++++++++---------
tests/Makefile.include             |  2 +-
11 files changed, 32 insertions(+), 38 deletions(-)

[Qemu-devel] [PULL 0/8] Linux user for 3.0 patches

Posted by Laurent Vivier 18 weeks ago
The following changes since commit 9f55925b8f50a962d1d08d815044db7767ae3838:

  Merge remote-tracking branch 'remotes/vivier/tags/m68k-for-3.0-pull-request' into staging (2018-06-11 12:46:16 +0100)

are available in the Git repository at:

  git://github.com/vivier/qemu.git tags/linux-user-for-3.0-pull-request

for you to fetch changes up to dec1c928494f76ddd1484a7a4584ec18b1900a7a:

  linux-user/sparc64: Add inotify_rm_watch and tee syscalls (2018-06-11 14:47:45 +0200)

----------------------------------------------------------------
Fixes in syscall numbers,
disable the build of binaries not needed for linux-user,
update of qemu-binfmt-conf.sh and cleanup around is_error()

----------------------------------------------------------------

Laurent Vivier (2):
  linux-user: disable qemu-bridge-helper and socket_scm_helper build
  qemu-binfmt-conf.sh: ignore the OS/ABI field

Philippe Mathieu-Daudé (2):
  linux-user: Export use is_error(), use it to avoid warnings
  linux-user: Use is_error() to avoid warnings and make the code clearer

Richard Henderson (4):
  linux-user/alpha: Fix epoll syscalls
  linux-user/hppa: Fix typo in mknodat syscall
  linux-user/microblaze: Fix typo in accept4 syscall
  linux-user/sparc64: Add inotify_rm_watch and tee syscalls

 Makefile                           |  2 +-
 linux-user/alpha/syscall_nr.h      |  6 +++---
 linux-user/flatload.c              | 15 +++++++++------
 linux-user/hppa/syscall_nr.h       |  2 +-
 linux-user/microblaze/syscall_nr.h |  2 +-
 linux-user/qemu.h                  |  5 +++++
 linux-user/sparc64/syscall_nr.h    |  4 ++--
 linux-user/strace.list             |  9 ---------
 linux-user/syscall.c               |  5 -----
 scripts/qemu-binfmt-conf.sh        | 18 +++++++++---------
 tests/Makefile.include             |  2 +-
 11 files changed, 32 insertions(+), 38 deletions(-)

-- 
2.14.4


Re: [Qemu-devel] [PULL 0/8] Linux user for 3.0 patches

Posted by no-reply@patchew.org 18 weeks ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180612105831.25703-1-laurent@vivier.eu
Subject: [Qemu-devel] [PULL 0/8] Linux user for 3.0 patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20180612105831.25703-1-laurent@vivier.eu -> patchew/20180612105831.25703-1-laurent@vivier.eu
Switched to a new branch 'test'
41c0008bdc linux-user/sparc64: Add inotify_rm_watch and tee syscalls
c5103fa93a linux-user/microblaze: Fix typo in accept4 syscall
31fbec571a linux-user/hppa: Fix typo in mknodat syscall
fdba8fbf40 linux-user/alpha: Fix epoll syscalls
6f8013f9db qemu-binfmt-conf.sh: ignore the OS/ABI field
974b0e798a linux-user: disable qemu-bridge-helper and socket_scm_helper build
6216250a43 linux-user: Use is_error() to avoid warnings and make the code clearer
a35243b5c7 linux-user: Export use is_error(), use it to avoid warnings

=== OUTPUT BEGIN ===
Checking PATCH 1/8: linux-user: Export use is_error(), use it to avoid warnings...
Checking PATCH 2/8: linux-user: Use is_error() to avoid warnings and make the code clearer...
Checking PATCH 3/8: linux-user: disable qemu-bridge-helper and socket_scm_helper build...
Checking PATCH 4/8: qemu-binfmt-conf.sh: ignore the OS/ABI field...
ERROR: line over 90 characters
#27: FILE: scripts/qemu-binfmt-conf.sh:10:
+i386_mask='\xff\xff\xff\xff\xff\xfe\xfe\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'

ERROR: line over 90 characters
#32: FILE: scripts/qemu-binfmt-conf.sh:14:
+i486_mask='\xff\xff\xff\xff\xff\xfe\xfe\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'

ERROR: line over 90 characters
#37: FILE: scripts/qemu-binfmt-conf.sh:18:
+alpha_mask='\xff\xff\xff\xff\xff\xfe\xfe\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'

ERROR: line over 90 characters
#46: FILE: scripts/qemu-binfmt-conf.sh:30:
+sparc_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff'

ERROR: line over 90 characters
#51: FILE: scripts/qemu-binfmt-conf.sh:34:
+sparc32plus_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff'

ERROR: line over 90 characters
#60: FILE: scripts/qemu-binfmt-conf.sh:50:
+m68k_mask='\xff\xff\xff\xff\xff\xff\xfe\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff'

ERROR: line over 90 characters
#69: FILE: scripts/qemu-binfmt-conf.sh:80:
+sh4_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'

ERROR: line over 90 characters
#74: FILE: scripts/qemu-binfmt-conf.sh:84:
+sh4eb_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff'

ERROR: line over 90 characters
#79: FILE: scripts/qemu-binfmt-conf.sh:88:
+s390x_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff'

total: 9 errors, 0 warnings, 57 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/8: linux-user/alpha: Fix epoll syscalls...
Checking PATCH 6/8: linux-user/hppa: Fix typo in mknodat syscall...
Checking PATCH 7/8: linux-user/microblaze: Fix typo in accept4 syscall...
Checking PATCH 8/8: linux-user/sparc64: Add inotify_rm_watch and tee syscalls...
WARNING: line over 80 characters
#20: FILE: linux-user/sparc64/syscall_nr.h:157:
+#define TARGET_NR_inotify_rm_watch   156 /* Linux specific                              */

total: 0 errors, 1 warnings, 16 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PULL 0/8] Linux user for 3.0 patches

Posted by Peter Maydell 18 weeks ago
On 12 June 2018 at 11:58, Laurent Vivier <laurent@vivier.eu> wrote:
> The following changes since commit 9f55925b8f50a962d1d08d815044db7767ae3838:
>
>   Merge remote-tracking branch 'remotes/vivier/tags/m68k-for-3.0-pull-request' into staging (2018-06-11 12:46:16 +0100)
>
> are available in the Git repository at:
>
>   git://github.com/vivier/qemu.git tags/linux-user-for-3.0-pull-request
>
> for you to fetch changes up to dec1c928494f76ddd1484a7a4584ec18b1900a7a:
>
>   linux-user/sparc64: Add inotify_rm_watch and tee syscalls (2018-06-11 14:47:45 +0200)
>
> ----------------------------------------------------------------
> Fixes in syscall numbers,
> disable the build of binaries not needed for linux-user,
> update of qemu-binfmt-conf.sh and cleanup around is_error()

Applied, thanks.

-- PMM