[Qemu-devel] [PATCH] travis: display config.log when configure fails

Daniel P. Berrangé posted 1 patch 18 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180612082823.25507-1-berrange@redhat.com
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test s390x passed
.travis.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH] travis: display config.log when configure fails

Posted by Daniel P. Berrangé 18 weeks ago
When configure fails in CI systems we must be able to see the contents
of the config.log file to diagnose the root cause.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 .travis.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 814be151f4..fc9a1fe8a8 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -69,7 +69,7 @@ before_install:
   - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ
   - git submodule update --init --recursive
 before_script:
-  - ./configure ${CONFIG}
+  - ./configure ${CONFIG} || (cat config.log && exit 1)
 script:
   - make ${MAKEFLAGS} && ${TEST_CMD}
 matrix:
@@ -151,4 +151,4 @@ matrix:
         - CONFIG="--cc=gcc-7 --cxx=g++-7 --disable-pie --disable-linux-user"
         - TEST_CMD=""
       before_script:
-        - ./configure ${CONFIG} --extra-cflags="-g3 -O0 -fsanitize=thread -fuse-ld=gold" || cat config.log
+        - ./configure ${CONFIG} --extra-cflags="-g3 -O0 -fsanitize=thread -fuse-ld=gold" || (cat config.log && exit 1)
-- 
2.17.0


Re: [Qemu-devel] [PATCH] travis: display config.log when configure fails

Posted by Fam Zheng 18 weeks ago
On Tue, 06/12 09:28, Daniel P. Berrangé wrote:
> When configure fails in CI systems we must be able to see the contents
> of the config.log file to diagnose the root cause.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  .travis.yml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 814be151f4..fc9a1fe8a8 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -69,7 +69,7 @@ before_install:
>    - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ
>    - git submodule update --init --recursive
>  before_script:
> -  - ./configure ${CONFIG}
> +  - ./configure ${CONFIG} || (cat config.log && exit 1)
>  script:
>    - make ${MAKEFLAGS} && ${TEST_CMD}
>  matrix:
> @@ -151,4 +151,4 @@ matrix:
>          - CONFIG="--cc=gcc-7 --cxx=g++-7 --disable-pie --disable-linux-user"
>          - TEST_CMD=""
>        before_script:
> -        - ./configure ${CONFIG} --extra-cflags="-g3 -O0 -fsanitize=thread -fuse-ld=gold" || cat config.log
> +        - ./configure ${CONFIG} --extra-cflags="-g3 -O0 -fsanitize=thread -fuse-ld=gold" || (cat config.log && exit 1)
> -- 
> 2.17.0
> 

Makes sense. this fixes the status code of before_script, though previously as
we mask the error with the "|| cat config.log", make will still fail.

Reviewed-by: Fam Zheng <famz@redhat.com>


Re: [Qemu-devel] [PATCH] travis: display config.log when configure fails

Posted by Eric Blake 18 weeks ago
On 06/12/2018 03:28 AM, Daniel P. Berrangé wrote:
> When configure fails in CI systems we must be able to see the contents
> of the config.log file to diagnose the root cause.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   .travis.yml | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 814be151f4..fc9a1fe8a8 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -69,7 +69,7 @@ before_install:
>     - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ
>     - git submodule update --init --recursive
>   before_script:
> -  - ./configure ${CONFIG}
> +  - ./configure ${CONFIG} || (cat config.log && exit 1)

If you want one less fork, you can spell this as:

- ./configure ${CONFIG} || { cat config.log && exit 1; }

Either way, the patch makes sense, so:
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH] travis: display config.log when configure fails

Posted by Philippe Mathieu-Daudé 18 weeks ago
On 06/12/2018 09:15 AM, Eric Blake wrote:
> On 06/12/2018 03:28 AM, Daniel P. Berrangé wrote:
>> When configure fails in CI systems we must be able to see the contents
>> of the config.log file to diagnose the root cause.
>>
>> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>> ---
>>   .travis.yml | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/.travis.yml b/.travis.yml
>> index 814be151f4..fc9a1fe8a8 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -69,7 +69,7 @@ before_install:
>>     - wget -O -
>> http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz |
>> tar -xvJ
>>     - git submodule update --init --recursive
>>   before_script:
>> -  - ./configure ${CONFIG}
>> +  - ./configure ${CONFIG} || (cat config.log && exit 1)
> 
> If you want one less fork, you can spell this as:
> 
> - ./configure ${CONFIG} || { cat config.log && exit 1; }

I was just digging for your previous mail explaining that to use as
reference ;)

> 
> Either way, the patch makes sense, so:
> Reviewed-by: Eric Blake <eblake@redhat.com>
> 

preferably using {:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Re: [Qemu-devel] [PATCH] travis: display config.log when configure fails

Posted by Alex Bennée 18 weeks ago
Daniel P. Berrangé <berrange@redhat.com> writes:

> When configure fails in CI systems we must be able to see the contents
> of the config.log file to diagnose the root cause.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

queued thanks.
<snip>

--
Alex Bennée