[v4] Use the IEC binary prefix definitions

[Qemu-devel] [PATCH v4 03/40] x86/cpu: Use definitions from "qemu/units.h"

Posted by Philippe Mathieu-Daudé 7 years, 8 months ago

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/i386/cpu.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 94260412e2..56c63615fe 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -18,6 +18,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/units.h"
 #include "qemu/cutils.h"
 
 #include "cpu.h"
@@ -64,9 +65,6 @@ struct CPUID2CacheDescriptorInfo {
     int associativity;
 };
 
-#define KiB 1024
-#define MiB (1024 * 1024)
-
 /*
  * Known CPUID 2 cache descriptors.
  * From Intel SDM Volume 2A, CPUID instruction
-- 
2.17.1

Re: [Qemu-devel] [PATCH v4 03/40] x86/cpu: Use definitions from "qemu/units.h"

Posted by Eduardo Habkost 7 years, 8 months ago

On Sun, Jun 10, 2018 at 10:14:24PM -0300, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Nice, thanks!

Acked-by: Eduardo Habkost <ehabkost@redhat.com>

> ---
>  target/i386/cpu.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 94260412e2..56c63615fe 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -18,6 +18,7 @@
>   */
>  
>  #include "qemu/osdep.h"
> +#include "qemu/units.h"
>  #include "qemu/cutils.h"
>  
>  #include "cpu.h"
> @@ -64,9 +65,6 @@ struct CPUID2CacheDescriptorInfo {
>      int associativity;
>  };
>  
> -#define KiB 1024
> -#define MiB (1024 * 1024)
> -
>  /*
>   * Known CPUID 2 cache descriptors.
>   * From Intel SDM Volume 2A, CPUID instruction
> -- 
> 2.17.1
> 

-- 
Eduardo