[Qemu-devel] [PATCH 1/3] ppc: remove obsolete pci_pmac_init() definitions from mac.h

Mark Cave-Ayland posted 3 patches 7 years, 8 months ago
[Qemu-devel] [PATCH 1/3] ppc: remove obsolete pci_pmac_init() definitions from mac.h
Posted by Mark Cave-Ayland 7 years, 8 months ago
Commits 7b19318bee and 8ce3f743c7 removed the pci_pmac_init() and
pci_pmac_u3_init() functions but missed the header prototypes in mac.h. Remove
them since they are no longer needed.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
 hw/ppc/mac.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/hw/ppc/mac.h b/hw/ppc/mac.h
index 22a7efbed6..dac96317af 100644
--- a/hw/ppc/mac.h
+++ b/hw/ppc/mac.h
@@ -97,12 +97,6 @@ void macio_init(PCIDevice *dev,
 /* Grackle PCI */
 #define TYPE_GRACKLE_PCI_HOST_BRIDGE "grackle-pcihost"
 
-/* UniNorth PCI */
-UNINHostState *pci_pmac_init(qemu_irq *pic,
-                             MemoryRegion *address_space_mem);
-UNINHostState *pci_pmac_u3_init(qemu_irq *pic,
-                                MemoryRegion *address_space_mem);
-
 /* Mac NVRAM */
 #define TYPE_MACIO_NVRAM "macio-nvram"
 #define MACIO_NVRAM(obj) \
-- 
2.11.0


Re: [Qemu-devel] [PATCH 1/3] ppc: remove obsolete pci_pmac_init() definitions from mac.h
Posted by Philippe Mathieu-Daudé 7 years, 8 months ago
On 06/07/2018 01:59 PM, Mark Cave-Ayland wrote:
> Commits 7b19318bee and 8ce3f743c7 removed the pci_pmac_init() and
> pci_pmac_u3_init() functions but missed the header prototypes in mac.h. Remove
> them since they are no longer needed.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  hw/ppc/mac.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/hw/ppc/mac.h b/hw/ppc/mac.h
> index 22a7efbed6..dac96317af 100644
> --- a/hw/ppc/mac.h
> +++ b/hw/ppc/mac.h
> @@ -97,12 +97,6 @@ void macio_init(PCIDevice *dev,
>  /* Grackle PCI */
>  #define TYPE_GRACKLE_PCI_HOST_BRIDGE "grackle-pcihost"
>  
> -/* UniNorth PCI */
> -UNINHostState *pci_pmac_init(qemu_irq *pic,
> -                             MemoryRegion *address_space_mem);
> -UNINHostState *pci_pmac_u3_init(qemu_irq *pic,
> -                                MemoryRegion *address_space_mem);
> -
>  /* Mac NVRAM */
>  #define TYPE_MACIO_NVRAM "macio-nvram"
>  #define MACIO_NVRAM(obj) \
>