misc: Add trailing '\n' to qemu_log() calls

[Qemu-devel] [PATCH 05/11] hw/core/register: Add trailing '\n' to qemu_log() call

Posted by Philippe Mathieu-Daudé 7 years, 8 months ago

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/core/register.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/core/register.c b/hw/core/register.c
index 0741a1af32..d2d1636250 100644
--- a/hw/core/register.c
+++ b/hw/core/register.c
@@ -96,7 +96,7 @@ void register_write(RegisterInfo *reg, uint64_t val, uint64_t we,
     if (test) {
         qemu_log_mask(LOG_UNIMP,
                       "%s:%s writing %#" PRIx64 " to unimplemented bits:" \
-                      " %#" PRIx64 "",
+                      " %#" PRIx64 "\n",
                       prefix, reg->access->name, val, ac->unimp);
     }
 
-- 
2.17.1

Re: [Qemu-devel] [PATCH 05/11] hw/core/register: Add trailing '\n' to qemu_log() call

Posted by Alistair Francis 7 years, 8 months ago

On Wed, Jun 6, 2018 at 8:21 AM, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  hw/core/register.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/core/register.c b/hw/core/register.c
> index 0741a1af32..d2d1636250 100644
> --- a/hw/core/register.c
> +++ b/hw/core/register.c
> @@ -96,7 +96,7 @@ void register_write(RegisterInfo *reg, uint64_t val, uint64_t we,
>      if (test) {
>          qemu_log_mask(LOG_UNIMP,
>                        "%s:%s writing %#" PRIx64 " to unimplemented bits:" \
> -                      " %#" PRIx64 "",
> +                      " %#" PRIx64 "\n",
>                        prefix, reg->access->name, val, ac->unimp);
>      }
>
> --
> 2.17.1
>
>