[Qemu-devel] [PATCH 6/6] hmp: Allow HMP in preconfig state again

Dr. David Alan Gilbert (git) posted 6 patches 7 years, 8 months ago
There is a newer version of this series
[Qemu-devel] [PATCH 6/6] hmp: Allow HMP in preconfig state again
Posted by Dr. David Alan Gilbert (git) 7 years, 8 months ago
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Now we can cope with preconfig in HMP, reenable by reverting
commit 71dc578e116599ea73c8a2a4e693134702ec0e83.

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 monitor.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/monitor.c b/monitor.c
index 9b29787a52..50bcba18db 100644
--- a/monitor.c
+++ b/monitor.c
@@ -3394,12 +3394,6 @@ static void handle_hmp_command(Monitor *mon, const char *cmdline)
 
     trace_handle_hmp_command(mon, cmdline);
 
-    if (runstate_check(RUN_STATE_PRECONFIG)) {
-        monitor_printf(mon, "HMP not available in preconfig state, "
-                            "use QMP instead\n");
-        return;
-    }
-
     cmd = monitor_parse_command(mon, cmdline, &cmdline, mon->cmd_table);
     if (!cmd) {
         return;
-- 
2.17.0


Re: [Qemu-devel] [PATCH 6/6] hmp: Allow HMP in preconfig state again
Posted by Peter Xu 7 years, 8 months ago
On Tue, Jun 05, 2018 at 01:26:36PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> 
> Now we can cope with preconfig in HMP, reenable by reverting
> commit 71dc578e116599ea73c8a2a4e693134702ec0e83.
> 
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu