[Qemu-devel] [PULL 33/53] exec.c: Initialize sa_flags passed to sigaction()

Paolo Bonzini posted 53 patches 7 years, 8 months ago
Only 39 patches received!
There is a newer version of this series
[Qemu-devel] [PULL 33/53] exec.c: Initialize sa_flags passed to sigaction()
Posted by Paolo Bonzini 7 years, 8 months ago
From: Peter Maydell <peter.maydell@linaro.org>

Coverity points out that in the user-only version of cpu_abort() we
call sigaction() with a partially initialized struct sigaction
(CID 1005351). Correct the omission.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20180515182700.31736-1-peter.maydell@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 exec.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/exec.c b/exec.c
index ffa1099547..bd8833fc9d 100644
--- a/exec.c
+++ b/exec.c
@@ -1124,6 +1124,7 @@ void cpu_abort(CPUState *cpu, const char *fmt, ...)
         struct sigaction act;
         sigfillset(&act.sa_mask);
         act.sa_handler = SIG_DFL;
+        act.sa_flags = 0;
         sigaction(SIGABRT, &act, NULL);
     }
 #endif
-- 
2.17.0