Hi Paolo, something messed with UTF-8...
On 05/31/2018 02:12 PM, Paolo Bonzini wrote:
> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> 4c3119a6e3e and cd9526ab7c0 introduced an incorrect and inconsistent
> use of Chardev->be. Also, this CharBackend member is private and is
> not supposed to be accessible.
>
> Fix it by removing the inconsistent check.
>
> Cc: qemu-stable@nongnu.org
> Reported-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Marc-André Lureau
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Philippe Mathieu-Daudé
> Message-Id: <20180515152500.19460-2-f4bug@amsat.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Correct.
> ---
> hw/isa/isa-superio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/isa/isa-superio.c b/hw/isa/isa-superio.c
> index 9359be7008..8bc2f69eaa 100644
> --- a/hw/isa/isa-superio.c
> +++ b/hw/isa/isa-superio.c
> @@ -42,7 +42,7 @@ static void isa_superio_realize(DeviceState *dev, Error **errp)
> if (!k->parallel.is_enabled || k->parallel.is_enabled(sio, i)) {
> /* FIXME use a qdev chardev prop instead of parallel_hds[] */
> chr = parallel_hds[i];
> - if (chr == NULL || chr->be) {
> + if (chr == NULL) {
> name = g_strdup_printf("discarding-parallel%d", i);
> chr = qemu_chr_new(name, "null");
> } else {
> @@ -82,7 +82,7 @@ static void isa_superio_realize(DeviceState *dev, Error **errp)
> if (!k->serial.is_enabled || k->serial.is_enabled(sio, i)) {
> /* FIXME use a qdev chardev prop instead of serial_hd() */
> chr = serial_hd(i);
> - if (chr == NULL || chr->be) {
> + if (chr == NULL) {
> name = g_strdup_printf("discarding-serial%d", i);
> chr = qemu_chr_new(name, "null");
> } else {
>