aspeed: add MMIO exec support to the FMC controller

[Qemu-devel] [PATCH 0/4] aspeed: add MMIO exec support to the FMC controller

Posted by Cédric Le Goater 7 years, 5 months ago

Hello,

When MMIO execution support is active, these changes let the Aspeed
SoC machine boot directly from CE0. As there is still some
issues, the feature is disabled by default and should be activated
with :

	-global driver=aspeed.smc,property=mmio-exec,value=true

Thanks,

C.

Cédric Le Goater (4):
  aspeed/smc: fix HW strapping
  aspeed/smc: rename aspeed_smc_flash_send_addr() to
    aspeed_smc_flash_setup()
  aspeed/smc: add a new memory region dedicated to MMIO execution
  hw/arm/aspeed: boot from the FMC CE0 flash module

 include/hw/ssi/aspeed_smc.h |   7 ++
 hw/arm/aspeed.c             |  41 +++++++----
 hw/ssi/aspeed_smc.c         | 161 +++++++++++++++++++++++++++++++++++++-------
 3 files changed, 172 insertions(+), 37 deletions(-)

-- 
2.13.6

Re: [Qemu-devel] [PATCH 0/4] aspeed: add MMIO exec support to the FMC controller

Posted by Peter Maydell 7 years, 5 months ago

On 30 May 2018 at 08:49, Cédric Le Goater <clg@kaod.org> wrote:
> Hello,
>
> When MMIO execution support is active, these changes let the Aspeed
> SoC machine boot directly from CE0. As there is still some
> issues, the feature is disabled by default and should be activated
> with :
>
>         -global driver=aspeed.smc,property=mmio-exec,value=true

I'd really rather not add another mmio-exec device until
we've sorted out making it actually work properly...

thanks
-- PMM

Re: [Qemu-devel] [PATCH 0/4] aspeed: add MMIO exec support to the FMC controller

Posted by Cédric Le Goater 7 years, 5 months ago

On 05/30/2018 02:40 PM, Peter Maydell wrote:
> On 30 May 2018 at 08:49, Cédric Le Goater <clg@kaod.org> wrote:
>> Hello,
>>
>> When MMIO execution support is active, these changes let the Aspeed
>> SoC machine boot directly from CE0. As there is still some
>> issues, the feature is disabled by default and should be activated
>> with :
>>
>>         -global driver=aspeed.smc,property=mmio-exec,value=true
> 
> I'd really rather not add another mmio-exec device until
> we've sorted out making it actually work properly...

OK. I will keep it for later. The FW of the witherspoon machine is 
a very good mmio-exec torture test. 

Thanks,

C.

Re: [Qemu-devel] [PATCH 0/4] aspeed: add MMIO exec support to the FMC controller

Posted by Cédric Le Goater 7 years, 4 months ago

On 05/30/2018 02:40 PM, Peter Maydell wrote:
> On 30 May 2018 at 08:49, Cédric Le Goater <clg@kaod.org> wrote:
>> Hello,
>>
>> When MMIO execution support is active, these changes let the Aspeed
>> SoC machine boot directly from CE0. As there is still some
>> issues, the feature is disabled by default and should be activated
>> with :
>>
>>         -global driver=aspeed.smc,property=mmio-exec,value=true
> 
> I'd really rather not add another mmio-exec device until
> we've sorted out making it actually work properly...

Could we still take patch 1-2 which are good model cleanups
for the flash controller ? 

Thanks,

C.