[v1] target/openrisc improvements

[Qemu-devel] [PATCH 01/20] target/openrisc: Remove DISAS_JUMP & DISAS_TB_JUMP

Posted by Richard Henderson 7 years, 5 months ago

These values are unused.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/openrisc/translate.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c
index e7c96ca990..f4f2f37e28 100644
--- a/target/openrisc/translate.c
+++ b/target/openrisc/translate.c
@@ -41,9 +41,7 @@
                   ## __VA_ARGS__)
 
 /* is_jmp field values */
-#define DISAS_JUMP    DISAS_TARGET_0 /* only pc was modified dynamically */
 #define DISAS_UPDATE  DISAS_TARGET_1 /* cpu state was modified dynamically */
-#define DISAS_TB_JUMP DISAS_TARGET_2 /* only pc was modified statically */
 
 typedef struct DisasContext {
     DisasContextBase base;
@@ -1467,8 +1465,6 @@ static void openrisc_tr_tb_stop(DisasContextBase *dcbase, CPUState *cs)
             gen_goto_tb(dc, 0, dc->base.pc_next);
             break;
         case DISAS_NORETURN:
-        case DISAS_JUMP:
-        case DISAS_TB_JUMP:
             break;
         case DISAS_UPDATE:
             /* indicate that the hash table must be used
-- 
2.17.0

Re: [Qemu-devel] [PATCH 01/20] target/openrisc: Remove DISAS_JUMP & DISAS_TB_JUMP

Posted by Philippe Mathieu-Daudé 7 years, 5 months ago

On 05/27/2018 11:13 AM, Richard Henderson wrote:
> These values are unused.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  target/openrisc/translate.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c
> index e7c96ca990..f4f2f37e28 100644
> --- a/target/openrisc/translate.c
> +++ b/target/openrisc/translate.c
> @@ -41,9 +41,7 @@
>                    ## __VA_ARGS__)
>  
>  /* is_jmp field values */
> -#define DISAS_JUMP    DISAS_TARGET_0 /* only pc was modified dynamically */
>  #define DISAS_UPDATE  DISAS_TARGET_1 /* cpu state was modified dynamically */
> -#define DISAS_TB_JUMP DISAS_TARGET_2 /* only pc was modified statically */
>  
>  typedef struct DisasContext {
>      DisasContextBase base;
> @@ -1467,8 +1465,6 @@ static void openrisc_tr_tb_stop(DisasContextBase *dcbase, CPUState *cs)
>              gen_goto_tb(dc, 0, dc->base.pc_next);
>              break;
>          case DISAS_NORETURN:
> -        case DISAS_JUMP:
> -        case DISAS_TB_JUMP:
>              break;
>          case DISAS_UPDATE:
>              /* indicate that the hash table must be used
>

Re: [Qemu-devel] [PATCH 01/20] target/openrisc: Remove DISAS_JUMP & DISAS_TB_JUMP

Posted by Stafford Horne 7 years, 5 months ago

On Sun, May 27, 2018 at 09:13:05AM -0500, Richard Henderson wrote:
> These values are unused.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Stafford Horne <shorne@gmail.com>