bochs-display: add missing break

[Qemu-devel] [PATCH] bochs-display: add missing break

Gerd Hoffmann posted 1 patch 7 years, 8 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180525045344.28347-1-kraxel@redhat.com

Test checkpatch passed

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

Test s390x passed

hw/display/bochs-display.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[Qemu-devel] [PATCH] bochs-display: add missing break

Posted by Gerd Hoffmann 7 years, 8 months ago

Fixes: CID 1391291
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/display/bochs-display.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c
index c33524b558..1187d77576 100644
--- a/hw/display/bochs-display.c
+++ b/hw/display/bochs-display.c
@@ -158,6 +158,7 @@ static int bochs_display_get_mode(BochsDisplayState *s,
         /* best effort: support native endianess only */
         mode->format = PIXMAN_r5g6b5;
         mode->bytepp = 2;
+        break;
     case 32:
         mode->format = s->big_endian_fb
             ? PIXMAN_BE_x8r8g8b8
-- 
2.9.3

Re: [Qemu-devel] [PATCH] bochs-display: add missing break

Posted by Ján Tomko 7 years, 8 months ago

On Fri, May 25, 2018 at 06:53:44AM +0200, Gerd Hoffmann wrote:
>Fixes: CID 1391291
>Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>---
> hw/display/bochs-display.c | 1 +
> 1 file changed, 1 insertion(+)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano

Re: [Qemu-devel] [PATCH] bochs-display: add missing break

Posted by Philippe Mathieu-Daudé 7 years, 8 months ago

On 05/25/2018 01:53 AM, Gerd Hoffmann wrote:
> Fixes: CID 1391291
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/display/bochs-display.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c
> index c33524b558..1187d77576 100644
> --- a/hw/display/bochs-display.c
> +++ b/hw/display/bochs-display.c
> @@ -158,6 +158,7 @@ static int bochs_display_get_mode(BochsDisplayState *s,
>          /* best effort: support native endianess only */
>          mode->format = PIXMAN_r5g6b5;
>          mode->bytepp = 2;
> +        break;

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

>      case 32:
>          mode->format = s->big_endian_fb
>              ? PIXMAN_BE_x8r8g8b8
>