[v2] sheepdog: remove huge BSS object

[Qemu-devel] [PATCH v2 0/2] sheepdog: remove huge BSS object

Paolo Bonzini posted 2 patches 5 years, 11 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180523160721.14018-1-pbonzini@redhat.com

Test checkpatch passed

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

Test s390x passed

block/sheepdog.c | 27 ++++++++++++++-------------
1 file changed, 14 insertions(+), 13 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v2 0/2] sheepdog: remove huge BSS object

Posted by Paolo Bonzini 5 years, 11 months ago

block/sheepdog.o has a 4M static variable that is 90% of QEMU's whole .bss
section.  Since it doesn't really have to be static, we can just use a
heap allocated block.  We can actually make it smaller too. :)

Patch 1 is a related cleanup since we're touching that area of the code.

Paolo

v1->v2: free the data...

Paolo Bonzini (2):
  sheepdog: cleanup repeated expression
  sheepdog: remove huge BSS object

 block/sheepdog.c | 27 ++++++++++++++-------------
 1 file changed, 14 insertions(+), 13 deletions(-)

-- 
2.17.0

Re: [Qemu-devel] [PATCH v2 0/2] sheepdog: remove huge BSS object

Posted by Jeff Cody 5 years, 11 months ago

On Wed, May 23, 2018 at 06:07:19PM +0200, Paolo Bonzini wrote:
> block/sheepdog.o has a 4M static variable that is 90% of QEMU's whole .bss
> section.  Since it doesn't really have to be static, we can just use a
> heap allocated block.  We can actually make it smaller too. :)
> 
> Patch 1 is a related cleanup since we're touching that area of the code.
> 
> Paolo
> 
> v1->v2: free the data...
> 
> Paolo Bonzini (2):
>   sheepdog: cleanup repeated expression
>   sheepdog: remove huge BSS object
> 
>  block/sheepdog.c | 27 ++++++++++++++-------------
>  1 file changed, 14 insertions(+), 13 deletions(-)
> 
> -- 
> 2.17.0
> 

Thanks,

Applied to my block branch:

git://github.com/codyprime/qemu-kvm-jtc block

-Jeff