[v5] softfloat patch roundup

[Qemu-devel] [PATCH v5 15/28] target/hppa: Remove floatX_maybe_silence_nan from conversions

Posted by Richard Henderson 7 years, 5 months ago

This is now handled properly by the generic softfloat code.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/hppa/op_helper.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/target/hppa/op_helper.c b/target/hppa/op_helper.c
index a3af62daf7..912e8d5be4 100644
--- a/target/hppa/op_helper.c
+++ b/target/hppa/op_helper.c
@@ -341,7 +341,6 @@ float64 HELPER(fdiv_d)(CPUHPPAState *env, float64 a, float64 b)
 float64 HELPER(fcnv_s_d)(CPUHPPAState *env, float32 arg)
 {
     float64 ret = float32_to_float64(arg, &env->fp_status);
-    ret = float64_maybe_silence_nan(ret, &env->fp_status);
     update_fr0_op(env, GETPC());
     return ret;
 }
@@ -349,7 +348,6 @@ float64 HELPER(fcnv_s_d)(CPUHPPAState *env, float32 arg)
 float32 HELPER(fcnv_d_s)(CPUHPPAState *env, float64 arg)
 {
     float32 ret = float64_to_float32(arg, &env->fp_status);
-    ret = float32_maybe_silence_nan(ret, &env->fp_status);
     update_fr0_op(env, GETPC());
     return ret;
 }
-- 
2.17.0

Re: [Qemu-devel] [PATCH v5 15/28] target/hppa: Remove floatX_maybe_silence_nan from conversions

Posted by Alex Bennée 7 years, 5 months ago

Richard Henderson <richard.henderson@linaro.org> writes:

> This is now handled properly by the generic softfloat code.
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  target/hppa/op_helper.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/target/hppa/op_helper.c b/target/hppa/op_helper.c
> index a3af62daf7..912e8d5be4 100644
> --- a/target/hppa/op_helper.c
> +++ b/target/hppa/op_helper.c
> @@ -341,7 +341,6 @@ float64 HELPER(fdiv_d)(CPUHPPAState *env, float64 a, float64 b)
>  float64 HELPER(fcnv_s_d)(CPUHPPAState *env, float32 arg)
>  {
>      float64 ret = float32_to_float64(arg, &env->fp_status);
> -    ret = float64_maybe_silence_nan(ret, &env->fp_status);
>      update_fr0_op(env, GETPC());
>      return ret;
>  }
> @@ -349,7 +348,6 @@ float64 HELPER(fcnv_s_d)(CPUHPPAState *env, float32 arg)
>  float32 HELPER(fcnv_d_s)(CPUHPPAState *env, float64 arg)
>  {
>      float32 ret = float64_to_float32(arg, &env->fp_status);
> -    ret = float32_maybe_silence_nan(ret, &env->fp_status);
>      update_fr0_op(env, GETPC());
>      return ret;
>  }


--
Alex Bennée