[Qemu-devel] [PATCH v4 00/11] target/arm: Fixups for ARM_FEATURE_V8_FP16

Richard Henderson posted 11 patches 7 years, 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180512003217.9105-1-richard.henderson@linaro.org
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test s390x passed
target/arm/helper-a64.h    |   2 +
target/arm/helper.h        |   6 +
target/arm/helper-a64.c    |  10 +
target/arm/helper.c        |  38 +++-
target/arm/translate-a64.c | 421 +++++++++++++++++++++++++++++++------
5 files changed, 413 insertions(+), 64 deletions(-)
[Qemu-devel] [PATCH v4 00/11] target/arm: Fixups for ARM_FEATURE_V8_FP16
Posted by Richard Henderson 7 years, 5 months ago
Changes since v3:
  * Fixup rebase vs target-arm.next.  One of the middle
    patches had conflicts resolved incorrectly, so the
    patch set was non-bisectable.

Changes since v2:
  * Rebased vs target-arm.next.
  * Merged Peter's review.
  * Split out return fix as a separate patch.

Changes since v1:
  * Rebased vs master instead of tgt-arm-sve-9.
  * Alex did some additional digging through the ARM xhtml
    and came up with some additional missing instructions.
  * Everything cc'd to qemu-stable.


r~


Alex Bennée (4):
  target/arm: Implement FCMP for fp16
  target/arm: Implement FCSEL for fp16
  target/arm: Implement FMOV (immediate) for fp16
  target/arm: Fix sqrt_f16 exception raising

Richard Henderson (7):
  target/arm: Implement FMOV (general) for fp16
  target/arm: Early exit after unallocated_encoding in disas_fp_int_conv
  target/arm: Implement FCVT (scalar,integer) for fp16
  target/arm: Implement FCVT (scalar,fixed-point) for fp16
  target/arm: Introduce and use read_fp_hreg
  target/arm: Implement FP data-processing (2 source) for fp16
  target/arm: Implement FP data-processing (3 source) for fp16

 target/arm/helper-a64.h    |   2 +
 target/arm/helper.h        |   6 +
 target/arm/helper-a64.c    |  10 +
 target/arm/helper.c        |  38 +++-
 target/arm/translate-a64.c | 421 +++++++++++++++++++++++++++++++------
 5 files changed, 413 insertions(+), 64 deletions(-)

-- 
2.17.0


Re: [Qemu-devel] [PATCH v4 00/11] target/arm: Fixups for ARM_FEATURE_V8_FP16
Posted by Alex Bennée 7 years, 5 months ago
Richard Henderson <richard.henderson@linaro.org> writes:

> Changes since v3:
>   * Fixup rebase vs target-arm.next.  One of the middle
>     patches had conflicts resolved incorrectly, so the
>     patch set was non-bisectable.

I've tested with the new RISU set:

 http://people.linaro.org/~alex.bennee/testcases/arm64.risu/testcases_aarch64_all_half.tar.xz

without any LD/ST opcodes on your rth/tgt-arm-fp16 branch

Tested-by: Alex Bennée <alex.bennee@linaro.org>

>
> Changes since v2:
>   * Rebased vs target-arm.next.
>   * Merged Peter's review.
>   * Split out return fix as a separate patch.
>
> Changes since v1:
>   * Rebased vs master instead of tgt-arm-sve-9.
>   * Alex did some additional digging through the ARM xhtml
>     and came up with some additional missing instructions.
>   * Everything cc'd to qemu-stable.
>
>
> r~
>
>
> Alex Bennée (4):
>   target/arm: Implement FCMP for fp16
>   target/arm: Implement FCSEL for fp16
>   target/arm: Implement FMOV (immediate) for fp16
>   target/arm: Fix sqrt_f16 exception raising
>
> Richard Henderson (7):
>   target/arm: Implement FMOV (general) for fp16
>   target/arm: Early exit after unallocated_encoding in disas_fp_int_conv
>   target/arm: Implement FCVT (scalar,integer) for fp16
>   target/arm: Implement FCVT (scalar,fixed-point) for fp16
>   target/arm: Introduce and use read_fp_hreg
>   target/arm: Implement FP data-processing (2 source) for fp16
>   target/arm: Implement FP data-processing (3 source) for fp16
>
>  target/arm/helper-a64.h    |   2 +
>  target/arm/helper.h        |   6 +
>  target/arm/helper-a64.c    |  10 +
>  target/arm/helper.c        |  38 +++-
>  target/arm/translate-a64.c | 421 +++++++++++++++++++++++++++++++------
>  5 files changed, 413 insertions(+), 64 deletions(-)


--
Alex Bennée

Re: [Qemu-devel] [PATCH v4 00/11] target/arm: Fixups for ARM_FEATURE_V8_FP16
Posted by Peter Maydell 7 years, 5 months ago
On 12 May 2018 at 01:32, Richard Henderson <richard.henderson@linaro.org> wrote:
> Changes since v3:
>   * Fixup rebase vs target-arm.next.  One of the middle
>     patches had conflicts resolved incorrectly, so the
>     patch set was non-bisectable.
>
> Changes since v2:
>   * Rebased vs target-arm.next.
>   * Merged Peter's review.
>   * Split out return fix as a separate patch.
>
> Changes since v1:
>   * Rebased vs master instead of tgt-arm-sve-9.
>   * Alex did some additional digging through the ARM xhtml
>     and came up with some additional missing instructions.
>   * Everything cc'd to qemu-stable.
>
>
> r~
>

Applied all to target-arm.next, thanks.

-- PMM