[v1] Honor CPU_DUMP_FPU

[Qemu-devel] [PATCH 8/9] target/unicore32: Honor CPU_DUMP_FPU

Posted by Richard Henderson 7 years, 5 months ago

Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/unicore32/translate.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/target/unicore32/translate.c b/target/unicore32/translate.c
index 5b51f2166d..63619e7d2c 100644
--- a/target/unicore32/translate.c
+++ b/target/unicore32/translate.c
@@ -2101,7 +2101,9 @@ void uc32_cpu_dump_state(CPUState *cs, FILE *f,
                 psr & (1 << 28) ? 'V' : '-',
                 cpu_mode_names[psr & 0xf]);
 
-    cpu_dump_state_ucf64(env, f, cpu_fprintf, flags);
+    if (flags & CPU_DUMP_FPU) {
+        cpu_dump_state_ucf64(env, f, cpu_fprintf, flags);
+    }
 }
 
 void restore_state_to_opc(CPUUniCore32State *env, TranslationBlock *tb,
-- 
2.17.0

Re: [Qemu-devel] [PATCH 8/9] target/unicore32: Honor CPU_DUMP_FPU

Posted by Philippe Mathieu-Daudé 7 years, 5 months ago

On 05/11/2018 12:52 AM, Richard Henderson wrote:
> Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  target/unicore32/translate.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/target/unicore32/translate.c b/target/unicore32/translate.c
> index 5b51f2166d..63619e7d2c 100644
> --- a/target/unicore32/translate.c
> +++ b/target/unicore32/translate.c
> @@ -2101,7 +2101,9 @@ void uc32_cpu_dump_state(CPUState *cs, FILE *f,
>                  psr & (1 << 28) ? 'V' : '-',
>                  cpu_mode_names[psr & 0xf]);
>  
> -    cpu_dump_state_ucf64(env, f, cpu_fprintf, flags);
> +    if (flags & CPU_DUMP_FPU) {
> +        cpu_dump_state_ucf64(env, f, cpu_fprintf, flags);
> +    }
>  }
>  
>  void restore_state_to_opc(CPUUniCore32State *env, TranslationBlock *tb,
>