hw/ide/ahci: Keep ALLWINNER_AHCI() macro internal

[Qemu-devel] [PATCH] hw/ide/ahci: Keep ALLWINNER_AHCI() macro internal

Philippe Mathieu-Daudé posted 1 patch 7 years, 5 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180508144948.14071-1-f4bug@amsat.org

Test checkpatch passed

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

Test s390x passed

hw/ide/ahci_internal.h  | 3 ---
hw/ide/ahci-allwinner.c | 3 +++
2 files changed, 3 insertions(+), 3 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] hw/ide/ahci: Keep ALLWINNER_AHCI() macro internal

Posted by Philippe Mathieu-Daudé 7 years, 5 months ago

The ALLWINNER_AHCI() macro is only used in ahci-allwinner.c.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/ide/ahci_internal.h  | 3 ---
 hw/ide/ahci-allwinner.c | 3 +++
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/ide/ahci_internal.h b/hw/ide/ahci_internal.h
index 8c755d4ca1..1a25d6c039 100644
--- a/hw/ide/ahci_internal.h
+++ b/hw/ide/ahci_internal.h
@@ -375,7 +375,4 @@ void ahci_reset(AHCIState *s);
 
 #define SYSBUS_AHCI(obj) OBJECT_CHECK(SysbusAHCIState, (obj), TYPE_SYSBUS_AHCI)
 
-#define ALLWINNER_AHCI(obj) OBJECT_CHECK(AllwinnerAHCIState, (obj), \
-                       TYPE_ALLWINNER_AHCI)
-
 #endif /* HW_IDE_AHCI_H */
diff --git a/hw/ide/ahci-allwinner.c b/hw/ide/ahci-allwinner.c
index 5397483fd8..2fd95078ba 100644
--- a/hw/ide/ahci-allwinner.c
+++ b/hw/ide/ahci-allwinner.c
@@ -24,6 +24,9 @@
 
 #include "trace.h"
 
+#define ALLWINNER_AHCI(obj) \
+        OBJECT_CHECK(AllwinnerAHCIState, (obj), TYPE_ALLWINNER_AHCI)
+
 #define ALLWINNER_AHCI_BISTAFR    ((0xa0 - ALLWINNER_AHCI_MMIO_OFF) / 4)
 #define ALLWINNER_AHCI_BISTCR     ((0xa4 - ALLWINNER_AHCI_MMIO_OFF) / 4)
 #define ALLWINNER_AHCI_BISTFCTR   ((0xa8 - ALLWINNER_AHCI_MMIO_OFF) / 4)
-- 
2.17.0

Re: [Qemu-devel] [PATCH] hw/ide/ahci: Keep ALLWINNER_AHCI() macro internal

Posted by John Snow 7 years, 5 months ago


On 05/08/2018 10:49 AM, Philippe Mathieu-Daudé wrote:
> The ALLWINNER_AHCI() macro is only used in ahci-allwinner.c.
> 

extra internal!

> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: John Snow <jsnow@redhat.com>

Feel free to stage in trivial, thanks.