ui/gtk: Only try to initialize EGL/X11 if GtkGlArea failed

[Qemu-devel] [PATCH] ui/gtk: Only try to initialize EGL/X11 if GtkGlArea failed

Tomeu Vizoso posted 1 patch 7 years, 5 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180507134237.14996-1-tomeu.vizoso@collabora.com

Test checkpatch passed

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

Test s390x passed

ui/gtk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] ui/gtk: Only try to initialize EGL/X11 if GtkGlArea failed

Posted by Tomeu Vizoso 7 years, 5 months ago

The commit referenced below changed the logic by causing the gtk-egl
backend to be initialized regardless of whether GtkGlArea initialization
succeeded. This causes eglInitialize to crash in Wayland systems without
XWayland.

This patch restores the previous logic.

Fixes: 4c70280592f5 ("ui/gtk: use GtkGlArea on wayland only")
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
---
 ui/gtk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/gtk.c b/ui/gtk.c
index ef5bc42094a3..72e2e246244d 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -2448,7 +2448,7 @@ static void early_gtk_display_init(DisplayOptions *opts)
         if (GDK_IS_WAYLAND_DISPLAY(gdk_display_get_default())) {
             gtk_use_gl_area = true;
             gtk_gl_area_init();
-        }
+        } else
 #endif
         {
             gtk_egl_init();
-- 
2.17.0

Re: [Qemu-devel] [PATCH] ui/gtk: Only try to initialize EGL/X11 if GtkGlArea failed

Posted by Gerd Hoffmann 7 years, 5 months ago

On Mon, May 07, 2018 at 03:42:37PM +0200, Tomeu Vizoso wrote:
> The commit referenced below changed the logic by causing the gtk-egl
> backend to be initialized regardless of whether GtkGlArea initialization
> succeeded. This causes eglInitialize to crash in Wayland systems without
> XWayland.
> 
> This patch restores the previous logic.

Added to ui patch queue.

thanks,
  Gerd