Revert "Makefile: add target to print generated files"

[Qemu-devel] [PATCH] Revert "Makefile: add target to print generated files"

Markus Armbruster posted 1 patch 7 years, 5 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180504054241.6833-1-armbru@redhat.com

Test checkpatch passed

Test docker-build@min-glib passed

Test docker-mingw@fedora passed

Test s390x passed

Makefile | 3 ---
1 file changed, 3 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] Revert "Makefile: add target to print generated files"

Posted by Markus Armbruster 7 years, 5 months ago

This reverts commit 9578f8cc3e8bd71de8e3f543dc7b95644d64824e.

The patch snuck in by accident without having been posted to
qemu-devel.  It's entirely redundant: existing target print-% already
serves the purpose.

Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 Makefile | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/Makefile b/Makefile
index d71dd5bea4..f36110d4aa 100644
--- a/Makefile
+++ b/Makefile
@@ -1047,9 +1047,6 @@ endif
 include $(SRC_PATH)/tests/docker/Makefile.include
 include $(SRC_PATH)/tests/vm/Makefile.include
 
-printgen:
-	@echo $(GENERATED_FILES)
-
 .PHONY: help
 help:
 	@echo  'Generic targets:'
-- 
2.13.6

Re: [Qemu-devel] [PATCH] Revert "Makefile: add target to print generated files"

Posted by Eric Blake 7 years, 5 months ago

On 05/04/2018 12:42 AM, Markus Armbruster wrote:
> This reverts commit 9578f8cc3e8bd71de8e3f543dc7b95644d64824e.
> 
> The patch snuck in by accident without having been posted to
> qemu-devel.  It's entirely redundant: existing target print-% already
> serves the purpose.
> 
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   Makefile | 3 ---
>   1 file changed, 3 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/Makefile b/Makefile
> index d71dd5bea4..f36110d4aa 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1047,9 +1047,6 @@ endif
>   include $(SRC_PATH)/tests/docker/Makefile.include
>   include $(SRC_PATH)/tests/vm/Makefile.include
>   
> -printgen:
> -	@echo $(GENERATED_FILES)
> -
>   .PHONY: help
>   help:
>   	@echo  'Generic targets:'
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org