[v1] target-microblaze: Add support for Extended Addressing

[Qemu-devel] [PATCH v1 29/29] target-microblaze: Allow address sizes between 32 and 64 bits

Posted by Edgar E. Iglesias 7 years, 5 months ago

From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>

Allow address sizes between 32 and 64 bits.

Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
 target/microblaze/cpu.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c
index d0649fdaaa..8c1f850ab1 100644
--- a/target/microblaze/cpu.c
+++ b/target/microblaze/cpu.c
@@ -155,9 +155,8 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **errp)
         return;
     }
 
-    if (cpu->cfg.addr_size != 32) {
-        error_setg(errp, "addr-size %d is out of range. "
-                   "Only 32bit is supported.",
+    if (cpu->cfg.addr_size < 32 || cpu->cfg.addr_size > 64) {
+        error_setg(errp, "addr-size %d is out of range (32 - 64)",
                    cpu->cfg.addr_size);
         return;
     }
-- 
2.14.1

Re: [Qemu-devel] [PATCH v1 29/29] target-microblaze: Allow address sizes between 32 and 64 bits

Posted by Richard Henderson 7 years, 5 months ago

On 05/03/2018 02:19 AM, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
> 
> Allow address sizes between 32 and 64 bits.
> 
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> ---
>  target/microblaze/cpu.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~

Re: [Qemu-devel] [PATCH v1 29/29] target-microblaze: Allow address sizes between 32 and 64 bits

Posted by Alistair Francis 7 years, 5 months ago

On Thu, May 3, 2018 at 2:38 AM Edgar E. Iglesias <edgar.iglesias@gmail.com>
wrote:

> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>

> Allow address sizes between 32 and 64 bits.

> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>   target/microblaze/cpu.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)

> diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c
> index d0649fdaaa..8c1f850ab1 100644
> --- a/target/microblaze/cpu.c
> +++ b/target/microblaze/cpu.c
> @@ -155,9 +155,8 @@ static void mb_cpu_realizefn(DeviceState *dev, Error
**errp)
>           return;
>       }

> -    if (cpu->cfg.addr_size != 32) {
> -        error_setg(errp, "addr-size %d is out of range. "
> -                   "Only 32bit is supported.",
> +    if (cpu->cfg.addr_size < 32 || cpu->cfg.addr_size > 64) {
> +        error_setg(errp, "addr-size %d is out of range (32 - 64)",
>                      cpu->cfg.addr_size);
>           return;
>       }
> --
> 2.14.1