[Qemu-devel] [PATCH 0/3] qemu-io/img: Fix -U/force-share conflict testing

Max Reitz posted 3 patches 7 years, 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180502202051.15493-1-mreitz@redhat.com
Test checkpatch passed
Test docker-build@min-glib passed
Test docker-mingw@fedora passed
Test s390x passed
qemu-img.c                 |  4 ++--
qemu-io.c                  |  4 ++--
tests/qemu-iotests/153     | 17 +++++++++++++++++
tests/qemu-iotests/153.out | 16 ++++++++++++++++
4 files changed, 37 insertions(+), 4 deletions(-)
[Qemu-devel] [PATCH 0/3] qemu-io/img: Fix -U/force-share conflict testing
Posted by Max Reitz 7 years, 5 months ago
qemu-img and qemu-io try to detect when you use both -U and force-share
manually, but a conflict is not rejected with an error message but with
a segmentation fault.  I guess that works, but it's probably not the way
it was meant to be.


Max Reitz (3):
  qemu-io: Use purely string blockdev options
  qemu-img: Use only string options in img_open_opts
  iotests: Add test for -U/force-share conflicts

 qemu-img.c                 |  4 ++--
 qemu-io.c                  |  4 ++--
 tests/qemu-iotests/153     | 17 +++++++++++++++++
 tests/qemu-iotests/153.out | 16 ++++++++++++++++
 4 files changed, 37 insertions(+), 4 deletions(-)

-- 
2.14.3


Re: [Qemu-devel] [PATCH 0/3] qemu-io/img: Fix -U/force-share conflict testing
Posted by Max Reitz 7 years, 5 months ago
On 2018-05-02 22:20, Max Reitz wrote:
> qemu-img and qemu-io try to detect when you use both -U and force-share
> manually, but a conflict is not rejected with an error message but with
> a segmentation fault.  I guess that works, but it's probably not the way
> it was meant to be.
> 
> 
> Max Reitz (3):
>   qemu-io: Use purely string blockdev options
>   qemu-img: Use only string options in img_open_opts
>   iotests: Add test for -U/force-share conflicts
> 
>  qemu-img.c                 |  4 ++--
>  qemu-io.c                  |  4 ++--
>  tests/qemu-iotests/153     | 17 +++++++++++++++++
>  tests/qemu-iotests/153.out | 16 ++++++++++++++++
>  4 files changed, 37 insertions(+), 4 deletions(-)

Thanks for the review, applied to my block branch.

Max