[v1] s390x/pci: add common fmb

[Qemu-devel] [RFC PATCH 0/1] s390x/pci: add common fmb

Yi Min Zhao posted 1 patch 7 years, 6 months ago

Diff against v1 v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180427100244.14258-1-zyimin@linux.ibm.com

Test checkpatch failed

Test docker-build@min-glib passed

Test docker-mingw@fedora passed

Test s390x passed

There is a newer version of this series

hw/s390x/s390-pci-bus.c  |  3 ++-
hw/s390x/s390-pci-bus.h  | 16 +++++++++++++
hw/s390x/s390-pci-inst.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++-
hw/s390x/s390-pci-inst.h |  1 +
4 files changed, 78 insertions(+), 2 deletions(-)

Expand all Fold all

[Qemu-devel] [RFC PATCH 0/1] s390x/pci: add common fmb

Posted by Yi Min Zhao 7 years, 6 months ago

Currently the code misses FMB functionality. This patch fixup this. Only common
FMB is supported now.

bb/zyimin/fmb

Yi Min Zhao (1):
  s390x/pci: add common fmb

 hw/s390x/s390-pci-bus.c  |  3 ++-
 hw/s390x/s390-pci-bus.h  | 16 +++++++++++++
 hw/s390x/s390-pci-inst.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++-
 hw/s390x/s390-pci-inst.h |  1 +
 4 files changed, 78 insertions(+), 2 deletions(-)

-- 
2.15.1 (Apple Git-101)

Re: [Qemu-devel] [RFC PATCH 0/1] s390x/pci: add common fmb

Posted by Yi Min Zhao 7 years, 6 months ago

Wrong operation. Please ignore this series.


在 2018/4/27 下午6:02, Yi Min Zhao 写道:
> Currently the code misses FMB functionality. This patch fixup this. Only common
> FMB is supported now.
>
> bb/zyimin/fmb
>
> Yi Min Zhao (1):
>    s390x/pci: add common fmb
>
>   hw/s390x/s390-pci-bus.c  |  3 ++-
>   hw/s390x/s390-pci-bus.h  | 16 +++++++++++++
>   hw/s390x/s390-pci-inst.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++-
>   hw/s390x/s390-pci-inst.h |  1 +
>   4 files changed, 78 insertions(+), 2 deletions(-)
>

Re: [Qemu-devel] [RFC PATCH 0/1] s390x/pci: add common fmb

Posted by no-reply@patchew.org 7 years, 6 months ago

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180427100244.14258-1-zyimin@linux.ibm.com
Subject: [Qemu-devel] [RFC PATCH 0/1] s390x/pci: add common fmb

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20180427100244.14258-1-zyimin@linux.ibm.com -> patchew/20180427100244.14258-1-zyimin@linux.ibm.com
Switched to a new branch 'test'
72e2d3f30c s390x/pci: add common fmb

=== OUTPUT BEGIN ===
Checking PATCH 1/1: s390x/pci: add common fmb...
ERROR: spaces prohibited around that ':' (ctx:WxW)
#50: FILE: hw/s390x/s390-pci-bus.h:293:
+    uint32_t format  : 8;
                      ^

ERROR: spaces prohibited around that ':' (ctx:WxW)
#51: FILE: hw/s390x/s390-pci-bus.h:294:
+    uint32_t fmt_ind : 24;
                      ^

ERROR: code indent should never use tabs
#185: FILE: hw/s390x/s390-pci-inst.c:1084:
+^I^I^I                    fmb_update, pbdev);$

total: 3 errors, 0 warnings, 158 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com