[Qemu-devel] [PATCH v3 28/46] tests/tcg/aarch64: add Makefile.target

Alex Bennée posted 46 patches 7 years, 6 months ago
There is a newer version of this series
[Qemu-devel] [PATCH v3 28/46] tests/tcg/aarch64: add Makefile.target
Posted by Alex Bennée 7 years, 6 months ago
Nothing much here yet.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/tcg/aarch64/Makefile.target | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 tests/tcg/aarch64/Makefile.target

diff --git a/tests/tcg/aarch64/Makefile.target b/tests/tcg/aarch64/Makefile.target
new file mode 100644
index 0000000000..4ac8fbe73f
--- /dev/null
+++ b/tests/tcg/aarch64/Makefile.target
@@ -0,0 +1,5 @@
+# -*- Mode: makefile -*-
+#
+# AArch64 specific tweaks
+
+fcvt: LDFLAGS+=-lm
-- 
2.17.0


Re: [Qemu-devel] [PATCH v3 28/46] tests/tcg/aarch64: add Makefile.target
Posted by Philippe Mathieu-Daudé 7 years, 6 months ago
On 04/24/2018 12:23 PM, Alex Bennée wrote:
> Nothing much here yet.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  tests/tcg/aarch64/Makefile.target | 5 +++++
>  1 file changed, 5 insertions(+)
>  create mode 100644 tests/tcg/aarch64/Makefile.target
> 
> diff --git a/tests/tcg/aarch64/Makefile.target b/tests/tcg/aarch64/Makefile.target
> new file mode 100644
> index 0000000000..4ac8fbe73f
> --- /dev/null
> +++ b/tests/tcg/aarch64/Makefile.target
> @@ -0,0 +1,5 @@
> +# -*- Mode: makefile -*-
> +#
> +# AArch64 specific tweaks
> +
> +fcvt: LDFLAGS+=-lm
> 

You missed tests/tcg/aarch64/Makefile.include with:

DOCKER_IMAGE=debian-arm64-cross
DOCKER_CROSS_COMPILER=aarch64-linux-gnueabi-gcc

Re: [Qemu-devel] [PATCH v3 28/46] tests/tcg/aarch64: add Makefile.target
Posted by Alex Bennée 7 years, 6 months ago
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> On 04/24/2018 12:23 PM, Alex Bennée wrote:
>> Nothing much here yet.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>  tests/tcg/aarch64/Makefile.target | 5 +++++
>>  1 file changed, 5 insertions(+)
>>  create mode 100644 tests/tcg/aarch64/Makefile.target
>>
>> diff --git a/tests/tcg/aarch64/Makefile.target b/tests/tcg/aarch64/Makefile.target
>> new file mode 100644
>> index 0000000000..4ac8fbe73f
>> --- /dev/null
>> +++ b/tests/tcg/aarch64/Makefile.target
>> @@ -0,0 +1,5 @@
>> +# -*- Mode: makefile -*-
>> +#
>> +# AArch64 specific tweaks
>> +
>> +fcvt: LDFLAGS+=-lm
>>
>
> You missed tests/tcg/aarch64/Makefile.include with:
>
> DOCKER_IMAGE=debian-arm64-cross
> DOCKER_CROSS_COMPILER=aarch64-linux-gnueabi-gcc

Doh.. of course I was testing with my cross-compiler and forgot about
this ;-)



--
Alex Bennée

Re: [Qemu-devel] [PATCH v3 28/46] tests/tcg/aarch64: add Makefile.target
Posted by Philippe Mathieu-Daudé 7 years, 6 months ago
On 04/25/2018 05:43 AM, Alex Bennée wrote:
> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
>> On 04/24/2018 12:23 PM, Alex Bennée wrote:
>>> Nothing much here yet.
>>>
>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>> ---
>>>  tests/tcg/aarch64/Makefile.target | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>>  create mode 100644 tests/tcg/aarch64/Makefile.target
>>>
>>> diff --git a/tests/tcg/aarch64/Makefile.target b/tests/tcg/aarch64/Makefile.target
>>> new file mode 100644
>>> index 0000000000..4ac8fbe73f
>>> --- /dev/null
>>> +++ b/tests/tcg/aarch64/Makefile.target
>>> @@ -0,0 +1,5 @@
>>> +# -*- Mode: makefile -*-
>>> +#
>>> +# AArch64 specific tweaks
>>> +
>>> +fcvt: LDFLAGS+=-lm
>>>
>>
>> You missed tests/tcg/aarch64/Makefile.include with:
>>
>> DOCKER_IMAGE=debian-arm64-cross
>> DOCKER_CROSS_COMPILER=aarch64-linux-gnueabi-gcc

Err this is not gnueabi, the correct line is:

DOCKER_CROSS_COMPILER=aarch64-linux-gnu-gcc

> 
> Doh.. of course I was testing with my cross-compiler and forgot about
> this ;-)