linux-user/aarch64/cpu_loop.inc.c | 1 + linux-user/aarch64/prologue.inc.c | 21 + linux-user/aarch64/signal.inc.c | 557 +++ linux-user/alpha/cpu_loop.inc.c | 191 + linux-user/alpha/prologue.inc.c | 9 + linux-user/alpha/signal.inc.c | 259 ++ linux-user/arm/cpu_loop.inc.c | 488 +++ linux-user/arm/prologue.inc.c | 23 + linux-user/arm/signal.inc.c | 750 ++++ linux-user/cris/cpu_loop.inc.c | 67 + linux-user/cris/prologue.inc.c | 19 + linux-user/cris/signal.inc.c | 167 + linux-user/hppa/cpu_loop.inc.c | 178 + linux-user/hppa/prologue.inc.c | 8 + linux-user/hppa/signal.inc.c | 188 + linux-user/i386/cpu_loop.inc.c | 229 ++ linux-user/i386/prologue.inc.c | 113 + linux-user/i386/signal.inc.c | 580 +++ linux-user/m68k/cpu_loop.inc.c | 115 + linux-user/m68k/prologue.inc.c | 26 + linux-user/m68k/signal.inc.c | 407 +++ linux-user/main.c | 4318 +--------------------- linux-user/microblaze/cpu_loop.inc.c | 116 + linux-user/microblaze/prologue.inc.c | 35 + linux-user/microblaze/signal.inc.c | 227 ++ linux-user/mips/cpu_loop.inc.c | 695 ++++ linux-user/mips/prologue.inc.c | 25 + linux-user/mips/signal.inc.c | 379 ++ linux-user/mips64/cpu_loop.inc.c | 1 + linux-user/mips64/prologue.inc.c | 1 + linux-user/mips64/signal.inc.c | 1 + linux-user/nios2/cpu_loop.inc.c | 98 + linux-user/nios2/prologue.inc.c | 29 + linux-user/nios2/signal.inc.c | 232 ++ linux-user/openrisc/cpu_loop.inc.c | 81 + linux-user/openrisc/prologue.inc.c | 9 + linux-user/openrisc/signal.inc.c | 209 ++ linux-user/ppc/cpu_loop.inc.c | 538 +++ linux-user/ppc/prologue.inc.c | 16 + linux-user/ppc/signal.inc.c | 668 ++++ linux-user/riscv/cpu_loop.inc.c | 89 + linux-user/riscv/prologue.inc.c | 4 + linux-user/riscv/signal.inc.c | 196 + linux-user/s390x/cpu_loop.inc.c | 132 + linux-user/s390x/prologue.inc.c | 8 + linux-user/s390x/signal.inc.c | 306 ++ linux-user/sh4/cpu_loop.inc.c | 78 + linux-user/sh4/prologue.inc.c | 8 + linux-user/sh4/signal.inc.c | 328 ++ linux-user/signal.c | 6623 +--------------------------------- linux-user/sparc/cpu_loop.inc.c | 271 ++ linux-user/sparc/prologue.inc.c | 10 + linux-user/sparc/signal.inc.c | 602 +++ linux-user/sparc64/cpu_loop.inc.c | 1 + linux-user/sparc64/prologue.inc.c | 1 + linux-user/sparc64/signal.inc.c | 1 + linux-user/tilegx/cpu_loop.inc.c | 251 ++ linux-user/tilegx/prologue.inc.c | 10 + linux-user/tilegx/signal.inc.c | 163 + linux-user/x86_64/cpu_loop.inc.c | 1 + linux-user/x86_64/prologue.inc.c | 1 + linux-user/x86_64/signal.inc.c | 1 + linux-user/xtensa/cpu_loop.inc.c | 231 ++ linux-user/xtensa/prologue.inc.c | 8 + linux-user/xtensa/signal.inc.c | 253 ++ 65 files changed, 10776 insertions(+), 10875 deletions(-) create mode 100644 linux-user/aarch64/cpu_loop.inc.c create mode 100644 linux-user/aarch64/prologue.inc.c create mode 100644 linux-user/aarch64/signal.inc.c create mode 100644 linux-user/alpha/cpu_loop.inc.c create mode 100644 linux-user/alpha/prologue.inc.c create mode 100644 linux-user/alpha/signal.inc.c create mode 100644 linux-user/arm/cpu_loop.inc.c create mode 100644 linux-user/arm/prologue.inc.c create mode 100644 linux-user/arm/signal.inc.c create mode 100644 linux-user/cris/cpu_loop.inc.c create mode 100644 linux-user/cris/prologue.inc.c create mode 100644 linux-user/cris/signal.inc.c create mode 100644 linux-user/hppa/cpu_loop.inc.c create mode 100644 linux-user/hppa/prologue.inc.c create mode 100644 linux-user/hppa/signal.inc.c create mode 100644 linux-user/i386/cpu_loop.inc.c create mode 100644 linux-user/i386/prologue.inc.c create mode 100644 linux-user/i386/signal.inc.c create mode 100644 linux-user/m68k/cpu_loop.inc.c create mode 100644 linux-user/m68k/prologue.inc.c create mode 100644 linux-user/m68k/signal.inc.c create mode 100644 linux-user/microblaze/cpu_loop.inc.c create mode 100644 linux-user/microblaze/prologue.inc.c create mode 100644 linux-user/microblaze/signal.inc.c create mode 100644 linux-user/mips/cpu_loop.inc.c create mode 100644 linux-user/mips/prologue.inc.c create mode 100644 linux-user/mips/signal.inc.c create mode 100644 linux-user/mips64/cpu_loop.inc.c create mode 100644 linux-user/mips64/prologue.inc.c create mode 100644 linux-user/mips64/signal.inc.c create mode 100644 linux-user/nios2/cpu_loop.inc.c create mode 100644 linux-user/nios2/prologue.inc.c create mode 100644 linux-user/nios2/signal.inc.c create mode 100644 linux-user/openrisc/cpu_loop.inc.c create mode 100644 linux-user/openrisc/prologue.inc.c create mode 100644 linux-user/openrisc/signal.inc.c create mode 100644 linux-user/ppc/cpu_loop.inc.c create mode 100644 linux-user/ppc/prologue.inc.c create mode 100644 linux-user/ppc/signal.inc.c create mode 100644 linux-user/riscv/cpu_loop.inc.c create mode 100644 linux-user/riscv/prologue.inc.c create mode 100644 linux-user/riscv/signal.inc.c create mode 100644 linux-user/s390x/cpu_loop.inc.c create mode 100644 linux-user/s390x/prologue.inc.c create mode 100644 linux-user/s390x/signal.inc.c create mode 100644 linux-user/sh4/cpu_loop.inc.c create mode 100644 linux-user/sh4/prologue.inc.c create mode 100644 linux-user/sh4/signal.inc.c create mode 100644 linux-user/sparc/cpu_loop.inc.c create mode 100644 linux-user/sparc/prologue.inc.c create mode 100644 linux-user/sparc/signal.inc.c create mode 100644 linux-user/sparc64/cpu_loop.inc.c create mode 100644 linux-user/sparc64/prologue.inc.c create mode 100644 linux-user/sparc64/signal.inc.c create mode 100644 linux-user/tilegx/cpu_loop.inc.c create mode 100644 linux-user/tilegx/prologue.inc.c create mode 100644 linux-user/tilegx/signal.inc.c create mode 100644 linux-user/x86_64/cpu_loop.inc.c create mode 100644 linux-user/x86_64/prologue.inc.c create mode 100644 linux-user/x86_64/signal.inc.c create mode 100644 linux-user/xtensa/cpu_loop.inc.c create mode 100644 linux-user/xtensa/prologue.inc.c create mode 100644 linux-user/xtensa/signal.inc.c
Some files like signal.c are really hard to read because all architectures are mixed in the same file. This series moves from signal.c these parts to the architecture dedicated directories in linux-user. Moerover, this allows to compare easier functions between architectures (it helps to debug problems). Adding new functions for a new architecture will be facilitated too. As we are doing that for signal.c, we can also do that for main.c, for the cpu loop part and the cpu loop prologue too. checkpatch.pl is not happy... but I only want to move code from a file to another. I don't want to change the content of the parts I move. Laurent Vivier (5): linux-user: cleanup signal.c linux-user: remove unneeded #ifdef in signal.c linux-user: define TARGET_ARCH_HAS_SETUP_FRAME linux-user: cleanup cpu_loop() linux-user: cleanup main() linux-user/aarch64/cpu_loop.inc.c | 1 + linux-user/aarch64/prologue.inc.c | 21 + linux-user/aarch64/signal.inc.c | 557 +++ linux-user/alpha/cpu_loop.inc.c | 191 + linux-user/alpha/prologue.inc.c | 9 + linux-user/alpha/signal.inc.c | 259 ++ linux-user/arm/cpu_loop.inc.c | 488 +++ linux-user/arm/prologue.inc.c | 23 + linux-user/arm/signal.inc.c | 750 ++++ linux-user/cris/cpu_loop.inc.c | 67 + linux-user/cris/prologue.inc.c | 19 + linux-user/cris/signal.inc.c | 167 + linux-user/hppa/cpu_loop.inc.c | 178 + linux-user/hppa/prologue.inc.c | 8 + linux-user/hppa/signal.inc.c | 188 + linux-user/i386/cpu_loop.inc.c | 229 ++ linux-user/i386/prologue.inc.c | 113 + linux-user/i386/signal.inc.c | 580 +++ linux-user/m68k/cpu_loop.inc.c | 115 + linux-user/m68k/prologue.inc.c | 26 + linux-user/m68k/signal.inc.c | 407 +++ linux-user/main.c | 4318 +--------------------- linux-user/microblaze/cpu_loop.inc.c | 116 + linux-user/microblaze/prologue.inc.c | 35 + linux-user/microblaze/signal.inc.c | 227 ++ linux-user/mips/cpu_loop.inc.c | 695 ++++ linux-user/mips/prologue.inc.c | 25 + linux-user/mips/signal.inc.c | 379 ++ linux-user/mips64/cpu_loop.inc.c | 1 + linux-user/mips64/prologue.inc.c | 1 + linux-user/mips64/signal.inc.c | 1 + linux-user/nios2/cpu_loop.inc.c | 98 + linux-user/nios2/prologue.inc.c | 29 + linux-user/nios2/signal.inc.c | 232 ++ linux-user/openrisc/cpu_loop.inc.c | 81 + linux-user/openrisc/prologue.inc.c | 9 + linux-user/openrisc/signal.inc.c | 209 ++ linux-user/ppc/cpu_loop.inc.c | 538 +++ linux-user/ppc/prologue.inc.c | 16 + linux-user/ppc/signal.inc.c | 668 ++++ linux-user/riscv/cpu_loop.inc.c | 89 + linux-user/riscv/prologue.inc.c | 4 + linux-user/riscv/signal.inc.c | 196 + linux-user/s390x/cpu_loop.inc.c | 132 + linux-user/s390x/prologue.inc.c | 8 + linux-user/s390x/signal.inc.c | 306 ++ linux-user/sh4/cpu_loop.inc.c | 78 + linux-user/sh4/prologue.inc.c | 8 + linux-user/sh4/signal.inc.c | 328 ++ linux-user/signal.c | 6623 +--------------------------------- linux-user/sparc/cpu_loop.inc.c | 271 ++ linux-user/sparc/prologue.inc.c | 10 + linux-user/sparc/signal.inc.c | 602 +++ linux-user/sparc64/cpu_loop.inc.c | 1 + linux-user/sparc64/prologue.inc.c | 1 + linux-user/sparc64/signal.inc.c | 1 + linux-user/tilegx/cpu_loop.inc.c | 251 ++ linux-user/tilegx/prologue.inc.c | 10 + linux-user/tilegx/signal.inc.c | 163 + linux-user/x86_64/cpu_loop.inc.c | 1 + linux-user/x86_64/prologue.inc.c | 1 + linux-user/x86_64/signal.inc.c | 1 + linux-user/xtensa/cpu_loop.inc.c | 231 ++ linux-user/xtensa/prologue.inc.c | 8 + linux-user/xtensa/signal.inc.c | 253 ++ 65 files changed, 10776 insertions(+), 10875 deletions(-) create mode 100644 linux-user/aarch64/cpu_loop.inc.c create mode 100644 linux-user/aarch64/prologue.inc.c create mode 100644 linux-user/aarch64/signal.inc.c create mode 100644 linux-user/alpha/cpu_loop.inc.c create mode 100644 linux-user/alpha/prologue.inc.c create mode 100644 linux-user/alpha/signal.inc.c create mode 100644 linux-user/arm/cpu_loop.inc.c create mode 100644 linux-user/arm/prologue.inc.c create mode 100644 linux-user/arm/signal.inc.c create mode 100644 linux-user/cris/cpu_loop.inc.c create mode 100644 linux-user/cris/prologue.inc.c create mode 100644 linux-user/cris/signal.inc.c create mode 100644 linux-user/hppa/cpu_loop.inc.c create mode 100644 linux-user/hppa/prologue.inc.c create mode 100644 linux-user/hppa/signal.inc.c create mode 100644 linux-user/i386/cpu_loop.inc.c create mode 100644 linux-user/i386/prologue.inc.c create mode 100644 linux-user/i386/signal.inc.c create mode 100644 linux-user/m68k/cpu_loop.inc.c create mode 100644 linux-user/m68k/prologue.inc.c create mode 100644 linux-user/m68k/signal.inc.c create mode 100644 linux-user/microblaze/cpu_loop.inc.c create mode 100644 linux-user/microblaze/prologue.inc.c create mode 100644 linux-user/microblaze/signal.inc.c create mode 100644 linux-user/mips/cpu_loop.inc.c create mode 100644 linux-user/mips/prologue.inc.c create mode 100644 linux-user/mips/signal.inc.c create mode 100644 linux-user/mips64/cpu_loop.inc.c create mode 100644 linux-user/mips64/prologue.inc.c create mode 100644 linux-user/mips64/signal.inc.c create mode 100644 linux-user/nios2/cpu_loop.inc.c create mode 100644 linux-user/nios2/prologue.inc.c create mode 100644 linux-user/nios2/signal.inc.c create mode 100644 linux-user/openrisc/cpu_loop.inc.c create mode 100644 linux-user/openrisc/prologue.inc.c create mode 100644 linux-user/openrisc/signal.inc.c create mode 100644 linux-user/ppc/cpu_loop.inc.c create mode 100644 linux-user/ppc/prologue.inc.c create mode 100644 linux-user/ppc/signal.inc.c create mode 100644 linux-user/riscv/cpu_loop.inc.c create mode 100644 linux-user/riscv/prologue.inc.c create mode 100644 linux-user/riscv/signal.inc.c create mode 100644 linux-user/s390x/cpu_loop.inc.c create mode 100644 linux-user/s390x/prologue.inc.c create mode 100644 linux-user/s390x/signal.inc.c create mode 100644 linux-user/sh4/cpu_loop.inc.c create mode 100644 linux-user/sh4/prologue.inc.c create mode 100644 linux-user/sh4/signal.inc.c create mode 100644 linux-user/sparc/cpu_loop.inc.c create mode 100644 linux-user/sparc/prologue.inc.c create mode 100644 linux-user/sparc/signal.inc.c create mode 100644 linux-user/sparc64/cpu_loop.inc.c create mode 100644 linux-user/sparc64/prologue.inc.c create mode 100644 linux-user/sparc64/signal.inc.c create mode 100644 linux-user/tilegx/cpu_loop.inc.c create mode 100644 linux-user/tilegx/prologue.inc.c create mode 100644 linux-user/tilegx/signal.inc.c create mode 100644 linux-user/x86_64/cpu_loop.inc.c create mode 100644 linux-user/x86_64/prologue.inc.c create mode 100644 linux-user/x86_64/signal.inc.c create mode 100644 linux-user/xtensa/cpu_loop.inc.c create mode 100644 linux-user/xtensa/prologue.inc.c create mode 100644 linux-user/xtensa/signal.inc.c -- 2.14.3
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180322215833.7713-1-laurent@vivier.eu
Subject: [Qemu-devel] [PATCH for 2.13 0/5] linux-user: move arch specific parts to arch directories
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
586d8b371e linux-user: cleanup main()
4f63afd0b5 linux-user: cleanup cpu_loop()
aa2bebb6ad linux-user: define TARGET_ARCH_HAS_SETUP_FRAME
647d489924 linux-user: remove unneeded #ifdef in signal.c
ea340535fe linux-user: cleanup signal.c
=== OUTPUT BEGIN ===
Checking PATCH 1/5: linux-user: cleanup signal.c...
ERROR: code indent should never use tabs
#873: FILE: linux-user/arm/signal.inc.c:30:
+ target_sigset_t tuc_sigmask;^I/* mask last for extensibility */$
ERROR: code indent should never use tabs
#881: FILE: linux-user/arm/signal.inc.c:38:
+ target_sigset_t tuc_sigmask;^I/* mask last for extensibility */$
ERROR: open brace '{' following struct go on the same line
#921: FILE: linux-user/arm/signal.inc.c:78:
+struct sigframe_v1
+{
ERROR: spaces required around that '-' (ctx:VxV)
#923: FILE: linux-user/arm/signal.inc.c:80:
+ abi_ulong extramask[TARGET_NSIG_WORDS-1];
^
ERROR: open brace '{' following struct go on the same line
#928: FILE: linux-user/arm/signal.inc.c:85:
+struct sigframe_v2
+{
ERROR: open brace '{' following struct go on the same line
#934: FILE: linux-user/arm/signal.inc.c:91:
+struct rt_sigframe_v1
+{
ERROR: open brace '{' following struct go on the same line
#943: FILE: linux-user/arm/signal.inc.c:100:
+struct rt_sigframe_v2
+{
WARNING: line over 80 characters
#954: FILE: linux-user/arm/signal.inc.c:111:
+#define SWI_SYS_SIGRETURN (0xef000000|(TARGET_NR_sigreturn + ARM_SYSCALL_BASE))
ERROR: code indent should never use tabs
#954: FILE: linux-user/arm/signal.inc.c:111:
+#define SWI_SYS_SIGRETURN^I(0xef000000|(TARGET_NR_sigreturn + ARM_SYSCALL_BASE))$
ERROR: spaces required around that '|' (ctx:VxV)
#954: FILE: linux-user/arm/signal.inc.c:111:
+#define SWI_SYS_SIGRETURN (0xef000000|(TARGET_NR_sigreturn + ARM_SYSCALL_BASE))
^
WARNING: line over 80 characters
#955: FILE: linux-user/arm/signal.inc.c:112:
+#define SWI_SYS_RT_SIGRETURN (0xef000000|(TARGET_NR_rt_sigreturn + ARM_SYSCALL_BASE))
ERROR: code indent should never use tabs
#955: FILE: linux-user/arm/signal.inc.c:112:
+#define SWI_SYS_RT_SIGRETURN^I(0xef000000|(TARGET_NR_rt_sigreturn + ARM_SYSCALL_BASE))$
ERROR: spaces required around that '|' (ctx:VxV)
#955: FILE: linux-user/arm/signal.inc.c:112:
+#define SWI_SYS_RT_SIGRETURN (0xef000000|(TARGET_NR_rt_sigreturn + ARM_SYSCALL_BASE))
^
ERROR: code indent should never use tabs
#961: FILE: linux-user/arm/signal.inc.c:118:
+#define SWI_THUMB_SIGRETURN^I(0xdf00 << 16 | 0x2700 | (TARGET_NR_sigreturn))$
WARNING: line over 80 characters
#962: FILE: linux-user/arm/signal.inc.c:119:
+#define SWI_THUMB_RT_SIGRETURN (0xdf00 << 16 | 0x2700 | (TARGET_NR_rt_sigreturn))
ERROR: code indent should never use tabs
#962: FILE: linux-user/arm/signal.inc.c:119:
+#define SWI_THUMB_RT_SIGRETURN^I(0xdf00 << 16 | 0x2700 | (TARGET_NR_rt_sigreturn))$
ERROR: code indent should never use tabs
#965: FILE: linux-user/arm/signal.inc.c:122:
+^ISWI_SYS_SIGRETURN,^ISWI_THUMB_SIGRETURN,$
ERROR: code indent should never use tabs
#966: FILE: linux-user/arm/signal.inc.c:123:
+^ISWI_SYS_RT_SIGRETURN,^ISWI_THUMB_RT_SIGRETURN$
ERROR: "(foo*)" should be "(foo *)"
#1073: FILE: linux-user/arm/signal.inc.c:230:
+ return (abi_ulong*)(vfpframe+1);
ERROR: spaces required around that '+' (ctx:VxV)
#1073: FILE: linux-user/arm/signal.inc.c:230:
+ return (abi_ulong*)(vfpframe+1);
^
ERROR: "(foo*)" should be "(foo *)"
#1093: FILE: linux-user/arm/signal.inc.c:250:
+ return (abi_ulong*)(iwmmxtframe+1);
ERROR: spaces required around that '+' (ctx:VxV)
#1093: FILE: linux-user/arm/signal.inc.c:250:
+ return (abi_ulong*)(iwmmxtframe+1);
^
ERROR: space required before the open parenthesis '('
#1125: FILE: linux-user/arm/signal.inc.c:282:
+ for(i = 0; i < TARGET_NSIG_WORDS; i++) {
ERROR: space required before the open parenthesis '('
#1145: FILE: linux-user/arm/signal.inc.c:302:
+ for(i = 1; i < TARGET_NSIG_WORDS; i++) {
ERROR: space required before the open parenthesis '('
#1222: FILE: linux-user/arm/signal.inc.c:379:
+ for(i = 0; i < TARGET_NSIG_WORDS; i++) {
ERROR: space required before the open parenthesis '('
#1336: FILE: linux-user/arm/signal.inc.c:493:
+ for(i = 1; i < TARGET_NSIG_WORDS; i++) {
ERROR: if this code is redundant consider removing it
#1347: FILE: linux-user/arm/signal.inc.c:504:
+#if 0
ERROR: braces {} are necessary for all arms of this statement
#1349: FILE: linux-user/arm/signal.inc.c:506:
+ if (ptrace_cancel_bpt(current))
[...]
ERROR: "(foo*)" should be "(foo *)"
#1387: FILE: linux-user/arm/signal.inc.c:544:
+ return (abi_ulong*)(vfpframe + 1);
ERROR: "(foo*)" should be "(foo *)"
#1412: FILE: linux-user/arm/signal.inc.c:569:
+ return (abi_ulong*)(iwmmxtframe + 1);
ERROR: braces {} are necessary for all arms of this statement
#1425: FILE: linux-user/arm/signal.inc.c:582:
+ if (restore_sigcontext(env, &uc->tuc_mcontext))
[...]
ERROR: if this code is redundant consider removing it
#1449: FILE: linux-user/arm/signal.inc.c:606:
+#if 0
ERROR: braces {} are necessary for all arms of this statement
#1451: FILE: linux-user/arm/signal.inc.c:608:
+ if (ptrace_cancel_bpt(current))
[...]
ERROR: line over 90 characters
#1531: FILE: linux-user/arm/signal.inc.c:688:
+ if (do_sigaltstack(frame_addr + offsetof(struct rt_sigframe_v1, uc.tuc_stack), 0, get_sp_from_cpustate(env)) == -EFAULT)
ERROR: braces {} are necessary for all arms of this statement
#1531: FILE: linux-user/arm/signal.inc.c:688:
+ if (do_sigaltstack(frame_addr + offsetof(struct rt_sigframe_v1, uc.tuc_stack), 0, get_sp_from_cpustate(env)) == -EFAULT)
[...]
ERROR: if this code is redundant consider removing it
#1534: FILE: linux-user/arm/signal.inc.c:691:
+#if 0
ERROR: braces {} are necessary for all arms of this statement
#1536: FILE: linux-user/arm/signal.inc.c:693:
+ if (ptrace_cancel_bpt(current))
[...]
ERROR: braces {} are necessary for all arms of this statement
#1684: FILE: linux-user/cris/signal.inc.c:86:
+ if (!lock_user_struct(VERIFY_WRITE, frame, frame_addr, 0))
[...]
ERROR: spaces required around that '+' (ctx:VxV)
#1694: FILE: linux-user/cris/signal.inc.c:96:
+ __put_user(0x9c5f, frame->retcode+0);
^
ERROR: space required before the open parenthesis '('
#1702: FILE: linux-user/cris/signal.inc.c:104:
+ for(i = 1; i < TARGET_NSIG_WORDS; i++) {
ERROR: space required before the open parenthesis '('
#1745: FILE: linux-user/cris/signal.inc.c:147:
+ for(i = 1; i < TARGET_NSIG_WORDS; i++) {
ERROR: spaces required around that '-' (ctx:VxV)
#2107: FILE: linux-user/i386/signal.inc.c:143:
+ abi_ulong extramask[TARGET_NSIG_WORDS-1];
^
WARNING: line over 80 characters
#2234: FILE: linux-user/i386/signal.inc.c:270:
+ esp = target_sigaltstack_used.ss_sp + target_sigaltstack_used.ss_size;
ERROR: braces {} are necessary for all arms of this statement
#2266: FILE: linux-user/i386/signal.inc.c:302:
+ if (!lock_user_struct(VERIFY_WRITE, frame, frame_addr, 0))
[...]
ERROR: space required before the open parenthesis '('
#2274: FILE: linux-user/i386/signal.inc.c:310:
+ for(i = 1; i < TARGET_NSIG_WORDS; i++) {
ERROR: spaces required around that '+' (ctx:VxV)
#2289: FILE: linux-user/i386/signal.inc.c:325:
+ __put_user(val16, (uint16_t *)(frame->retcode+0));
^
ERROR: spaces required around that '+' (ctx:VxV)
#2290: FILE: linux-user/i386/signal.inc.c:326:
+ __put_user(TARGET_NR_sigreturn, (int *)(frame->retcode+2));
^
ERROR: spaces required around that '+' (ctx:VxV)
#2292: FILE: linux-user/i386/signal.inc.c:328:
+ __put_user(val16, (uint16_t *)(frame->retcode+6));
^
ERROR: braces {} are necessary for all arms of this statement
#2329: FILE: linux-user/i386/signal.inc.c:365:
+ if (!lock_user_struct(VERIFY_WRITE, frame, frame_addr, 0))
[...]
ERROR: space required before the open parenthesis '('
#2355: FILE: linux-user/i386/signal.inc.c:391:
+ for(i = 0; i < TARGET_NSIG_WORDS; i++) {
ERROR: spaces required around that '+' (ctx:VxV)
#2369: FILE: linux-user/i386/signal.inc.c:405:
+ __put_user(0xb8, (char *)(frame->retcode+0));
^
ERROR: spaces required around that '+' (ctx:VxV)
#2370: FILE: linux-user/i386/signal.inc.c:406:
+ __put_user(TARGET_NR_rt_sigreturn, (int *)(frame->retcode+1));
^
ERROR: spaces required around that '+' (ctx:VxV)
#2372: FILE: linux-user/i386/signal.inc.c:408:
+ __put_user(val16, (uint16_t *)(frame->retcode+5));
^
ERROR: code indent should never use tabs
#2459: FILE: linux-user/i386/signal.inc.c:495:
+ //^I^Iregs->orig_eax = -1;^I^I/* disable syscall checks */$
ERROR: do not use C99 // comments
#2459: FILE: linux-user/i386/signal.inc.c:495:
+ // regs->orig_eax = -1; /* disable syscall checks */
ERROR: braces {} are necessary for all arms of this statement
#2463: FILE: linux-user/i386/signal.inc.c:499:
+ if (!access_ok(VERIFY_READ, fpstate_addr,
[...]
ERROR: braces {} are necessary for all arms of this statement
#2489: FILE: linux-user/i386/signal.inc.c:525:
+ if (!lock_user_struct(VERIFY_READ, frame, frame_addr, 1))
[...]
ERROR: space required before the open parenthesis '('
#2493: FILE: linux-user/i386/signal.inc.c:529:
+ for(i = 1; i < TARGET_NSIG_WORDS; i++) {
ERROR: braces {} are necessary for all arms of this statement
#2501: FILE: linux-user/i386/signal.inc.c:537:
+ if (restore_sigcontext(env, &frame->sc))
[...]
ERROR: braces {} are necessary for all arms of this statement
#2521: FILE: linux-user/i386/signal.inc.c:557:
+ if (!lock_user_struct(VERIFY_READ, frame, frame_addr, 1))
[...]
WARNING: line over 80 characters
#2530: FILE: linux-user/i386/signal.inc.c:566:
+ if (do_sigaltstack(frame_addr + offsetof(struct rt_sigframe, uc.tuc_stack), 0,
ERROR: open brace '{' following struct go on the same line
#2563: FILE: linux-user/m68k/signal.inc.c:14:
+struct target_sigframe
+{
ERROR: spaces required around that '-' (ctx:VxV)
#2569: FILE: linux-user/m68k/signal.inc.c:20:
+ abi_ulong extramask[TARGET_NSIG_WORDS-1];
^
ERROR: spaces required around that '*' (ctx:VxV)
#2579: FILE: linux-user/m68k/signal.inc.c:30:
+ int f_fpregs[8*3];
^
ERROR: open brace '{' following struct go on the same line
#2600: FILE: linux-user/m68k/signal.inc.c:51:
+struct target_rt_sigframe
+{
ERROR: space prohibited between function name and open parenthesis '('
#2651: FILE: linux-user/m68k/signal.inc.c:102:
+ if ((ka->sa_flags & TARGET_SA_ONSTACK) && (sas_ss_flags (sp) == 0)) {
ERROR: return is not a function, parentheses are not required
#2655: FILE: linux-user/m68k/signal.inc.c:106:
+ return ((sp - frame_size) & -8UL);
ERROR: space required before the open parenthesis '('
#2680: FILE: linux-user/m68k/signal.inc.c:131:
+ for(i = 1; i < TARGET_NSIG_WORDS; i++) {
ERROR: braces {} are necessary for all arms of this statement
#2783: FILE: linux-user/m68k/signal.inc.c:234:
+ if (temp != TARGET_MCONTEXT_VERSION)
[...]
ERROR: braces {} are necessary for all arms of this statement
#2855: FILE: linux-user/m68k/signal.inc.c:306:
+ if (err)
[...]
ERROR: space required before the open parenthesis '('
#2858: FILE: linux-user/m68k/signal.inc.c:309:
+ for(i = 0; i < TARGET_NSIG_WORDS; i++) {
ERROR: braces {} are necessary for all arms of this statement
#2873: FILE: linux-user/m68k/signal.inc.c:324:
+ if (err)
[...]
ERROR: braces {} are necessary for all arms of this statement
#2898: FILE: linux-user/m68k/signal.inc.c:349:
+ if (!lock_user_struct(VERIFY_READ, frame, frame_addr, 1))
[...]
ERROR: space required before the open parenthesis '('
#2905: FILE: linux-user/m68k/signal.inc.c:356:
+ for(i = 1; i < TARGET_NSIG_WORDS; i++) {
ERROR: braces {} are necessary for all arms of this statement
#2931: FILE: linux-user/m68k/signal.inc.c:382:
+ if (!lock_user_struct(VERIFY_READ, frame, frame_addr, 1))
[...]
ERROR: braces {} are necessary for all arms of this statement
#2939: FILE: linux-user/m68k/signal.inc.c:390:
+ if (target_rt_restore_ucontext(env, &frame->uc))
[...]
ERROR: braces {} are necessary for all arms of this statement
#2942: FILE: linux-user/m68k/signal.inc.c:393:
+ if (do_sigaltstack(frame_addr +
[...]
ERROR: return is not a function, parentheses are not required
#3078: FILE: linux-user/microblaze/signal.inc.c:117:
+ return ((sp - frame_size) & -8UL);
ERROR: braces {} are necessary for all arms of this statement
#3090: FILE: linux-user/microblaze/signal.inc.c:129:
+ if (!lock_user_struct(VERIFY_WRITE, frame, frame_addr, 0))
[...]
ERROR: space required before the open parenthesis '('
#3096: FILE: linux-user/microblaze/signal.inc.c:135:
+ for(i = 1; i < TARGET_NSIG_WORDS; i++) {
ERROR: spaces required around that '-' (ctx:VxV)
#3106: FILE: linux-user/microblaze/signal.inc.c:145:
+ env->regs[15] = ((unsigned long)ka->sa_restorer)-8;
^
ERROR: braces {} are necessary for all arms of this statement
#3158: FILE: linux-user/microblaze/signal.inc.c:197:
+ if (!lock_user_struct(VERIFY_WRITE, frame, frame_addr, 1))
[...]
ERROR: space required before the open parenthesis '('
#3163: FILE: linux-user/microblaze/signal.inc.c:202:
+ for(i = 1; i < TARGET_NSIG_WORDS; i++) {
ERROR: space prohibited between function name and open parenthesis '('
#3363: FILE: linux-user/mips/signal.inc.c:170:
+ if ((ka->sa_flags & TARGET_SA_ONSTACK) && (sas_ss_flags (sp) == 0)) {
ERROR: "foo * bar" should be "foo *bar"
#3381: FILE: linux-user/mips/signal.inc.c:188:
+static void setup_frame(int sig, struct target_sigaction * ka,
ERROR: space required before the open parenthesis '('
#3398: FILE: linux-user/mips/signal.inc.c:205:
+ for(i = 0; i < TARGET_NSIG_WORDS; i++) {
ERROR: space prohibited after that open square bracket '['
#3412: FILE: linux-user/mips/signal.inc.c:219:
+ regs->active_tc.gpr[ 4] = sig;
ERROR: space prohibited after that open square bracket '['
#3413: FILE: linux-user/mips/signal.inc.c:220:
+ regs->active_tc.gpr[ 5] = 0;
ERROR: space prohibited after that open square bracket '['
#3414: FILE: linux-user/mips/signal.inc.c:221:
+ regs->active_tc.gpr[ 6] = frame_addr + offsetof(struct sigframe, sf_sc);
ERROR: braces {} are necessary for all arms of this statement
#3439: FILE: linux-user/mips/signal.inc.c:246:
+ if (!lock_user_struct(VERIFY_READ, frame, frame_addr, 1))
[...]
ERROR: space required before the open parenthesis '('
#3442: FILE: linux-user/mips/signal.inc.c:249:
+ for(i = 0; i < TARGET_NSIG_WORDS; i++) {
ERROR: if this code is redundant consider removing it
#3451: FILE: linux-user/mips/signal.inc.c:258:
+#if 0
ERROR: spaces required around that ':' (ctx:ExV)
#3459: FILE: linux-user/mips/signal.inc.c:266:
+ :"r" (®s));
^
WARNING: line over 80 characters
#3497: FILE: linux-user/mips/signal.inc.c:304:
+ __put_user(target_sigaltstack_used.ss_size, &frame->rs_uc.tuc_stack.ss_size);
ERROR: space required before the open parenthesis '('
#3503: FILE: linux-user/mips/signal.inc.c:310:
+ for(i = 0; i < TARGET_NSIG_WORDS; i++) {
ERROR: space prohibited after that open square bracket '['
#3517: FILE: linux-user/mips/signal.inc.c:324:
+ env->active_tc.gpr[ 4] = sig;
ERROR: space prohibited after that open square bracket '['
#3518: FILE: linux-user/mips/signal.inc.c:325:
+ env->active_tc.gpr[ 5] = frame_addr
ERROR: space prohibited after that open square bracket '['
#3520: FILE: linux-user/mips/signal.inc.c:327:
+ env->active_tc.gpr[ 6] = frame_addr
ERROR: braces {} are necessary for all arms of this statement
#3555: FILE: linux-user/mips/signal.inc.c:362:
+ if (do_sigaltstack(frame_addr +
[...]
ERROR: if this code is redundant consider removing it
#3848: FILE: linux-user/openrisc/signal.inc.c:26:
+#if 0
ERROR: braces {} are necessary for all arms of this statement
#4382: FILE: linux-user/ppc/signal.inc.c:345:
+ if (sig)
[...]
ERROR: braces {} are necessary for all arms of this statement
#4461: FILE: linux-user/ppc/signal.inc.c:424:
+ if (!lock_user_struct(VERIFY_WRITE, frame, frame_addr, 1))
[...]
ERROR: braces {} are necessary for all arms of this statement
#4488: FILE: linux-user/ppc/signal.inc.c:451:
+ if (err)
[...]
ERROR: braces {} are necessary for all arms of this statement
#4525: FILE: linux-user/ppc/signal.inc.c:488:
+ if (!lock_user_struct(VERIFY_WRITE, rt_sf, rt_sf_addr, 1))
[...]
ERROR: space prohibited between function name and open parenthesis '('
#4539: FILE: linux-user/ppc/signal.inc.c:502:
+ __put_user(h2g (&rt_sf->uc.tuc_mcontext),
ERROR: space required before the open parenthesis '('
#4542: FILE: linux-user/ppc/signal.inc.c:505:
+ for(i = 0; i < TARGET_NSIG_WORDS; i++) {
ERROR: braces {} are necessary for all arms of this statement
#4572: FILE: linux-user/ppc/signal.inc.c:535:
+ if (err)
[...]
ERROR: braces {} are necessary for all arms of this statement
#4621: FILE: linux-user/ppc/signal.inc.c:584:
+ if (!lock_user_struct(VERIFY_READ, sc, sc_addr, 1))
[...]
ERROR: braces {} are necessary for all arms of this statement
#4634: FILE: linux-user/ppc/signal.inc.c:597:
+ if (!lock_user_struct(VERIFY_READ, sr, sr_addr, 1))
[...]
WARNING: line over 80 characters
#4658: FILE: linux-user/ppc/signal.inc.c:621:
+ if (copy_from_user(&set, h2g(ucp) + offsetof(struct target_ucontext, tuc_sigmask),
ERROR: braces {} are necessary for all arms of this statement
#4658: FILE: linux-user/ppc/signal.inc.c:621:
+ if (copy_from_user(&set, h2g(ucp) + offsetof(struct target_ucontext, tuc_sigmask),
[...]
ERROR: space prohibited between function name and open parenthesis '('
#4659: FILE: linux-user/ppc/signal.inc.c:622:
+ sizeof (set)))
ERROR: braces {} are necessary for all arms of this statement
#4669: FILE: linux-user/ppc/signal.inc.c:632:
+ if (!lock_user_struct(VERIFY_READ, mcp, mcp_addr, 1))
[...]
ERROR: braces {} are necessary for all arms of this statement
#4686: FILE: linux-user/ppc/signal.inc.c:649:
+ if (!lock_user_struct(VERIFY_READ, rt_sf, rt_sf_addr, 1))
[...]
ERROR: braces {} are necessary for all arms of this statement
#4689: FILE: linux-user/ppc/signal.inc.c:652:
+ if (do_setcontext(&rt_sf->uc, env, 1))
[...]
ERROR: spaces required around that '*' (ctx:VxV)
#4924: FILE: linux-user/s390x/signal.inc.c:12:
+#define _SIGMASK_COPY_SIZE (sizeof(unsigned long)*_SIGCONTEXT_NSIG_WORDS)
^
WARNING: line over 80 characters
#4925: FILE: linux-user/s390x/signal.inc.c:13:
+#define PSW_ADDR_AMODE 0x0000000000000000UL /* 0x80000000UL for 31-bit */
ERROR: do not use C99 // comments
#5001: FILE: linux-user/s390x/signal.inc.c:89:
+ //save_access_regs(current->thread.acrs); FIXME
ERROR: do not use C99 // comments
#5017: FILE: linux-user/s390x/signal.inc.c:105:
+ //save_fp_regs(¤t->thread.fp_regs); FIXME
ERROR: do not use C99 // comments
#5061: FILE: linux-user/s390x/signal.inc.c:149:
+ env->regs[2] = sig; //map_signal(sig);
ERROR: do not use C99 // comments
#5066: FILE: linux-user/s390x/signal.inc.c:154:
+ env->regs[4] = 0; // FIXME: no clue... current->thread.trap_no;
ERROR: do not use C99 // comments
#5067: FILE: linux-user/s390x/signal.inc.c:155:
+ env->regs[5] = 0; // FIXME: no clue... current->thread.prot_addr;
ERROR: do not use C99 // comments
#5124: FILE: linux-user/s390x/signal.inc.c:212:
+ env->regs[2] = sig; //map_signal(sig);
ERROR: open brace '{' following struct go on the same line
#5252: FILE: linux-user/sh4/signal.inc.c:29:
+struct target_sigframe
+{
ERROR: spaces required around that '-' (ctx:VxV)
#5254: FILE: linux-user/sh4/signal.inc.c:31:
+ target_ulong extramask[TARGET_NSIG_WORDS-1];
^
ERROR: code indent should never use tabs
#5264: FILE: linux-user/sh4/signal.inc.c:41:
+ target_sigset_t tuc_sigmask;^I/* mask last for extensibility */$
ERROR: open brace '{' following struct go on the same line
#5268: FILE: linux-user/sh4/signal.inc.c:45:
+struct target_rt_sigframe
+{
ERROR: spaces required around that '|' (ctx:VxV)
#5275: FILE: linux-user/sh4/signal.inc.c:52:
+#define MOVW(n) (0x9300|((n)-2)) /* Move mem word at PC+n to R3 */
^
ERROR: spaces required around that '-' (ctx:VxV)
#5275: FILE: linux-user/sh4/signal.inc.c:52:
+#define MOVW(n) (0x9300|((n)-2)) /* Move mem word at PC+n to R3 */
^
ERROR: spaces required around that '=' (ctx:VxV)
#5331: FILE: linux-user/sh4/signal.inc.c:108:
+ for (i=0; i<16; i++) {
^
ERROR: spaces required around that '<' (ctx:VxV)
#5331: FILE: linux-user/sh4/signal.inc.c:108:
+ for (i=0; i<16; i++) {
^
ERROR: spaces required around that '=' (ctx:VxV)
#5359: FILE: linux-user/sh4/signal.inc.c:136:
+ for (i=0; i<16; i++) {
^
ERROR: spaces required around that '<' (ctx:VxV)
#5359: FILE: linux-user/sh4/signal.inc.c:136:
+ for (i=0; i<16; i++) {
^
ERROR: space required before the open parenthesis '('
#5449: FILE: linux-user/sh4/signal.inc.c:226:
+ for(i = 0; i < TARGET_NSIG_WORDS; i++) {
ERROR: space required before the open parenthesis '('
#5499: FILE: linux-user/sh4/signal.inc.c:276:
+ for(i = 1; i < TARGET_NSIG_WORDS; i++) {
ERROR: braces {} are necessary for all arms of this statement
#5503: FILE: linux-user/sh4/signal.inc.c:280:
+ if (err)
[...]
ERROR: space prohibited before open square bracket '['
#12114: FILE: linux-user/sparc/signal.inc.c:60:
+ } si_fpqueue [16];
ERROR: space prohibited between function name and open parenthesis '('
#12122: FILE: linux-user/sparc/signal.inc.c:68:
+ abi_ulong insns[2] __attribute__ ((aligned (8)));
ERROR: code indent should never use tabs
#12149: FILE: linux-user/sparc/signal.inc.c:95:
+#define UREG_L0^I 8$
ERROR: line over 90 characters
#12164: FILE: linux-user/sparc/signal.inc.c:110:
+ && !((target_sigaltstack_used.ss_sp + target_sigaltstack_used.ss_size) & 7)) {
WARNING: line over 80 characters
#12165: FILE: linux-user/sparc/signal.inc.c:111:
+ sp = target_sigaltstack_used.ss_sp + target_sigaltstack_used.ss_size;
ERROR: spaces required around that '=' (ctx:VxV)
#12180: FILE: linux-user/sparc/signal.inc.c:126:
+ for (i=0; i < 8; i++) {
^
ERROR: spaces required around that '=' (ctx:VxV)
#12183: FILE: linux-user/sparc/signal.inc.c:129:
+ for (i=0; i < 8; i++) {
^
ERROR: spaces required around that '+' (ctx:VxV)
#12184: FILE: linux-user/sparc/signal.inc.c:130:
+ __put_user(env->regwptr[UREG_I0 + i], &si->si_regs.u_regs[i+8]);
^
ERROR: if this code is redundant consider removing it
#12190: FILE: linux-user/sparc/signal.inc.c:136:
+#if 0
ERROR: do not use C99 // comments
#12218: FILE: linux-user/sparc/signal.inc.c:164:
+ //synchronize_user_stack();
ERROR: if this code is redundant consider removing it
#12229: FILE: linux-user/sparc/signal.inc.c:175:
+#if 0
ERROR: braces {} are necessary for all arms of this statement
#12230: FILE: linux-user/sparc/signal.inc.c:176:
+ if (invalid_frame_pointer(sf, sigframe_size))
[...]
ERROR: do not use C99 // comments
#12237: FILE: linux-user/sparc/signal.inc.c:183:
+ //save_fpu_state(regs, &sf->fpu_state);
ERROR: do not use C99 // comments
#12238: FILE: linux-user/sparc/signal.inc.c:184:
+ //__put_user(&sf->fpu_state, &sf->fpu_save);
ERROR: braces {} are necessary for all arms of this statement
#12251: FILE: linux-user/sparc/signal.inc.c:197:
+ if (err)
[...]
ERROR: braces {} are necessary for all arms of this statement
#12281: FILE: linux-user/sparc/signal.inc.c:227:
+ if (err)
[...]
ERROR: do not use C99 // comments
#12285: FILE: linux-user/sparc/signal.inc.c:231:
+ // flush_sig_insns(current->mm, (unsigned long) &(sf->insns[0]));
ERROR: do not use C99 // comments
#12286: FILE: linux-user/sparc/signal.inc.c:232:
+ // tb_flush(env);
ERROR: if this code is redundant consider removing it
#12290: FILE: linux-user/sparc/signal.inc.c:236:
+#if 0
ERROR: spaces required around that '=' (ctx:VxV)
#12313: FILE: linux-user/sparc/signal.inc.c:259:
+ int err=0, i;
^
ERROR: braces {} are necessary for all arms of this statement
#12323: FILE: linux-user/sparc/signal.inc.c:269:
+ if (sf_addr & 3)
[...]
ERROR: spaces required around that '=' (ctx:VxV)
#12343: FILE: linux-user/sparc/signal.inc.c:289:
+ for (i=0; i < 8; i++) {
^
ERROR: spaces required around that '=' (ctx:VxV)
#12346: FILE: linux-user/sparc/signal.inc.c:292:
+ for (i=0; i < 8; i++) {
^
ERROR: spaces required around that '+' (ctx:VxV)
#12347: FILE: linux-user/sparc/signal.inc.c:293:
+ __get_user(env->regwptr[i + UREG_I0], &sf->info.si_regs.u_regs[i+8]);
^
ERROR: space required before the open parenthesis '('
#12360: FILE: linux-user/sparc/signal.inc.c:306:
+ for(i = 1; i < TARGET_NSIG_WORDS; i++) {
ERROR: do not use C99 // comments
#12420: FILE: linux-user/sparc/signal.inc.c:366:
+ //uint128_t qregs[16];
ERROR: spaces required around that '+' (ctx:VxV)
#12517: FILE: linux-user/sparc/signal.inc.c:463:
+ w_addr = TARGET_STACK_BIAS+env->regwptr[UREG_I6];
^
ERROR: spaces required around that '/' (ctx:VxV)
#12536: FILE: linux-user/sparc/signal.inc.c:482:
+ __get_user(env->fpr[i/2].l.lower, src);
^
ERROR: spaces required around that '/' (ctx:VxV)
#12538: FILE: linux-user/sparc/signal.inc.c:484:
+ __get_user(env->fpr[i/2].l.upper, src);
^
ERROR: braces {} are necessary for all arms of this statement
#12595: FILE: linux-user/sparc/signal.inc.c:541:
+ if (err)
[...]
ERROR: do not use C99 // comments
#12600: FILE: linux-user/sparc/signal.inc.c:546:
+ // __put_user(env->tstate, &((*grp)[SPARC_MC_TSTATE]));
ERROR: spaces required around that '+' (ctx:VxV)
#12620: FILE: linux-user/sparc/signal.inc.c:566:
+ w_addr = TARGET_STACK_BIAS+env->regwptr[UREG_I6];
^
ERROR: spaces required around that '/' (ctx:VxV)
#12637: FILE: linux-user/sparc/signal.inc.c:583:
+ __put_user(env->fpr[i/2].l.lower, dst);
^
ERROR: spaces required around that '/' (ctx:VxV)
#12639: FILE: linux-user/sparc/signal.inc.c:585:
+ __put_user(env->fpr[i/2].l.upper, dst);
^
ERROR: braces {} are necessary for all arms of this statement
#12647: FILE: linux-user/sparc/signal.inc.c:593:
+ if (err)
[...]
total: 162 errors, 9 warnings, 12955 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/5: linux-user: remove unneeded #ifdef in signal.c...
Checking PATCH 3/5: linux-user: define TARGET_ARCH_HAS_SETUP_FRAME...
Checking PATCH 4/5: linux-user: cleanup cpu_loop()...
ERROR: space prohibited between function name and open parenthesis '('
#200: FILE: linux-user/alpha/cpu_loop.inc.c:176:
+ printf ("Unhandled trap: 0x%x\n", trapnr);
ERROR: space prohibited between function name and open parenthesis '('
#204: FILE: linux-user/alpha/cpu_loop.inc.c:180:
+ process_pending_signals (env);
ERROR: braces {} are necessary for all arms of this statement
#369: FILE: linux-user/arm/cpu_loop.inc.c:148:
+ if (get_user_u32(val, addr))
[...]
ERROR: space required before the open parenthesis '('
#414: FILE: linux-user/arm/cpu_loop.inc.c:193:
+ for(;;) {
ERROR: space required before the open parenthesis '('
#420: FILE: linux-user/arm/cpu_loop.inc.c:199:
+ switch(trapnr) {
ERROR: spaces required around that '=' (ctx:VxV)
#442: FILE: linux-user/arm/cpu_loop.inc.c:221:
+ int arm_fpe=0;
^
ERROR: suspect code indent for conditional statements (20, 22)
#445: FILE: linux-user/arm/cpu_loop.inc.c:224:
+ if (-rc & float_flag_invalid)
+ arm_fpe |= BIT_IOC;
ERROR: braces {} are necessary for all arms of this statement
#445: FILE: linux-user/arm/cpu_loop.inc.c:224:
+ if (-rc & float_flag_invalid)
[...]
ERROR: suspect code indent for conditional statements (20, 22)
#447: FILE: linux-user/arm/cpu_loop.inc.c:226:
+ if (-rc & float_flag_divbyzero)
+ arm_fpe |= BIT_DZC;
ERROR: braces {} are necessary for all arms of this statement
#447: FILE: linux-user/arm/cpu_loop.inc.c:226:
+ if (-rc & float_flag_divbyzero)
[...]
ERROR: suspect code indent for conditional statements (20, 22)
#449: FILE: linux-user/arm/cpu_loop.inc.c:228:
+ if (-rc & float_flag_overflow)
+ arm_fpe |= BIT_OFC;
ERROR: braces {} are necessary for all arms of this statement
#449: FILE: linux-user/arm/cpu_loop.inc.c:228:
+ if (-rc & float_flag_overflow)
[...]
ERROR: suspect code indent for conditional statements (20, 22)
#451: FILE: linux-user/arm/cpu_loop.inc.c:230:
+ if (-rc & float_flag_underflow)
+ arm_fpe |= BIT_UFC;
ERROR: braces {} are necessary for all arms of this statement
#451: FILE: linux-user/arm/cpu_loop.inc.c:230:
+ if (-rc & float_flag_underflow)
[...]
ERROR: suspect code indent for conditional statements (20, 22)
#453: FILE: linux-user/arm/cpu_loop.inc.c:232:
+ if (-rc & float_flag_inexact)
+ arm_fpe |= BIT_IXC;
ERROR: braces {} are necessary for all arms of this statement
#453: FILE: linux-user/arm/cpu_loop.inc.c:232:
+ if (-rc & float_flag_inexact)
[...]
ERROR: do not use C99 // comments
#457: FILE: linux-user/arm/cpu_loop.inc.c:236:
+ //printf("fpsr 0x%x, arm_fpe 0x%x\n",fpsr,arm_fpe);
ERROR: trailing statements should be on next line
#464: FILE: linux-user/arm/cpu_loop.inc.c:243:
+ if (arm_fpe & BIT_IXC) info.si_code = TARGET_FPE_FLTRES;
ERROR: braces {} are necessary for all arms of this statement
#464: FILE: linux-user/arm/cpu_loop.inc.c:243:
+ if (arm_fpe & BIT_IXC) info.si_code = TARGET_FPE_FLTRES;
[...]
ERROR: trailing statements should be on next line
#465: FILE: linux-user/arm/cpu_loop.inc.c:244:
+ if (arm_fpe & BIT_UFC) info.si_code = TARGET_FPE_FLTUND;
ERROR: braces {} are necessary for all arms of this statement
#465: FILE: linux-user/arm/cpu_loop.inc.c:244:
+ if (arm_fpe & BIT_UFC) info.si_code = TARGET_FPE_FLTUND;
[...]
ERROR: trailing statements should be on next line
#466: FILE: linux-user/arm/cpu_loop.inc.c:245:
+ if (arm_fpe & BIT_OFC) info.si_code = TARGET_FPE_FLTOVF;
ERROR: braces {} are necessary for all arms of this statement
#466: FILE: linux-user/arm/cpu_loop.inc.c:245:
+ if (arm_fpe & BIT_OFC) info.si_code = TARGET_FPE_FLTOVF;
[...]
ERROR: trailing statements should be on next line
#467: FILE: linux-user/arm/cpu_loop.inc.c:246:
+ if (arm_fpe & BIT_DZC) info.si_code = TARGET_FPE_FLTDIV;
ERROR: braces {} are necessary for all arms of this statement
#467: FILE: linux-user/arm/cpu_loop.inc.c:246:
+ if (arm_fpe & BIT_DZC) info.si_code = TARGET_FPE_FLTDIV;
[...]
ERROR: trailing statements should be on next line
#468: FILE: linux-user/arm/cpu_loop.inc.c:247:
+ if (arm_fpe & BIT_IOC) info.si_code = TARGET_FPE_FLTINV;
ERROR: braces {} are necessary for all arms of this statement
#468: FILE: linux-user/arm/cpu_loop.inc.c:247:
+ if (arm_fpe & BIT_IOC) info.si_code = TARGET_FPE_FLTINV;
[...]
ERROR: suspect code indent for conditional statements (20, 22)
#477: FILE: linux-user/arm/cpu_loop.inc.c:256:
+ if ((!(fpsr & BIT_IXE)) && (arm_fpe & BIT_IXC))
+ fpsr |= BIT_IXC;
ERROR: braces {} are necessary for all arms of this statement
#477: FILE: linux-user/arm/cpu_loop.inc.c:256:
+ if ((!(fpsr & BIT_IXE)) && (arm_fpe & BIT_IXC))
[...]
ERROR: suspect code indent for conditional statements (20, 22)
#479: FILE: linux-user/arm/cpu_loop.inc.c:258:
+ if ((!(fpsr & BIT_UFE)) && (arm_fpe & BIT_UFC))
+ fpsr |= BIT_UFC;
ERROR: braces {} are necessary for all arms of this statement
#479: FILE: linux-user/arm/cpu_loop.inc.c:258:
+ if ((!(fpsr & BIT_UFE)) && (arm_fpe & BIT_UFC))
[...]
ERROR: suspect code indent for conditional statements (20, 22)
#481: FILE: linux-user/arm/cpu_loop.inc.c:260:
+ if ((!(fpsr & BIT_OFE)) && (arm_fpe & BIT_OFC))
+ fpsr |= BIT_OFC;
ERROR: braces {} are necessary for all arms of this statement
#481: FILE: linux-user/arm/cpu_loop.inc.c:260:
+ if ((!(fpsr & BIT_OFE)) && (arm_fpe & BIT_OFC))
[...]
ERROR: suspect code indent for conditional statements (20, 22)
#483: FILE: linux-user/arm/cpu_loop.inc.c:262:
+ if ((!(fpsr & BIT_DZE)) && (arm_fpe & BIT_DZC))
+ fpsr |= BIT_DZC;
ERROR: braces {} are necessary for all arms of this statement
#483: FILE: linux-user/arm/cpu_loop.inc.c:262:
+ if ((!(fpsr & BIT_DZE)) && (arm_fpe & BIT_DZC))
[...]
ERROR: suspect code indent for conditional statements (20, 22)
#485: FILE: linux-user/arm/cpu_loop.inc.c:264:
+ if ((!(fpsr & BIT_IOE)) && (arm_fpe & BIT_IOC))
+ fpsr |= BIT_IOC;
ERROR: braces {} are necessary for all arms of this statement
#485: FILE: linux-user/arm/cpu_loop.inc.c:264:
+ if ((!(fpsr & BIT_IOE)) && (arm_fpe & BIT_IOC))
[...]
ERROR: spaces required around that '=' (ctx:VxV)
#487: FILE: linux-user/arm/cpu_loop.inc.c:266:
+ ts->fpa.fpsr=fpsr;
^
ERROR: space prohibited between function name and open parenthesis '('
#527: FILE: linux-user/arm/cpu_loop.inc.c:306:
+ env->regs[0] = do_arm_semihosting (env);
ERROR: space prohibited after that open parenthesis '('
#536: FILE: linux-user/arm/cpu_loop.inc.c:315:
+ if ( n > ARM_NR_BASE) {
ERROR: that open brace { should be on the previous line
#599: FILE: linux-user/arm/cpu_loop.inc.c:378:
+ if (sig)
+ {
ERROR: suspect code indent for conditional statements (12, 14)
#609: FILE: linux-user/arm/cpu_loop.inc.c:388:
+ if (do_kernel_trap(env))
+ goto error;
ERROR: braces {} are necessary for all arms of this statement
#609: FILE: linux-user/arm/cpu_loop.inc.c:388:
+ if (do_kernel_trap(env))
[...]
WARNING: line over 80 characters
#620: FILE: linux-user/arm/cpu_loop.inc.c:399:
+ EXCP_DUMP(env, "qemu: unhandled CPU exception 0x%x - aborting\n", trapnr);
WARNING: line over 80 characters
#699: FILE: linux-user/arm/cpu_loop.inc.c:478:
+ EXCP_DUMP(env, "qemu: unhandled CPU exception 0x%x - aborting\n", trapnr);
ERROR: code indent should never use tabs
#739: FILE: linux-user/cris/cpu_loop.inc.c:24:
+^Icase EXCP_INTERRUPT:$
ERROR: code indent should never use tabs
#740: FILE: linux-user/cris/cpu_loop.inc.c:25:
+^I /* just indicate that signals should be handled asap */$
ERROR: code indent should never use tabs
#741: FILE: linux-user/cris/cpu_loop.inc.c:26:
+^I break;$
ERROR: that open brace { should be on the previous line
#763: FILE: linux-user/cris/cpu_loop.inc.c:48:
+ if (sig)
+ {
ERROR: space prohibited between function name and open parenthesis '('
#776: FILE: linux-user/cris/cpu_loop.inc.c:61:
+ printf ("Unhandled trap: 0x%x\n", trapnr);
ERROR: space prohibited between function name and open parenthesis '('
#780: FILE: linux-user/cris/cpu_loop.inc.c:65:
+ process_pending_signals (env);
ERROR: space required before the open parenthesis '('
#1040: FILE: linux-user/i386/cpu_loop.inc.c:68:
+ for(;;) {
ERROR: space required before the open parenthesis '('
#1046: FILE: linux-user/i386/cpu_loop.inc.c:74:
+ switch(trapnr) {
ERROR: braces {} are necessary for all arms of this statement
#1094: FILE: linux-user/i386/cpu_loop.inc.c:122:
+ if (env->eflags & VM_MASK) {
[...]
+ } else
[...]
ERROR: braces {} are necessary for all arms of this statement
#1109: FILE: linux-user/i386/cpu_loop.inc.c:137:
+ if (!(env->error_code & 1))
[...]
+ else
[...]
ERROR: braces {} are necessary for all arms of this statement
#1118: FILE: linux-user/i386/cpu_loop.inc.c:146:
+ if (env->eflags & VM_MASK) {
[...]
+ } else
[...]
ERROR: braces {} are necessary for all arms of this statement
#1134: FILE: linux-user/i386/cpu_loop.inc.c:162:
+ if (env->eflags & VM_MASK) {
[...]
+ } else
[...]
ERROR: braces {} are necessary for all arms of this statement
#1154: FILE: linux-user/i386/cpu_loop.inc.c:182:
+ if (env->eflags & VM_MASK) {
[...]
+ } else
[...]
ERROR: that open brace { should be on the previous line
#1181: FILE: linux-user/i386/cpu_loop.inc.c:209:
+ if (sig)
+ {
WARNING: line over 80 characters
#1195: FILE: linux-user/i386/cpu_loop.inc.c:223:
+ EXCP_DUMP(env, "qemu: 0x%08lx: unhandled CPU exception 0x%x - aborting\n",
ERROR: space required before the open parenthesis '('
#1216: FILE: linux-user/m68k/cpu_loop.inc.c:9:
+ for(;;) {
ERROR: space required before the open parenthesis '('
#1222: FILE: linux-user/m68k/cpu_loop.inc.c:15:
+ switch(trapnr) {
ERROR: that open brace { should be on the previous line
#1304: FILE: linux-user/m68k/cpu_loop.inc.c:97:
+ if (sig)
+ {
WARNING: line over 80 characters
#1317: FILE: linux-user/m68k/cpu_loop.inc.c:110:
+ EXCP_DUMP(env, "qemu: unhandled CPU exception 0x%x - aborting\n", trapnr);
ERROR: code indent should never use tabs
#5281: FILE: linux-user/microblaze/cpu_loop.inc.c:24:
+^Icase EXCP_INTERRUPT:$
ERROR: code indent should never use tabs
#5282: FILE: linux-user/microblaze/cpu_loop.inc.c:25:
+^I /* just indicate that signals should be handled asap */$
ERROR: code indent should never use tabs
#5283: FILE: linux-user/microblaze/cpu_loop.inc.c:26:
+^I break;$
ERROR: switch and case should be at the same indent
#5321: FILE: linux-user/microblaze/cpu_loop.inc.c:64:
+ switch (env->sregs[SR_ESR] & 31) {
+ case ESR_EC_DIVZERO:
[...]
+ case ESR_EC_FPU:
[...]
+ default:
ERROR: space prohibited between function name and open parenthesis '('
#5342: FILE: linux-user/microblaze/cpu_loop.inc.c:85:
+ printf ("Unhandled hw-exception: 0x%x\n",
ERROR: that open brace { should be on the previous line
#5354: FILE: linux-user/microblaze/cpu_loop.inc.c:97:
+ if (sig)
+ {
ERROR: space prohibited between function name and open parenthesis '('
#5367: FILE: linux-user/microblaze/cpu_loop.inc.c:110:
+ printf ("Unhandled trap: 0x%x\n", trapnr);
ERROR: space prohibited between function name and open parenthesis '('
#5371: FILE: linux-user/microblaze/cpu_loop.inc.c:114:
+ process_pending_signals (env);
ERROR: Macros with complex values should be enclosed in parenthesis
#5381: FILE: linux-user/mips/cpu_loop.inc.c:2:
+# define MIPS_SYS(name, args) args,
ERROR: code indent should never use tabs
#5383: FILE: linux-user/mips/cpu_loop.inc.c:4:
+^IMIPS_SYS(sys_syscall^I, 8)^I/* 4000 */$
ERROR: code indent should never use tabs
#5384: FILE: linux-user/mips/cpu_loop.inc.c:5:
+^IMIPS_SYS(sys_exit^I, 1)$
ERROR: code indent should never use tabs
#5385: FILE: linux-user/mips/cpu_loop.inc.c:6:
+^IMIPS_SYS(sys_fork^I, 0)$
ERROR: code indent should never use tabs
#5386: FILE: linux-user/mips/cpu_loop.inc.c:7:
+^IMIPS_SYS(sys_read^I, 3)$
ERROR: code indent should never use tabs
#5387: FILE: linux-user/mips/cpu_loop.inc.c:8:
+^IMIPS_SYS(sys_write^I, 3)$
ERROR: code indent should never use tabs
#5388: FILE: linux-user/mips/cpu_loop.inc.c:9:
+^IMIPS_SYS(sys_open^I, 3)^I/* 4005 */$
ERROR: code indent should never use tabs
#5389: FILE: linux-user/mips/cpu_loop.inc.c:10:
+^IMIPS_SYS(sys_close^I, 1)$
ERROR: code indent should never use tabs
#5390: FILE: linux-user/mips/cpu_loop.inc.c:11:
+^IMIPS_SYS(sys_waitpid^I, 3)$
ERROR: code indent should never use tabs
#5391: FILE: linux-user/mips/cpu_loop.inc.c:12:
+^IMIPS_SYS(sys_creat^I, 2)$
ERROR: code indent should never use tabs
#5392: FILE: linux-user/mips/cpu_loop.inc.c:13:
+^IMIPS_SYS(sys_link^I, 2)$
ERROR: code indent should never use tabs
#5393: FILE: linux-user/mips/cpu_loop.inc.c:14:
+^IMIPS_SYS(sys_unlink^I, 1)^I/* 4010 */$
ERROR: code indent should never use tabs
#5394: FILE: linux-user/mips/cpu_loop.inc.c:15:
+^IMIPS_SYS(sys_execve^I, 0)$
ERROR: code indent should never use tabs
#5395: FILE: linux-user/mips/cpu_loop.inc.c:16:
+^IMIPS_SYS(sys_chdir^I, 1)$
ERROR: code indent should never use tabs
#5396: FILE: linux-user/mips/cpu_loop.inc.c:17:
+^IMIPS_SYS(sys_time^I, 1)$
ERROR: code indent should never use tabs
#5397: FILE: linux-user/mips/cpu_loop.inc.c:18:
+^IMIPS_SYS(sys_mknod^I, 3)$
ERROR: code indent should never use tabs
#5398: FILE: linux-user/mips/cpu_loop.inc.c:19:
+^IMIPS_SYS(sys_chmod^I, 2)^I/* 4015 */$
ERROR: code indent should never use tabs
#5399: FILE: linux-user/mips/cpu_loop.inc.c:20:
+^IMIPS_SYS(sys_lchown^I, 3)$
ERROR: code indent should never use tabs
#5400: FILE: linux-user/mips/cpu_loop.inc.c:21:
+^IMIPS_SYS(sys_ni_syscall^I, 0)$
ERROR: code indent should never use tabs
#5401: FILE: linux-user/mips/cpu_loop.inc.c:22:
+^IMIPS_SYS(sys_ni_syscall^I, 0)^I/* was sys_stat */$
ERROR: code indent should never use tabs
#5402: FILE: linux-user/mips/cpu_loop.inc.c:23:
+^IMIPS_SYS(sys_lseek^I, 3)$
ERROR: code indent should never use tabs
#5403: FILE: linux-user/mips/cpu_loop.inc.c:24:
+^IMIPS_SYS(sys_getpid^I, 0)^I/* 4020 */$
ERROR: code indent should never use tabs
#5404: FILE: linux-user/mips/cpu_loop.inc.c:25:
+^IMIPS_SYS(sys_mount^I, 5)$
ERROR: code indent should never use tabs
#5405: FILE: linux-user/mips/cpu_loop.inc.c:26:
+^IMIPS_SYS(sys_umount^I, 1)$
ERROR: code indent should never use tabs
#5406: FILE: linux-user/mips/cpu_loop.inc.c:27:
+^IMIPS_SYS(sys_setuid^I, 1)$
ERROR: code indent should never use tabs
#5407: FILE: linux-user/mips/cpu_loop.inc.c:28:
+^IMIPS_SYS(sys_getuid^I, 0)$
ERROR: code indent should never use tabs
#5408: FILE: linux-user/mips/cpu_loop.inc.c:29:
+^IMIPS_SYS(sys_stime^I, 1)^I/* 4025 */$
ERROR: code indent should never use tabs
#5409: FILE: linux-user/mips/cpu_loop.inc.c:30:
+^IMIPS_SYS(sys_ptrace^I, 4)$
ERROR: code indent should never use tabs
#5410: FILE: linux-user/mips/cpu_loop.inc.c:31:
+^IMIPS_SYS(sys_alarm^I, 1)$
ERROR: code indent should never use tabs
#5411: FILE: linux-user/mips/cpu_loop.inc.c:32:
+^IMIPS_SYS(sys_ni_syscall^I, 0)^I/* was sys_fstat */$
ERROR: code indent should never use tabs
#5412: FILE: linux-user/mips/cpu_loop.inc.c:33:
+^IMIPS_SYS(sys_pause^I, 0)$
ERROR: code indent should never use tabs
#5413: FILE: linux-user/mips/cpu_loop.inc.c:34:
+^IMIPS_SYS(sys_utime^I, 2)^I/* 4030 */$
ERROR: code indent should never use tabs
#5414: FILE: linux-user/mips/cpu_loop.inc.c:35:
+^IMIPS_SYS(sys_ni_syscall^I, 0)$
ERROR: code indent should never use tabs
#5415: FILE: linux-user/mips/cpu_loop.inc.c:36:
+^IMIPS_SYS(sys_ni_syscall^I, 0)$
ERROR: code indent should never use tabs
#5416: FILE: linux-user/mips/cpu_loop.inc.c:37:
+^IMIPS_SYS(sys_access^I, 2)$
ERROR: code indent should never use tabs
#5417: FILE: linux-user/mips/cpu_loop.inc.c:38:
+^IMIPS_SYS(sys_nice^I, 1)$
ERROR: code indent should never use tabs
#5418: FILE: linux-user/mips/cpu_loop.inc.c:39:
+^IMIPS_SYS(sys_ni_syscall^I, 0)^I/* 4035 */$
ERROR: code indent should never use tabs
#5419: FILE: linux-user/mips/cpu_loop.inc.c:40:
+^IMIPS_SYS(sys_sync^I, 0)$
ERROR: code indent should never use tabs
#5420: FILE: linux-user/mips/cpu_loop.inc.c:41:
+^IMIPS_SYS(sys_kill^I, 2)$
ERROR: code indent should never use tabs
#5421: FILE: linux-user/mips/cpu_loop.inc.c:42:
+^IMIPS_SYS(sys_rename^I, 2)$
ERROR: code indent should never use tabs
#5422: FILE: linux-user/mips/cpu_loop.inc.c:43:
+^IMIPS_SYS(sys_mkdir^I, 2)$
ERROR: code indent should never use tabs
#5423: FILE: linux-user/mips/cpu_loop.inc.c:44:
+^IMIPS_SYS(sys_rmdir^I, 1)^I/* 4040 */$
ERROR: code indent should never use tabs
#5424: FILE: linux-user/mips/cpu_loop.inc.c:45:
+^IMIPS_SYS(sys_dup^I^I, 1)$
ERROR: code indent should never use tabs
#5425: FILE: linux-user/mips/cpu_loop.inc.c:46:
+^IMIPS_SYS(sys_pipe^I, 0)$
ERROR: code indent should never use tabs
#5426: FILE: linux-user/mips/cpu_loop.inc.c:47:
+^IMIPS_SYS(sys_times^I, 1)$
ERROR: code indent should never use tabs
#5427: FILE: linux-user/mips/cpu_loop.inc.c:48:
+^IMIPS_SYS(sys_ni_syscall^I, 0)$
ERROR: code indent should never use tabs
#5428: FILE: linux-user/mips/cpu_loop.inc.c:49:
+^IMIPS_SYS(sys_brk^I^I, 1)^I/* 4045 */$
ERROR: code indent should never use tabs
#5429: FILE: linux-user/mips/cpu_loop.inc.c:50:
+^IMIPS_SYS(sys_setgid^I, 1)$
ERROR: code indent should never use tabs
#5430: FILE: linux-user/mips/cpu_loop.inc.c:51:
+^IMIPS_SYS(sys_getgid^I, 0)$
ERROR: code indent should never use tabs
#5431: FILE: linux-user/mips/cpu_loop.inc.c:52:
+^IMIPS_SYS(sys_ni_syscall^I, 0)^I/* was signal(2) */$
ERROR: code indent should never use tabs
#5432: FILE: linux-user/mips/cpu_loop.inc.c:53:
+^IMIPS_SYS(sys_geteuid^I, 0)$
ERROR: code indent should never use tabs
#5433: FILE: linux-user/mips/cpu_loop.inc.c:54:
+^IMIPS_SYS(sys_getegid^I, 0)^I/* 4050 */$
ERROR: code indent should never use tabs
#5434: FILE: linux-user/mips/cpu_loop.inc.c:55:
+^IMIPS_SYS(sys_acct^I, 0)$
ERROR: code indent should never use tabs
#5435: FILE: linux-user/mips/cpu_loop.inc.c:56:
+^IMIPS_SYS(sys_umount2^I, 2)$
ERROR: code indent should never use tabs
#5436: FILE: linux-user/mips/cpu_loop.inc.c:57:
+^IMIPS_SYS(sys_ni_syscall^I, 0)$
ERROR: code indent should never use tabs
#5437: FILE: linux-user/mips/cpu_loop.inc.c:58:
+^IMIPS_SYS(sys_ioctl^I, 3)$
ERROR: code indent should never use tabs
#5438: FILE: linux-user/mips/cpu_loop.inc.c:59:
+^IMIPS_SYS(sys_fcntl^I, 3)^I/* 4055 */$
ERROR: code indent should never use tabs
#5439: FILE: linux-user/mips/cpu_loop.inc.c:60:
+^IMIPS_SYS(sys_ni_syscall^I, 2)$
ERROR: code indent should never use tabs
#5440: FILE: linux-user/mips/cpu_loop.inc.c:61:
+^IMIPS_SYS(sys_setpgid^I, 2)$
ERROR: code indent should never use tabs
#5441: FILE: linux-user/mips/cpu_loop.inc.c:62:
+^IMIPS_SYS(sys_ni_syscall^I, 0)$
ERROR: code indent should never use tabs
#5442: FILE: linux-user/mips/cpu_loop.inc.c:63:
+^IMIPS_SYS(sys_olduname^I, 1)$
ERROR: code indent should never use tabs
#5443: FILE: linux-user/mips/cpu_loop.inc.c:64:
+^IMIPS_SYS(sys_umask^I, 1)^I/* 4060 */$
ERROR: code indent should never use tabs
#5444: FILE: linux-user/mips/cpu_loop.inc.c:65:
+^IMIPS_SYS(sys_chroot^I, 1)$
ERROR: code indent should never use tabs
#5445: FILE: linux-user/mips/cpu_loop.inc.c:66:
+^IMIPS_SYS(sys_ustat^I, 2)$
ERROR: code indent should never use tabs
#5446: FILE: linux-user/mips/cpu_loop.inc.c:67:
+^IMIPS_SYS(sys_dup2^I, 2)$
ERROR: code indent should never use tabs
#5447: FILE: linux-user/mips/cpu_loop.inc.c:68:
+^IMIPS_SYS(sys_getppid^I, 0)$
ERROR: code indent should never use tabs
#5448: FILE: linux-user/mips/cpu_loop.inc.c:69:
+^IMIPS_SYS(sys_getpgrp^I, 0)^I/* 4065 */$
ERROR: code indent should never use tabs
#5449: FILE: linux-user/mips/cpu_loop.inc.c:70:
+^IMIPS_SYS(sys_setsid^I, 0)$
ERROR: code indent should never use tabs
#5450: FILE: linux-user/mips/cpu_loop.inc.c:71:
+^IMIPS_SYS(sys_sigaction^I, 3)$
ERROR: code indent should never use tabs
#5451: FILE: linux-user/mips/cpu_loop.inc.c:72:
+^IMIPS_SYS(sys_sgetmask^I, 0)$
ERROR: code indent should never use tabs
#5452: FILE: linux-user/mips/cpu_loop.inc.c:73:
+^IMIPS_SYS(sys_ssetmask^I, 1)$
ERROR: code indent should never use tabs
#5453: FILE: linux-user/mips/cpu_loop.inc.c:74:
+^IMIPS_SYS(sys_setreuid^I, 2)^I/* 4070 */$
ERROR: code indent should never use tabs
#5454: FILE: linux-user/mips/cpu_loop.inc.c:75:
+^IMIPS_SYS(sys_setregid^I, 2)$
ERROR: code indent should never use tabs
#5455: FILE: linux-user/mips/cpu_loop.inc.c:76:
+^IMIPS_SYS(sys_sigsuspend^I, 0)$
ERROR: code indent should never use tabs
#5456: FILE: linux-user/mips/cpu_loop.inc.c:77:
+^IMIPS_SYS(sys_sigpending^I, 1)$
ERROR: code indent should never use tabs
#5457: FILE: linux-user/mips/cpu_loop.inc.c:78:
+^IMIPS_SYS(sys_sethostname^I, 2)$
ERROR: code indent should never use tabs
#5458: FILE: linux-user/mips/cpu_loop.inc.c:79:
+^IMIPS_SYS(sys_setrlimit^I, 2)^I/* 4075 */$
ERROR: code indent should never use tabs
#5459: FILE: linux-user/mips/cpu_loop.inc.c:80:
+^IMIPS_SYS(sys_getrlimit^I, 2)$
ERROR: code indent should never use tabs
#5460: FILE: linux-user/mips/cpu_loop.inc.c:81:
+^IMIPS_SYS(sys_getrusage^I, 2)$
ERROR: code indent should never use tabs
#5461: FILE: linux-user/mips/cpu_loop.inc.c:82:
+^IMIPS_SYS(sys_gettimeofday, 2)$
ERROR: code indent should never use tabs
#5462: FILE: linux-user/mips/cpu_loop.inc.c:83:
+^IMIPS_SYS(sys_settimeofday, 2)$
ERROR: code indent should never use tabs
#5463: FILE: linux-user/mips/cpu_loop.inc.c:84:
+^IMIPS_SYS(sys_getgroups^I, 2)^I/* 4080 */$
ERROR: code indent should never use tabs
#5464: FILE: linux-user/mips/cpu_loop.inc.c:85:
+^IMIPS_SYS(sys_setgroups^I, 2)$
ERROR: code indent should never use tabs
#5465: FILE: linux-user/mips/cpu_loop.inc.c:86:
+^IMIPS_SYS(sys_ni_syscall^I, 0)^I/* old_select */$
ERROR: code indent should never use tabs
#5466: FILE: linux-user/mips/cpu_loop.inc.c:87:
+^IMIPS_SYS(sys_symlink^I, 2)$
ERROR: code indent should never use tabs
#5467: FILE: linux-user/mips/cpu_loop.inc.c:88:
+^IMIPS_SYS(sys_ni_syscall^I, 0)^I/* was sys_lstat */$
ERROR: code indent should never use tabs
#5468: FILE: linux-user/mips/cpu_loop.inc.c:89:
+^IMIPS_SYS(sys_readlink^I, 3)^I/* 4085 */$
ERROR: code indent should never use tabs
#5469: FILE: linux-user/mips/cpu_loop.inc.c:90:
+^IMIPS_SYS(sys_uselib^I, 1)$
ERROR: code indent should never use tabs
#5470: FILE: linux-user/mips/cpu_loop.inc.c:91:
+^IMIPS_SYS(sys_swapon^I, 2)$
ERROR: code indent should never use tabs
#5471: FILE: linux-user/mips/cpu_loop.inc.c:92:
+^IMIPS_SYS(sys_reboot^I, 3)$
ERROR: code indent should never use tabs
#5472: FILE: linux-user/mips/cpu_loop.inc.c:93:
+^IMIPS_SYS(old_readdir^I, 3)$
ERROR: code indent should never use tabs
#5473: FILE: linux-user/mips/cpu_loop.inc.c:94:
+^IMIPS_SYS(old_mmap^I, 6)^I/* 4090 */$
ERROR: code indent should never use tabs
#5474: FILE: linux-user/mips/cpu_loop.inc.c:95:
+^IMIPS_SYS(sys_munmap^I, 2)$
ERROR: code indent should never use tabs
#5475: FILE: linux-user/mips/cpu_loop.inc.c:96:
+^IMIPS_SYS(sys_truncate^I, 2)$
ERROR: code indent should never use tabs
#5476: FILE: linux-user/mips/cpu_loop.inc.c:97:
+^IMIPS_SYS(sys_ftruncate^I, 2)$
ERROR: code indent should never use tabs
#5477: FILE: linux-user/mips/cpu_loop.inc.c:98:
+^IMIPS_SYS(sys_fchmod^I, 2)$
ERROR: code indent should never use tabs
#5478: FILE: linux-user/mips/cpu_loop.inc.c:99:
+^IMIPS_SYS(sys_fchown^I, 3)^I/* 4095 */$
ERROR: code indent should never use tabs
#5479: FILE: linux-user/mips/cpu_loop.inc.c:100:
+^IMIPS_SYS(sys_getpriority^I, 2)$
ERROR: code indent should never use tabs
#5480: FILE: linux-user/mips/cpu_loop.inc.c:101:
+^IMIPS_SYS(sys_setpriority^I, 3)$
ERROR: code indent should never use tabs
#5481: FILE: linux-user/mips/cpu_loop.inc.c:102:
+^IMIPS_SYS(sys_ni_syscall^I, 0)$
ERROR: code indent should never use tabs
#5482: FILE: linux-user/mips/cpu_loop.inc.c:103:
+^IMIPS_SYS(sys_statfs^I, 2)$
ERROR: code indent should never use tabs
#5483: FILE: linux-user/mips/cpu_loop.inc.c:104:
+^IMIPS_SYS(sys_fstatfs^I, 2)^I/* 4100 */$
ERROR: code indent should never use tabs
#5484: FILE: linux-user/mips/cpu_loop.inc.c:105:
+^IMIPS_SYS(sys_ni_syscall^I, 0)^I/* was ioperm(2) */$
ERROR: code indent should never use tabs
#5485: FILE: linux-user/mips/cpu_loop.inc.c:106:
+^IMIPS_SYS(sys_socketcall^I, 2)$
ERROR: code indent should never use tabs
#5486: FILE: linux-user/mips/cpu_loop.inc.c:107:
+^IMIPS_SYS(sys_syslog^I, 3)$
ERROR: code indent should never use tabs
#5487: FILE: linux-user/mips/cpu_loop.inc.c:108:
+^IMIPS_SYS(sys_setitimer^I, 3)$
ERROR: code indent should never use tabs
#5488: FILE: linux-user/mips/cpu_loop.inc.c:109:
+^IMIPS_SYS(sys_getitimer^I, 2)^I/* 4105 */$
ERROR: code indent should never use tabs
#5489: FILE: linux-user/mips/cpu_loop.inc.c:110:
+^IMIPS_SYS(sys_newstat^I, 2)$
ERROR: code indent should never use tabs
#5490: FILE: linux-user/mips/cpu_loop.inc.c:111:
+^IMIPS_SYS(sys_newlstat^I, 2)$
ERROR: code indent should never use tabs
#5491: FILE: linux-user/mips/cpu_loop.inc.c:112:
+^IMIPS_SYS(sys_newfstat^I, 2)$
ERROR: code indent should never use tabs
#5492: FILE: linux-user/mips/cpu_loop.inc.c:113:
+^IMIPS_SYS(sys_uname^I, 1)$
ERROR: code indent should never use tabs
#5493: FILE: linux-user/mips/cpu_loop.inc.c:114:
+^IMIPS_SYS(sys_ni_syscall^I, 0)^I/* 4110 was iopl(2) */$
ERROR: code indent should never use tabs
#5494: FILE: linux-user/mips/cpu_loop.inc.c:115:
+^IMIPS_SYS(sys_vhangup^I, 0)$
ERROR: code indent should never use tabs
#5495: FILE: linux-user/mips/cpu_loop.inc.c:116:
+^IMIPS_SYS(sys_ni_syscall^I, 0)^I/* was sys_idle() */$
ERROR: code indent should never use tabs
#5496: FILE: linux-user/mips/cpu_loop.inc.c:117:
+^IMIPS_SYS(sys_ni_syscall^I, 0)^I/* was sys_vm86 */$
ERROR: code indent should never use tabs
#5497: FILE: linux-user/mips/cpu_loop.inc.c:118:
+^IMIPS_SYS(sys_wait4^I, 4)$
ERROR: code indent should never use tabs
#5498: FILE: linux-user/mips/cpu_loop.inc.c:119:
+^IMIPS_SYS(sys_swapoff^I, 1)^I/* 4115 */$
ERROR: code indent should never use tabs
#5499: FILE: linux-user/mips/cpu_loop.inc.c:120:
+^IMIPS_SYS(sys_sysinfo^I, 1)$
ERROR: code indent should never use tabs
#5500: FILE: linux-user/mips/cpu_loop.inc.c:121:
+^IMIPS_SYS(sys_ipc^I^I, 6)$
ERROR: code indent should never use tabs
#5501: FILE: linux-user/mips/cpu_loop.inc.c:122:
+^IMIPS_SYS(sys_fsync^I, 1)$
ERROR: code indent should never use tabs
#5502: FILE: linux-user/mips/cpu_loop.inc.c:123:
+^IMIPS_SYS(sys_sigreturn^I, 0)$
ERROR: code indent should never use tabs
#5503: FILE: linux-user/mips/cpu_loop.inc.c:124:
+^IMIPS_SYS(sys_clone^I, 6)^I/* 4120 */$
ERROR: code indent should never use tabs
#5504: FILE: linux-user/mips/cpu_loop.inc.c:125:
+^IMIPS_SYS(sys_setdomainname, 2)$
ERROR: code indent should never use tabs
#5505: FILE: linux-user/mips/cpu_loop.inc.c:126:
+^IMIPS_SYS(sys_newuname^I, 1)$
ERROR: code indent should never use tabs
#5506: FILE: linux-user/mips/cpu_loop.inc.c:127:
+^IMIPS_SYS(sys_ni_syscall^I, 0)^I/* sys_modify_ldt */$
ERROR: code indent should never use tabs
#5507: FILE: linux-user/mips/cpu_loop.inc.c:128:
+^IMIPS_SYS(sys_adjtimex^I, 1)$
ERROR: code indent should never use tabs
#5508: FILE: linux-user/mips/cpu_loop.inc.c:129:
+^IMIPS_SYS(sys_mprotect^I, 3)^I/* 4125 */$
ERROR: code indent should never use tabs
#5509: FILE: linux-user/mips/cpu_loop.inc.c:130:
+^IMIPS_SYS(sys_sigprocmask^I, 3)$
ERROR: code indent should never use tabs
#5510: FILE: linux-user/mips/cpu_loop.inc.c:131:
+^IMIPS_SYS(sys_ni_syscall^I, 0)^I/* was create_module */$
ERROR: code indent should never use tabs
#5511: FILE: linux-user/mips/cpu_loop.inc.c:132:
+^IMIPS_SYS(sys_init_module^I, 5)$
ERROR: code indent should never use tabs
#5512: FILE: linux-user/mips/cpu_loop.inc.c:133:
+^IMIPS_SYS(sys_delete_module, 1)$
ERROR: code indent should never use tabs
#5513: FILE: linux-user/mips/cpu_loop.inc.c:134:
+^IMIPS_SYS(sys_ni_syscall^I, 0)^I/* 4130^Iwas get_kernel_syms */$
ERROR: code indent should never use tabs
#5514: FILE: linux-user/mips/cpu_loop.inc.c:135:
+^IMIPS_SYS(sys_quotactl^I, 0)$
ERROR: code indent should never use tabs
#5515: FILE: linux-user/mips/cpu_loop.inc.c:136:
+^IMIPS_SYS(sys_getpgid^I, 1)$
ERROR: code indent should never use tabs
#5516: FILE: linux-user/mips/cpu_loop.inc.c:137:
+^IMIPS_SYS(sys_fchdir^I, 1)$
ERROR: code indent should never use tabs
#5517: FILE: linux-user/mips/cpu_loop.inc.c:138:
+^IMIPS_SYS(sys_bdflush^I, 2)$
ERROR: code indent should never use tabs
#5518: FILE: linux-user/mips/cpu_loop.inc.c:139:
+^IMIPS_SYS(sys_sysfs^I, 3)^I/* 4135 */$
ERROR: code indent should never use tabs
#5519: FILE: linux-user/mips/cpu_loop.inc.c:140:
+^IMIPS_SYS(sys_personality^I, 1)$
ERROR: code indent should never use tabs
#5520: FILE: linux-user/mips/cpu_loop.inc.c:141:
+^IMIPS_SYS(sys_ni_syscall^I, 0)^I/* for afs_syscall */$
ERROR: code indent should never use tabs
#5521: FILE: linux-user/mips/cpu_loop.inc.c:142:
+^IMIPS_SYS(sys_setfsuid^I, 1)$
ERROR: code indent should never use tabs
#5522: FILE: linux-user/mips/cpu_loop.inc.c:143:
+^IMIPS_SYS(sys_setfsgid^I, 1)$
ERROR: code indent should never use tabs
#5523: FILE: linux-user/mips/cpu_loop.inc.c:144:
+^IMIPS_SYS(sys_llseek^I, 5)^I/* 4140 */$
ERROR: code indent should never use tabs
#5524: FILE: linux-user/mips/cpu_loop.inc.c:145:
+^IMIPS_SYS(sys_getdents^I, 3)$
ERROR: code indent should never use tabs
#5525: FILE: linux-user/mips/cpu_loop.inc.c:146:
+^IMIPS_SYS(sys_select^I, 5)$
ERROR: code indent should never use tabs
#5526: FILE: linux-user/mips/cpu_loop.inc.c:147:
+^IMIPS_SYS(sys_flock^I, 2)$
ERROR: code indent should never use tabs
#5527: FILE: linux-user/mips/cpu_loop.inc.c:148:
+^IMIPS_SYS(sys_msync^I, 3)$
ERROR: code indent should never use tabs
#5528: FILE: linux-user/mips/cpu_loop.inc.c:149:
+^IMIPS_SYS(sys_readv^I, 3)^I/* 4145 */$
ERROR: code indent should never use tabs
#5529: FILE: linux-user/mips/cpu_loop.inc.c:150:
+^IMIPS_SYS(sys_writev^I, 3)$
ERROR: code indent should never use tabs
#5530: FILE: linux-user/mips/cpu_loop.inc.c:151:
+^IMIPS_SYS(sys_cacheflush^I, 3)$
ERROR: code indent should never use tabs
#5531: FILE: linux-user/mips/cpu_loop.inc.c:152:
+^IMIPS_SYS(sys_cachectl^I, 3)$
ERROR: code indent should never use tabs
#5532: FILE: linux-user/mips/cpu_loop.inc.c:153:
+^IMIPS_SYS(sys_sysmips^I, 4)$
ERROR: code indent should never use tabs
#5533: FILE: linux-user/mips/cpu_loop.inc.c:154:
+^IMIPS_SYS(sys_ni_syscall^I, 0)^I/* 4150 */$
ERROR: code indent should never use tabs
#5534: FILE: linux-user/mips/cpu_loop.inc.c:155:
+^IMIPS_SYS(sys_getsid^I, 1)$
ERROR: code indent should never use tabs
#5535: FILE: linux-user/mips/cpu_loop.inc.c:156:
+^IMIPS_SYS(sys_fdatasync^I, 0)$
ERROR: code indent should never use tabs
#5536: FILE: linux-user/mips/cpu_loop.inc.c:157:
+^IMIPS_SYS(sys_sysctl^I, 1)$
ERROR: code indent should never use tabs
#5537: FILE: linux-user/mips/cpu_loop.inc.c:158:
+^IMIPS_SYS(sys_mlock^I, 2)$
ERROR: code indent should never use tabs
#5538: FILE: linux-user/mips/cpu_loop.inc.c:159:
+^IMIPS_SYS(sys_munlock^I, 2)^I/* 4155 */$
ERROR: code indent should never use tabs
#5539: FILE: linux-user/mips/cpu_loop.inc.c:160:
+^IMIPS_SYS(sys_mlockall^I, 1)$
ERROR: code indent should never use tabs
#5540: FILE: linux-user/mips/cpu_loop.inc.c:161:
+^IMIPS_SYS(sys_munlockall^I, 0)$
ERROR: code indent should never use tabs
#5541: FILE: linux-user/mips/cpu_loop.inc.c:162:
+^IMIPS_SYS(sys_sched_setparam, 2)$
ERROR: code indent should never use tabs
#5542: FILE: linux-user/mips/cpu_loop.inc.c:163:
+^IMIPS_SYS(sys_sched_getparam, 2)$
ERROR: code indent should never use tabs
#5543: FILE: linux-user/mips/cpu_loop.inc.c:164:
+^IMIPS_SYS(sys_sched_setscheduler, 3)^I/* 4160 */$
ERROR: code indent should never use tabs
#5544: FILE: linux-user/mips/cpu_loop.inc.c:165:
+^IMIPS_SYS(sys_sched_getscheduler, 1)$
ERROR: code indent should never use tabs
#5545: FILE: linux-user/mips/cpu_loop.inc.c:166:
+^IMIPS_SYS(sys_sched_yield^I, 0)$
ERROR: code indent should never use tabs
#5546: FILE: linux-user/mips/cpu_loop.inc.c:167:
+^IMIPS_SYS(sys_sched_get_priority_max, 1)$
ERROR: code indent should never use tabs
#5547: FILE: linux-user/mips/cpu_loop.inc.c:168:
+^IMIPS_SYS(sys_sched_get_priority_min, 1)$
ERROR: code indent should never use tabs
#5548: FILE: linux-user/mips/cpu_loop.inc.c:169:
+^IMIPS_SYS(sys_sched_rr_get_interval, 2)^I/* 4165 */$
ERROR: code indent should never use tabs
#5549: FILE: linux-user/mips/cpu_loop.inc.c:170:
+^IMIPS_SYS(sys_nanosleep,^I2)$
ERROR: code indent should never use tabs
#5550: FILE: linux-user/mips/cpu_loop.inc.c:171:
+^IMIPS_SYS(sys_mremap^I, 5)$
ERROR: code indent should never use tabs
#5551: FILE: linux-user/mips/cpu_loop.inc.c:172:
+^IMIPS_SYS(sys_accept^I, 3)$
ERROR: code indent should never use tabs
#5552: FILE: linux-user/mips/cpu_loop.inc.c:173:
+^IMIPS_SYS(sys_bind^I, 3)$
ERROR: code indent should never use tabs
#5553: FILE: linux-user/mips/cpu_loop.inc.c:174:
+^IMIPS_SYS(sys_connect^I, 3)^I/* 4170 */$
ERROR: code indent should never use tabs
#5554: FILE: linux-user/mips/cpu_loop.inc.c:175:
+^IMIPS_SYS(sys_getpeername^I, 3)$
ERROR: code indent should never use tabs
#5555: FILE: linux-user/mips/cpu_loop.inc.c:176:
+^IMIPS_SYS(sys_getsockname^I, 3)$
ERROR: code indent should never use tabs
#5556: FILE: linux-user/mips/cpu_loop.inc.c:177:
+^IMIPS_SYS(sys_getsockopt^I, 5)$
ERROR: code indent should never use tabs
#5557: FILE: linux-user/mips/cpu_loop.inc.c:178:
+^IMIPS_SYS(sys_listen^I, 2)$
ERROR: code indent should never use tabs
#5558: FILE: linux-user/mips/cpu_loop.inc.c:179:
+^IMIPS_SYS(sys_recv^I, 4)^I/* 4175 */$
ERROR: code indent should never use tabs
#5559: FILE: linux-user/mips/cpu_loop.inc.c:180:
+^IMIPS_SYS(sys_recvfrom^I, 6)$
ERROR: code indent should never use tabs
#5560: FILE: linux-user/mips/cpu_loop.inc.c:181:
+^IMIPS_SYS(sys_recvmsg^I, 3)$
ERROR: code indent should never use tabs
#5561: FILE: linux-user/mips/cpu_loop.inc.c:182:
+^IMIPS_SYS(sys_send^I, 4)$
ERROR: code indent should never use tabs
#5562: FILE: linux-user/mips/cpu_loop.inc.c:183:
+^IMIPS_SYS(sys_sendmsg^I, 3)$
ERROR: code indent should never use tabs
#5563: FILE: linux-user/mips/cpu_loop.inc.c:184:
+^IMIPS_SYS(sys_sendto^I, 6)^I/* 4180 */$
ERROR: code indent should never use tabs
#5564: FILE: linux-user/mips/cpu_loop.inc.c:185:
+^IMIPS_SYS(sys_setsockopt^I, 5)$
ERROR: code indent should never use tabs
#5565: FILE: linux-user/mips/cpu_loop.inc.c:186:
+^IMIPS_SYS(sys_shutdown^I, 2)$
ERROR: code indent should never use tabs
#5566: FILE: linux-user/mips/cpu_loop.inc.c:187:
+^IMIPS_SYS(sys_socket^I, 3)$
ERROR: code indent should never use tabs
#5567: FILE: linux-user/mips/cpu_loop.inc.c:188:
+^IMIPS_SYS(sys_socketpair^I, 4)$
ERROR: code indent should never use tabs
#5568: FILE: linux-user/mips/cpu_loop.inc.c:189:
+^IMIPS_SYS(sys_setresuid^I, 3)^I/* 4185 */$
ERROR: code indent should never use tabs
#5569: FILE: linux-user/mips/cpu_loop.inc.c:190:
+^IMIPS_SYS(sys_getresuid^I, 3)$
ERROR: code indent should never use tabs
#5570: FILE: linux-user/mips/cpu_loop.inc.c:191:
+^IMIPS_SYS(sys_ni_syscall^I, 0)^I/* was sys_query_module */$
ERROR: code indent should never use tabs
#5571: FILE: linux-user/mips/cpu_loop.inc.c:192:
+^IMIPS_SYS(sys_poll^I, 3)$
ERROR: code indent should never use tabs
#5572: FILE: linux-user/mips/cpu_loop.inc.c:193:
+^IMIPS_SYS(sys_nfsservctl^I, 3)$
ERROR: code indent should never use tabs
#5573: FILE: linux-user/mips/cpu_loop.inc.c:194:
+^IMIPS_SYS(sys_setresgid^I, 3)^I/* 4190 */$
ERROR: code indent should never use tabs
#5574: FILE: linux-user/mips/cpu_loop.inc.c:195:
+^IMIPS_SYS(sys_getresgid^I, 3)$
ERROR: code indent should never use tabs
#5575: FILE: linux-user/mips/cpu_loop.inc.c:196:
+^IMIPS_SYS(sys_prctl^I, 5)$
ERROR: code indent should never use tabs
#5576: FILE: linux-user/mips/cpu_loop.inc.c:197:
+^IMIPS_SYS(sys_rt_sigreturn, 0)$
ERROR: code indent should never use tabs
#5577: FILE: linux-user/mips/cpu_loop.inc.c:198:
+^IMIPS_SYS(sys_rt_sigaction, 4)$
ERROR: code indent should never use tabs
#5578: FILE: linux-user/mips/cpu_loop.inc.c:199:
+^IMIPS_SYS(sys_rt_sigprocmask, 4)^I/* 4195 */$
ERROR: code indent should never use tabs
#5579: FILE: linux-user/mips/cpu_loop.inc.c:200:
+^IMIPS_SYS(sys_rt_sigpending, 2)$
ERROR: code indent should never use tabs
#5580: FILE: linux-user/mips/cpu_loop.inc.c:201:
+^IMIPS_SYS(sys_rt_sigtimedwait, 4)$
ERROR: code indent should never use tabs
#5581: FILE: linux-user/mips/cpu_loop.inc.c:202:
+^IMIPS_SYS(sys_rt_sigqueueinfo, 3)$
ERROR: code indent should never use tabs
#5582: FILE: linux-user/mips/cpu_loop.inc.c:203:
+^IMIPS_SYS(sys_rt_sigsuspend, 0)$
ERROR: code indent should never use tabs
#5583: FILE: linux-user/mips/cpu_loop.inc.c:204:
+^IMIPS_SYS(sys_pread64^I, 6)^I/* 4200 */$
ERROR: code indent should never use tabs
#5584: FILE: linux-user/mips/cpu_loop.inc.c:205:
+^IMIPS_SYS(sys_pwrite64^I, 6)$
ERROR: code indent should never use tabs
#5585: FILE: linux-user/mips/cpu_loop.inc.c:206:
+^IMIPS_SYS(sys_chown^I, 3)$
ERROR: code indent should never use tabs
#5586: FILE: linux-user/mips/cpu_loop.inc.c:207:
+^IMIPS_SYS(sys_getcwd^I, 2)$
ERROR: code indent should never use tabs
#5587: FILE: linux-user/mips/cpu_loop.inc.c:208:
+^IMIPS_SYS(sys_capget^I, 2)$
ERROR: code indent should never use tabs
#5588: FILE: linux-user/mips/cpu_loop.inc.c:209:
+^IMIPS_SYS(sys_capset^I, 2)^I/* 4205 */$
ERROR: code indent should never use tabs
#5589: FILE: linux-user/mips/cpu_loop.inc.c:210:
+^IMIPS_SYS(sys_sigaltstack^I, 2)$
ERROR: code indent should never use tabs
#5590: FILE: linux-user/mips/cpu_loop.inc.c:211:
+^IMIPS_SYS(sys_sendfile^I, 4)$
ERROR: code indent should never use tabs
#5591: FILE: linux-user/mips/cpu_loop.inc.c:212:
+^IMIPS_SYS(sys_ni_syscall^I, 0)$
ERROR: code indent should never use tabs
#5592: FILE: linux-user/mips/cpu_loop.inc.c:213:
+^IMIPS_SYS(sys_ni_syscall^I, 0)$
ERROR: code indent should never use tabs
#5593: FILE: linux-user/mips/cpu_loop.inc.c:214:
+^IMIPS_SYS(sys_mmap2^I, 6)^I/* 4210 */$
ERROR: code indent should never use tabs
#5594: FILE: linux-user/mips/cpu_loop.inc.c:215:
+^IMIPS_SYS(sys_truncate64^I, 4)$
ERROR: code indent should never use tabs
#5595: FILE: linux-user/mips/cpu_loop.inc.c:216:
+^IMIPS_SYS(sys_ftruncate64^I, 4)$
ERROR: code indent should never use tabs
#5596: FILE: linux-user/mips/cpu_loop.inc.c:217:
+^IMIPS_SYS(sys_stat64^I, 2)$
ERROR: code indent should never use tabs
#5597: FILE: linux-user/mips/cpu_loop.inc.c:218:
+^IMIPS_SYS(sys_lstat64^I, 2)$
ERROR: code indent should never use tabs
#5598: FILE: linux-user/mips/cpu_loop.inc.c:219:
+^IMIPS_SYS(sys_fstat64^I, 2)^I/* 4215 */$
ERROR: code indent should never use tabs
#5599: FILE: linux-user/mips/cpu_loop.inc.c:220:
+^IMIPS_SYS(sys_pivot_root^I, 2)$
ERROR: code indent should never use tabs
#5600: FILE: linux-user/mips/cpu_loop.inc.c:221:
+^IMIPS_SYS(sys_mincore^I, 3)$
ERROR: code indent should never use tabs
#5601: FILE: linux-user/mips/cpu_loop.inc.c:222:
+^IMIPS_SYS(sys_madvise^I, 3)$
ERROR: code indent should never use tabs
#5602: FILE: linux-user/mips/cpu_loop.inc.c:223:
+^IMIPS_SYS(sys_getdents64^I, 3)$
ERROR: code indent should never use tabs
#5603: FILE: linux-user/mips/cpu_loop.inc.c:224:
+^IMIPS_SYS(sys_fcntl64^I, 3)^I/* 4220 */$
ERROR: code indent should never use tabs
#5604: FILE: linux-user/mips/cpu_loop.inc.c:225:
+^IMIPS_SYS(sys_ni_syscall^I, 0)$
ERROR: code indent should never use tabs
#5605: FILE: linux-user/mips/cpu_loop.inc.c:226:
+^IMIPS_SYS(sys_gettid^I, 0)$
ERROR: code indent should never use tabs
#5606: FILE: linux-user/mips/cpu_loop.inc.c:227:
+^IMIPS_SYS(sys_readahead^I, 5)$
ERROR: code indent should never use tabs
#5607: FILE: linux-user/mips/cpu_loop.inc.c:228:
+^IMIPS_SYS(sys_setxattr^I, 5)$
ERROR: code indent should never use tabs
#5608: FILE: linux-user/mips/cpu_loop.inc.c:229:
+^IMIPS_SYS(sys_lsetxattr^I, 5)^I/* 4225 */$
ERROR: code indent should never use tabs
#5609: FILE: linux-user/mips/cpu_loop.inc.c:230:
+^IMIPS_SYS(sys_fsetxattr^I, 5)$
ERROR: code indent should never use tabs
#5610: FILE: linux-user/mips/cpu_loop.inc.c:231:
+^IMIPS_SYS(sys_getxattr^I, 4)$
ERROR: code indent should never use tabs
#5611: FILE: linux-user/mips/cpu_loop.inc.c:232:
+^IMIPS_SYS(sys_lgetxattr^I, 4)$
ERROR: code indent should never use tabs
#5612: FILE: linux-user/mips/cpu_loop.inc.c:233:
+^IMIPS_SYS(sys_fgetxattr^I, 4)$
ERROR: code indent should never use tabs
#5613: FILE: linux-user/mips/cpu_loop.inc.c:234:
+^IMIPS_SYS(sys_listxattr^I, 3)^I/* 4230 */$
ERROR: code indent should never use tabs
#5614: FILE: linux-user/mips/cpu_loop.inc.c:235:
+^IMIPS_SYS(sys_llistxattr^I, 3)$
ERROR: code indent should never use tabs
#5615: FILE: linux-user/mips/cpu_loop.inc.c:236:
+^IMIPS_SYS(sys_flistxattr^I, 3)$
ERROR: code indent should never use tabs
#5616: FILE: linux-user/mips/cpu_loop.inc.c:237:
+^IMIPS_SYS(sys_removexattr^I, 2)$
ERROR: code indent should never use tabs
#5617: FILE: linux-user/mips/cpu_loop.inc.c:238:
+^IMIPS_SYS(sys_lremovexattr, 2)$
ERROR: code indent should never use tabs
#5618: FILE: linux-user/mips/cpu_loop.inc.c:239:
+^IMIPS_SYS(sys_fremovexattr, 2)^I/* 4235 */$
ERROR: code indent should never use tabs
#5619: FILE: linux-user/mips/cpu_loop.inc.c:240:
+^IMIPS_SYS(sys_tkill^I, 2)$
ERROR: code indent should never use tabs
#5620: FILE: linux-user/mips/cpu_loop.inc.c:241:
+^IMIPS_SYS(sys_sendfile64^I, 5)$
ERROR: code indent should never use tabs
#5621: FILE: linux-user/mips/cpu_loop.inc.c:242:
+^IMIPS_SYS(sys_futex^I, 6)$
ERROR: code indent should never use tabs
#5622: FILE: linux-user/mips/cpu_loop.inc.c:243:
+^IMIPS_SYS(sys_sched_setaffinity, 3)$
ERROR: code indent should never use tabs
#5623: FILE: linux-user/mips/cpu_loop.inc.c:244:
+^IMIPS_SYS(sys_sched_getaffinity, 3)^I/* 4240 */$
ERROR: code indent should never use tabs
#5624: FILE: linux-user/mips/cpu_loop.inc.c:245:
+^IMIPS_SYS(sys_io_setup^I, 2)$
ERROR: code indent should never use tabs
#5625: FILE: linux-user/mips/cpu_loop.inc.c:246:
+^IMIPS_SYS(sys_io_destroy^I, 1)$
ERROR: code indent should never use tabs
#5626: FILE: linux-user/mips/cpu_loop.inc.c:247:
+^IMIPS_SYS(sys_io_getevents, 5)$
ERROR: code indent should never use tabs
#5627: FILE: linux-user/mips/cpu_loop.inc.c:248:
+^IMIPS_SYS(sys_io_submit^I, 3)$
ERROR: code indent should never use tabs
#5628: FILE: linux-user/mips/cpu_loop.inc.c:249:
+^IMIPS_SYS(sys_io_cancel^I, 3)^I/* 4245 */$
ERROR: code indent should never use tabs
#5629: FILE: linux-user/mips/cpu_loop.inc.c:250:
+^IMIPS_SYS(sys_exit_group^I, 1)$
ERROR: code indent should never use tabs
#5630: FILE: linux-user/mips/cpu_loop.inc.c:251:
+^IMIPS_SYS(sys_lookup_dcookie, 3)$
ERROR: code indent should never use tabs
#5631: FILE: linux-user/mips/cpu_loop.inc.c:252:
+^IMIPS_SYS(sys_epoll_create, 1)$
ERROR: code indent should never use tabs
#5632: FILE: linux-user/mips/cpu_loop.inc.c:253:
+^IMIPS_SYS(sys_epoll_ctl^I, 4)$
ERROR: code indent should never use tabs
#5633: FILE: linux-user/mips/cpu_loop.inc.c:254:
+^IMIPS_SYS(sys_epoll_wait^I, 3)^I/* 4250 */$
ERROR: code indent should never use tabs
#5634: FILE: linux-user/mips/cpu_loop.inc.c:255:
+^IMIPS_SYS(sys_remap_file_pages, 5)$
ERROR: code indent should never use tabs
#5635: FILE: linux-user/mips/cpu_loop.inc.c:256:
+^IMIPS_SYS(sys_set_tid_address, 1)$
ERROR: code indent should never use tabs
#5636: FILE: linux-user/mips/cpu_loop.inc.c:257:
+^IMIPS_SYS(sys_restart_syscall, 0)$
ERROR: code indent should never use tabs
#5637: FILE: linux-user/mips/cpu_loop.inc.c:258:
+^IMIPS_SYS(sys_fadvise64_64, 7)$
ERROR: code indent should never use tabs
#5638: FILE: linux-user/mips/cpu_loop.inc.c:259:
+^IMIPS_SYS(sys_statfs64^I, 3)^I/* 4255 */$
ERROR: code indent should never use tabs
#5639: FILE: linux-user/mips/cpu_loop.inc.c:260:
+^IMIPS_SYS(sys_fstatfs64^I, 2)$
ERROR: code indent should never use tabs
#5640: FILE: linux-user/mips/cpu_loop.inc.c:261:
+^IMIPS_SYS(sys_timer_create, 3)$
ERROR: code indent should never use tabs
#5641: FILE: linux-user/mips/cpu_loop.inc.c:262:
+^IMIPS_SYS(sys_timer_settime, 4)$
ERROR: code indent should never use tabs
#5642: FILE: linux-user/mips/cpu_loop.inc.c:263:
+^IMIPS_SYS(sys_timer_gettime, 2)$
ERROR: code indent should never use tabs
#5643: FILE: linux-user/mips/cpu_loop.inc.c:264:
+^IMIPS_SYS(sys_timer_getoverrun, 1)^I/* 4260 */$
ERROR: code indent should never use tabs
#5644: FILE: linux-user/mips/cpu_loop.inc.c:265:
+^IMIPS_SYS(sys_timer_delete, 1)$
ERROR: code indent should never use tabs
#5645: FILE: linux-user/mips/cpu_loop.inc.c:266:
+^IMIPS_SYS(sys_clock_settime, 2)$
ERROR: code indent should never use tabs
#5646: FILE: linux-user/mips/cpu_loop.inc.c:267:
+^IMIPS_SYS(sys_clock_gettime, 2)$
ERROR: code indent should never use tabs
#5647: FILE: linux-user/mips/cpu_loop.inc.c:268:
+^IMIPS_SYS(sys_clock_getres, 2)$
ERROR: code indent should never use tabs
#5648: FILE: linux-user/mips/cpu_loop.inc.c:269:
+^IMIPS_SYS(sys_clock_nanosleep, 4)^I/* 4265 */$
ERROR: code indent should never use tabs
#5649: FILE: linux-user/mips/cpu_loop.inc.c:270:
+^IMIPS_SYS(sys_tgkill^I, 3)$
ERROR: code indent should never use tabs
#5650: FILE: linux-user/mips/cpu_loop.inc.c:271:
+^IMIPS_SYS(sys_utimes^I, 2)$
ERROR: code indent should never use tabs
#5651: FILE: linux-user/mips/cpu_loop.inc.c:272:
+^IMIPS_SYS(sys_mbind^I, 4)$
ERROR: code indent should never use tabs
#5652: FILE: linux-user/mips/cpu_loop.inc.c:273:
+^IMIPS_SYS(sys_ni_syscall^I, 0)^I/* sys_get_mempolicy */$
ERROR: code indent should never use tabs
#5653: FILE: linux-user/mips/cpu_loop.inc.c:274:
+^IMIPS_SYS(sys_ni_syscall^I, 0)^I/* 4270 sys_set_mempolicy */$
ERROR: code indent should never use tabs
#5654: FILE: linux-user/mips/cpu_loop.inc.c:275:
+^IMIPS_SYS(sys_mq_open^I, 4)$
ERROR: code indent should never use tabs
#5655: FILE: linux-user/mips/cpu_loop.inc.c:276:
+^IMIPS_SYS(sys_mq_unlink^I, 1)$
ERROR: code indent should never use tabs
#5656: FILE: linux-user/mips/cpu_loop.inc.c:277:
+^IMIPS_SYS(sys_mq_timedsend, 5)$
ERROR: code indent should never use tabs
#5657: FILE: linux-user/mips/cpu_loop.inc.c:278:
+^IMIPS_SYS(sys_mq_timedreceive, 5)$
ERROR: code indent should never use tabs
#5658: FILE: linux-user/mips/cpu_loop.inc.c:279:
+^IMIPS_SYS(sys_mq_notify^I, 2)^I/* 4275 */$
ERROR: code indent should never use tabs
#5659: FILE: linux-user/mips/cpu_loop.inc.c:280:
+^IMIPS_SYS(sys_mq_getsetattr, 3)$
ERROR: code indent should never use tabs
#5660: FILE: linux-user/mips/cpu_loop.inc.c:281:
+^IMIPS_SYS(sys_ni_syscall^I, 0)^I/* sys_vserver */$
ERROR: code indent should never use tabs
#5661: FILE: linux-user/mips/cpu_loop.inc.c:282:
+^IMIPS_SYS(sys_waitid^I, 4)$
ERROR: code indent should never use tabs
#5662: FILE: linux-user/mips/cpu_loop.inc.c:283:
+^IMIPS_SYS(sys_ni_syscall^I, 0)^I/* available, was setaltroot */$
ERROR: code indent should never use tabs
#5663: FILE: linux-user/mips/cpu_loop.inc.c:284:
+^IMIPS_SYS(sys_add_key^I, 5)$
ERROR: code indent should never use tabs
#5664: FILE: linux-user/mips/cpu_loop.inc.c:285:
+^IMIPS_SYS(sys_request_key, 4)$
ERROR: code indent should never use tabs
#5665: FILE: linux-user/mips/cpu_loop.inc.c:286:
+^IMIPS_SYS(sys_keyctl^I, 5)$
ERROR: code indent should never use tabs
#5666: FILE: linux-user/mips/cpu_loop.inc.c:287:
+^IMIPS_SYS(sys_set_thread_area, 1)$
ERROR: code indent should never use tabs
#5667: FILE: linux-user/mips/cpu_loop.inc.c:288:
+^IMIPS_SYS(sys_inotify_init, 0)$
ERROR: code indent should never use tabs
#5668: FILE: linux-user/mips/cpu_loop.inc.c:289:
+^IMIPS_SYS(sys_inotify_add_watch, 3) /* 4285 */$
ERROR: code indent should never use tabs
#5669: FILE: linux-user/mips/cpu_loop.inc.c:290:
+^IMIPS_SYS(sys_inotify_rm_watch, 2)$
ERROR: code indent should never use tabs
#5670: FILE: linux-user/mips/cpu_loop.inc.c:291:
+^IMIPS_SYS(sys_migrate_pages, 4)$
ERROR: code indent should never use tabs
#5671: FILE: linux-user/mips/cpu_loop.inc.c:292:
+^IMIPS_SYS(sys_openat, 4)$
ERROR: code indent should never use tabs
#5672: FILE: linux-user/mips/cpu_loop.inc.c:293:
+^IMIPS_SYS(sys_mkdirat, 3)$
ERROR: code indent should never use tabs
#5673: FILE: linux-user/mips/cpu_loop.inc.c:294:
+^IMIPS_SYS(sys_mknodat, 4)^I/* 4290 */$
ERROR: code indent should never use tabs
#5674: FILE: linux-user/mips/cpu_loop.inc.c:295:
+^IMIPS_SYS(sys_fchownat, 5)$
ERROR: code indent should never use tabs
#5675: FILE: linux-user/mips/cpu_loop.inc.c:296:
+^IMIPS_SYS(sys_futimesat, 3)$
ERROR: code indent should never use tabs
#5676: FILE: linux-user/mips/cpu_loop.inc.c:297:
+^IMIPS_SYS(sys_fstatat64, 4)$
ERROR: code indent should never use tabs
#5677: FILE: linux-user/mips/cpu_loop.inc.c:298:
+^IMIPS_SYS(sys_unlinkat, 3)$
ERROR: code indent should never use tabs
#5678: FILE: linux-user/mips/cpu_loop.inc.c:299:
+^IMIPS_SYS(sys_renameat, 4)^I/* 4295 */$
ERROR: code indent should never use tabs
#5679: FILE: linux-user/mips/cpu_loop.inc.c:300:
+^IMIPS_SYS(sys_linkat, 5)$
ERROR: code indent should never use tabs
#5680: FILE: linux-user/mips/cpu_loop.inc.c:301:
+^IMIPS_SYS(sys_symlinkat, 3)$
ERROR: code indent should never use tabs
#5681: FILE: linux-user/mips/cpu_loop.inc.c:302:
+^IMIPS_SYS(sys_readlinkat, 4)$
ERROR: code indent should never use tabs
#5682: FILE: linux-user/mips/cpu_loop.inc.c:303:
+^IMIPS_SYS(sys_fchmodat, 3)$
ERROR: code indent should never use tabs
#5683: FILE: linux-user/mips/cpu_loop.inc.c:304:
+^IMIPS_SYS(sys_faccessat, 3)^I/* 4300 */$
ERROR: code indent should never use tabs
#5684: FILE: linux-user/mips/cpu_loop.inc.c:305:
+^IMIPS_SYS(sys_pselect6, 6)$
ERROR: code indent should never use tabs
#5685: FILE: linux-user/mips/cpu_loop.inc.c:306:
+^IMIPS_SYS(sys_ppoll, 5)$
ERROR: code indent should never use tabs
#5686: FILE: linux-user/mips/cpu_loop.inc.c:307:
+^IMIPS_SYS(sys_unshare, 1)$
ERROR: code indent should never use tabs
#5687: FILE: linux-user/mips/cpu_loop.inc.c:308:
+^IMIPS_SYS(sys_splice, 6)$
ERROR: code indent should never use tabs
#5688: FILE: linux-user/mips/cpu_loop.inc.c:309:
+^IMIPS_SYS(sys_sync_file_range, 7) /* 4305 */$
ERROR: code indent should never use tabs
#5689: FILE: linux-user/mips/cpu_loop.inc.c:310:
+^IMIPS_SYS(sys_tee, 4)$
ERROR: code indent should never use tabs
#5690: FILE: linux-user/mips/cpu_loop.inc.c:311:
+^IMIPS_SYS(sys_vmsplice, 4)$
ERROR: code indent should never use tabs
#5691: FILE: linux-user/mips/cpu_loop.inc.c:312:
+^IMIPS_SYS(sys_move_pages, 6)$
ERROR: code indent should never use tabs
#5692: FILE: linux-user/mips/cpu_loop.inc.c:313:
+^IMIPS_SYS(sys_set_robust_list, 2)$
ERROR: code indent should never use tabs
#5693: FILE: linux-user/mips/cpu_loop.inc.c:314:
+^IMIPS_SYS(sys_get_robust_list, 3) /* 4310 */$
ERROR: code indent should never use tabs
#5694: FILE: linux-user/mips/cpu_loop.inc.c:315:
+^IMIPS_SYS(sys_kexec_load, 4)$
ERROR: code indent should never use tabs
#5695: FILE: linux-user/mips/cpu_loop.inc.c:316:
+^IMIPS_SYS(sys_getcpu, 3)$
ERROR: code indent should never use tabs
#5696: FILE: linux-user/mips/cpu_loop.inc.c:317:
+^IMIPS_SYS(sys_epoll_pwait, 6)$
ERROR: code indent should never use tabs
#5697: FILE: linux-user/mips/cpu_loop.inc.c:318:
+^IMIPS_SYS(sys_ioprio_set, 3)$
ERROR: code indent should never use tabs
#5698: FILE: linux-user/mips/cpu_loop.inc.c:319:
+^IMIPS_SYS(sys_ioprio_get, 2)$
ERROR: space required before the open parenthesis '('
#5840: FILE: linux-user/mips/cpu_loop.inc.c:461:
+ for(;;) {
ERROR: space required before the open parenthesis '('
#5846: FILE: linux-user/mips/cpu_loop.inc.c:467:
+ switch(trapnr) {
ERROR: do not use assignment in if condition
#5863: FILE: linux-user/mips/cpu_loop.inc.c:484:
+ if ((ret = get_user_ual(arg8, sp_reg + 28)) != 0) {
ERROR: do not use assignment in if condition
#5867: FILE: linux-user/mips/cpu_loop.inc.c:488:
+ if ((ret = get_user_ual(arg7, sp_reg + 24)) != 0) {
ERROR: do not use assignment in if condition
#5871: FILE: linux-user/mips/cpu_loop.inc.c:492:
+ if ((ret = get_user_ual(arg6, sp_reg + 20)) != 0) {
ERROR: do not use assignment in if condition
#5875: FILE: linux-user/mips/cpu_loop.inc.c:496:
+ if ((ret = get_user_ual(arg5, sp_reg + 16)) != 0) {
ERROR: that open brace { should be on the previous line
#5939: FILE: linux-user/mips/cpu_loop.inc.c:560:
+ if (sig)
+ {
WARNING: line over 80 characters
#6069: FILE: linux-user/mips/cpu_loop.inc.c:690:
+ EXCP_DUMP(env, "qemu: unhandled CPU exception 0x%x - aborting\n", trapnr);
ERROR: space prohibited between function name and open parenthesis '('
#6305: FILE: linux-user/ppc/cpu_loop.inc.c:27:
+__attribute__ (( alias ("cpu_ppc_load_tbu") ));
ERROR: space prohibited after that open parenthesis '('
#6305: FILE: linux-user/ppc/cpu_loop.inc.c:27:
+__attribute__ (( alias ("cpu_ppc_load_tbu") ));
ERROR: space prohibited before that close parenthesis ')'
#6305: FILE: linux-user/ppc/cpu_loop.inc.c:27:
+__attribute__ (( alias ("cpu_ppc_load_tbu") ));
ERROR: space prohibited between function name and open parenthesis '('
#6313: FILE: linux-user/ppc/cpu_loop.inc.c:35:
+int ppc_dcr_read (ppc_dcr_t *dcr_env, int dcrn, uint32_t *valp)
ERROR: space prohibited between function name and open parenthesis '('
#6318: FILE: linux-user/ppc/cpu_loop.inc.c:40:
+int ppc_dcr_write (ppc_dcr_t *dcr_env, int dcrn, uint32_t val)
ERROR: trailing statements should be on next line
#6345: FILE: linux-user/ppc/cpu_loop.inc.c:67:
+ case 1: segv = get_user_u8(val, addr); break;
ERROR: trailing statements should be on next line
#6346: FILE: linux-user/ppc/cpu_loop.inc.c:68:
+ case 2: segv = get_user_u16(val, addr); break;
ERROR: trailing statements should be on next line
#6347: FILE: linux-user/ppc/cpu_loop.inc.c:69:
+ case 4: segv = get_user_u32(val, addr); break;
ERROR: trailing statements should be on next line
#6349: FILE: linux-user/ppc/cpu_loop.inc.c:71:
+ case 8: segv = get_user_u64(val, addr); break;
ERROR: trailing statements should be on next line
#6358: FILE: linux-user/ppc/cpu_loop.inc.c:80:
+ default: abort();
ERROR: trailing statements should be on next line
#6363: FILE: linux-user/ppc/cpu_loop.inc.c:85:
+ case 1: segv = put_user_u8(val, addr); break;
ERROR: trailing statements should be on next line
#6364: FILE: linux-user/ppc/cpu_loop.inc.c:86:
+ case 2: segv = put_user_u16(val, addr); break;
ERROR: trailing statements should be on next line
#6365: FILE: linux-user/ppc/cpu_loop.inc.c:87:
+ case 4: segv = put_user_u32(val, addr); break;
ERROR: trailing statements should be on next line
#6367: FILE: linux-user/ppc/cpu_loop.inc.c:89:
+ case 8: segv = put_user_u64(val, addr); break;
ERROR: spaces required around that '+' (ctx:VxV)
#6372: FILE: linux-user/ppc/cpu_loop.inc.c:94:
+ val = env->gpr[reg+1];
^
ERROR: spaces required around that '+' (ctx:VxV)
#6374: FILE: linux-user/ppc/cpu_loop.inc.c:96:
+ val2 = env->gpr[reg+1];
^
ERROR: trailing statements should be on next line
#6384: FILE: linux-user/ppc/cpu_loop.inc.c:106:
+ default: abort();
ERROR: space required before the open parenthesis '('
#6409: FILE: linux-user/ppc/cpu_loop.inc.c:131:
+ for(;;) {
ERROR: space required before the open parenthesis '('
#6415: FILE: linux-user/ppc/cpu_loop.inc.c:137:
+ switch(trapnr) {
ERROR: space prohibited between function name and open parenthesis '('
#7047: FILE: linux-user/s390x/cpu_loop.inc.c:130:
+ process_pending_signals (env);
ERROR: code indent should never use tabs
#7106: FILE: linux-user/sh4/cpu_loop.inc.c:51:
+^Icase 0xa0:$
ERROR: code indent should never use tabs
#7107: FILE: linux-user/sh4/cpu_loop.inc.c:52:
+^Icase 0xc0:$
ERROR: code indent should never use tabs
#7113: FILE: linux-user/sh4/cpu_loop.inc.c:58:
+^I break;$
ERROR: space prohibited between function name and open parenthesis '('
#7119: FILE: linux-user/sh4/cpu_loop.inc.c:64:
+ printf ("Unhandled trap: 0x%x\n", trapnr);
ERROR: space prohibited between function name and open parenthesis '('
#7123: FILE: linux-user/sh4/cpu_loop.inc.c:68:
+ process_pending_signals (env);
ERROR: do not use C99 // comments
#7142: FILE: linux-user/sparc/cpu_loop.inc.c:3:
+//#define DEBUG_WIN
ERROR: braces {} are necessary for all arms of this statement
#7151: FILE: linux-user/sparc/cpu_loop.inc.c:12:
+ if (index < 8 && env->cwp == env->nwindows - 1)
[...]
ERROR: braces {} are necessary for all arms of this statement
#7164: FILE: linux-user/sparc/cpu_loop.inc.c:25:
+ if (sp_ptr & 3)
[...]
ERROR: space required before the open parenthesis '('
#7171: FILE: linux-user/sparc/cpu_loop.inc.c:32:
+ for(i = 0; i < 16; i++) {
ERROR: braces {} are necessary for all arms of this statement
#7210: FILE: linux-user/sparc/cpu_loop.inc.c:71:
+ if (sp_ptr & 3)
[...]
ERROR: space required before the open parenthesis '('
#7217: FILE: linux-user/sparc/cpu_loop.inc.c:78:
+ for(i = 0; i < 16; i++) {
ERROR: braces {} are necessary for all arms of this statement
#7224: FILE: linux-user/sparc/cpu_loop.inc.c:85:
+ if (env->cleanwin < env->nwindows - 1)
[...]
ERROR: space required before the open parenthesis '('
#7237: FILE: linux-user/sparc/cpu_loop.inc.c:98:
+ for(;;) {
ERROR: braces {} are necessary for all arms of this statement
#7241: FILE: linux-user/sparc/cpu_loop.inc.c:102:
+ if (env->wim & (1 << cwp1))
[...]
ERROR: braces {} are necessary for all arms of this statement
#7244: FILE: linux-user/sparc/cpu_loop.inc.c:105:
+ if (env->canrestore == 0)
[...]
ERROR: space prohibited between function name and open parenthesis '('
#7262: FILE: linux-user/sparc/cpu_loop.inc.c:123:
+void cpu_loop (CPUSPARCState *env)
ERROR: space prohibited between function name and open parenthesis '('
#7288: FILE: linux-user/sparc/cpu_loop.inc.c:149:
+ ret = do_syscall (env, env->gregs[1],
ERROR: braces {} are necessary for all arms of this statement
#7356: FILE: linux-user/sparc/cpu_loop.inc.c:217:
+ if (trapnr == TT_DFAULT)
[...]
+ else
[...]
ERROR: that open brace { should be on the previous line
#7391: FILE: linux-user/sparc/cpu_loop.inc.c:252:
+ if (sig)
+ {
ERROR: space prohibited between function name and open parenthesis '('
#7404: FILE: linux-user/sparc/cpu_loop.inc.c:265:
+ printf ("Unhandled trap: 0x%x\n", trapnr);
ERROR: space prohibited between function name and open parenthesis '('
#7408: FILE: linux-user/sparc/cpu_loop.inc.c:269:
+ process_pending_signals (env);
total: 433 errors, 5 warnings, 7776 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/5: linux-user: cleanup main()...
ERROR: space required before the open parenthesis '('
#48: FILE: linux-user/alpha/prologue.inc.c:4:
+ for(i = 0; i < 28; i++) {
ERROR: space required before the open parenthesis '('
#64: FILE: linux-user/arm/prologue.inc.c:5:
+ for(i = 0; i < 16; i++) {
ERROR: code indent should never use tabs
#90: FILE: linux-user/cris/prologue.inc.c:2:
+^I env->regs[0] = regs->r0;$
ERROR: code indent should never use tabs
#91: FILE: linux-user/cris/prologue.inc.c:3:
+^I env->regs[1] = regs->r1;$
ERROR: code indent should never use tabs
#92: FILE: linux-user/cris/prologue.inc.c:4:
+^I env->regs[2] = regs->r2;$
ERROR: code indent should never use tabs
#93: FILE: linux-user/cris/prologue.inc.c:5:
+^I env->regs[3] = regs->r3;$
ERROR: code indent should never use tabs
#94: FILE: linux-user/cris/prologue.inc.c:6:
+^I env->regs[4] = regs->r4;$
ERROR: code indent should never use tabs
#95: FILE: linux-user/cris/prologue.inc.c:7:
+^I env->regs[5] = regs->r5;$
ERROR: code indent should never use tabs
#96: FILE: linux-user/cris/prologue.inc.c:8:
+^I env->regs[6] = regs->r6;$
ERROR: code indent should never use tabs
#97: FILE: linux-user/cris/prologue.inc.c:9:
+^I env->regs[7] = regs->r7;$
ERROR: code indent should never use tabs
#98: FILE: linux-user/cris/prologue.inc.c:10:
+^I env->regs[8] = regs->r8;$
ERROR: code indent should never use tabs
#99: FILE: linux-user/cris/prologue.inc.c:11:
+^I env->regs[9] = regs->r9;$
ERROR: code indent should never use tabs
#100: FILE: linux-user/cris/prologue.inc.c:12:
+^I env->regs[10] = regs->r10;$
ERROR: code indent should never use tabs
#101: FILE: linux-user/cris/prologue.inc.c:13:
+^I env->regs[11] = regs->r11;$
ERROR: code indent should never use tabs
#102: FILE: linux-user/cris/prologue.inc.c:14:
+^I env->regs[12] = regs->r12;$
ERROR: code indent should never use tabs
#103: FILE: linux-user/cris/prologue.inc.c:15:
+^I env->regs[13] = regs->r13;$
ERROR: code indent should never use tabs
#104: FILE: linux-user/cris/prologue.inc.c:16:
+^I env->regs[14] = info->start_stack;$
ERROR: code indent should never use tabs
#105: FILE: linux-user/cris/prologue.inc.c:17:
+^I env->regs[15] = regs->acr;$
ERROR: code indent should never use tabs
#106: FILE: linux-user/cris/prologue.inc.c:18:
+^I env->pc = regs->erp;$
ERROR: spaces required around that '|' (ctx:VxV)
#178: FILE: linux-user/i386/prologue.inc.c:51:
+ PROT_READ|PROT_WRITE,
^
ERROR: spaces required around that '|' (ctx:VxV)
#179: FILE: linux-user/i386/prologue.inc.c:52:
+ MAP_ANONYMOUS|MAP_PRIVATE, -1, 0);
^
ERROR: spaces required around that '|' (ctx:VxV)
#207: FILE: linux-user/i386/prologue.inc.c:80:
+ PROT_READ|PROT_WRITE,
^
ERROR: spaces required around that '|' (ctx:VxV)
#208: FILE: linux-user/i386/prologue.inc.c:81:
+ MAP_ANONYMOUS|MAP_PRIVATE, -1, 0);
^
ERROR: space required before the open parenthesis '('
#734: FILE: linux-user/mips/prologue.inc.c:4:
+ for(i = 0; i < 32; i++) {
ERROR: space required before the open parenthesis '('
#831: FILE: linux-user/ppc/prologue.inc.c:13:
+ for(i = 0; i < 32; i++) {
ERROR: space required before the open parenthesis '('
#868: FILE: linux-user/sh4/prologue.inc.c:4:
+ for(i = 0; i < 16; i++) {
ERROR: code indent should never use tabs
#881: FILE: linux-user/sparc/prologue.inc.c:3:
+^Ienv->pc = regs->pc;$
ERROR: code indent should never use tabs
#882: FILE: linux-user/sparc/prologue.inc.c:4:
+^Ienv->npc = regs->npc;$
ERROR: space required before the open parenthesis '('
#884: FILE: linux-user/sparc/prologue.inc.c:6:
+ for(i = 0; i < 8; i++)
ERROR: braces {} are necessary for all arms of this statement
#884: FILE: linux-user/sparc/prologue.inc.c:6:
+ for(i = 0; i < 8; i++)
[...]
ERROR: space required before the open parenthesis '('
#886: FILE: linux-user/sparc/prologue.inc.c:8:
+ for(i = 0; i < 8; i++)
ERROR: braces {} are necessary for all arms of this statement
#886: FILE: linux-user/sparc/prologue.inc.c:8:
+ for(i = 0; i < 8; i++)
[...]
total: 32 errors, 0 warnings, 790 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
On 22 March 2018 at 21:58, Laurent Vivier <laurent@vivier.eu> wrote: > Some files like signal.c are really hard to read > because all architectures are mixed in the same > file. > > This series moves from signal.c these parts to > the architecture dedicated directories in linux-user. > Moerover, this allows to compare easier functions > between architectures (it helps to debug problems). > Adding new functions for a new architecture will > be facilitated too. > > As we are doing that for signal.c, we can also > do that for main.c, for the cpu loop part > and the cpu loop prologue too. Yeah, this is something I've kind of had on my backlog of "it would be nice to do this" for years. Thanks for putting in the work! > checkpatch.pl is not happy... but I only want to > move code from a file to another. I don't want > to change the content of the parts I move. Yeah, that's reasonable. (Since the move will reduce the effectiveness of git blame anyway we might want to do a fix-coding-style pass afterwards, but we can do that as a separate patchset.) thanks -- PMM
© 2016 - 2025 Red Hat, Inc.