target/xtensa: improvements for core-specific files

[Qemu-devel] [PATCH 0/3] target/xtensa: improvements for core-specific files

Max Filippov posted 3 patches 7 years, 7 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180322180940.8253-1-jcmvbkbc@gmail.com

Test checkpatch passed

Test docker-build@min-glib passed

Test docker-mingw@fedora passed

Test docker-quick@centos6 failed

Test s390x passed

target/xtensa/core-dc232b.c                                      | 4 ++--
target/xtensa/core-dc232b/{gdb-config.c => gdb-config.inc.c}     | 0
.../core-dc232b/{xtensa-modules.c => xtensa-modules.inc.c}       | 0
target/xtensa/core-dc233c.c                                      | 4 ++--
target/xtensa/core-dc233c/{gdb-config.c => gdb-config.inc.c}     | 0
.../core-dc233c/{xtensa-modules.c => xtensa-modules.inc.c}       | 0
target/xtensa/core-de212.c                                       | 4 ++--
target/xtensa/core-de212/{gdb-config.c => gdb-config.inc.c}      | 0
.../xtensa/core-de212/{xtensa-modules.c => xtensa-modules.inc.c} | 0
target/xtensa/core-fsf.c                                         | 2 +-
.../xtensa/core-fsf/{xtensa-modules.c => xtensa-modules.inc.c}   | 0
target/xtensa/core-sample_controller.c                           | 4 ++--
.../core-sample_controller/{gdb-config.c => gdb-config.inc.c}    | 0
.../{xtensa-modules.c => xtensa-modules.inc.c}                   | 0
target/xtensa/import_core.sh                                     | 9 +++++----
15 files changed, 14 insertions(+), 13 deletions(-)
rename target/xtensa/core-dc232b/{gdb-config.c => gdb-config.inc.c} (100%)
rename target/xtensa/core-dc232b/{xtensa-modules.c => xtensa-modules.inc.c} (100%)
rename target/xtensa/core-dc233c/{gdb-config.c => gdb-config.inc.c} (100%)
rename target/xtensa/core-dc233c/{xtensa-modules.c => xtensa-modules.inc.c} (100%)
rename target/xtensa/core-de212/{gdb-config.c => gdb-config.inc.c} (100%)
rename target/xtensa/core-de212/{xtensa-modules.c => xtensa-modules.inc.c} (100%)
rename target/xtensa/core-fsf/{xtensa-modules.c => xtensa-modules.inc.c} (100%)
rename target/xtensa/core-sample_controller/{gdb-config.c => gdb-config.inc.c} (100%)
rename target/xtensa/core-sample_controller/{xtensa-modules.c => xtensa-modules.inc.c} (100%)

Expand all Fold all

[Qemu-devel] [PATCH 0/3] target/xtensa: improvements for core-specific files

Posted by Max Filippov 7 years, 7 months ago

Hello,

this series adds .inc. to the names of non-top level xtensa core-specific
files and fixes script import_core.sh so that it does it automatically.
It also adds a fixup to the script that changes #include <xtensa-isa.h>
to #include "xtensa-isa.h".

Max Filippov (3):
  target/xtensa: add .inc. to non-top level source file names
  target/xtensa/import_core.sh: fix names of non-top level files
  target/xtensa/import_core.sh: fix #include <xtensa-isa.h>

 target/xtensa/core-dc232b.c                                      | 4 ++--
 target/xtensa/core-dc232b/{gdb-config.c => gdb-config.inc.c}     | 0
 .../core-dc232b/{xtensa-modules.c => xtensa-modules.inc.c}       | 0
 target/xtensa/core-dc233c.c                                      | 4 ++--
 target/xtensa/core-dc233c/{gdb-config.c => gdb-config.inc.c}     | 0
 .../core-dc233c/{xtensa-modules.c => xtensa-modules.inc.c}       | 0
 target/xtensa/core-de212.c                                       | 4 ++--
 target/xtensa/core-de212/{gdb-config.c => gdb-config.inc.c}      | 0
 .../xtensa/core-de212/{xtensa-modules.c => xtensa-modules.inc.c} | 0
 target/xtensa/core-fsf.c                                         | 2 +-
 .../xtensa/core-fsf/{xtensa-modules.c => xtensa-modules.inc.c}   | 0
 target/xtensa/core-sample_controller.c                           | 4 ++--
 .../core-sample_controller/{gdb-config.c => gdb-config.inc.c}    | 0
 .../{xtensa-modules.c => xtensa-modules.inc.c}                   | 0
 target/xtensa/import_core.sh                                     | 9 +++++----
 15 files changed, 14 insertions(+), 13 deletions(-)
 rename target/xtensa/core-dc232b/{gdb-config.c => gdb-config.inc.c} (100%)
 rename target/xtensa/core-dc232b/{xtensa-modules.c => xtensa-modules.inc.c} (100%)
 rename target/xtensa/core-dc233c/{gdb-config.c => gdb-config.inc.c} (100%)
 rename target/xtensa/core-dc233c/{xtensa-modules.c => xtensa-modules.inc.c} (100%)
 rename target/xtensa/core-de212/{gdb-config.c => gdb-config.inc.c} (100%)
 rename target/xtensa/core-de212/{xtensa-modules.c => xtensa-modules.inc.c} (100%)
 rename target/xtensa/core-fsf/{xtensa-modules.c => xtensa-modules.inc.c} (100%)
 rename target/xtensa/core-sample_controller/{gdb-config.c => gdb-config.inc.c} (100%)
 rename target/xtensa/core-sample_controller/{xtensa-modules.c => xtensa-modules.inc.c} (100%)

-- 
2.11.0

Re: [Qemu-devel] [PATCH 0/3] target/xtensa: improvements for core-specific files

Posted by Eric Blake 7 years, 7 months ago

On 03/22/2018 01:09 PM, Max Filippov wrote:
> Hello,
> 
> this series adds .inc. to the names of non-top level xtensa core-specific
> files and fixes script import_core.sh so that it does it automatically.
> It also adds a fixup to the script that changes #include <xtensa-isa.h>
> to #include "xtensa-isa.h".
> 
> Max Filippov (3):
>    target/xtensa: add .inc. to non-top level source file names
>    target/xtensa/import_core.sh: fix names of non-top level files
>    target/xtensa/import_core.sh: fix #include <xtensa-isa.h>

Simple enough.  I don't know if it qualifies as a bug fix, so up to you 
as maintainer whether you feel comfortable enough getting it into 2.12. 
See my per-patch comments about possibly merging 1 and 2; but for the 
series,
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org