[Qemu-devel] [PATCH for-2.12 v2 00/12] block: Follow-up for .bdrv_co_create (part 1)

Kevin Wolf posted 12 patches 7 years, 7 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180321173714.14741-1-kwolf@redhat.com
Test checkpatch passed
Test docker-build@min-glib passed
Test docker-mingw@fedora failed
Test docker-quick@centos6 failed
Test s390x passed
qapi/block-core.json       |   7 +-
block/crypto.c             |   6 +-
block/parallels.c          |   5 +
block/vdi.c                |  46 ++++--
block/vhdx.c               |  17 ++-
tests/qemu-iotests/025     |   9 +-
tests/qemu-iotests/210     |  37 +++++
tests/qemu-iotests/210.out |  16 +++
tests/qemu-iotests/211     | 246 ++++++++++++++++++++++++++++++++
tests/qemu-iotests/211.out |  97 +++++++++++++
tests/qemu-iotests/212     | 326 ++++++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/212.out | 111 ++++++++++++++
tests/qemu-iotests/213     | 349 +++++++++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/213.out | 121 ++++++++++++++++
tests/qemu-iotests/group   |   3 +
15 files changed, 1371 insertions(+), 25 deletions(-)
create mode 100755 tests/qemu-iotests/211
create mode 100644 tests/qemu-iotests/211.out
create mode 100755 tests/qemu-iotests/212
create mode 100644 tests/qemu-iotests/212.out
create mode 100755 tests/qemu-iotests/213
create mode 100644 tests/qemu-iotests/213.out
[Qemu-devel] [PATCH for-2.12 v2 00/12] block: Follow-up for .bdrv_co_create (part 1)
Posted by Kevin Wolf 7 years, 7 months ago
This series adds qemu-iotests for a few more block drivers (yet more to
come in another series) and fixes a few things that previous review and
these tests brought up.

The only major design change is that I converted the vdi block driver
from a boolean 'static' create option to the standard 'preallocation'
one that other drivers are using. This seems like a good move to make
while the interface isn't stable yet.

v2:
- Patch 1: Mention allowed values for 'preallocation' [Eric]
- Patch 3: Fixed comments, removed 2^63-512 case [Eric]
- Patch 6: Added missing reference output change [Eric]
- Patch 7: s/UINT64_MAX/INT64_MAX/ [Eric]
- Patches 8 and 12: Fixed comments [Eric]

Kevin Wolf (12):
  vdi: Change 'static' create option to 'preallocation' in QMP
  vdi: Fix build with CONFIG_VDI_DEBUG
  qemu-iotests: Test vdi image creation with QMP
  qemu-iotests: Enable 025 for luks
  luks: Turn another invalid assertion into check
  qemu-iotests: Test invalid resize on luks
  parallels: Check maximum cluster size on create
  qemu-iotests: Test parallels image creation with QMP
  vhdx: Require power-of-two block size on create
  vhdx: Don't use error_setg_errno() with constant errno
  vhdx: Check for 4 GB maximum log size on creation
  qemu-iotests: Test vhdx image creation with QMP

 qapi/block-core.json       |   7 +-
 block/crypto.c             |   6 +-
 block/parallels.c          |   5 +
 block/vdi.c                |  46 ++++--
 block/vhdx.c               |  17 ++-
 tests/qemu-iotests/025     |   9 +-
 tests/qemu-iotests/210     |  37 +++++
 tests/qemu-iotests/210.out |  16 +++
 tests/qemu-iotests/211     | 246 ++++++++++++++++++++++++++++++++
 tests/qemu-iotests/211.out |  97 +++++++++++++
 tests/qemu-iotests/212     | 326 ++++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/212.out | 111 ++++++++++++++
 tests/qemu-iotests/213     | 349 +++++++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/213.out | 121 ++++++++++++++++
 tests/qemu-iotests/group   |   3 +
 15 files changed, 1371 insertions(+), 25 deletions(-)
 create mode 100755 tests/qemu-iotests/211
 create mode 100644 tests/qemu-iotests/211.out
 create mode 100755 tests/qemu-iotests/212
 create mode 100644 tests/qemu-iotests/212.out
 create mode 100755 tests/qemu-iotests/213
 create mode 100644 tests/qemu-iotests/213.out

-- 
2.13.6


Re: [Qemu-devel] [PATCH for-2.12 v2 00/12] block: Follow-up for .bdrv_co_create (part 1)
Posted by Kevin Wolf 7 years, 7 months ago
Am 21.03.2018 um 18:37 hat Kevin Wolf geschrieben:
> This series adds qemu-iotests for a few more block drivers (yet more to
> come in another series) and fixes a few things that previous review and
> these tests brought up.
> 
> The only major design change is that I converted the vdi block driver
> from a boolean 'static' create option to the standard 'preallocation'
> one that other drivers are using. This seems like a good move to make
> while the interface isn't stable yet.
> 
> v2:
> - Patch 1: Mention allowed values for 'preallocation' [Eric]
> - Patch 3: Fixed comments, removed 2^63-512 case [Eric]
> - Patch 6: Added missing reference output change [Eric]
> - Patch 7: s/UINT64_MAX/INT64_MAX/ [Eric]
> - Patches 8 and 12: Fixed comments [Eric]

Applied to the block branch.

Kevin