sdl2 text console fixes and cleanups.

[Qemu-devel] [PATCH 0/5] sdl2 text console fixes and cleanups.

Posted by Gerd Hoffmann 7 years, 7 months ago


Gerd Hoffmann (5):
  ui: add ctrl modifier support to kbd_put_qcode_console()
  sdl2: track kbd modifier state unconditionally
  sdl2: enable ctrl modifier keys for text consoles
  sdl2: drop QEMU_KEY_BACKSPACE special case
  sdl2: drop dead code

 include/ui/console.h |  2 +-
 ui/console.c         | 15 +++++++++++++--
 ui/gtk.c             |  4 ++--
 ui/sdl2-input.c      | 46 ++++++++++++++++++++--------------------------
 4 files changed, 36 insertions(+), 31 deletions(-)

-- 
2.9.3

Re: [Qemu-devel] [PATCH 0/5] sdl2 text console fixes and cleanups.

Posted by BALATON Zoltan 7 years, 6 months ago

On Wed, 21 Mar 2018, Gerd Hoffmann wrote:
> Gerd Hoffmann (5):
>  ui: add ctrl modifier support to kbd_put_qcode_console()
>  sdl2: track kbd modifier state unconditionally
>  sdl2: enable ctrl modifier keys for text consoles
>  sdl2: drop QEMU_KEY_BACKSPACE special case
>  sdl2: drop dead code
>
> include/ui/console.h |  2 +-
> ui/console.c         | 15 +++++++++++++--
> ui/gtk.c             |  4 ++--
> ui/sdl2-input.c      | 46 ++++++++++++++++++++--------------------------
> 4 files changed, 36 insertions(+), 31 deletions(-)

Will this be included in 2.12? I haven't seen it reaching master yet.

Regards,
BALATON Zoltan

Re: [Qemu-devel] [PATCH 0/5] sdl2 text console fixes and cleanups.

Posted by Gerd Hoffmann 7 years, 6 months ago

On Sun, Apr 08, 2018 at 12:52:18PM +0200, BALATON Zoltan wrote:
> On Wed, 21 Mar 2018, Gerd Hoffmann wrote:
> > Gerd Hoffmann (5):
> >  ui: add ctrl modifier support to kbd_put_qcode_console()
> >  sdl2: track kbd modifier state unconditionally
> >  sdl2: enable ctrl modifier keys for text consoles
> >  sdl2: drop QEMU_KEY_BACKSPACE special case
> >  sdl2: drop dead code
> > 
> > include/ui/console.h |  2 +-
> > ui/console.c         | 15 +++++++++++++--
> > ui/gtk.c             |  4 ++--
> > ui/sdl2-input.c      | 46 ++++++++++++++++++++--------------------------
> > 4 files changed, 36 insertions(+), 31 deletions(-)
> 
> Will this be included in 2.12? I haven't seen it reaching master yet.

Oops.  Thanks for the reminder.  Pull request sent.

cheers,
  Gerd

Re: [Qemu-devel] [PATCH 0/5] sdl2 text console fixes and cleanups.

Posted by Mark Cave-Ayland 7 years, 6 months ago

On 09/04/18 10:43, Gerd Hoffmann wrote:

> On Sun, Apr 08, 2018 at 12:52:18PM +0200, BALATON Zoltan wrote:
>> On Wed, 21 Mar 2018, Gerd Hoffmann wrote:
>>> Gerd Hoffmann (5):
>>>   ui: add ctrl modifier support to kbd_put_qcode_console()
>>>   sdl2: track kbd modifier state unconditionally
>>>   sdl2: enable ctrl modifier keys for text consoles
>>>   sdl2: drop QEMU_KEY_BACKSPACE special case
>>>   sdl2: drop dead code
>>>
>>> include/ui/console.h |  2 +-
>>> ui/console.c         | 15 +++++++++++++--
>>> ui/gtk.c             |  4 ++--
>>> ui/sdl2-input.c      | 46 ++++++++++++++++++++--------------------------
>>> 4 files changed, 36 insertions(+), 31 deletions(-)
>>
>> Will this be included in 2.12? I haven't seen it reaching master yet.
> 
> Oops.  Thanks for the reminder.  Pull request sent.

FWIW I think we're also missing the patch for the GTK errors: 
https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg04315.html.


ATB,

Mark.