1 | Arm patch queue -- these are all bug fix patches but we might | 1 | The following changes since commit eae587e8e3694b1aceab23239493fb4c7e1a80f5: |
---|---|---|---|
2 | as well put them in to rc0... | ||
3 | 2 | ||
4 | thanks | 3 | Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2021-09-13' into staging (2021-09-13 11:00:30 +0100) |
5 | -- PMM | ||
6 | |||
7 | The following changes since commit 2c8cfc0b52b5a4d123c26c0b5fdf941be24805be: | ||
8 | |||
9 | Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2018-03-19 11:44:26 +0000) | ||
10 | 4 | ||
11 | are available in the Git repository at: | 5 | are available in the Git repository at: |
12 | 6 | ||
13 | git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20180319 | 7 | https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20210913 |
14 | 8 | ||
15 | for you to fetch changes up to ff72cb6b46b95bb530787add5277c211af3d31c6: | 9 | for you to fetch changes up to 9a2b2ecf4d25a3943918c95d2db4508b304161b5: |
16 | 10 | ||
17 | hw/arm/raspi: Provide spin-loop code for AArch64 CPUs (2018-03-19 18:23:24 +0000) | 11 | hw/arm/mps2.c: Mark internal-only I2C buses as 'full' (2021-09-13 17:09:28 +0100) |
18 | 12 | ||
19 | ---------------------------------------------------------------- | 13 | ---------------------------------------------------------------- |
20 | target-arm queue: | 14 | target-arm queue: |
21 | * fsl-imx6: Fix incorrect Ethernet interrupt defines | 15 | * mark MPS2/MPS3 board-internal i2c buses as 'full' so that command |
22 | * dump: Update correct kdump phys_base field for AArch64 | 16 | line user-created devices are not plugged into them |
23 | * char: i.MX: Add support for "TX complete" interrupt | 17 | * Take an exception if PSTATE.IL is set |
24 | * bcm2836/raspi: Fix various bugs resulting in panics trying | 18 | * Support an emulated ITS in the virt board |
25 | to boot a Debian Linux kernel on raspi3 | 19 | * Add support for kudo-bmc board |
20 | * Probe for KVM_CAP_ARM_VM_IPA_SIZE when creating scratch VM | ||
21 | * cadence_uart: Fix clock handling issues that prevented | ||
22 | u-boot from running | ||
26 | 23 | ||
27 | ---------------------------------------------------------------- | 24 | ---------------------------------------------------------------- |
28 | Andrey Smirnov (2): | 25 | Bin Meng (6): |
29 | char: i.MX: Simplify imx_update() | 26 | hw/misc: zynq_slcr: Correctly compute output clocks in the reset exit phase |
30 | char: i.MX: Add support for "TX complete" interrupt | 27 | hw/char: cadence_uart: Disable transmit when input clock is disabled |
28 | hw/char: cadence_uart: Move clock/reset check to uart_can_receive() | ||
29 | hw/char: cadence_uart: Convert to memop_with_attrs() ops | ||
30 | hw/char: cadence_uart: Ignore access when unclocked or in reset for uart_{read, write}() | ||
31 | hw/char: cadence_uart: Log a guest error when device is unclocked or in reset | ||
31 | 32 | ||
32 | Guenter Roeck (1): | 33 | Chris Rauer (1): |
33 | fsl-imx6: Swap Ethernet interrupt defines | 34 | hw/arm: Add support for kudo-bmc board. |
34 | 35 | ||
35 | Peter Maydell (9): | 36 | Marc Zyngier (1): |
36 | hw/arm/raspi: Don't do board-setup or secure-boot for raspi3 | 37 | hw/arm/virt: KVM: Probe for KVM_CAP_ARM_VM_IPA_SIZE when creating scratch VM |
37 | hw/arm/boot: assert that secure_boot and secure_board_setup are false for AArch64 | ||
38 | hw/arm/boot: If booting a kernel in EL2, set SCR_EL3.HCE | ||
39 | hw/arm/bcm2386: Fix parent type of bcm2386 | ||
40 | hw/arm/bcm2836: Rename bcm2836 type/struct to bcm283x | ||
41 | hw/arm/bcm2836: Create proper bcm2837 device | ||
42 | hw/arm/bcm2836: Use correct affinity values for BCM2837 | ||
43 | hw/arm/bcm2836: Hardcode correct CPU type | ||
44 | hw/arm/raspi: Provide spin-loop code for AArch64 CPUs | ||
45 | 38 | ||
46 | Wei Huang (1): | 39 | Peter Maydell (5): |
47 | dump: Update correct kdump phys_base field for AArch64 | 40 | target/arm: Take an exception if PSTATE.IL is set |
41 | qdev: Support marking individual buses as 'full' | ||
42 | hw/arm/mps2-tz.c: Add extra data parameter to MakeDevFn | ||
43 | hw/arm/mps2-tz.c: Mark internal-only I2C buses as 'full' | ||
44 | hw/arm/mps2.c: Mark internal-only I2C buses as 'full' | ||
48 | 45 | ||
49 | include/hw/arm/bcm2836.h | 31 +++++++++++++--- | 46 | Richard Henderson (1): |
50 | include/hw/arm/fsl-imx6.h | 4 +- | 47 | target/arm: Merge disas_a64_insn into aarch64_tr_translate_insn |
51 | include/hw/char/imx_serial.h | 3 ++ | ||
52 | dump.c | 14 +++++-- | ||
53 | hw/arm/bcm2836.c | 87 +++++++++++++++++++++++++++++++------------- | ||
54 | hw/arm/boot.c | 12 ++++++ | ||
55 | hw/arm/raspi.c | 77 +++++++++++++++++++++++++++++++-------- | ||
56 | hw/char/imx_serial.c | 44 ++++++++++++++++------ | ||
57 | hw/net/imx_fec.c | 28 +++++++++++++- | ||
58 | 9 files changed, 237 insertions(+), 63 deletions(-) | ||
59 | 48 | ||
49 | Shashi Mallela (9): | ||
50 | hw/intc: GICv3 ITS initial framework | ||
51 | hw/intc: GICv3 ITS register definitions added | ||
52 | hw/intc: GICv3 ITS command queue framework | ||
53 | hw/intc: GICv3 ITS Command processing | ||
54 | hw/intc: GICv3 ITS Feature enablement | ||
55 | hw/intc: GICv3 redistributor ITS processing | ||
56 | tests/data/acpi/virt: Add IORT files for ITS | ||
57 | hw/arm/virt: add ITS support in virt GIC | ||
58 | tests/data/acpi/virt: Update IORT files for ITS | ||
59 | |||
60 | docs/system/arm/nuvoton.rst | 1 + | ||
61 | hw/intc/gicv3_internal.h | 188 ++++- | ||
62 | include/hw/arm/virt.h | 2 + | ||
63 | include/hw/intc/arm_gicv3_common.h | 13 + | ||
64 | include/hw/intc/arm_gicv3_its_common.h | 32 +- | ||
65 | include/hw/qdev-core.h | 24 + | ||
66 | target/arm/cpu.h | 1 + | ||
67 | target/arm/kvm_arm.h | 4 +- | ||
68 | target/arm/syndrome.h | 5 + | ||
69 | target/arm/translate.h | 2 + | ||
70 | hw/arm/mps2-tz.c | 92 ++- | ||
71 | hw/arm/mps2.c | 12 +- | ||
72 | hw/arm/npcm7xx_boards.c | 34 + | ||
73 | hw/arm/virt.c | 29 +- | ||
74 | hw/char/cadence_uart.c | 61 +- | ||
75 | hw/intc/arm_gicv3.c | 14 + | ||
76 | hw/intc/arm_gicv3_common.c | 13 + | ||
77 | hw/intc/arm_gicv3_cpuif.c | 7 +- | ||
78 | hw/intc/arm_gicv3_dist.c | 5 +- | ||
79 | hw/intc/arm_gicv3_its.c | 1322 ++++++++++++++++++++++++++++++++ | ||
80 | hw/intc/arm_gicv3_its_common.c | 7 +- | ||
81 | hw/intc/arm_gicv3_its_kvm.c | 2 +- | ||
82 | hw/intc/arm_gicv3_redist.c | 153 +++- | ||
83 | hw/misc/zynq_slcr.c | 31 +- | ||
84 | softmmu/qdev-monitor.c | 7 +- | ||
85 | target/arm/helper-a64.c | 1 + | ||
86 | target/arm/helper.c | 8 + | ||
87 | target/arm/kvm.c | 7 +- | ||
88 | target/arm/translate-a64.c | 255 +++--- | ||
89 | target/arm/translate.c | 21 + | ||
90 | hw/intc/meson.build | 1 + | ||
91 | tests/data/acpi/virt/IORT | Bin 0 -> 124 bytes | ||
92 | tests/data/acpi/virt/IORT.memhp | Bin 0 -> 124 bytes | ||
93 | tests/data/acpi/virt/IORT.numamem | Bin 0 -> 124 bytes | ||
94 | tests/data/acpi/virt/IORT.pxb | Bin 0 -> 124 bytes | ||
95 | 35 files changed, 2144 insertions(+), 210 deletions(-) | ||
96 | create mode 100644 hw/intc/arm_gicv3_its.c | ||
97 | create mode 100644 tests/data/acpi/virt/IORT | ||
98 | create mode 100644 tests/data/acpi/virt/IORT.memhp | ||
99 | create mode 100644 tests/data/acpi/virt/IORT.numamem | ||
100 | create mode 100644 tests/data/acpi/virt/IORT.pxb | ||
101 | diff view generated by jsdifflib |
1 | The bcm2837 is pretty similar to the bcm2836, but it does have | 1 | From: Bin Meng <bmeng.cn@gmail.com> |
---|---|---|---|
2 | some differences. Notably, the MPIDR affinity aff1 values it | ||
3 | sets for the CPUs are 0x0, rather than the 0xf that the bcm2836 | ||
4 | uses, and if this is wrong Linux will not boot. | ||
5 | 2 | ||
6 | Rather than trying to have one device with properties that | 3 | As of today, when booting upstream U-Boot for Xilinx Zynq, the UART |
7 | configure it differently for the two cases, create two | 4 | does not receive anything. Debugging shows that the UART input clock |
8 | separate QOM devices for the two SoCs. We use the same approach | 5 | frequency is zero which prevents the UART from receiving anything as |
9 | as hw/arm/aspeed_soc.c and share code and have a data table | 6 | per the logic in uart_receive(). |
10 | that might differ per-SoC. For the moment the two types don't | ||
11 | actually have different behaviour. | ||
12 | 7 | ||
8 | From zynq_slcr_reset_exit() comment, it intends to compute output | ||
9 | clocks according to ps_clk and registers. zynq_slcr_compute_clocks() | ||
10 | is called to accomplish the task, inside which device_is_in_reset() | ||
11 | is called to actually make the attempt in vain. | ||
12 | |||
13 | Rework reset_hold() and reset_exit() so that in the reset exit phase, | ||
14 | the logic can really compute output clocks in reset_exit(). | ||
15 | |||
16 | With this change, upstream U-Boot boots properly again with: | ||
17 | |||
18 | $ qemu-system-arm -M xilinx-zynq-a9 -m 1G -display none -serial null -serial stdio \ | ||
19 | -device loader,file=u-boot-dtb.bin,addr=0x4000000,cpu-num=0 | ||
20 | |||
21 | Fixes: 38867cb7ec90 ("hw/misc/zynq_slcr: add clock generation for uarts") | ||
22 | Signed-off-by: Bin Meng <bmeng.cn@gmail.com> | ||
23 | Acked-by: Alistair Francis <alistair.francis@wdc.com> | ||
24 | Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> | ||
25 | Message-id: 20210901124521.30599-2-bmeng.cn@gmail.com | ||
13 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 26 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
14 | Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | ||
15 | Message-id: 20180313153458.26822-7-peter.maydell@linaro.org | ||
16 | --- | 27 | --- |
17 | include/hw/arm/bcm2836.h | 19 +++++++++++++++++++ | 28 | hw/misc/zynq_slcr.c | 31 ++++++++++++++++++------------- |
18 | hw/arm/bcm2836.c | 37 ++++++++++++++++++++++++++++++++----- | 29 | 1 file changed, 18 insertions(+), 13 deletions(-) |
19 | hw/arm/raspi.c | 3 ++- | ||
20 | 3 files changed, 53 insertions(+), 6 deletions(-) | ||
21 | 30 | ||
22 | diff --git a/include/hw/arm/bcm2836.h b/include/hw/arm/bcm2836.h | 31 | diff --git a/hw/misc/zynq_slcr.c b/hw/misc/zynq_slcr.c |
23 | index XXXXXXX..XXXXXXX 100644 | 32 | index XXXXXXX..XXXXXXX 100644 |
24 | --- a/include/hw/arm/bcm2836.h | 33 | --- a/hw/misc/zynq_slcr.c |
25 | +++ b/include/hw/arm/bcm2836.h | 34 | +++ b/hw/misc/zynq_slcr.c |
26 | @@ -XXX,XX +XXX,XX @@ | 35 | @@ -XXX,XX +XXX,XX @@ static uint64_t zynq_slcr_compute_clock(const uint64_t periods[], |
27 | 36 | zynq_slcr_compute_clock((plls), (state)->regs[reg], \ | |
28 | #define BCM283X_NCPUS 4 | 37 | reg ## _ ## enable_field ## _SHIFT) |
29 | 38 | ||
30 | +/* These type names are for specific SoCs; other than instantiating | 39 | +static void zynq_slcr_compute_clocks_internal(ZynqSLCRState *s, uint64_t ps_clk) |
31 | + * them, code using these devices should always handle them via the | 40 | +{ |
32 | + * BCM283x base class, so they have no BCM2836(obj) etc macros. | 41 | + uint64_t io_pll = zynq_slcr_compute_pll(ps_clk, s->regs[R_IO_PLL_CTRL]); |
33 | + */ | 42 | + uint64_t arm_pll = zynq_slcr_compute_pll(ps_clk, s->regs[R_ARM_PLL_CTRL]); |
34 | +#define TYPE_BCM2836 "bcm2836" | 43 | + uint64_t ddr_pll = zynq_slcr_compute_pll(ps_clk, s->regs[R_DDR_PLL_CTRL]); |
35 | +#define TYPE_BCM2837 "bcm2837" | ||
36 | + | 44 | + |
37 | typedef struct BCM283XState { | 45 | + uint64_t uart_mux[4] = {io_pll, io_pll, arm_pll, ddr_pll}; |
38 | /*< private >*/ | ||
39 | DeviceState parent_obj; | ||
40 | @@ -XXX,XX +XXX,XX @@ typedef struct BCM283XState { | ||
41 | BCM2835PeripheralState peripherals; | ||
42 | } BCM283XState; | ||
43 | |||
44 | +typedef struct BCM283XInfo BCM283XInfo; | ||
45 | + | 46 | + |
46 | +typedef struct BCM283XClass { | 47 | + /* compute uartX reference clocks */ |
47 | + DeviceClass parent_class; | 48 | + clock_set(s->uart0_ref_clk, |
48 | + const BCM283XInfo *info; | 49 | + ZYNQ_COMPUTE_CLK(s, uart_mux, R_UART_CLK_CTRL, CLKACT0)); |
49 | +} BCM283XClass; | 50 | + clock_set(s->uart1_ref_clk, |
51 | + ZYNQ_COMPUTE_CLK(s, uart_mux, R_UART_CLK_CTRL, CLKACT1)); | ||
52 | +} | ||
50 | + | 53 | + |
51 | +#define BCM283X_CLASS(klass) \ | 54 | /** |
52 | + OBJECT_CLASS_CHECK(BCM283XClass, (klass), TYPE_BCM283X) | 55 | * Compute and set the ouputs clocks periods. |
53 | +#define BCM283X_GET_CLASS(obj) \ | 56 | * But do not propagate them further. Connected clocks |
54 | + OBJECT_GET_CLASS(BCM283XClass, (obj), TYPE_BCM283X) | 57 | @@ -XXX,XX +XXX,XX @@ static void zynq_slcr_compute_clocks(ZynqSLCRState *s) |
55 | + | 58 | ps_clk = 0; |
56 | #endif /* BCM2836_H */ | 59 | } |
57 | diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c | 60 | |
58 | index XXXXXXX..XXXXXXX 100644 | 61 | - uint64_t io_pll = zynq_slcr_compute_pll(ps_clk, s->regs[R_IO_PLL_CTRL]); |
59 | --- a/hw/arm/bcm2836.c | 62 | - uint64_t arm_pll = zynq_slcr_compute_pll(ps_clk, s->regs[R_ARM_PLL_CTRL]); |
60 | +++ b/hw/arm/bcm2836.c | 63 | - uint64_t ddr_pll = zynq_slcr_compute_pll(ps_clk, s->regs[R_DDR_PLL_CTRL]); |
61 | @@ -XXX,XX +XXX,XX @@ | 64 | - |
62 | /* "QA7" (Pi2) interrupt controller and mailboxes etc. */ | 65 | - uint64_t uart_mux[4] = {io_pll, io_pll, arm_pll, ddr_pll}; |
63 | #define BCM2836_CONTROL_BASE 0x40000000 | 66 | - |
64 | 67 | - /* compute uartX reference clocks */ | |
65 | +struct BCM283XInfo { | 68 | - clock_set(s->uart0_ref_clk, |
66 | + const char *name; | 69 | - ZYNQ_COMPUTE_CLK(s, uart_mux, R_UART_CLK_CTRL, CLKACT0)); |
67 | +}; | 70 | - clock_set(s->uart1_ref_clk, |
68 | + | 71 | - ZYNQ_COMPUTE_CLK(s, uart_mux, R_UART_CLK_CTRL, CLKACT1)); |
69 | +static const BCM283XInfo bcm283x_socs[] = { | 72 | + zynq_slcr_compute_clocks_internal(s, ps_clk); |
70 | + { | ||
71 | + .name = TYPE_BCM2836, | ||
72 | + }, | ||
73 | + { | ||
74 | + .name = TYPE_BCM2837, | ||
75 | + }, | ||
76 | +}; | ||
77 | + | ||
78 | static void bcm2836_init(Object *obj) | ||
79 | { | ||
80 | BCM283XState *s = BCM283X(obj); | ||
81 | @@ -XXX,XX +XXX,XX @@ static Property bcm2836_props[] = { | ||
82 | DEFINE_PROP_END_OF_LIST() | ||
83 | }; | ||
84 | |||
85 | -static void bcm2836_class_init(ObjectClass *oc, void *data) | ||
86 | +static void bcm283x_class_init(ObjectClass *oc, void *data) | ||
87 | { | ||
88 | DeviceClass *dc = DEVICE_CLASS(oc); | ||
89 | + BCM283XClass *bc = BCM283X_CLASS(oc); | ||
90 | |||
91 | - dc->props = bcm2836_props; | ||
92 | + bc->info = data; | ||
93 | dc->realize = bcm2836_realize; | ||
94 | + dc->props = bcm2836_props; | ||
95 | } | 73 | } |
96 | 74 | ||
97 | -static const TypeInfo bcm2836_type_info = { | 75 | /** |
98 | +static const TypeInfo bcm283x_type_info = { | 76 | @@ -XXX,XX +XXX,XX @@ static void zynq_slcr_reset_hold(Object *obj) |
99 | .name = TYPE_BCM283X, | 77 | ZynqSLCRState *s = ZYNQ_SLCR(obj); |
100 | .parent = TYPE_DEVICE, | 78 | |
101 | .instance_size = sizeof(BCM283XState), | 79 | /* will disable all output clocks */ |
102 | .instance_init = bcm2836_init, | 80 | - zynq_slcr_compute_clocks(s); |
103 | - .class_init = bcm2836_class_init, | 81 | + zynq_slcr_compute_clocks_internal(s, 0); |
104 | + .class_size = sizeof(BCM283XClass), | 82 | zynq_slcr_propagate_clocks(s); |
105 | + .abstract = true, | ||
106 | }; | ||
107 | |||
108 | static void bcm2836_register_types(void) | ||
109 | { | ||
110 | - type_register_static(&bcm2836_type_info); | ||
111 | + int i; | ||
112 | + | ||
113 | + type_register_static(&bcm283x_type_info); | ||
114 | + for (i = 0; i < ARRAY_SIZE(bcm283x_socs); i++) { | ||
115 | + TypeInfo ti = { | ||
116 | + .name = bcm283x_socs[i].name, | ||
117 | + .parent = TYPE_BCM283X, | ||
118 | + .class_init = bcm283x_class_init, | ||
119 | + .class_data = (void *) &bcm283x_socs[i], | ||
120 | + }; | ||
121 | + type_register(&ti); | ||
122 | + } | ||
123 | } | 83 | } |
124 | 84 | ||
125 | type_init(bcm2836_register_types) | 85 | @@ -XXX,XX +XXX,XX @@ static void zynq_slcr_reset_exit(Object *obj) |
126 | diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c | 86 | ZynqSLCRState *s = ZYNQ_SLCR(obj); |
127 | index XXXXXXX..XXXXXXX 100644 | 87 | |
128 | --- a/hw/arm/raspi.c | 88 | /* will compute output clocks according to ps_clk and registers */ |
129 | +++ b/hw/arm/raspi.c | 89 | - zynq_slcr_compute_clocks(s); |
130 | @@ -XXX,XX +XXX,XX @@ static void raspi_init(MachineState *machine, int version) | 90 | + zynq_slcr_compute_clocks_internal(s, clock_get(s->ps_clk)); |
131 | BusState *bus; | 91 | zynq_slcr_propagate_clocks(s); |
132 | DeviceState *carddev; | 92 | } |
133 | |||
134 | - object_initialize(&s->soc, sizeof(s->soc), TYPE_BCM283X); | ||
135 | + object_initialize(&s->soc, sizeof(s->soc), | ||
136 | + version == 3 ? TYPE_BCM2837 : TYPE_BCM2836); | ||
137 | object_property_add_child(OBJECT(machine), "soc", OBJECT(&s->soc), | ||
138 | &error_abort); | ||
139 | 93 | ||
140 | -- | 94 | -- |
141 | 2.16.2 | 95 | 2.20.1 |
142 | 96 | ||
143 | 97 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Bin Meng <bmeng.cn@gmail.com> | ||
1 | 2 | ||
3 | At present when input clock is disabled, any character transmitted | ||
4 | to tx fifo can still show on the serial line, which is wrong. | ||
5 | |||
6 | Fixes: b636db306e06 ("hw/char/cadence_uart: add clock support") | ||
7 | Signed-off-by: Bin Meng <bmeng.cn@gmail.com> | ||
8 | Reviewed-by: Alistair Francis <alistair.francis@wdc.com> | ||
9 | Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> | ||
10 | Message-id: 20210901124521.30599-3-bmeng.cn@gmail.com | ||
11 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
12 | --- | ||
13 | hw/char/cadence_uart.c | 5 +++++ | ||
14 | 1 file changed, 5 insertions(+) | ||
15 | |||
16 | diff --git a/hw/char/cadence_uart.c b/hw/char/cadence_uart.c | ||
17 | index XXXXXXX..XXXXXXX 100644 | ||
18 | --- a/hw/char/cadence_uart.c | ||
19 | +++ b/hw/char/cadence_uart.c | ||
20 | @@ -XXX,XX +XXX,XX @@ static gboolean cadence_uart_xmit(void *do_not_use, GIOCondition cond, | ||
21 | static void uart_write_tx_fifo(CadenceUARTState *s, const uint8_t *buf, | ||
22 | int size) | ||
23 | { | ||
24 | + /* ignore characters when unclocked or in reset */ | ||
25 | + if (!clock_is_enabled(s->refclk) || device_is_in_reset(DEVICE(s))) { | ||
26 | + return; | ||
27 | + } | ||
28 | + | ||
29 | if ((s->r[R_CR] & UART_CR_TX_DIS) || !(s->r[R_CR] & UART_CR_TX_EN)) { | ||
30 | return; | ||
31 | } | ||
32 | -- | ||
33 | 2.20.1 | ||
34 | |||
35 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Bin Meng <bmeng.cn@gmail.com> | ||
1 | 2 | ||
3 | Currently the clock/reset check is done in uart_receive(), but we | ||
4 | can move the check to uart_can_receive() which is earlier. | ||
5 | |||
6 | Signed-off-by: Bin Meng <bmeng.cn@gmail.com> | ||
7 | Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> | ||
8 | Reviewed-by: Alistair Francis <alistair.francis@wdc.com> | ||
9 | Message-id: 20210901124521.30599-4-bmeng.cn@gmail.com | ||
10 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
11 | --- | ||
12 | hw/char/cadence_uart.c | 17 ++++++++++------- | ||
13 | 1 file changed, 10 insertions(+), 7 deletions(-) | ||
14 | |||
15 | diff --git a/hw/char/cadence_uart.c b/hw/char/cadence_uart.c | ||
16 | index XXXXXXX..XXXXXXX 100644 | ||
17 | --- a/hw/char/cadence_uart.c | ||
18 | +++ b/hw/char/cadence_uart.c | ||
19 | @@ -XXX,XX +XXX,XX @@ static void uart_parameters_setup(CadenceUARTState *s) | ||
20 | static int uart_can_receive(void *opaque) | ||
21 | { | ||
22 | CadenceUARTState *s = opaque; | ||
23 | - int ret = MAX(CADENCE_UART_RX_FIFO_SIZE, CADENCE_UART_TX_FIFO_SIZE); | ||
24 | - uint32_t ch_mode = s->r[R_MR] & UART_MR_CHMODE; | ||
25 | + int ret; | ||
26 | + uint32_t ch_mode; | ||
27 | + | ||
28 | + /* ignore characters when unclocked or in reset */ | ||
29 | + if (!clock_is_enabled(s->refclk) || device_is_in_reset(DEVICE(s))) { | ||
30 | + return 0; | ||
31 | + } | ||
32 | + | ||
33 | + ret = MAX(CADENCE_UART_RX_FIFO_SIZE, CADENCE_UART_TX_FIFO_SIZE); | ||
34 | + ch_mode = s->r[R_MR] & UART_MR_CHMODE; | ||
35 | |||
36 | if (ch_mode == NORMAL_MODE || ch_mode == ECHO_MODE) { | ||
37 | ret = MIN(ret, CADENCE_UART_RX_FIFO_SIZE - s->rx_count); | ||
38 | @@ -XXX,XX +XXX,XX @@ static void uart_receive(void *opaque, const uint8_t *buf, int size) | ||
39 | CadenceUARTState *s = opaque; | ||
40 | uint32_t ch_mode = s->r[R_MR] & UART_MR_CHMODE; | ||
41 | |||
42 | - /* ignore characters when unclocked or in reset */ | ||
43 | - if (!clock_is_enabled(s->refclk) || device_is_in_reset(DEVICE(s))) { | ||
44 | - return; | ||
45 | - } | ||
46 | - | ||
47 | if (ch_mode == NORMAL_MODE || ch_mode == ECHO_MODE) { | ||
48 | uart_write_rx_fifo(opaque, buf, size); | ||
49 | } | ||
50 | -- | ||
51 | 2.20.1 | ||
52 | |||
53 | diff view generated by jsdifflib |
1 | Our BCM2836 type is really a generic one that can be any of | 1 | From: Bin Meng <bmeng.cn@gmail.com> |
---|---|---|---|
2 | the bcm283x family. Rename it accordingly. We change only | ||
3 | the names which are visible via the header file to the | ||
4 | rest of the QEMU code, leaving private function names | ||
5 | in bcm2836.c as they are. | ||
6 | 2 | ||
7 | This is a preliminary to making bcm283x be an abstract | 3 | This converts uart_read() and uart_write() to memop_with_attrs() ops. |
8 | parent class to specific types for the bcm2836 and bcm2837. | ||
9 | 4 | ||
5 | Signed-off-by: Bin Meng <bmeng.cn@gmail.com> | ||
6 | Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> | ||
7 | Reviewed-by: Alistair Francis <alistair.francis@wdc.com> | ||
8 | Message-id: 20210901124521.30599-5-bmeng.cn@gmail.com | ||
10 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 9 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
11 | Reviewed-by: Andrew Baumann <Andrew.Baumann@microsoft.com> | ||
12 | Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | ||
13 | Message-id: 20180313153458.26822-6-peter.maydell@linaro.org | ||
14 | --- | 10 | --- |
15 | include/hw/arm/bcm2836.h | 12 ++++++------ | 11 | hw/char/cadence_uart.c | 26 +++++++++++++++----------- |
16 | hw/arm/bcm2836.c | 17 +++++++++-------- | 12 | 1 file changed, 15 insertions(+), 11 deletions(-) |
17 | hw/arm/raspi.c | 16 ++++++++-------- | ||
18 | 3 files changed, 23 insertions(+), 22 deletions(-) | ||
19 | 13 | ||
20 | diff --git a/include/hw/arm/bcm2836.h b/include/hw/arm/bcm2836.h | 14 | diff --git a/hw/char/cadence_uart.c b/hw/char/cadence_uart.c |
21 | index XXXXXXX..XXXXXXX 100644 | 15 | index XXXXXXX..XXXXXXX 100644 |
22 | --- a/include/hw/arm/bcm2836.h | 16 | --- a/hw/char/cadence_uart.c |
23 | +++ b/include/hw/arm/bcm2836.h | 17 | +++ b/hw/char/cadence_uart.c |
24 | @@ -XXX,XX +XXX,XX @@ | 18 | @@ -XXX,XX +XXX,XX @@ static void uart_read_rx_fifo(CadenceUARTState *s, uint32_t *c) |
25 | #include "hw/arm/bcm2835_peripherals.h" | 19 | uart_update_status(s); |
26 | #include "hw/intc/bcm2836_control.h" | 20 | } |
27 | 21 | ||
28 | -#define TYPE_BCM2836 "bcm2836" | 22 | -static void uart_write(void *opaque, hwaddr offset, |
29 | -#define BCM2836(obj) OBJECT_CHECK(BCM2836State, (obj), TYPE_BCM2836) | 23 | - uint64_t value, unsigned size) |
30 | +#define TYPE_BCM283X "bcm283x" | 24 | +static MemTxResult uart_write(void *opaque, hwaddr offset, |
31 | +#define BCM283X(obj) OBJECT_CHECK(BCM283XState, (obj), TYPE_BCM283X) | 25 | + uint64_t value, unsigned size, MemTxAttrs attrs) |
32 | |||
33 | -#define BCM2836_NCPUS 4 | ||
34 | +#define BCM283X_NCPUS 4 | ||
35 | |||
36 | -typedef struct BCM2836State { | ||
37 | +typedef struct BCM283XState { | ||
38 | /*< private >*/ | ||
39 | DeviceState parent_obj; | ||
40 | /*< public >*/ | ||
41 | @@ -XXX,XX +XXX,XX @@ typedef struct BCM2836State { | ||
42 | char *cpu_type; | ||
43 | uint32_t enabled_cpus; | ||
44 | |||
45 | - ARMCPU cpus[BCM2836_NCPUS]; | ||
46 | + ARMCPU cpus[BCM283X_NCPUS]; | ||
47 | BCM2836ControlState control; | ||
48 | BCM2835PeripheralState peripherals; | ||
49 | -} BCM2836State; | ||
50 | +} BCM283XState; | ||
51 | |||
52 | #endif /* BCM2836_H */ | ||
53 | diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c | ||
54 | index XXXXXXX..XXXXXXX 100644 | ||
55 | --- a/hw/arm/bcm2836.c | ||
56 | +++ b/hw/arm/bcm2836.c | ||
57 | @@ -XXX,XX +XXX,XX @@ | ||
58 | |||
59 | static void bcm2836_init(Object *obj) | ||
60 | { | 26 | { |
61 | - BCM2836State *s = BCM2836(obj); | 27 | CadenceUARTState *s = opaque; |
62 | + BCM283XState *s = BCM283X(obj); | 28 | |
63 | 29 | DB_PRINT(" offset:%x data:%08x\n", (unsigned)offset, (unsigned)value); | |
64 | object_initialize(&s->control, sizeof(s->control), TYPE_BCM2836_CONTROL); | 30 | offset >>= 2; |
65 | object_property_add_child(obj, "control", OBJECT(&s->control), NULL); | 31 | if (offset >= CADENCE_UART_R_MAX) { |
66 | @@ -XXX,XX +XXX,XX @@ static void bcm2836_init(Object *obj) | 32 | - return; |
67 | 33 | + return MEMTX_DECODE_ERROR; | |
68 | static void bcm2836_realize(DeviceState *dev, Error **errp) | 34 | } |
35 | switch (offset) { | ||
36 | case R_IER: /* ier (wts imr) */ | ||
37 | @@ -XXX,XX +XXX,XX @@ static void uart_write(void *opaque, hwaddr offset, | ||
38 | break; | ||
39 | } | ||
40 | uart_update_status(s); | ||
41 | + | ||
42 | + return MEMTX_OK; | ||
43 | } | ||
44 | |||
45 | -static uint64_t uart_read(void *opaque, hwaddr offset, | ||
46 | - unsigned size) | ||
47 | +static MemTxResult uart_read(void *opaque, hwaddr offset, | ||
48 | + uint64_t *value, unsigned size, MemTxAttrs attrs) | ||
69 | { | 49 | { |
70 | - BCM2836State *s = BCM2836(dev); | 50 | CadenceUARTState *s = opaque; |
71 | + BCM283XState *s = BCM283X(dev); | 51 | uint32_t c = 0; |
72 | Object *obj; | 52 | |
73 | Error *err = NULL; | 53 | offset >>= 2; |
74 | int n; | 54 | if (offset >= CADENCE_UART_R_MAX) { |
75 | @@ -XXX,XX +XXX,XX @@ static void bcm2836_realize(DeviceState *dev, Error **errp) | 55 | - c = 0; |
76 | /* common peripherals from bcm2835 */ | 56 | - } else if (offset == R_TX_RX) { |
77 | 57 | + return MEMTX_DECODE_ERROR; | |
78 | obj = OBJECT(dev); | 58 | + } |
79 | - for (n = 0; n < BCM2836_NCPUS; n++) { | 59 | + if (offset == R_TX_RX) { |
80 | + for (n = 0; n < BCM283X_NCPUS; n++) { | 60 | uart_read_rx_fifo(s, &c); |
81 | object_initialize(&s->cpus[n], sizeof(s->cpus[n]), | 61 | } else { |
82 | s->cpu_type); | 62 | - c = s->r[offset]; |
83 | object_property_add_child(obj, "cpu[*]", OBJECT(&s->cpus[n]), | 63 | + c = s->r[offset]; |
84 | @@ -XXX,XX +XXX,XX @@ static void bcm2836_realize(DeviceState *dev, Error **errp) | 64 | } |
85 | sysbus_connect_irq(SYS_BUS_DEVICE(&s->peripherals), 1, | 65 | |
86 | qdev_get_gpio_in_named(DEVICE(&s->control), "gpu-fiq", 0)); | 66 | DB_PRINT(" offset:%x data:%08x\n", (unsigned)(offset << 2), (unsigned)c); |
87 | 67 | - return c; | |
88 | - for (n = 0; n < BCM2836_NCPUS; n++) { | 68 | + *value = c; |
89 | + for (n = 0; n < BCM283X_NCPUS; n++) { | 69 | + return MEMTX_OK; |
90 | /* Mirror bcm2836, which has clusterid set to 0xf | ||
91 | * TODO: this should be converted to a property of ARM_CPU | ||
92 | */ | ||
93 | @@ -XXX,XX +XXX,XX @@ static void bcm2836_realize(DeviceState *dev, Error **errp) | ||
94 | } | 70 | } |
95 | 71 | ||
96 | static Property bcm2836_props[] = { | 72 | static const MemoryRegionOps uart_ops = { |
97 | - DEFINE_PROP_STRING("cpu-type", BCM2836State, cpu_type), | 73 | - .read = uart_read, |
98 | - DEFINE_PROP_UINT32("enabled-cpus", BCM2836State, enabled_cpus, BCM2836_NCPUS), | 74 | - .write = uart_write, |
99 | + DEFINE_PROP_STRING("cpu-type", BCM283XState, cpu_type), | 75 | + .read_with_attrs = uart_read, |
100 | + DEFINE_PROP_UINT32("enabled-cpus", BCM283XState, enabled_cpus, | 76 | + .write_with_attrs = uart_write, |
101 | + BCM283X_NCPUS), | 77 | .endianness = DEVICE_NATIVE_ENDIAN, |
102 | DEFINE_PROP_END_OF_LIST() | ||
103 | }; | 78 | }; |
104 | 79 | ||
105 | @@ -XXX,XX +XXX,XX @@ static void bcm2836_class_init(ObjectClass *oc, void *data) | ||
106 | } | ||
107 | |||
108 | static const TypeInfo bcm2836_type_info = { | ||
109 | - .name = TYPE_BCM2836, | ||
110 | + .name = TYPE_BCM283X, | ||
111 | .parent = TYPE_DEVICE, | ||
112 | - .instance_size = sizeof(BCM2836State), | ||
113 | + .instance_size = sizeof(BCM283XState), | ||
114 | .instance_init = bcm2836_init, | ||
115 | .class_init = bcm2836_class_init, | ||
116 | }; | ||
117 | diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c | ||
118 | index XXXXXXX..XXXXXXX 100644 | ||
119 | --- a/hw/arm/raspi.c | ||
120 | +++ b/hw/arm/raspi.c | ||
121 | @@ -XXX,XX +XXX,XX @@ | ||
122 | static const int raspi_boardid[] = {[1] = 0xc42, [2] = 0xc43, [3] = 0xc44}; | ||
123 | |||
124 | typedef struct RasPiState { | ||
125 | - BCM2836State soc; | ||
126 | + BCM283XState soc; | ||
127 | MemoryRegion ram; | ||
128 | } RasPiState; | ||
129 | |||
130 | @@ -XXX,XX +XXX,XX @@ static void raspi_init(MachineState *machine, int version) | ||
131 | BusState *bus; | ||
132 | DeviceState *carddev; | ||
133 | |||
134 | - object_initialize(&s->soc, sizeof(s->soc), TYPE_BCM2836); | ||
135 | + object_initialize(&s->soc, sizeof(s->soc), TYPE_BCM283X); | ||
136 | object_property_add_child(OBJECT(machine), "soc", OBJECT(&s->soc), | ||
137 | &error_abort); | ||
138 | |||
139 | @@ -XXX,XX +XXX,XX @@ static void raspi2_machine_init(MachineClass *mc) | ||
140 | mc->no_floppy = 1; | ||
141 | mc->no_cdrom = 1; | ||
142 | mc->default_cpu_type = ARM_CPU_TYPE_NAME("cortex-a15"); | ||
143 | - mc->max_cpus = BCM2836_NCPUS; | ||
144 | - mc->min_cpus = BCM2836_NCPUS; | ||
145 | - mc->default_cpus = BCM2836_NCPUS; | ||
146 | + mc->max_cpus = BCM283X_NCPUS; | ||
147 | + mc->min_cpus = BCM283X_NCPUS; | ||
148 | + mc->default_cpus = BCM283X_NCPUS; | ||
149 | mc->default_ram_size = 1024 * 1024 * 1024; | ||
150 | mc->ignore_memory_transaction_failures = true; | ||
151 | }; | ||
152 | @@ -XXX,XX +XXX,XX @@ static void raspi3_machine_init(MachineClass *mc) | ||
153 | mc->no_floppy = 1; | ||
154 | mc->no_cdrom = 1; | ||
155 | mc->default_cpu_type = ARM_CPU_TYPE_NAME("cortex-a53"); | ||
156 | - mc->max_cpus = BCM2836_NCPUS; | ||
157 | - mc->min_cpus = BCM2836_NCPUS; | ||
158 | - mc->default_cpus = BCM2836_NCPUS; | ||
159 | + mc->max_cpus = BCM283X_NCPUS; | ||
160 | + mc->min_cpus = BCM283X_NCPUS; | ||
161 | + mc->default_cpus = BCM283X_NCPUS; | ||
162 | mc->default_ram_size = 1024 * 1024 * 1024; | ||
163 | } | ||
164 | DEFINE_MACHINE("raspi3", raspi3_machine_init) | ||
165 | -- | 80 | -- |
166 | 2.16.2 | 81 | 2.20.1 |
167 | 82 | ||
168 | 83 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Bin Meng <bmeng.cn@gmail.com> | ||
1 | 2 | ||
3 | Read or write to uart registers when unclocked or in reset should be | ||
4 | ignored. Add the check there, and as a result of this, the check in | ||
5 | uart_write_tx_fifo() is now unnecessary. | ||
6 | |||
7 | Signed-off-by: Bin Meng <bmeng.cn@gmail.com> | ||
8 | Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> | ||
9 | Reviewed-by: Alistair Francis <alistair.francis@wdc.com> | ||
10 | Message-id: 20210901124521.30599-6-bmeng.cn@gmail.com | ||
11 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
12 | --- | ||
13 | hw/char/cadence_uart.c | 15 ++++++++++----- | ||
14 | 1 file changed, 10 insertions(+), 5 deletions(-) | ||
15 | |||
16 | diff --git a/hw/char/cadence_uart.c b/hw/char/cadence_uart.c | ||
17 | index XXXXXXX..XXXXXXX 100644 | ||
18 | --- a/hw/char/cadence_uart.c | ||
19 | +++ b/hw/char/cadence_uart.c | ||
20 | @@ -XXX,XX +XXX,XX @@ static gboolean cadence_uart_xmit(void *do_not_use, GIOCondition cond, | ||
21 | static void uart_write_tx_fifo(CadenceUARTState *s, const uint8_t *buf, | ||
22 | int size) | ||
23 | { | ||
24 | - /* ignore characters when unclocked or in reset */ | ||
25 | - if (!clock_is_enabled(s->refclk) || device_is_in_reset(DEVICE(s))) { | ||
26 | - return; | ||
27 | - } | ||
28 | - | ||
29 | if ((s->r[R_CR] & UART_CR_TX_DIS) || !(s->r[R_CR] & UART_CR_TX_EN)) { | ||
30 | return; | ||
31 | } | ||
32 | @@ -XXX,XX +XXX,XX @@ static MemTxResult uart_write(void *opaque, hwaddr offset, | ||
33 | { | ||
34 | CadenceUARTState *s = opaque; | ||
35 | |||
36 | + /* ignore access when unclocked or in reset */ | ||
37 | + if (!clock_is_enabled(s->refclk) || device_is_in_reset(DEVICE(s))) { | ||
38 | + return MEMTX_ERROR; | ||
39 | + } | ||
40 | + | ||
41 | DB_PRINT(" offset:%x data:%08x\n", (unsigned)offset, (unsigned)value); | ||
42 | offset >>= 2; | ||
43 | if (offset >= CADENCE_UART_R_MAX) { | ||
44 | @@ -XXX,XX +XXX,XX @@ static MemTxResult uart_read(void *opaque, hwaddr offset, | ||
45 | CadenceUARTState *s = opaque; | ||
46 | uint32_t c = 0; | ||
47 | |||
48 | + /* ignore access when unclocked or in reset */ | ||
49 | + if (!clock_is_enabled(s->refclk) || device_is_in_reset(DEVICE(s))) { | ||
50 | + return MEMTX_ERROR; | ||
51 | + } | ||
52 | + | ||
53 | offset >>= 2; | ||
54 | if (offset >= CADENCE_UART_R_MAX) { | ||
55 | return MEMTX_DECODE_ERROR; | ||
56 | -- | ||
57 | 2.20.1 | ||
58 | |||
59 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Bin Meng <bmeng.cn@gmail.com> | ||
1 | 2 | ||
3 | We've got SW that expects FSBL (Bootlooader) to setup clocks and | ||
4 | resets. It's quite common that users run that SW on QEMU without | ||
5 | FSBL (FSBL typically requires the Xilinx tools installed). That's | ||
6 | fine, since users can stil use -device loader to enable clocks etc. | ||
7 | |||
8 | To help folks understand what's going, a log (guest-error) message | ||
9 | would be helpful here. In particular with the serial port since | ||
10 | things will go very quiet if they get things wrong. | ||
11 | |||
12 | Suggested-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> | ||
13 | Signed-off-by: Bin Meng <bmeng.cn@gmail.com> | ||
14 | Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> | ||
15 | Reviewed-by: Alistair Francis <alistair.francis@wdc.com> | ||
16 | Message-id: 20210901124521.30599-7-bmeng.cn@gmail.com | ||
17 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
18 | --- | ||
19 | hw/char/cadence_uart.c | 8 ++++++++ | ||
20 | 1 file changed, 8 insertions(+) | ||
21 | |||
22 | diff --git a/hw/char/cadence_uart.c b/hw/char/cadence_uart.c | ||
23 | index XXXXXXX..XXXXXXX 100644 | ||
24 | --- a/hw/char/cadence_uart.c | ||
25 | +++ b/hw/char/cadence_uart.c | ||
26 | @@ -XXX,XX +XXX,XX @@ static int uart_can_receive(void *opaque) | ||
27 | |||
28 | /* ignore characters when unclocked or in reset */ | ||
29 | if (!clock_is_enabled(s->refclk) || device_is_in_reset(DEVICE(s))) { | ||
30 | + qemu_log_mask(LOG_GUEST_ERROR, "%s: uart is unclocked or in reset\n", | ||
31 | + __func__); | ||
32 | return 0; | ||
33 | } | ||
34 | |||
35 | @@ -XXX,XX +XXX,XX @@ static void uart_event(void *opaque, QEMUChrEvent event) | ||
36 | |||
37 | /* ignore characters when unclocked or in reset */ | ||
38 | if (!clock_is_enabled(s->refclk) || device_is_in_reset(DEVICE(s))) { | ||
39 | + qemu_log_mask(LOG_GUEST_ERROR, "%s: uart is unclocked or in reset\n", | ||
40 | + __func__); | ||
41 | return; | ||
42 | } | ||
43 | |||
44 | @@ -XXX,XX +XXX,XX @@ static MemTxResult uart_write(void *opaque, hwaddr offset, | ||
45 | |||
46 | /* ignore access when unclocked or in reset */ | ||
47 | if (!clock_is_enabled(s->refclk) || device_is_in_reset(DEVICE(s))) { | ||
48 | + qemu_log_mask(LOG_GUEST_ERROR, "%s: uart is unclocked or in reset\n", | ||
49 | + __func__); | ||
50 | return MEMTX_ERROR; | ||
51 | } | ||
52 | |||
53 | @@ -XXX,XX +XXX,XX @@ static MemTxResult uart_read(void *opaque, hwaddr offset, | ||
54 | |||
55 | /* ignore access when unclocked or in reset */ | ||
56 | if (!clock_is_enabled(s->refclk) || device_is_in_reset(DEVICE(s))) { | ||
57 | + qemu_log_mask(LOG_GUEST_ERROR, "%s: uart is unclocked or in reset\n", | ||
58 | + __func__); | ||
59 | return MEMTX_ERROR; | ||
60 | } | ||
61 | |||
62 | -- | ||
63 | 2.20.1 | ||
64 | |||
65 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Marc Zyngier <maz@kernel.org> | ||
1 | 2 | ||
3 | Although we probe for the IPA limits imposed by KVM (and the hardware) | ||
4 | when computing the memory map, we still use the old style '0' when | ||
5 | creating a scratch VM in kvm_arm_create_scratch_host_vcpu(). | ||
6 | |||
7 | On systems that are severely IPA challenged (such as the Apple M1), | ||
8 | this results in a failure as KVM cannot use the default 40bit that | ||
9 | '0' represents. | ||
10 | |||
11 | Instead, probe for the extension and use the reported IPA limit | ||
12 | if available. | ||
13 | |||
14 | Cc: Andrew Jones <drjones@redhat.com> | ||
15 | Cc: Eric Auger <eric.auger@redhat.com> | ||
16 | Cc: Peter Maydell <peter.maydell@linaro.org> | ||
17 | Signed-off-by: Marc Zyngier <maz@kernel.org> | ||
18 | Reviewed-by: Andrew Jones <drjones@redhat.com> | ||
19 | Message-id: 20210822144441.1290891-2-maz@kernel.org | ||
20 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
21 | --- | ||
22 | target/arm/kvm.c | 7 ++++++- | ||
23 | 1 file changed, 6 insertions(+), 1 deletion(-) | ||
24 | |||
25 | diff --git a/target/arm/kvm.c b/target/arm/kvm.c | ||
26 | index XXXXXXX..XXXXXXX 100644 | ||
27 | --- a/target/arm/kvm.c | ||
28 | +++ b/target/arm/kvm.c | ||
29 | @@ -XXX,XX +XXX,XX @@ bool kvm_arm_create_scratch_host_vcpu(const uint32_t *cpus_to_try, | ||
30 | struct kvm_vcpu_init *init) | ||
31 | { | ||
32 | int ret = 0, kvmfd = -1, vmfd = -1, cpufd = -1; | ||
33 | + int max_vm_pa_size; | ||
34 | |||
35 | kvmfd = qemu_open_old("/dev/kvm", O_RDWR); | ||
36 | if (kvmfd < 0) { | ||
37 | goto err; | ||
38 | } | ||
39 | - vmfd = ioctl(kvmfd, KVM_CREATE_VM, 0); | ||
40 | + max_vm_pa_size = ioctl(kvmfd, KVM_CHECK_EXTENSION, KVM_CAP_ARM_VM_IPA_SIZE); | ||
41 | + if (max_vm_pa_size < 0) { | ||
42 | + max_vm_pa_size = 0; | ||
43 | + } | ||
44 | + vmfd = ioctl(kvmfd, KVM_CREATE_VM, max_vm_pa_size); | ||
45 | if (vmfd < 0) { | ||
46 | goto err; | ||
47 | } | ||
48 | -- | ||
49 | 2.20.1 | ||
50 | |||
51 | diff view generated by jsdifflib |
1 | The BCM2837 sets the Aff1 field of the MPIDR affinity values for the | 1 | From: Chris Rauer <crauer@google.com> |
---|---|---|---|
2 | CPUs to 0, whereas the BCM2836 uses 0xf. Set this correctly, as it | ||
3 | is required for Linux to boot. | ||
4 | 2 | ||
3 | kudo-bmc is a board supported by OpenBMC. | ||
4 | https://github.com/openbmc/openbmc/tree/master/meta-fii/meta-kudo | ||
5 | |||
6 | Since v1: | ||
7 | - hyphenated Cortex-A9 | ||
8 | |||
9 | Tested: Booted kudo firmware. | ||
10 | Signed-off-by: Chris Rauer <crauer@google.com> | ||
11 | Reviewed-by: Patrick Venture <venture@google.com> | ||
12 | Message-id: 20210907223234.1165705-1-crauer@google.com | ||
5 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 13 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
6 | Reviewed-by: Andrew Baumann <Andrew.Baumann@microsoft.com> | ||
7 | Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | ||
8 | Message-id: 20180313153458.26822-8-peter.maydell@linaro.org | ||
9 | --- | 14 | --- |
10 | hw/arm/bcm2836.c | 11 +++++++---- | 15 | docs/system/arm/nuvoton.rst | 1 + |
11 | 1 file changed, 7 insertions(+), 4 deletions(-) | 16 | hw/arm/npcm7xx_boards.c | 34 ++++++++++++++++++++++++++++++++++ |
17 | 2 files changed, 35 insertions(+) | ||
12 | 18 | ||
13 | diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c | 19 | diff --git a/docs/system/arm/nuvoton.rst b/docs/system/arm/nuvoton.rst |
14 | index XXXXXXX..XXXXXXX 100644 | 20 | index XXXXXXX..XXXXXXX 100644 |
15 | --- a/hw/arm/bcm2836.c | 21 | --- a/docs/system/arm/nuvoton.rst |
16 | +++ b/hw/arm/bcm2836.c | 22 | +++ b/docs/system/arm/nuvoton.rst |
23 | @@ -XXX,XX +XXX,XX @@ Hyperscale applications. The following machines are based on this chip : | ||
24 | |||
25 | - ``quanta-gbs-bmc`` Quanta GBS server BMC | ||
26 | - ``quanta-gsj`` Quanta GSJ server BMC | ||
27 | +- ``kudo-bmc`` Fii USA Kudo server BMC | ||
28 | |||
29 | There are also two more SoCs, NPCM710 and NPCM705, which are single-core | ||
30 | variants of NPCM750 and NPCM730, respectively. These are currently not | ||
31 | diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.c | ||
32 | index XXXXXXX..XXXXXXX 100644 | ||
33 | --- a/hw/arm/npcm7xx_boards.c | ||
34 | +++ b/hw/arm/npcm7xx_boards.c | ||
17 | @@ -XXX,XX +XXX,XX @@ | 35 | @@ -XXX,XX +XXX,XX @@ |
18 | 36 | #define NPCM750_EVB_POWER_ON_STRAPS 0x00001ff7 | |
19 | struct BCM283XInfo { | 37 | #define QUANTA_GSJ_POWER_ON_STRAPS 0x00001fff |
20 | const char *name; | 38 | #define QUANTA_GBS_POWER_ON_STRAPS 0x000017ff |
21 | + int clusterid; | 39 | +#define KUDO_BMC_POWER_ON_STRAPS 0x00001fff |
22 | }; | 40 | |
23 | 41 | static const char npcm7xx_default_bootrom[] = "npcm7xx_bootrom.bin"; | |
24 | static const BCM283XInfo bcm283x_socs[] = { | 42 | |
43 | @@ -XXX,XX +XXX,XX @@ static void quanta_gbs_init(MachineState *machine) | ||
44 | npcm7xx_load_kernel(machine, soc); | ||
45 | } | ||
46 | |||
47 | +static void kudo_bmc_init(MachineState *machine) | ||
48 | +{ | ||
49 | + NPCM7xxState *soc; | ||
50 | + | ||
51 | + soc = npcm7xx_create_soc(machine, KUDO_BMC_POWER_ON_STRAPS); | ||
52 | + npcm7xx_connect_dram(soc, machine->ram); | ||
53 | + qdev_realize(DEVICE(soc), NULL, &error_fatal); | ||
54 | + | ||
55 | + npcm7xx_load_bootrom(machine, soc); | ||
56 | + npcm7xx_connect_flash(&soc->fiu[0], 0, "mx66u51235f", | ||
57 | + drive_get(IF_MTD, 0, 0)); | ||
58 | + npcm7xx_connect_flash(&soc->fiu[1], 0, "mx66u51235f", | ||
59 | + drive_get(IF_MTD, 3, 0)); | ||
60 | + | ||
61 | + npcm7xx_load_kernel(machine, soc); | ||
62 | +} | ||
63 | + | ||
64 | static void npcm7xx_set_soc_type(NPCM7xxMachineClass *nmc, const char *type) | ||
65 | { | ||
66 | NPCM7xxClass *sc = NPCM7XX_CLASS(object_class_by_name(type)); | ||
67 | @@ -XXX,XX +XXX,XX @@ static void gbs_bmc_machine_class_init(ObjectClass *oc, void *data) | ||
68 | mc->default_ram_size = 1 * GiB; | ||
69 | } | ||
70 | |||
71 | +static void kudo_bmc_machine_class_init(ObjectClass *oc, void *data) | ||
72 | +{ | ||
73 | + NPCM7xxMachineClass *nmc = NPCM7XX_MACHINE_CLASS(oc); | ||
74 | + MachineClass *mc = MACHINE_CLASS(oc); | ||
75 | + | ||
76 | + npcm7xx_set_soc_type(nmc, TYPE_NPCM730); | ||
77 | + | ||
78 | + mc->desc = "Kudo BMC (Cortex-A9)"; | ||
79 | + mc->init = kudo_bmc_init; | ||
80 | + mc->default_ram_size = 1 * GiB; | ||
81 | +}; | ||
82 | + | ||
83 | static const TypeInfo npcm7xx_machine_types[] = { | ||
25 | { | 84 | { |
26 | .name = TYPE_BCM2836, | 85 | .name = TYPE_NPCM7XX_MACHINE, |
27 | + .clusterid = 0xf, | 86 | @@ -XXX,XX +XXX,XX @@ static const TypeInfo npcm7xx_machine_types[] = { |
28 | }, | 87 | .name = MACHINE_TYPE_NAME("quanta-gbs-bmc"), |
29 | { | 88 | .parent = TYPE_NPCM7XX_MACHINE, |
30 | .name = TYPE_BCM2837, | 89 | .class_init = gbs_bmc_machine_class_init, |
31 | + .clusterid = 0x0, | 90 | + }, { |
91 | + .name = MACHINE_TYPE_NAME("kudo-bmc"), | ||
92 | + .parent = TYPE_NPCM7XX_MACHINE, | ||
93 | + .class_init = kudo_bmc_machine_class_init, | ||
32 | }, | 94 | }, |
33 | }; | 95 | }; |
34 | 96 | ||
35 | @@ -XXX,XX +XXX,XX @@ static void bcm2836_init(Object *obj) | ||
36 | static void bcm2836_realize(DeviceState *dev, Error **errp) | ||
37 | { | ||
38 | BCM283XState *s = BCM283X(dev); | ||
39 | + BCM283XClass *bc = BCM283X_GET_CLASS(dev); | ||
40 | + const BCM283XInfo *info = bc->info; | ||
41 | Object *obj; | ||
42 | Error *err = NULL; | ||
43 | int n; | ||
44 | @@ -XXX,XX +XXX,XX @@ static void bcm2836_realize(DeviceState *dev, Error **errp) | ||
45 | qdev_get_gpio_in_named(DEVICE(&s->control), "gpu-fiq", 0)); | ||
46 | |||
47 | for (n = 0; n < BCM283X_NCPUS; n++) { | ||
48 | - /* Mirror bcm2836, which has clusterid set to 0xf | ||
49 | - * TODO: this should be converted to a property of ARM_CPU | ||
50 | - */ | ||
51 | - s->cpus[n].mp_affinity = 0xF00 | n; | ||
52 | + /* TODO: this should be converted to a property of ARM_CPU */ | ||
53 | + s->cpus[n].mp_affinity = (info->clusterid << 8) | n; | ||
54 | |||
55 | /* set periphbase/CBAR value for CPU-local registers */ | ||
56 | object_property_set_int(OBJECT(&s->cpus[n]), | ||
57 | -- | 97 | -- |
58 | 2.16.2 | 98 | 2.20.1 |
59 | 99 | ||
60 | 100 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Shashi Mallela <shashi.mallela@linaro.org> | ||
1 | 2 | ||
3 | Added register definitions relevant to ITS,implemented overall | ||
4 | ITS device framework with stubs for ITS control and translater | ||
5 | regions read/write,extended ITS common to handle mmio init between | ||
6 | existing kvm device and newer qemu device. | ||
7 | |||
8 | Signed-off-by: Shashi Mallela <shashi.mallela@linaro.org> | ||
9 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
10 | Reviewed-by: Eric Auger <eric.auger@redhat.com> | ||
11 | Tested-by: Neil Armstrong <narmstrong@baylibre.com> | ||
12 | Message-id: 20210910143951.92242-2-shashi.mallela@linaro.org | ||
13 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
14 | --- | ||
15 | hw/intc/gicv3_internal.h | 96 +++++++++- | ||
16 | include/hw/intc/arm_gicv3_its_common.h | 9 +- | ||
17 | hw/intc/arm_gicv3_its.c | 241 +++++++++++++++++++++++++ | ||
18 | hw/intc/arm_gicv3_its_common.c | 7 +- | ||
19 | hw/intc/arm_gicv3_its_kvm.c | 2 +- | ||
20 | hw/intc/meson.build | 1 + | ||
21 | 6 files changed, 342 insertions(+), 14 deletions(-) | ||
22 | create mode 100644 hw/intc/arm_gicv3_its.c | ||
23 | |||
24 | diff --git a/hw/intc/gicv3_internal.h b/hw/intc/gicv3_internal.h | ||
25 | index XXXXXXX..XXXXXXX 100644 | ||
26 | --- a/hw/intc/gicv3_internal.h | ||
27 | +++ b/hw/intc/gicv3_internal.h | ||
28 | @@ -XXX,XX +XXX,XX @@ | ||
29 | #ifndef QEMU_ARM_GICV3_INTERNAL_H | ||
30 | #define QEMU_ARM_GICV3_INTERNAL_H | ||
31 | |||
32 | +#include "hw/registerfields.h" | ||
33 | #include "hw/intc/arm_gicv3_common.h" | ||
34 | |||
35 | /* Distributor registers, as offsets from the distributor base address */ | ||
36 | @@ -XXX,XX +XXX,XX @@ | ||
37 | #define GICD_CTLR_E1NWF (1U << 7) | ||
38 | #define GICD_CTLR_RWP (1U << 31) | ||
39 | |||
40 | +/* 16 bits EventId */ | ||
41 | +#define GICD_TYPER_IDBITS 0xf | ||
42 | + | ||
43 | /* | ||
44 | * Redistributor frame offsets from RD_base | ||
45 | */ | ||
46 | @@ -XXX,XX +XXX,XX @@ | ||
47 | #define GICR_WAKER_ProcessorSleep (1U << 1) | ||
48 | #define GICR_WAKER_ChildrenAsleep (1U << 2) | ||
49 | |||
50 | -#define GICR_PROPBASER_OUTER_CACHEABILITY_MASK (7ULL << 56) | ||
51 | -#define GICR_PROPBASER_ADDR_MASK (0xfffffffffULL << 12) | ||
52 | -#define GICR_PROPBASER_SHAREABILITY_MASK (3U << 10) | ||
53 | -#define GICR_PROPBASER_CACHEABILITY_MASK (7U << 7) | ||
54 | -#define GICR_PROPBASER_IDBITS_MASK (0x1f) | ||
55 | +FIELD(GICR_PROPBASER, IDBITS, 0, 5) | ||
56 | +FIELD(GICR_PROPBASER, INNERCACHE, 7, 3) | ||
57 | +FIELD(GICR_PROPBASER, SHAREABILITY, 10, 2) | ||
58 | +FIELD(GICR_PROPBASER, PHYADDR, 12, 40) | ||
59 | +FIELD(GICR_PROPBASER, OUTERCACHE, 56, 3) | ||
60 | |||
61 | -#define GICR_PENDBASER_PTZ (1ULL << 62) | ||
62 | -#define GICR_PENDBASER_OUTER_CACHEABILITY_MASK (7ULL << 56) | ||
63 | -#define GICR_PENDBASER_ADDR_MASK (0xffffffffULL << 16) | ||
64 | -#define GICR_PENDBASER_SHAREABILITY_MASK (3U << 10) | ||
65 | -#define GICR_PENDBASER_CACHEABILITY_MASK (7U << 7) | ||
66 | +FIELD(GICR_PENDBASER, INNERCACHE, 7, 3) | ||
67 | +FIELD(GICR_PENDBASER, SHAREABILITY, 10, 2) | ||
68 | +FIELD(GICR_PENDBASER, PHYADDR, 16, 36) | ||
69 | +FIELD(GICR_PENDBASER, OUTERCACHE, 56, 3) | ||
70 | +FIELD(GICR_PENDBASER, PTZ, 62, 1) | ||
71 | |||
72 | #define ICC_CTLR_EL1_CBPR (1U << 0) | ||
73 | #define ICC_CTLR_EL1_EOIMODE (1U << 1) | ||
74 | @@ -XXX,XX +XXX,XX @@ | ||
75 | #define ICH_VTR_EL2_PREBITS_SHIFT 26 | ||
76 | #define ICH_VTR_EL2_PRIBITS_SHIFT 29 | ||
77 | |||
78 | +/* ITS Registers */ | ||
79 | + | ||
80 | +FIELD(GITS_BASER, SIZE, 0, 8) | ||
81 | +FIELD(GITS_BASER, PAGESIZE, 8, 2) | ||
82 | +FIELD(GITS_BASER, SHAREABILITY, 10, 2) | ||
83 | +FIELD(GITS_BASER, PHYADDR, 12, 36) | ||
84 | +FIELD(GITS_BASER, PHYADDRL_64K, 16, 32) | ||
85 | +FIELD(GITS_BASER, PHYADDRH_64K, 12, 4) | ||
86 | +FIELD(GITS_BASER, ENTRYSIZE, 48, 5) | ||
87 | +FIELD(GITS_BASER, OUTERCACHE, 53, 3) | ||
88 | +FIELD(GITS_BASER, TYPE, 56, 3) | ||
89 | +FIELD(GITS_BASER, INNERCACHE, 59, 3) | ||
90 | +FIELD(GITS_BASER, INDIRECT, 62, 1) | ||
91 | +FIELD(GITS_BASER, VALID, 63, 1) | ||
92 | + | ||
93 | +FIELD(GITS_CTLR, QUIESCENT, 31, 1) | ||
94 | + | ||
95 | +FIELD(GITS_TYPER, PHYSICAL, 0, 1) | ||
96 | +FIELD(GITS_TYPER, ITT_ENTRY_SIZE, 4, 4) | ||
97 | +FIELD(GITS_TYPER, IDBITS, 8, 5) | ||
98 | +FIELD(GITS_TYPER, DEVBITS, 13, 5) | ||
99 | +FIELD(GITS_TYPER, SEIS, 18, 1) | ||
100 | +FIELD(GITS_TYPER, PTA, 19, 1) | ||
101 | +FIELD(GITS_TYPER, CIDBITS, 32, 4) | ||
102 | +FIELD(GITS_TYPER, CIL, 36, 1) | ||
103 | + | ||
104 | +#define GITS_BASER_PAGESIZE_4K 0 | ||
105 | +#define GITS_BASER_PAGESIZE_16K 1 | ||
106 | +#define GITS_BASER_PAGESIZE_64K 2 | ||
107 | + | ||
108 | +#define GITS_BASER_TYPE_DEVICE 1ULL | ||
109 | +#define GITS_BASER_TYPE_COLLECTION 4ULL | ||
110 | + | ||
111 | +/** | ||
112 | + * Default features advertised by this version of ITS | ||
113 | + */ | ||
114 | +/* Physical LPIs supported */ | ||
115 | +#define GITS_TYPE_PHYSICAL (1U << 0) | ||
116 | + | ||
117 | +/* | ||
118 | + * 12 bytes Interrupt translation Table Entry size | ||
119 | + * as per Table 5.3 in GICv3 spec | ||
120 | + * ITE Lower 8 Bytes | ||
121 | + * Bits: | 49 ... 26 | 25 ... 2 | 1 | 0 | | ||
122 | + * Values: | 1023 | IntNum | IntType | Valid | | ||
123 | + * ITE Higher 4 Bytes | ||
124 | + * Bits: | 31 ... 16 | 15 ...0 | | ||
125 | + * Values: | vPEID | ICID | | ||
126 | + */ | ||
127 | +#define ITS_ITT_ENTRY_SIZE 0xC | ||
128 | + | ||
129 | +/* 16 bits EventId */ | ||
130 | +#define ITS_IDBITS GICD_TYPER_IDBITS | ||
131 | + | ||
132 | +/* 16 bits DeviceId */ | ||
133 | +#define ITS_DEVBITS 0xF | ||
134 | + | ||
135 | +/* 16 bits CollectionId */ | ||
136 | +#define ITS_CIDBITS 0xF | ||
137 | + | ||
138 | +/* | ||
139 | + * 8 bytes Device Table Entry size | ||
140 | + * Valid = 1 bit,ITTAddr = 44 bits,Size = 5 bits | ||
141 | + */ | ||
142 | +#define GITS_DTE_SIZE (0x8ULL) | ||
143 | + | ||
144 | +/* | ||
145 | + * 8 bytes Collection Table Entry size | ||
146 | + * Valid = 1 bit,RDBase = 36 bits(considering max RDBASE) | ||
147 | + */ | ||
148 | +#define GITS_CTE_SIZE (0x8ULL) | ||
149 | + | ||
150 | /* Special interrupt IDs */ | ||
151 | #define INTID_SECURE 1020 | ||
152 | #define INTID_NONSECURE 1021 | ||
153 | diff --git a/include/hw/intc/arm_gicv3_its_common.h b/include/hw/intc/arm_gicv3_its_common.h | ||
154 | index XXXXXXX..XXXXXXX 100644 | ||
155 | --- a/include/hw/intc/arm_gicv3_its_common.h | ||
156 | +++ b/include/hw/intc/arm_gicv3_its_common.h | ||
157 | @@ -XXX,XX +XXX,XX @@ | ||
158 | #include "hw/intc/arm_gicv3_common.h" | ||
159 | #include "qom/object.h" | ||
160 | |||
161 | +#define TYPE_ARM_GICV3_ITS "arm-gicv3-its" | ||
162 | + | ||
163 | #define ITS_CONTROL_SIZE 0x10000 | ||
164 | #define ITS_TRANS_SIZE 0x10000 | ||
165 | #define ITS_SIZE (ITS_CONTROL_SIZE + ITS_TRANS_SIZE) | ||
166 | |||
167 | #define GITS_CTLR 0x0 | ||
168 | #define GITS_IIDR 0x4 | ||
169 | +#define GITS_TYPER 0x8 | ||
170 | #define GITS_CBASER 0x80 | ||
171 | #define GITS_CWRITER 0x88 | ||
172 | #define GITS_CREADR 0x90 | ||
173 | #define GITS_BASER 0x100 | ||
174 | |||
175 | +#define GITS_TRANSLATER 0x0040 | ||
176 | + | ||
177 | struct GICv3ITSState { | ||
178 | SysBusDevice parent_obj; | ||
179 | |||
180 | @@ -XXX,XX +XXX,XX @@ struct GICv3ITSState { | ||
181 | /* Registers */ | ||
182 | uint32_t ctlr; | ||
183 | uint32_t iidr; | ||
184 | + uint64_t typer; | ||
185 | uint64_t cbaser; | ||
186 | uint64_t cwriter; | ||
187 | uint64_t creadr; | ||
188 | @@ -XXX,XX +XXX,XX @@ struct GICv3ITSState { | ||
189 | |||
190 | typedef struct GICv3ITSState GICv3ITSState; | ||
191 | |||
192 | -void gicv3_its_init_mmio(GICv3ITSState *s, const MemoryRegionOps *ops); | ||
193 | +void gicv3_its_init_mmio(GICv3ITSState *s, const MemoryRegionOps *ops, | ||
194 | + const MemoryRegionOps *tops); | ||
195 | |||
196 | #define TYPE_ARM_GICV3_ITS_COMMON "arm-gicv3-its-common" | ||
197 | typedef struct GICv3ITSCommonClass GICv3ITSCommonClass; | ||
198 | diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c | ||
199 | new file mode 100644 | ||
200 | index XXXXXXX..XXXXXXX | ||
201 | --- /dev/null | ||
202 | +++ b/hw/intc/arm_gicv3_its.c | ||
203 | @@ -XXX,XX +XXX,XX @@ | ||
204 | +/* | ||
205 | + * ITS emulation for a GICv3-based system | ||
206 | + * | ||
207 | + * Copyright Linaro.org 2021 | ||
208 | + * | ||
209 | + * Authors: | ||
210 | + * Shashi Mallela <shashi.mallela@linaro.org> | ||
211 | + * | ||
212 | + * This work is licensed under the terms of the GNU GPL, version 2 or (at your | ||
213 | + * option) any later version. See the COPYING file in the top-level directory. | ||
214 | + * | ||
215 | + */ | ||
216 | + | ||
217 | +#include "qemu/osdep.h" | ||
218 | +#include "qemu/log.h" | ||
219 | +#include "hw/qdev-properties.h" | ||
220 | +#include "hw/intc/arm_gicv3_its_common.h" | ||
221 | +#include "gicv3_internal.h" | ||
222 | +#include "qom/object.h" | ||
223 | +#include "qapi/error.h" | ||
224 | + | ||
225 | +typedef struct GICv3ITSClass GICv3ITSClass; | ||
226 | +/* This is reusing the GICv3ITSState typedef from ARM_GICV3_ITS_COMMON */ | ||
227 | +DECLARE_OBJ_CHECKERS(GICv3ITSState, GICv3ITSClass, | ||
228 | + ARM_GICV3_ITS, TYPE_ARM_GICV3_ITS) | ||
229 | + | ||
230 | +struct GICv3ITSClass { | ||
231 | + GICv3ITSCommonClass parent_class; | ||
232 | + void (*parent_reset)(DeviceState *dev); | ||
233 | +}; | ||
234 | + | ||
235 | +static MemTxResult gicv3_its_translation_write(void *opaque, hwaddr offset, | ||
236 | + uint64_t data, unsigned size, | ||
237 | + MemTxAttrs attrs) | ||
238 | +{ | ||
239 | + return MEMTX_OK; | ||
240 | +} | ||
241 | + | ||
242 | +static bool its_writel(GICv3ITSState *s, hwaddr offset, | ||
243 | + uint64_t value, MemTxAttrs attrs) | ||
244 | +{ | ||
245 | + bool result = true; | ||
246 | + | ||
247 | + return result; | ||
248 | +} | ||
249 | + | ||
250 | +static bool its_readl(GICv3ITSState *s, hwaddr offset, | ||
251 | + uint64_t *data, MemTxAttrs attrs) | ||
252 | +{ | ||
253 | + bool result = true; | ||
254 | + | ||
255 | + return result; | ||
256 | +} | ||
257 | + | ||
258 | +static bool its_writell(GICv3ITSState *s, hwaddr offset, | ||
259 | + uint64_t value, MemTxAttrs attrs) | ||
260 | +{ | ||
261 | + bool result = true; | ||
262 | + | ||
263 | + return result; | ||
264 | +} | ||
265 | + | ||
266 | +static bool its_readll(GICv3ITSState *s, hwaddr offset, | ||
267 | + uint64_t *data, MemTxAttrs attrs) | ||
268 | +{ | ||
269 | + bool result = true; | ||
270 | + | ||
271 | + return result; | ||
272 | +} | ||
273 | + | ||
274 | +static MemTxResult gicv3_its_read(void *opaque, hwaddr offset, uint64_t *data, | ||
275 | + unsigned size, MemTxAttrs attrs) | ||
276 | +{ | ||
277 | + GICv3ITSState *s = (GICv3ITSState *)opaque; | ||
278 | + bool result; | ||
279 | + | ||
280 | + switch (size) { | ||
281 | + case 4: | ||
282 | + result = its_readl(s, offset, data, attrs); | ||
283 | + break; | ||
284 | + case 8: | ||
285 | + result = its_readll(s, offset, data, attrs); | ||
286 | + break; | ||
287 | + default: | ||
288 | + result = false; | ||
289 | + break; | ||
290 | + } | ||
291 | + | ||
292 | + if (!result) { | ||
293 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
294 | + "%s: invalid guest read at offset " TARGET_FMT_plx | ||
295 | + "size %u\n", __func__, offset, size); | ||
296 | + /* | ||
297 | + * The spec requires that reserved registers are RAZ/WI; | ||
298 | + * so use false returns from leaf functions as a way to | ||
299 | + * trigger the guest-error logging but don't return it to | ||
300 | + * the caller, or we'll cause a spurious guest data abort. | ||
301 | + */ | ||
302 | + *data = 0; | ||
303 | + } | ||
304 | + return MEMTX_OK; | ||
305 | +} | ||
306 | + | ||
307 | +static MemTxResult gicv3_its_write(void *opaque, hwaddr offset, uint64_t data, | ||
308 | + unsigned size, MemTxAttrs attrs) | ||
309 | +{ | ||
310 | + GICv3ITSState *s = (GICv3ITSState *)opaque; | ||
311 | + bool result; | ||
312 | + | ||
313 | + switch (size) { | ||
314 | + case 4: | ||
315 | + result = its_writel(s, offset, data, attrs); | ||
316 | + break; | ||
317 | + case 8: | ||
318 | + result = its_writell(s, offset, data, attrs); | ||
319 | + break; | ||
320 | + default: | ||
321 | + result = false; | ||
322 | + break; | ||
323 | + } | ||
324 | + | ||
325 | + if (!result) { | ||
326 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
327 | + "%s: invalid guest write at offset " TARGET_FMT_plx | ||
328 | + "size %u\n", __func__, offset, size); | ||
329 | + /* | ||
330 | + * The spec requires that reserved registers are RAZ/WI; | ||
331 | + * so use false returns from leaf functions as a way to | ||
332 | + * trigger the guest-error logging but don't return it to | ||
333 | + * the caller, or we'll cause a spurious guest data abort. | ||
334 | + */ | ||
335 | + } | ||
336 | + return MEMTX_OK; | ||
337 | +} | ||
338 | + | ||
339 | +static const MemoryRegionOps gicv3_its_control_ops = { | ||
340 | + .read_with_attrs = gicv3_its_read, | ||
341 | + .write_with_attrs = gicv3_its_write, | ||
342 | + .valid.min_access_size = 4, | ||
343 | + .valid.max_access_size = 8, | ||
344 | + .impl.min_access_size = 4, | ||
345 | + .impl.max_access_size = 8, | ||
346 | + .endianness = DEVICE_NATIVE_ENDIAN, | ||
347 | +}; | ||
348 | + | ||
349 | +static const MemoryRegionOps gicv3_its_translation_ops = { | ||
350 | + .write_with_attrs = gicv3_its_translation_write, | ||
351 | + .valid.min_access_size = 2, | ||
352 | + .valid.max_access_size = 4, | ||
353 | + .impl.min_access_size = 2, | ||
354 | + .impl.max_access_size = 4, | ||
355 | + .endianness = DEVICE_NATIVE_ENDIAN, | ||
356 | +}; | ||
357 | + | ||
358 | +static void gicv3_arm_its_realize(DeviceState *dev, Error **errp) | ||
359 | +{ | ||
360 | + GICv3ITSState *s = ARM_GICV3_ITS_COMMON(dev); | ||
361 | + int i; | ||
362 | + | ||
363 | + for (i = 0; i < s->gicv3->num_cpu; i++) { | ||
364 | + if (!(s->gicv3->cpu[i].gicr_typer & GICR_TYPER_PLPIS)) { | ||
365 | + error_setg(errp, "Physical LPI not supported by CPU %d", i); | ||
366 | + return; | ||
367 | + } | ||
368 | + } | ||
369 | + | ||
370 | + gicv3_its_init_mmio(s, &gicv3_its_control_ops, &gicv3_its_translation_ops); | ||
371 | + | ||
372 | + /* set the ITS default features supported */ | ||
373 | + s->typer = FIELD_DP64(s->typer, GITS_TYPER, PHYSICAL, | ||
374 | + GITS_TYPE_PHYSICAL); | ||
375 | + s->typer = FIELD_DP64(s->typer, GITS_TYPER, ITT_ENTRY_SIZE, | ||
376 | + ITS_ITT_ENTRY_SIZE - 1); | ||
377 | + s->typer = FIELD_DP64(s->typer, GITS_TYPER, IDBITS, ITS_IDBITS); | ||
378 | + s->typer = FIELD_DP64(s->typer, GITS_TYPER, DEVBITS, ITS_DEVBITS); | ||
379 | + s->typer = FIELD_DP64(s->typer, GITS_TYPER, CIL, 1); | ||
380 | + s->typer = FIELD_DP64(s->typer, GITS_TYPER, CIDBITS, ITS_CIDBITS); | ||
381 | +} | ||
382 | + | ||
383 | +static void gicv3_its_reset(DeviceState *dev) | ||
384 | +{ | ||
385 | + GICv3ITSState *s = ARM_GICV3_ITS_COMMON(dev); | ||
386 | + GICv3ITSClass *c = ARM_GICV3_ITS_GET_CLASS(s); | ||
387 | + | ||
388 | + c->parent_reset(dev); | ||
389 | + | ||
390 | + /* Quiescent bit reset to 1 */ | ||
391 | + s->ctlr = FIELD_DP32(s->ctlr, GITS_CTLR, QUIESCENT, 1); | ||
392 | + | ||
393 | + /* | ||
394 | + * setting GITS_BASER0.Type = 0b001 (Device) | ||
395 | + * GITS_BASER1.Type = 0b100 (Collection Table) | ||
396 | + * GITS_BASER<n>.Type,where n = 3 to 7 are 0b00 (Unimplemented) | ||
397 | + * GITS_BASER<0,1>.Page_Size = 64KB | ||
398 | + * and default translation table entry size to 16 bytes | ||
399 | + */ | ||
400 | + s->baser[0] = FIELD_DP64(s->baser[0], GITS_BASER, TYPE, | ||
401 | + GITS_BASER_TYPE_DEVICE); | ||
402 | + s->baser[0] = FIELD_DP64(s->baser[0], GITS_BASER, PAGESIZE, | ||
403 | + GITS_BASER_PAGESIZE_64K); | ||
404 | + s->baser[0] = FIELD_DP64(s->baser[0], GITS_BASER, ENTRYSIZE, | ||
405 | + GITS_DTE_SIZE - 1); | ||
406 | + | ||
407 | + s->baser[1] = FIELD_DP64(s->baser[1], GITS_BASER, TYPE, | ||
408 | + GITS_BASER_TYPE_COLLECTION); | ||
409 | + s->baser[1] = FIELD_DP64(s->baser[1], GITS_BASER, PAGESIZE, | ||
410 | + GITS_BASER_PAGESIZE_64K); | ||
411 | + s->baser[1] = FIELD_DP64(s->baser[1], GITS_BASER, ENTRYSIZE, | ||
412 | + GITS_CTE_SIZE - 1); | ||
413 | +} | ||
414 | + | ||
415 | +static Property gicv3_its_props[] = { | ||
416 | + DEFINE_PROP_LINK("parent-gicv3", GICv3ITSState, gicv3, "arm-gicv3", | ||
417 | + GICv3State *), | ||
418 | + DEFINE_PROP_END_OF_LIST(), | ||
419 | +}; | ||
420 | + | ||
421 | +static void gicv3_its_class_init(ObjectClass *klass, void *data) | ||
422 | +{ | ||
423 | + DeviceClass *dc = DEVICE_CLASS(klass); | ||
424 | + GICv3ITSClass *ic = ARM_GICV3_ITS_CLASS(klass); | ||
425 | + | ||
426 | + dc->realize = gicv3_arm_its_realize; | ||
427 | + device_class_set_props(dc, gicv3_its_props); | ||
428 | + device_class_set_parent_reset(dc, gicv3_its_reset, &ic->parent_reset); | ||
429 | +} | ||
430 | + | ||
431 | +static const TypeInfo gicv3_its_info = { | ||
432 | + .name = TYPE_ARM_GICV3_ITS, | ||
433 | + .parent = TYPE_ARM_GICV3_ITS_COMMON, | ||
434 | + .instance_size = sizeof(GICv3ITSState), | ||
435 | + .class_init = gicv3_its_class_init, | ||
436 | + .class_size = sizeof(GICv3ITSClass), | ||
437 | +}; | ||
438 | + | ||
439 | +static void gicv3_its_register_types(void) | ||
440 | +{ | ||
441 | + type_register_static(&gicv3_its_info); | ||
442 | +} | ||
443 | + | ||
444 | +type_init(gicv3_its_register_types) | ||
445 | diff --git a/hw/intc/arm_gicv3_its_common.c b/hw/intc/arm_gicv3_its_common.c | ||
446 | index XXXXXXX..XXXXXXX 100644 | ||
447 | --- a/hw/intc/arm_gicv3_its_common.c | ||
448 | +++ b/hw/intc/arm_gicv3_its_common.c | ||
449 | @@ -XXX,XX +XXX,XX @@ static int gicv3_its_post_load(void *opaque, int version_id) | ||
450 | |||
451 | static const VMStateDescription vmstate_its = { | ||
452 | .name = "arm_gicv3_its", | ||
453 | + .version_id = 1, | ||
454 | + .minimum_version_id = 1, | ||
455 | .pre_save = gicv3_its_pre_save, | ||
456 | .post_load = gicv3_its_post_load, | ||
457 | .priority = MIG_PRI_GICV3_ITS, | ||
458 | @@ -XXX,XX +XXX,XX @@ static const MemoryRegionOps gicv3_its_trans_ops = { | ||
459 | .endianness = DEVICE_NATIVE_ENDIAN, | ||
460 | }; | ||
461 | |||
462 | -void gicv3_its_init_mmio(GICv3ITSState *s, const MemoryRegionOps *ops) | ||
463 | +void gicv3_its_init_mmio(GICv3ITSState *s, const MemoryRegionOps *ops, | ||
464 | + const MemoryRegionOps *tops) | ||
465 | { | ||
466 | SysBusDevice *sbd = SYS_BUS_DEVICE(s); | ||
467 | |||
468 | memory_region_init_io(&s->iomem_its_cntrl, OBJECT(s), ops, s, | ||
469 | "control", ITS_CONTROL_SIZE); | ||
470 | memory_region_init_io(&s->iomem_its_translation, OBJECT(s), | ||
471 | - &gicv3_its_trans_ops, s, | ||
472 | + tops ? tops : &gicv3_its_trans_ops, s, | ||
473 | "translation", ITS_TRANS_SIZE); | ||
474 | |||
475 | /* Our two regions are always adjacent, therefore we now combine them | ||
476 | diff --git a/hw/intc/arm_gicv3_its_kvm.c b/hw/intc/arm_gicv3_its_kvm.c | ||
477 | index XXXXXXX..XXXXXXX 100644 | ||
478 | --- a/hw/intc/arm_gicv3_its_kvm.c | ||
479 | +++ b/hw/intc/arm_gicv3_its_kvm.c | ||
480 | @@ -XXX,XX +XXX,XX @@ static void kvm_arm_its_realize(DeviceState *dev, Error **errp) | ||
481 | kvm_arm_register_device(&s->iomem_its_cntrl, -1, KVM_DEV_ARM_VGIC_GRP_ADDR, | ||
482 | KVM_VGIC_ITS_ADDR_TYPE, s->dev_fd, 0); | ||
483 | |||
484 | - gicv3_its_init_mmio(s, NULL); | ||
485 | + gicv3_its_init_mmio(s, NULL, NULL); | ||
486 | |||
487 | if (!kvm_device_check_attr(s->dev_fd, KVM_DEV_ARM_VGIC_GRP_ITS_REGS, | ||
488 | GITS_CTLR)) { | ||
489 | diff --git a/hw/intc/meson.build b/hw/intc/meson.build | ||
490 | index XXXXXXX..XXXXXXX 100644 | ||
491 | --- a/hw/intc/meson.build | ||
492 | +++ b/hw/intc/meson.build | ||
493 | @@ -XXX,XX +XXX,XX @@ softmmu_ss.add(when: 'CONFIG_ARM_GIC', if_true: files( | ||
494 | 'arm_gicv3_dist.c', | ||
495 | 'arm_gicv3_its_common.c', | ||
496 | 'arm_gicv3_redist.c', | ||
497 | + 'arm_gicv3_its.c', | ||
498 | )) | ||
499 | softmmu_ss.add(when: 'CONFIG_ETRAXFS', if_true: files('etraxfs_pic.c')) | ||
500 | softmmu_ss.add(when: 'CONFIG_HEATHROW_PIC', if_true: files('heathrow_pic.c')) | ||
501 | -- | ||
502 | 2.20.1 | ||
503 | |||
504 | diff view generated by jsdifflib |
1 | Now we have separate types for BCM2386 and BCM2387, we might as well | 1 | From: Shashi Mallela <shashi.mallela@linaro.org> |
---|---|---|---|
2 | just hard-code the CPU type they use rather than having it passed | ||
3 | through as an object property. This then lets us put the initialization | ||
4 | of the CPU object in init rather than realize. | ||
5 | 2 | ||
6 | Note that this change means that it's no longer possible on | 3 | Defined descriptors for ITS device table,collection table and ITS |
7 | the command line to use -cpu to ask for a different kind of | 4 | command queue entities.Implemented register read/write functions, |
8 | CPU than the SoC supports. This was never a supported thing to | 5 | extract ITS table parameters and command queue parameters,extended |
9 | do anyway; we were just not sanity-checking the command line. | 6 | gicv3 common to capture qemu address space(which host the ITS table |
7 | platform memories required for subsequent ITS processing) and | ||
8 | initialize the same in ITS device. | ||
10 | 9 | ||
11 | This does require us to only build the bcm2837 object on | 10 | Signed-off-by: Shashi Mallela <shashi.mallela@linaro.org> |
12 | TARGET_AARCH64 configs, since otherwise it won't instantiate | 11 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> |
13 | due to the missing cortex-a53 device and "make check" will fail. | 12 | Reviewed-by: Eric Auger <eric.auger@redhat.com> |
13 | Tested-by: Neil Armstrong <narmstrong@baylibre.com> | ||
14 | Message-id: 20210910143951.92242-3-shashi.mallela@linaro.org | ||
15 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
16 | --- | ||
17 | hw/intc/gicv3_internal.h | 29 ++ | ||
18 | include/hw/intc/arm_gicv3_common.h | 3 + | ||
19 | include/hw/intc/arm_gicv3_its_common.h | 23 ++ | ||
20 | hw/intc/arm_gicv3_its.c | 376 +++++++++++++++++++++++++ | ||
21 | 4 files changed, 431 insertions(+) | ||
14 | 22 | ||
15 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 23 | diff --git a/hw/intc/gicv3_internal.h b/hw/intc/gicv3_internal.h |
16 | Reviewed-by: Andrew Baumann <Andrew.Baumann@microsoft.com> | ||
17 | Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | ||
18 | Message-id: 20180313153458.26822-9-peter.maydell@linaro.org | ||
19 | --- | ||
20 | hw/arm/bcm2836.c | 24 +++++++++++++++--------- | ||
21 | hw/arm/raspi.c | 2 -- | ||
22 | 2 files changed, 15 insertions(+), 11 deletions(-) | ||
23 | |||
24 | diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c | ||
25 | index XXXXXXX..XXXXXXX 100644 | 24 | index XXXXXXX..XXXXXXX 100644 |
26 | --- a/hw/arm/bcm2836.c | 25 | --- a/hw/intc/gicv3_internal.h |
27 | +++ b/hw/arm/bcm2836.c | 26 | +++ b/hw/intc/gicv3_internal.h |
27 | @@ -XXX,XX +XXX,XX @@ FIELD(GITS_BASER, INNERCACHE, 59, 3) | ||
28 | FIELD(GITS_BASER, INDIRECT, 62, 1) | ||
29 | FIELD(GITS_BASER, VALID, 63, 1) | ||
30 | |||
31 | +FIELD(GITS_CBASER, SIZE, 0, 8) | ||
32 | +FIELD(GITS_CBASER, SHAREABILITY, 10, 2) | ||
33 | +FIELD(GITS_CBASER, PHYADDR, 12, 40) | ||
34 | +FIELD(GITS_CBASER, OUTERCACHE, 53, 3) | ||
35 | +FIELD(GITS_CBASER, INNERCACHE, 59, 3) | ||
36 | +FIELD(GITS_CBASER, VALID, 63, 1) | ||
37 | + | ||
38 | +FIELD(GITS_CREADR, STALLED, 0, 1) | ||
39 | +FIELD(GITS_CREADR, OFFSET, 5, 15) | ||
40 | + | ||
41 | +FIELD(GITS_CWRITER, RETRY, 0, 1) | ||
42 | +FIELD(GITS_CWRITER, OFFSET, 5, 15) | ||
43 | + | ||
44 | +FIELD(GITS_CTLR, ENABLED, 0, 1) | ||
45 | FIELD(GITS_CTLR, QUIESCENT, 31, 1) | ||
46 | |||
47 | FIELD(GITS_TYPER, PHYSICAL, 0, 1) | ||
48 | @@ -XXX,XX +XXX,XX @@ FIELD(GITS_TYPER, PTA, 19, 1) | ||
49 | FIELD(GITS_TYPER, CIDBITS, 32, 4) | ||
50 | FIELD(GITS_TYPER, CIL, 36, 1) | ||
51 | |||
52 | +#define GITS_IDREGS 0xFFD0 | ||
53 | + | ||
54 | +#define ITS_CTLR_ENABLED (1U) /* ITS Enabled */ | ||
55 | + | ||
56 | +#define GITS_BASER_RO_MASK (R_GITS_BASER_ENTRYSIZE_MASK | \ | ||
57 | + R_GITS_BASER_TYPE_MASK) | ||
58 | + | ||
59 | #define GITS_BASER_PAGESIZE_4K 0 | ||
60 | #define GITS_BASER_PAGESIZE_16K 1 | ||
61 | #define GITS_BASER_PAGESIZE_64K 2 | ||
62 | @@ -XXX,XX +XXX,XX @@ FIELD(GITS_TYPER, CIL, 36, 1) | ||
63 | #define GITS_BASER_TYPE_DEVICE 1ULL | ||
64 | #define GITS_BASER_TYPE_COLLECTION 4ULL | ||
65 | |||
66 | +#define GITS_PAGE_SIZE_4K 0x1000 | ||
67 | +#define GITS_PAGE_SIZE_16K 0x4000 | ||
68 | +#define GITS_PAGE_SIZE_64K 0x10000 | ||
69 | + | ||
70 | +#define L1TABLE_ENTRY_SIZE 8 | ||
71 | + | ||
72 | +#define GITS_CMDQ_ENTRY_SIZE 32 | ||
73 | + | ||
74 | /** | ||
75 | * Default features advertised by this version of ITS | ||
76 | */ | ||
77 | diff --git a/include/hw/intc/arm_gicv3_common.h b/include/hw/intc/arm_gicv3_common.h | ||
78 | index XXXXXXX..XXXXXXX 100644 | ||
79 | --- a/include/hw/intc/arm_gicv3_common.h | ||
80 | +++ b/include/hw/intc/arm_gicv3_common.h | ||
81 | @@ -XXX,XX +XXX,XX @@ struct GICv3State { | ||
82 | int dev_fd; /* kvm device fd if backed by kvm vgic support */ | ||
83 | Error *migration_blocker; | ||
84 | |||
85 | + MemoryRegion *dma; | ||
86 | + AddressSpace dma_as; | ||
87 | + | ||
88 | /* Distributor */ | ||
89 | |||
90 | /* for a GIC with the security extensions the NS banked version of this | ||
91 | diff --git a/include/hw/intc/arm_gicv3_its_common.h b/include/hw/intc/arm_gicv3_its_common.h | ||
92 | index XXXXXXX..XXXXXXX 100644 | ||
93 | --- a/include/hw/intc/arm_gicv3_its_common.h | ||
94 | +++ b/include/hw/intc/arm_gicv3_its_common.h | ||
28 | @@ -XXX,XX +XXX,XX @@ | 95 | @@ -XXX,XX +XXX,XX @@ |
29 | 96 | ||
30 | struct BCM283XInfo { | 97 | #define GITS_TRANSLATER 0x0040 |
31 | const char *name; | 98 | |
32 | + const char *cpu_type; | 99 | +typedef struct { |
33 | int clusterid; | 100 | + bool valid; |
101 | + bool indirect; | ||
102 | + uint16_t entry_sz; | ||
103 | + uint32_t page_sz; | ||
104 | + uint32_t max_entries; | ||
105 | + union { | ||
106 | + uint32_t max_devids; | ||
107 | + uint32_t max_collids; | ||
108 | + } maxids; | ||
109 | + uint64_t base_addr; | ||
110 | +} TableDesc; | ||
111 | + | ||
112 | +typedef struct { | ||
113 | + bool valid; | ||
114 | + uint32_t max_entries; | ||
115 | + uint64_t base_addr; | ||
116 | +} CmdQDesc; | ||
117 | + | ||
118 | struct GICv3ITSState { | ||
119 | SysBusDevice parent_obj; | ||
120 | |||
121 | @@ -XXX,XX +XXX,XX @@ struct GICv3ITSState { | ||
122 | uint64_t creadr; | ||
123 | uint64_t baser[8]; | ||
124 | |||
125 | + TableDesc dt; | ||
126 | + TableDesc ct; | ||
127 | + CmdQDesc cq; | ||
128 | + | ||
129 | Error *migration_blocker; | ||
34 | }; | 130 | }; |
35 | 131 | ||
36 | static const BCM283XInfo bcm283x_socs[] = { | 132 | diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c |
37 | { | 133 | index XXXXXXX..XXXXXXX 100644 |
38 | .name = TYPE_BCM2836, | 134 | --- a/hw/intc/arm_gicv3_its.c |
39 | + .cpu_type = ARM_CPU_TYPE_NAME("cortex-a15"), | 135 | +++ b/hw/intc/arm_gicv3_its.c |
40 | .clusterid = 0xf, | 136 | @@ -XXX,XX +XXX,XX @@ struct GICv3ITSClass { |
41 | }, | 137 | void (*parent_reset)(DeviceState *dev); |
42 | +#ifdef TARGET_AARCH64 | ||
43 | { | ||
44 | .name = TYPE_BCM2837, | ||
45 | + .cpu_type = ARM_CPU_TYPE_NAME("cortex-a53"), | ||
46 | .clusterid = 0x0, | ||
47 | }, | ||
48 | +#endif | ||
49 | }; | 138 | }; |
50 | 139 | ||
51 | static void bcm2836_init(Object *obj) | 140 | +static uint64_t baser_base_addr(uint64_t value, uint32_t page_sz) |
141 | +{ | ||
142 | + uint64_t result = 0; | ||
143 | + | ||
144 | + switch (page_sz) { | ||
145 | + case GITS_PAGE_SIZE_4K: | ||
146 | + case GITS_PAGE_SIZE_16K: | ||
147 | + result = FIELD_EX64(value, GITS_BASER, PHYADDR) << 12; | ||
148 | + break; | ||
149 | + | ||
150 | + case GITS_PAGE_SIZE_64K: | ||
151 | + result = FIELD_EX64(value, GITS_BASER, PHYADDRL_64K) << 16; | ||
152 | + result |= FIELD_EX64(value, GITS_BASER, PHYADDRH_64K) << 48; | ||
153 | + break; | ||
154 | + | ||
155 | + default: | ||
156 | + break; | ||
157 | + } | ||
158 | + return result; | ||
159 | +} | ||
160 | + | ||
161 | +/* | ||
162 | + * This function extracts the ITS Device and Collection table specific | ||
163 | + * parameters (like base_addr, size etc) from GITS_BASER register. | ||
164 | + * It is called during ITS enable and also during post_load migration | ||
165 | + */ | ||
166 | +static void extract_table_params(GICv3ITSState *s) | ||
167 | +{ | ||
168 | + uint16_t num_pages = 0; | ||
169 | + uint8_t page_sz_type; | ||
170 | + uint8_t type; | ||
171 | + uint32_t page_sz = 0; | ||
172 | + uint64_t value; | ||
173 | + | ||
174 | + for (int i = 0; i < 8; i++) { | ||
175 | + value = s->baser[i]; | ||
176 | + | ||
177 | + if (!value) { | ||
178 | + continue; | ||
179 | + } | ||
180 | + | ||
181 | + page_sz_type = FIELD_EX64(value, GITS_BASER, PAGESIZE); | ||
182 | + | ||
183 | + switch (page_sz_type) { | ||
184 | + case 0: | ||
185 | + page_sz = GITS_PAGE_SIZE_4K; | ||
186 | + break; | ||
187 | + | ||
188 | + case 1: | ||
189 | + page_sz = GITS_PAGE_SIZE_16K; | ||
190 | + break; | ||
191 | + | ||
192 | + case 2: | ||
193 | + case 3: | ||
194 | + page_sz = GITS_PAGE_SIZE_64K; | ||
195 | + break; | ||
196 | + | ||
197 | + default: | ||
198 | + g_assert_not_reached(); | ||
199 | + } | ||
200 | + | ||
201 | + num_pages = FIELD_EX64(value, GITS_BASER, SIZE) + 1; | ||
202 | + | ||
203 | + type = FIELD_EX64(value, GITS_BASER, TYPE); | ||
204 | + | ||
205 | + switch (type) { | ||
206 | + | ||
207 | + case GITS_BASER_TYPE_DEVICE: | ||
208 | + memset(&s->dt, 0 , sizeof(s->dt)); | ||
209 | + s->dt.valid = FIELD_EX64(value, GITS_BASER, VALID); | ||
210 | + | ||
211 | + if (!s->dt.valid) { | ||
212 | + return; | ||
213 | + } | ||
214 | + | ||
215 | + s->dt.page_sz = page_sz; | ||
216 | + s->dt.indirect = FIELD_EX64(value, GITS_BASER, INDIRECT); | ||
217 | + s->dt.entry_sz = FIELD_EX64(value, GITS_BASER, ENTRYSIZE); | ||
218 | + | ||
219 | + if (!s->dt.indirect) { | ||
220 | + s->dt.max_entries = (num_pages * page_sz) / s->dt.entry_sz; | ||
221 | + } else { | ||
222 | + s->dt.max_entries = (((num_pages * page_sz) / | ||
223 | + L1TABLE_ENTRY_SIZE) * | ||
224 | + (page_sz / s->dt.entry_sz)); | ||
225 | + } | ||
226 | + | ||
227 | + s->dt.maxids.max_devids = (1UL << (FIELD_EX64(s->typer, GITS_TYPER, | ||
228 | + DEVBITS) + 1)); | ||
229 | + | ||
230 | + s->dt.base_addr = baser_base_addr(value, page_sz); | ||
231 | + | ||
232 | + break; | ||
233 | + | ||
234 | + case GITS_BASER_TYPE_COLLECTION: | ||
235 | + memset(&s->ct, 0 , sizeof(s->ct)); | ||
236 | + s->ct.valid = FIELD_EX64(value, GITS_BASER, VALID); | ||
237 | + | ||
238 | + /* | ||
239 | + * GITS_TYPER.HCC is 0 for this implementation | ||
240 | + * hence writes are discarded if ct.valid is 0 | ||
241 | + */ | ||
242 | + if (!s->ct.valid) { | ||
243 | + return; | ||
244 | + } | ||
245 | + | ||
246 | + s->ct.page_sz = page_sz; | ||
247 | + s->ct.indirect = FIELD_EX64(value, GITS_BASER, INDIRECT); | ||
248 | + s->ct.entry_sz = FIELD_EX64(value, GITS_BASER, ENTRYSIZE); | ||
249 | + | ||
250 | + if (!s->ct.indirect) { | ||
251 | + s->ct.max_entries = (num_pages * page_sz) / s->ct.entry_sz; | ||
252 | + } else { | ||
253 | + s->ct.max_entries = (((num_pages * page_sz) / | ||
254 | + L1TABLE_ENTRY_SIZE) * | ||
255 | + (page_sz / s->ct.entry_sz)); | ||
256 | + } | ||
257 | + | ||
258 | + if (FIELD_EX64(s->typer, GITS_TYPER, CIL)) { | ||
259 | + s->ct.maxids.max_collids = (1UL << (FIELD_EX64(s->typer, | ||
260 | + GITS_TYPER, CIDBITS) + 1)); | ||
261 | + } else { | ||
262 | + /* 16-bit CollectionId supported when CIL == 0 */ | ||
263 | + s->ct.maxids.max_collids = (1UL << 16); | ||
264 | + } | ||
265 | + | ||
266 | + s->ct.base_addr = baser_base_addr(value, page_sz); | ||
267 | + | ||
268 | + break; | ||
269 | + | ||
270 | + default: | ||
271 | + break; | ||
272 | + } | ||
273 | + } | ||
274 | +} | ||
275 | + | ||
276 | +static void extract_cmdq_params(GICv3ITSState *s) | ||
277 | +{ | ||
278 | + uint16_t num_pages = 0; | ||
279 | + uint64_t value = s->cbaser; | ||
280 | + | ||
281 | + num_pages = FIELD_EX64(value, GITS_CBASER, SIZE) + 1; | ||
282 | + | ||
283 | + memset(&s->cq, 0 , sizeof(s->cq)); | ||
284 | + s->cq.valid = FIELD_EX64(value, GITS_CBASER, VALID); | ||
285 | + | ||
286 | + if (s->cq.valid) { | ||
287 | + s->cq.max_entries = (num_pages * GITS_PAGE_SIZE_4K) / | ||
288 | + GITS_CMDQ_ENTRY_SIZE; | ||
289 | + s->cq.base_addr = FIELD_EX64(value, GITS_CBASER, PHYADDR); | ||
290 | + s->cq.base_addr <<= R_GITS_CBASER_PHYADDR_SHIFT; | ||
291 | + } | ||
292 | +} | ||
293 | + | ||
294 | static MemTxResult gicv3_its_translation_write(void *opaque, hwaddr offset, | ||
295 | uint64_t data, unsigned size, | ||
296 | MemTxAttrs attrs) | ||
297 | @@ -XXX,XX +XXX,XX @@ static bool its_writel(GICv3ITSState *s, hwaddr offset, | ||
298 | uint64_t value, MemTxAttrs attrs) | ||
52 | { | 299 | { |
53 | BCM283XState *s = BCM283X(obj); | 300 | bool result = true; |
54 | + BCM283XClass *bc = BCM283X_GET_CLASS(obj); | 301 | + int index; |
55 | + const BCM283XInfo *info = bc->info; | 302 | |
56 | + int n; | 303 | + switch (offset) { |
57 | + | 304 | + case GITS_CTLR: |
58 | + for (n = 0; n < BCM283X_NCPUS; n++) { | 305 | + s->ctlr |= (value & ~(s->ctlr)); |
59 | + object_initialize(&s->cpus[n], sizeof(s->cpus[n]), | 306 | + |
60 | + info->cpu_type); | 307 | + if (s->ctlr & ITS_CTLR_ENABLED) { |
61 | + object_property_add_child(obj, "cpu[*]", OBJECT(&s->cpus[n]), | 308 | + extract_table_params(s); |
62 | + &error_abort); | 309 | + extract_cmdq_params(s); |
63 | + } | 310 | + s->creadr = 0; |
64 | 311 | + } | |
65 | object_initialize(&s->control, sizeof(s->control), TYPE_BCM2836_CONTROL); | 312 | + break; |
66 | object_property_add_child(obj, "control", OBJECT(&s->control), NULL); | 313 | + case GITS_CBASER: |
67 | @@ -XXX,XX +XXX,XX @@ static void bcm2836_realize(DeviceState *dev, Error **errp) | 314 | + /* |
68 | 315 | + * IMPDEF choice:- GITS_CBASER register becomes RO if ITS is | |
69 | /* common peripherals from bcm2835 */ | 316 | + * already enabled |
70 | 317 | + */ | |
71 | - obj = OBJECT(dev); | 318 | + if (!(s->ctlr & ITS_CTLR_ENABLED)) { |
72 | - for (n = 0; n < BCM283X_NCPUS; n++) { | 319 | + s->cbaser = deposit64(s->cbaser, 0, 32, value); |
73 | - object_initialize(&s->cpus[n], sizeof(s->cpus[n]), | 320 | + s->creadr = 0; |
74 | - s->cpu_type); | 321 | + s->cwriter = s->creadr; |
75 | - object_property_add_child(obj, "cpu[*]", OBJECT(&s->cpus[n]), | 322 | + } |
76 | - &error_abort); | 323 | + break; |
77 | - } | 324 | + case GITS_CBASER + 4: |
78 | - | 325 | + /* |
79 | obj = object_property_get_link(OBJECT(dev), "ram", &err); | 326 | + * IMPDEF choice:- GITS_CBASER register becomes RO if ITS is |
80 | if (obj == NULL) { | 327 | + * already enabled |
81 | error_setg(errp, "%s: required ram link not found: %s", | 328 | + */ |
82 | @@ -XXX,XX +XXX,XX @@ static void bcm2836_realize(DeviceState *dev, Error **errp) | 329 | + if (!(s->ctlr & ITS_CTLR_ENABLED)) { |
330 | + s->cbaser = deposit64(s->cbaser, 32, 32, value); | ||
331 | + s->creadr = 0; | ||
332 | + s->cwriter = s->creadr; | ||
333 | + } | ||
334 | + break; | ||
335 | + case GITS_CWRITER: | ||
336 | + s->cwriter = deposit64(s->cwriter, 0, 32, | ||
337 | + (value & ~R_GITS_CWRITER_RETRY_MASK)); | ||
338 | + break; | ||
339 | + case GITS_CWRITER + 4: | ||
340 | + s->cwriter = deposit64(s->cwriter, 32, 32, value); | ||
341 | + break; | ||
342 | + case GITS_CREADR: | ||
343 | + if (s->gicv3->gicd_ctlr & GICD_CTLR_DS) { | ||
344 | + s->creadr = deposit64(s->creadr, 0, 32, | ||
345 | + (value & ~R_GITS_CREADR_STALLED_MASK)); | ||
346 | + } else { | ||
347 | + /* RO register, ignore the write */ | ||
348 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
349 | + "%s: invalid guest write to RO register at offset " | ||
350 | + TARGET_FMT_plx "\n", __func__, offset); | ||
351 | + } | ||
352 | + break; | ||
353 | + case GITS_CREADR + 4: | ||
354 | + if (s->gicv3->gicd_ctlr & GICD_CTLR_DS) { | ||
355 | + s->creadr = deposit64(s->creadr, 32, 32, value); | ||
356 | + } else { | ||
357 | + /* RO register, ignore the write */ | ||
358 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
359 | + "%s: invalid guest write to RO register at offset " | ||
360 | + TARGET_FMT_plx "\n", __func__, offset); | ||
361 | + } | ||
362 | + break; | ||
363 | + case GITS_BASER ... GITS_BASER + 0x3f: | ||
364 | + /* | ||
365 | + * IMPDEF choice:- GITS_BASERn register becomes RO if ITS is | ||
366 | + * already enabled | ||
367 | + */ | ||
368 | + if (!(s->ctlr & ITS_CTLR_ENABLED)) { | ||
369 | + index = (offset - GITS_BASER) / 8; | ||
370 | + | ||
371 | + if (offset & 7) { | ||
372 | + value <<= 32; | ||
373 | + value &= ~GITS_BASER_RO_MASK; | ||
374 | + s->baser[index] &= GITS_BASER_RO_MASK | MAKE_64BIT_MASK(0, 32); | ||
375 | + s->baser[index] |= value; | ||
376 | + } else { | ||
377 | + value &= ~GITS_BASER_RO_MASK; | ||
378 | + s->baser[index] &= GITS_BASER_RO_MASK | MAKE_64BIT_MASK(32, 32); | ||
379 | + s->baser[index] |= value; | ||
380 | + } | ||
381 | + } | ||
382 | + break; | ||
383 | + case GITS_IIDR: | ||
384 | + case GITS_IDREGS ... GITS_IDREGS + 0x2f: | ||
385 | + /* RO registers, ignore the write */ | ||
386 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
387 | + "%s: invalid guest write to RO register at offset " | ||
388 | + TARGET_FMT_plx "\n", __func__, offset); | ||
389 | + break; | ||
390 | + default: | ||
391 | + result = false; | ||
392 | + break; | ||
393 | + } | ||
394 | return result; | ||
83 | } | 395 | } |
84 | 396 | ||
85 | static Property bcm2836_props[] = { | 397 | @@ -XXX,XX +XXX,XX @@ static bool its_readl(GICv3ITSState *s, hwaddr offset, |
86 | - DEFINE_PROP_STRING("cpu-type", BCM283XState, cpu_type), | 398 | uint64_t *data, MemTxAttrs attrs) |
87 | DEFINE_PROP_UINT32("enabled-cpus", BCM283XState, enabled_cpus, | 399 | { |
88 | BCM283X_NCPUS), | 400 | bool result = true; |
89 | DEFINE_PROP_END_OF_LIST() | 401 | + int index; |
90 | diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c | 402 | |
91 | index XXXXXXX..XXXXXXX 100644 | 403 | + switch (offset) { |
92 | --- a/hw/arm/raspi.c | 404 | + case GITS_CTLR: |
93 | +++ b/hw/arm/raspi.c | 405 | + *data = s->ctlr; |
94 | @@ -XXX,XX +XXX,XX @@ static void raspi_init(MachineState *machine, int version) | 406 | + break; |
95 | /* Setup the SOC */ | 407 | + case GITS_IIDR: |
96 | object_property_add_const_link(OBJECT(&s->soc), "ram", OBJECT(&s->ram), | 408 | + *data = gicv3_iidr(); |
97 | &error_abort); | 409 | + break; |
98 | - object_property_set_str(OBJECT(&s->soc), machine->cpu_type, "cpu-type", | 410 | + case GITS_IDREGS ... GITS_IDREGS + 0x2f: |
99 | - &error_abort); | 411 | + /* ID registers */ |
100 | object_property_set_int(OBJECT(&s->soc), smp_cpus, "enabled-cpus", | 412 | + *data = gicv3_idreg(offset - GITS_IDREGS); |
101 | &error_abort); | 413 | + break; |
102 | int board_rev = version == 3 ? 0xa02082 : 0xa21041; | 414 | + case GITS_TYPER: |
415 | + *data = extract64(s->typer, 0, 32); | ||
416 | + break; | ||
417 | + case GITS_TYPER + 4: | ||
418 | + *data = extract64(s->typer, 32, 32); | ||
419 | + break; | ||
420 | + case GITS_CBASER: | ||
421 | + *data = extract64(s->cbaser, 0, 32); | ||
422 | + break; | ||
423 | + case GITS_CBASER + 4: | ||
424 | + *data = extract64(s->cbaser, 32, 32); | ||
425 | + break; | ||
426 | + case GITS_CREADR: | ||
427 | + *data = extract64(s->creadr, 0, 32); | ||
428 | + break; | ||
429 | + case GITS_CREADR + 4: | ||
430 | + *data = extract64(s->creadr, 32, 32); | ||
431 | + break; | ||
432 | + case GITS_CWRITER: | ||
433 | + *data = extract64(s->cwriter, 0, 32); | ||
434 | + break; | ||
435 | + case GITS_CWRITER + 4: | ||
436 | + *data = extract64(s->cwriter, 32, 32); | ||
437 | + break; | ||
438 | + case GITS_BASER ... GITS_BASER + 0x3f: | ||
439 | + index = (offset - GITS_BASER) / 8; | ||
440 | + if (offset & 7) { | ||
441 | + *data = extract64(s->baser[index], 32, 32); | ||
442 | + } else { | ||
443 | + *data = extract64(s->baser[index], 0, 32); | ||
444 | + } | ||
445 | + break; | ||
446 | + default: | ||
447 | + result = false; | ||
448 | + break; | ||
449 | + } | ||
450 | return result; | ||
451 | } | ||
452 | |||
453 | @@ -XXX,XX +XXX,XX @@ static bool its_writell(GICv3ITSState *s, hwaddr offset, | ||
454 | uint64_t value, MemTxAttrs attrs) | ||
455 | { | ||
456 | bool result = true; | ||
457 | + int index; | ||
458 | |||
459 | + switch (offset) { | ||
460 | + case GITS_BASER ... GITS_BASER + 0x3f: | ||
461 | + /* | ||
462 | + * IMPDEF choice:- GITS_BASERn register becomes RO if ITS is | ||
463 | + * already enabled | ||
464 | + */ | ||
465 | + if (!(s->ctlr & ITS_CTLR_ENABLED)) { | ||
466 | + index = (offset - GITS_BASER) / 8; | ||
467 | + s->baser[index] &= GITS_BASER_RO_MASK; | ||
468 | + s->baser[index] |= (value & ~GITS_BASER_RO_MASK); | ||
469 | + } | ||
470 | + break; | ||
471 | + case GITS_CBASER: | ||
472 | + /* | ||
473 | + * IMPDEF choice:- GITS_CBASER register becomes RO if ITS is | ||
474 | + * already enabled | ||
475 | + */ | ||
476 | + if (!(s->ctlr & ITS_CTLR_ENABLED)) { | ||
477 | + s->cbaser = value; | ||
478 | + s->creadr = 0; | ||
479 | + s->cwriter = s->creadr; | ||
480 | + } | ||
481 | + break; | ||
482 | + case GITS_CWRITER: | ||
483 | + s->cwriter = value & ~R_GITS_CWRITER_RETRY_MASK; | ||
484 | + break; | ||
485 | + case GITS_CREADR: | ||
486 | + if (s->gicv3->gicd_ctlr & GICD_CTLR_DS) { | ||
487 | + s->creadr = value & ~R_GITS_CREADR_STALLED_MASK; | ||
488 | + } else { | ||
489 | + /* RO register, ignore the write */ | ||
490 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
491 | + "%s: invalid guest write to RO register at offset " | ||
492 | + TARGET_FMT_plx "\n", __func__, offset); | ||
493 | + } | ||
494 | + break; | ||
495 | + case GITS_TYPER: | ||
496 | + /* RO registers, ignore the write */ | ||
497 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
498 | + "%s: invalid guest write to RO register at offset " | ||
499 | + TARGET_FMT_plx "\n", __func__, offset); | ||
500 | + break; | ||
501 | + default: | ||
502 | + result = false; | ||
503 | + break; | ||
504 | + } | ||
505 | return result; | ||
506 | } | ||
507 | |||
508 | @@ -XXX,XX +XXX,XX @@ static bool its_readll(GICv3ITSState *s, hwaddr offset, | ||
509 | uint64_t *data, MemTxAttrs attrs) | ||
510 | { | ||
511 | bool result = true; | ||
512 | + int index; | ||
513 | |||
514 | + switch (offset) { | ||
515 | + case GITS_TYPER: | ||
516 | + *data = s->typer; | ||
517 | + break; | ||
518 | + case GITS_BASER ... GITS_BASER + 0x3f: | ||
519 | + index = (offset - GITS_BASER) / 8; | ||
520 | + *data = s->baser[index]; | ||
521 | + break; | ||
522 | + case GITS_CBASER: | ||
523 | + *data = s->cbaser; | ||
524 | + break; | ||
525 | + case GITS_CREADR: | ||
526 | + *data = s->creadr; | ||
527 | + break; | ||
528 | + case GITS_CWRITER: | ||
529 | + *data = s->cwriter; | ||
530 | + break; | ||
531 | + default: | ||
532 | + result = false; | ||
533 | + break; | ||
534 | + } | ||
535 | return result; | ||
536 | } | ||
537 | |||
538 | @@ -XXX,XX +XXX,XX @@ static void gicv3_arm_its_realize(DeviceState *dev, Error **errp) | ||
539 | |||
540 | gicv3_its_init_mmio(s, &gicv3_its_control_ops, &gicv3_its_translation_ops); | ||
541 | |||
542 | + address_space_init(&s->gicv3->dma_as, s->gicv3->dma, | ||
543 | + "gicv3-its-sysmem"); | ||
544 | + | ||
545 | /* set the ITS default features supported */ | ||
546 | s->typer = FIELD_DP64(s->typer, GITS_TYPER, PHYSICAL, | ||
547 | GITS_TYPE_PHYSICAL); | ||
548 | @@ -XXX,XX +XXX,XX @@ static void gicv3_its_reset(DeviceState *dev) | ||
549 | GITS_CTE_SIZE - 1); | ||
550 | } | ||
551 | |||
552 | +static void gicv3_its_post_load(GICv3ITSState *s) | ||
553 | +{ | ||
554 | + if (s->ctlr & ITS_CTLR_ENABLED) { | ||
555 | + extract_table_params(s); | ||
556 | + extract_cmdq_params(s); | ||
557 | + } | ||
558 | +} | ||
559 | + | ||
560 | static Property gicv3_its_props[] = { | ||
561 | DEFINE_PROP_LINK("parent-gicv3", GICv3ITSState, gicv3, "arm-gicv3", | ||
562 | GICv3State *), | ||
563 | @@ -XXX,XX +XXX,XX @@ static void gicv3_its_class_init(ObjectClass *klass, void *data) | ||
564 | { | ||
565 | DeviceClass *dc = DEVICE_CLASS(klass); | ||
566 | GICv3ITSClass *ic = ARM_GICV3_ITS_CLASS(klass); | ||
567 | + GICv3ITSCommonClass *icc = ARM_GICV3_ITS_COMMON_CLASS(klass); | ||
568 | |||
569 | dc->realize = gicv3_arm_its_realize; | ||
570 | device_class_set_props(dc, gicv3_its_props); | ||
571 | device_class_set_parent_reset(dc, gicv3_its_reset, &ic->parent_reset); | ||
572 | + icc->post_load = gicv3_its_post_load; | ||
573 | } | ||
574 | |||
575 | static const TypeInfo gicv3_its_info = { | ||
103 | -- | 576 | -- |
104 | 2.16.2 | 577 | 2.20.1 |
105 | 578 | ||
106 | 579 | diff view generated by jsdifflib |
1 | From: Andrey Smirnov <andrew.smirnov@gmail.com> | 1 | From: Shashi Mallela <shashi.mallela@linaro.org> |
---|---|---|---|
2 | 2 | ||
3 | Add support for "TX complete"/TXDC interrupt generate by real HW since | 3 | Added functionality to trigger ITS command queue processing on |
4 | it is needed to support guests other than Linux. | 4 | write to CWRITE register and process each command queue entry to |
5 | identify the command type and handle commands like MAPD,MAPC,SYNC. | ||
5 | 6 | ||
6 | Based on the patch by Bill Paul as found here: | 7 | Signed-off-by: Shashi Mallela <shashi.mallela@linaro.org> |
7 | https://bugs.launchpad.net/qemu/+bug/1753314 | ||
8 | |||
9 | Cc: qemu-devel@nongnu.org | ||
10 | Cc: qemu-arm@nongnu.org | ||
11 | Cc: Bill Paul <wpaul@windriver.com> | ||
12 | Cc: Peter Maydell <peter.maydell@linaro.org> | ||
13 | Signed-off-by: Bill Paul <wpaul@windriver.com> | ||
14 | Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> | ||
15 | Message-id: 20180315191141.6789-2-andrew.smirnov@gmail.com | ||
16 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | 8 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> |
9 | Reviewed-by: Eric Auger <eric.auger@redhat.com> | ||
10 | Tested-by: Neil Armstrong <narmstrong@baylibre.com> | ||
11 | Message-id: 20210910143951.92242-4-shashi.mallela@linaro.org | ||
17 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 12 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
18 | --- | 13 | --- |
19 | include/hw/char/imx_serial.h | 3 +++ | 14 | hw/intc/gicv3_internal.h | 40 +++++ |
20 | hw/char/imx_serial.c | 20 +++++++++++++++++--- | 15 | hw/intc/arm_gicv3_its.c | 319 +++++++++++++++++++++++++++++++++++++++ |
21 | 2 files changed, 20 insertions(+), 3 deletions(-) | 16 | 2 files changed, 359 insertions(+) |
22 | 17 | ||
23 | diff --git a/include/hw/char/imx_serial.h b/include/hw/char/imx_serial.h | 18 | diff --git a/hw/intc/gicv3_internal.h b/hw/intc/gicv3_internal.h |
24 | index XXXXXXX..XXXXXXX 100644 | 19 | index XXXXXXX..XXXXXXX 100644 |
25 | --- a/include/hw/char/imx_serial.h | 20 | --- a/hw/intc/gicv3_internal.h |
26 | +++ b/include/hw/char/imx_serial.h | 21 | +++ b/hw/intc/gicv3_internal.h |
27 | @@ -XXX,XX +XXX,XX @@ | 22 | @@ -XXX,XX +XXX,XX @@ FIELD(GITS_TYPER, CIL, 36, 1) |
28 | #define UCR2_RXEN (1<<1) /* Receiver enable */ | 23 | #define L1TABLE_ENTRY_SIZE 8 |
29 | #define UCR2_SRST (1<<0) /* Reset complete */ | 24 | |
30 | 25 | #define GITS_CMDQ_ENTRY_SIZE 32 | |
31 | +#define UCR4_TCEN BIT(3) /* TX complete interrupt enable */ | 26 | +#define NUM_BYTES_IN_DW 8 |
32 | + | 27 | + |
33 | #define UTS1_TXEMPTY (1<<6) | 28 | +#define CMD_MASK 0xff |
34 | #define UTS1_RXEMPTY (1<<5) | 29 | + |
35 | #define UTS1_TXFULL (1<<4) | 30 | +/* ITS Commands */ |
36 | @@ -XXX,XX +XXX,XX @@ typedef struct IMXSerialState { | 31 | +#define GITS_CMD_CLEAR 0x04 |
37 | uint32_t ubmr; | 32 | +#define GITS_CMD_DISCARD 0x0F |
38 | uint32_t ubrc; | 33 | +#define GITS_CMD_INT 0x03 |
39 | uint32_t ucr3; | 34 | +#define GITS_CMD_MAPC 0x09 |
40 | + uint32_t ucr4; | 35 | +#define GITS_CMD_MAPD 0x08 |
41 | 36 | +#define GITS_CMD_MAPI 0x0B | |
42 | qemu_irq irq; | 37 | +#define GITS_CMD_MAPTI 0x0A |
43 | CharBackend chr; | 38 | +#define GITS_CMD_INV 0x0C |
44 | diff --git a/hw/char/imx_serial.c b/hw/char/imx_serial.c | 39 | +#define GITS_CMD_INVALL 0x0D |
40 | +#define GITS_CMD_SYNC 0x05 | ||
41 | + | ||
42 | +/* MAPC command fields */ | ||
43 | +#define ICID_LENGTH 16 | ||
44 | +#define ICID_MASK ((1U << ICID_LENGTH) - 1) | ||
45 | +FIELD(MAPC, RDBASE, 16, 32) | ||
46 | + | ||
47 | +#define RDBASE_PROCNUM_LENGTH 16 | ||
48 | +#define RDBASE_PROCNUM_MASK ((1ULL << RDBASE_PROCNUM_LENGTH) - 1) | ||
49 | + | ||
50 | +/* MAPD command fields */ | ||
51 | +#define ITTADDR_LENGTH 44 | ||
52 | +#define ITTADDR_SHIFT 8 | ||
53 | +#define ITTADDR_MASK MAKE_64BIT_MASK(ITTADDR_SHIFT, ITTADDR_LENGTH) | ||
54 | +#define SIZE_MASK 0x1f | ||
55 | + | ||
56 | +#define DEVID_SHIFT 32 | ||
57 | +#define DEVID_MASK MAKE_64BIT_MASK(32, 32) | ||
58 | + | ||
59 | +#define VALID_SHIFT 63 | ||
60 | +#define CMD_FIELD_VALID_MASK (1ULL << VALID_SHIFT) | ||
61 | +#define L2_TABLE_VALID_MASK CMD_FIELD_VALID_MASK | ||
62 | +#define TABLE_ENTRY_VALID_MASK (1ULL << 0) | ||
63 | |||
64 | /** | ||
65 | * Default features advertised by this version of ITS | ||
66 | @@ -XXX,XX +XXX,XX @@ FIELD(GITS_TYPER, CIL, 36, 1) | ||
67 | * Valid = 1 bit,ITTAddr = 44 bits,Size = 5 bits | ||
68 | */ | ||
69 | #define GITS_DTE_SIZE (0x8ULL) | ||
70 | +#define GITS_DTE_ITTADDR_SHIFT 6 | ||
71 | +#define GITS_DTE_ITTADDR_MASK MAKE_64BIT_MASK(GITS_DTE_ITTADDR_SHIFT, \ | ||
72 | + ITTADDR_LENGTH) | ||
73 | |||
74 | /* | ||
75 | * 8 bytes Collection Table Entry size | ||
76 | diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c | ||
45 | index XXXXXXX..XXXXXXX 100644 | 77 | index XXXXXXX..XXXXXXX 100644 |
46 | --- a/hw/char/imx_serial.c | 78 | --- a/hw/intc/arm_gicv3_its.c |
47 | +++ b/hw/char/imx_serial.c | 79 | +++ b/hw/intc/arm_gicv3_its.c |
48 | @@ -XXX,XX +XXX,XX @@ | 80 | @@ -XXX,XX +XXX,XX @@ static uint64_t baser_base_addr(uint64_t value, uint32_t page_sz) |
49 | 81 | return result; | |
50 | static const VMStateDescription vmstate_imx_serial = { | 82 | } |
51 | .name = TYPE_IMX_SERIAL, | 83 | |
52 | - .version_id = 1, | 84 | +static bool update_cte(GICv3ITSState *s, uint16_t icid, bool valid, |
53 | - .minimum_version_id = 1, | 85 | + uint64_t rdbase) |
54 | + .version_id = 2, | 86 | +{ |
55 | + .minimum_version_id = 2, | 87 | + AddressSpace *as = &s->gicv3->dma_as; |
56 | .fields = (VMStateField[]) { | 88 | + uint64_t value; |
57 | VMSTATE_INT32(readbuff, IMXSerialState), | 89 | + uint64_t l2t_addr; |
58 | VMSTATE_UINT32(usr1, IMXSerialState), | 90 | + bool valid_l2t; |
59 | @@ -XXX,XX +XXX,XX @@ static const VMStateDescription vmstate_imx_serial = { | 91 | + uint32_t l2t_id; |
60 | VMSTATE_UINT32(ubmr, IMXSerialState), | 92 | + uint32_t max_l2_entries; |
61 | VMSTATE_UINT32(ubrc, IMXSerialState), | 93 | + uint64_t cte = 0; |
62 | VMSTATE_UINT32(ucr3, IMXSerialState), | 94 | + MemTxResult res = MEMTX_OK; |
63 | + VMSTATE_UINT32(ucr4, IMXSerialState), | 95 | + |
64 | VMSTATE_END_OF_LIST() | 96 | + if (!s->ct.valid) { |
65 | }, | 97 | + return true; |
66 | }; | 98 | + } |
67 | @@ -XXX,XX +XXX,XX @@ static void imx_update(IMXSerialState *s) | 99 | + |
68 | * unfortunately. | 100 | + if (valid) { |
69 | */ | 101 | + /* add mapping entry to collection table */ |
70 | mask = (s->ucr1 & UCR1_TXMPTYEN) ? USR2_TXFE : 0; | 102 | + cte = (valid & TABLE_ENTRY_VALID_MASK) | (rdbase << 1ULL); |
103 | + } | ||
104 | + | ||
71 | + /* | 105 | + /* |
72 | + * TCEN and TXDC are both bit 3 | 106 | + * The specification defines the format of level 1 entries of a |
107 | + * 2-level table, but the format of level 2 entries and the format | ||
108 | + * of flat-mapped tables is IMPDEF. | ||
73 | + */ | 109 | + */ |
74 | + mask |= s->ucr4 & UCR4_TCEN; | 110 | + if (s->ct.indirect) { |
75 | + | 111 | + l2t_id = icid / (s->ct.page_sz / L1TABLE_ENTRY_SIZE); |
76 | usr2 = s->usr2 & mask; | 112 | + |
77 | 113 | + value = address_space_ldq_le(as, | |
78 | qemu_set_irq(s->irq, usr1 || usr2); | 114 | + s->ct.base_addr + |
79 | @@ -XXX,XX +XXX,XX @@ static uint64_t imx_serial_read(void *opaque, hwaddr offset, | 115 | + (l2t_id * L1TABLE_ENTRY_SIZE), |
80 | return s->ucr3; | 116 | + MEMTXATTRS_UNSPECIFIED, &res); |
81 | 117 | + | |
82 | case 0x23: /* UCR4 */ | 118 | + if (res != MEMTX_OK) { |
83 | + return s->ucr4; | 119 | + return false; |
84 | + | 120 | + } |
85 | case 0x29: /* BRM Incremental */ | 121 | + |
86 | return 0x0; /* TODO */ | 122 | + valid_l2t = (value & L2_TABLE_VALID_MASK) != 0; |
87 | 123 | + | |
88 | @@ -XXX,XX +XXX,XX @@ static void imx_serial_write(void *opaque, hwaddr offset, | 124 | + if (valid_l2t) { |
89 | * qemu_chr_fe_write and background I/O callbacks */ | 125 | + max_l2_entries = s->ct.page_sz / s->ct.entry_sz; |
90 | qemu_chr_fe_write_all(&s->chr, &ch, 1); | 126 | + |
91 | s->usr1 &= ~USR1_TRDY; | 127 | + l2t_addr = value & ((1ULL << 51) - 1); |
92 | + s->usr2 &= ~USR2_TXDC; | 128 | + |
93 | imx_update(s); | 129 | + address_space_stq_le(as, l2t_addr + |
94 | s->usr1 |= USR1_TRDY; | 130 | + ((icid % max_l2_entries) * GITS_CTE_SIZE), |
95 | + s->usr2 |= USR2_TXDC; | 131 | + cte, MEMTXATTRS_UNSPECIFIED, &res); |
96 | imx_update(s); | 132 | + } |
133 | + } else { | ||
134 | + /* Flat level table */ | ||
135 | + address_space_stq_le(as, s->ct.base_addr + (icid * GITS_CTE_SIZE), | ||
136 | + cte, MEMTXATTRS_UNSPECIFIED, &res); | ||
137 | + } | ||
138 | + if (res != MEMTX_OK) { | ||
139 | + return false; | ||
140 | + } else { | ||
141 | + return true; | ||
142 | + } | ||
143 | +} | ||
144 | + | ||
145 | +static bool process_mapc(GICv3ITSState *s, uint32_t offset) | ||
146 | +{ | ||
147 | + AddressSpace *as = &s->gicv3->dma_as; | ||
148 | + uint16_t icid; | ||
149 | + uint64_t rdbase; | ||
150 | + bool valid; | ||
151 | + MemTxResult res = MEMTX_OK; | ||
152 | + bool result = false; | ||
153 | + uint64_t value; | ||
154 | + | ||
155 | + offset += NUM_BYTES_IN_DW; | ||
156 | + offset += NUM_BYTES_IN_DW; | ||
157 | + | ||
158 | + value = address_space_ldq_le(as, s->cq.base_addr + offset, | ||
159 | + MEMTXATTRS_UNSPECIFIED, &res); | ||
160 | + | ||
161 | + if (res != MEMTX_OK) { | ||
162 | + return result; | ||
163 | + } | ||
164 | + | ||
165 | + icid = value & ICID_MASK; | ||
166 | + | ||
167 | + rdbase = (value & R_MAPC_RDBASE_MASK) >> R_MAPC_RDBASE_SHIFT; | ||
168 | + rdbase &= RDBASE_PROCNUM_MASK; | ||
169 | + | ||
170 | + valid = (value & CMD_FIELD_VALID_MASK); | ||
171 | + | ||
172 | + if ((icid > s->ct.maxids.max_collids) || (rdbase > s->gicv3->num_cpu)) { | ||
173 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
174 | + "ITS MAPC: invalid collection table attributes " | ||
175 | + "icid %d rdbase %lu\n", icid, rdbase); | ||
176 | + /* | ||
177 | + * in this implementation, in case of error | ||
178 | + * we ignore this command and move onto the next | ||
179 | + * command in the queue | ||
180 | + */ | ||
181 | + } else { | ||
182 | + result = update_cte(s, icid, valid, rdbase); | ||
183 | + } | ||
184 | + | ||
185 | + return result; | ||
186 | +} | ||
187 | + | ||
188 | +static bool update_dte(GICv3ITSState *s, uint32_t devid, bool valid, | ||
189 | + uint8_t size, uint64_t itt_addr) | ||
190 | +{ | ||
191 | + AddressSpace *as = &s->gicv3->dma_as; | ||
192 | + uint64_t value; | ||
193 | + uint64_t l2t_addr; | ||
194 | + bool valid_l2t; | ||
195 | + uint32_t l2t_id; | ||
196 | + uint32_t max_l2_entries; | ||
197 | + uint64_t dte = 0; | ||
198 | + MemTxResult res = MEMTX_OK; | ||
199 | + | ||
200 | + if (s->dt.valid) { | ||
201 | + if (valid) { | ||
202 | + /* add mapping entry to device table */ | ||
203 | + dte = (valid & TABLE_ENTRY_VALID_MASK) | | ||
204 | + ((size & SIZE_MASK) << 1U) | | ||
205 | + (itt_addr << GITS_DTE_ITTADDR_SHIFT); | ||
206 | + } | ||
207 | + } else { | ||
208 | + return true; | ||
209 | + } | ||
210 | + | ||
211 | + /* | ||
212 | + * The specification defines the format of level 1 entries of a | ||
213 | + * 2-level table, but the format of level 2 entries and the format | ||
214 | + * of flat-mapped tables is IMPDEF. | ||
215 | + */ | ||
216 | + if (s->dt.indirect) { | ||
217 | + l2t_id = devid / (s->dt.page_sz / L1TABLE_ENTRY_SIZE); | ||
218 | + | ||
219 | + value = address_space_ldq_le(as, | ||
220 | + s->dt.base_addr + | ||
221 | + (l2t_id * L1TABLE_ENTRY_SIZE), | ||
222 | + MEMTXATTRS_UNSPECIFIED, &res); | ||
223 | + | ||
224 | + if (res != MEMTX_OK) { | ||
225 | + return false; | ||
226 | + } | ||
227 | + | ||
228 | + valid_l2t = (value & L2_TABLE_VALID_MASK) != 0; | ||
229 | + | ||
230 | + if (valid_l2t) { | ||
231 | + max_l2_entries = s->dt.page_sz / s->dt.entry_sz; | ||
232 | + | ||
233 | + l2t_addr = value & ((1ULL << 51) - 1); | ||
234 | + | ||
235 | + address_space_stq_le(as, l2t_addr + | ||
236 | + ((devid % max_l2_entries) * GITS_DTE_SIZE), | ||
237 | + dte, MEMTXATTRS_UNSPECIFIED, &res); | ||
238 | + } | ||
239 | + } else { | ||
240 | + /* Flat level table */ | ||
241 | + address_space_stq_le(as, s->dt.base_addr + (devid * GITS_DTE_SIZE), | ||
242 | + dte, MEMTXATTRS_UNSPECIFIED, &res); | ||
243 | + } | ||
244 | + if (res != MEMTX_OK) { | ||
245 | + return false; | ||
246 | + } else { | ||
247 | + return true; | ||
248 | + } | ||
249 | +} | ||
250 | + | ||
251 | +static bool process_mapd(GICv3ITSState *s, uint64_t value, uint32_t offset) | ||
252 | +{ | ||
253 | + AddressSpace *as = &s->gicv3->dma_as; | ||
254 | + uint32_t devid; | ||
255 | + uint8_t size; | ||
256 | + uint64_t itt_addr; | ||
257 | + bool valid; | ||
258 | + MemTxResult res = MEMTX_OK; | ||
259 | + bool result = false; | ||
260 | + | ||
261 | + devid = ((value & DEVID_MASK) >> DEVID_SHIFT); | ||
262 | + | ||
263 | + offset += NUM_BYTES_IN_DW; | ||
264 | + value = address_space_ldq_le(as, s->cq.base_addr + offset, | ||
265 | + MEMTXATTRS_UNSPECIFIED, &res); | ||
266 | + | ||
267 | + if (res != MEMTX_OK) { | ||
268 | + return result; | ||
269 | + } | ||
270 | + | ||
271 | + size = (value & SIZE_MASK); | ||
272 | + | ||
273 | + offset += NUM_BYTES_IN_DW; | ||
274 | + value = address_space_ldq_le(as, s->cq.base_addr + offset, | ||
275 | + MEMTXATTRS_UNSPECIFIED, &res); | ||
276 | + | ||
277 | + if (res != MEMTX_OK) { | ||
278 | + return result; | ||
279 | + } | ||
280 | + | ||
281 | + itt_addr = (value & ITTADDR_MASK) >> ITTADDR_SHIFT; | ||
282 | + | ||
283 | + valid = (value & CMD_FIELD_VALID_MASK); | ||
284 | + | ||
285 | + if ((devid > s->dt.maxids.max_devids) || | ||
286 | + (size > FIELD_EX64(s->typer, GITS_TYPER, IDBITS))) { | ||
287 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
288 | + "ITS MAPD: invalid device table attributes " | ||
289 | + "devid %d or size %d\n", devid, size); | ||
290 | + /* | ||
291 | + * in this implementation, in case of error | ||
292 | + * we ignore this command and move onto the next | ||
293 | + * command in the queue | ||
294 | + */ | ||
295 | + } else { | ||
296 | + result = update_dte(s, devid, valid, size, itt_addr); | ||
297 | + } | ||
298 | + | ||
299 | + return result; | ||
300 | +} | ||
301 | + | ||
302 | +/* | ||
303 | + * Current implementation blocks until all | ||
304 | + * commands are processed | ||
305 | + */ | ||
306 | +static void process_cmdq(GICv3ITSState *s) | ||
307 | +{ | ||
308 | + uint32_t wr_offset = 0; | ||
309 | + uint32_t rd_offset = 0; | ||
310 | + uint32_t cq_offset = 0; | ||
311 | + uint64_t data; | ||
312 | + AddressSpace *as = &s->gicv3->dma_as; | ||
313 | + MemTxResult res = MEMTX_OK; | ||
314 | + bool result = true; | ||
315 | + uint8_t cmd; | ||
316 | + | ||
317 | + if (!(s->ctlr & ITS_CTLR_ENABLED)) { | ||
318 | + return; | ||
319 | + } | ||
320 | + | ||
321 | + wr_offset = FIELD_EX64(s->cwriter, GITS_CWRITER, OFFSET); | ||
322 | + | ||
323 | + if (wr_offset > s->cq.max_entries) { | ||
324 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
325 | + "%s: invalid write offset " | ||
326 | + "%d\n", __func__, wr_offset); | ||
327 | + return; | ||
328 | + } | ||
329 | + | ||
330 | + rd_offset = FIELD_EX64(s->creadr, GITS_CREADR, OFFSET); | ||
331 | + | ||
332 | + if (rd_offset > s->cq.max_entries) { | ||
333 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
334 | + "%s: invalid read offset " | ||
335 | + "%d\n", __func__, rd_offset); | ||
336 | + return; | ||
337 | + } | ||
338 | + | ||
339 | + while (wr_offset != rd_offset) { | ||
340 | + cq_offset = (rd_offset * GITS_CMDQ_ENTRY_SIZE); | ||
341 | + data = address_space_ldq_le(as, s->cq.base_addr + cq_offset, | ||
342 | + MEMTXATTRS_UNSPECIFIED, &res); | ||
343 | + if (res != MEMTX_OK) { | ||
344 | + result = false; | ||
345 | + } | ||
346 | + cmd = (data & CMD_MASK); | ||
347 | + | ||
348 | + switch (cmd) { | ||
349 | + case GITS_CMD_INT: | ||
350 | + break; | ||
351 | + case GITS_CMD_CLEAR: | ||
352 | + break; | ||
353 | + case GITS_CMD_SYNC: | ||
354 | + /* | ||
355 | + * Current implementation makes a blocking synchronous call | ||
356 | + * for every command issued earlier, hence the internal state | ||
357 | + * is already consistent by the time SYNC command is executed. | ||
358 | + * Hence no further processing is required for SYNC command. | ||
359 | + */ | ||
360 | + break; | ||
361 | + case GITS_CMD_MAPD: | ||
362 | + result = process_mapd(s, data, cq_offset); | ||
363 | + break; | ||
364 | + case GITS_CMD_MAPC: | ||
365 | + result = process_mapc(s, cq_offset); | ||
366 | + break; | ||
367 | + case GITS_CMD_MAPTI: | ||
368 | + break; | ||
369 | + case GITS_CMD_MAPI: | ||
370 | + break; | ||
371 | + case GITS_CMD_DISCARD: | ||
372 | + break; | ||
373 | + case GITS_CMD_INV: | ||
374 | + case GITS_CMD_INVALL: | ||
375 | + break; | ||
376 | + default: | ||
377 | + break; | ||
378 | + } | ||
379 | + if (result) { | ||
380 | + rd_offset++; | ||
381 | + rd_offset %= s->cq.max_entries; | ||
382 | + s->creadr = FIELD_DP64(s->creadr, GITS_CREADR, OFFSET, rd_offset); | ||
383 | + } else { | ||
384 | + /* | ||
385 | + * in this implementation, in case of dma read/write error | ||
386 | + * we stall the command processing | ||
387 | + */ | ||
388 | + s->creadr = FIELD_DP64(s->creadr, GITS_CREADR, STALLED, 1); | ||
389 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
390 | + "%s: %x cmd processing failed\n", __func__, cmd); | ||
391 | + break; | ||
392 | + } | ||
393 | + } | ||
394 | +} | ||
395 | + | ||
396 | /* | ||
397 | * This function extracts the ITS Device and Collection table specific | ||
398 | * parameters (like base_addr, size etc) from GITS_BASER register. | ||
399 | @@ -XXX,XX +XXX,XX @@ static bool its_writel(GICv3ITSState *s, hwaddr offset, | ||
400 | extract_table_params(s); | ||
401 | extract_cmdq_params(s); | ||
402 | s->creadr = 0; | ||
403 | + process_cmdq(s); | ||
97 | } | 404 | } |
98 | break; | 405 | break; |
99 | @@ -XXX,XX +XXX,XX @@ static void imx_serial_write(void *opaque, hwaddr offset, | 406 | case GITS_CBASER: |
100 | s->ucr3 = value & 0xffff; | 407 | @@ -XXX,XX +XXX,XX @@ static bool its_writel(GICv3ITSState *s, hwaddr offset, |
408 | case GITS_CWRITER: | ||
409 | s->cwriter = deposit64(s->cwriter, 0, 32, | ||
410 | (value & ~R_GITS_CWRITER_RETRY_MASK)); | ||
411 | + if (s->cwriter != s->creadr) { | ||
412 | + process_cmdq(s); | ||
413 | + } | ||
101 | break; | 414 | break; |
102 | 415 | case GITS_CWRITER + 4: | |
103 | - case 0x2d: /* UTS1 */ | 416 | s->cwriter = deposit64(s->cwriter, 32, 32, value); |
104 | case 0x23: /* UCR4 */ | 417 | @@ -XXX,XX +XXX,XX @@ static bool its_writell(GICv3ITSState *s, hwaddr offset, |
105 | + s->ucr4 = value & 0xffff; | 418 | break; |
106 | + imx_update(s); | 419 | case GITS_CWRITER: |
107 | + break; | 420 | s->cwriter = value & ~R_GITS_CWRITER_RETRY_MASK; |
108 | + | 421 | + if (s->cwriter != s->creadr) { |
109 | + case 0x2d: /* UTS1 */ | 422 | + process_cmdq(s); |
110 | qemu_log_mask(LOG_UNIMP, "[%s]%s: Unimplemented reg 0x%" | 423 | + } |
111 | HWADDR_PRIx "\n", TYPE_IMX_SERIAL, __func__, offset); | 424 | break; |
112 | /* TODO */ | 425 | case GITS_CREADR: |
426 | if (s->gicv3->gicd_ctlr & GICD_CTLR_DS) { | ||
113 | -- | 427 | -- |
114 | 2.16.2 | 428 | 2.20.1 |
115 | 429 | ||
116 | 430 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Shashi Mallela <shashi.mallela@linaro.org> | ||
1 | 2 | ||
3 | Added ITS command queue handling for MAPTI,MAPI commands,handled ITS | ||
4 | translation which triggers an LPI via INT command as well as write | ||
5 | to GITS_TRANSLATER register,defined enum to differentiate between ITS | ||
6 | command interrupt trigger and GITS_TRANSLATER based interrupt trigger. | ||
7 | Each of these commands make use of other functionalities implemented to | ||
8 | get device table entry,collection table entry or interrupt translation | ||
9 | table entry required for their processing. | ||
10 | |||
11 | Signed-off-by: Shashi Mallela <shashi.mallela@linaro.org> | ||
12 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
13 | Message-id: 20210910143951.92242-5-shashi.mallela@linaro.org | ||
14 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
15 | --- | ||
16 | hw/intc/gicv3_internal.h | 12 + | ||
17 | include/hw/intc/arm_gicv3_common.h | 2 + | ||
18 | hw/intc/arm_gicv3_its.c | 365 ++++++++++++++++++++++++++++- | ||
19 | 3 files changed, 378 insertions(+), 1 deletion(-) | ||
20 | |||
21 | diff --git a/hw/intc/gicv3_internal.h b/hw/intc/gicv3_internal.h | ||
22 | index XXXXXXX..XXXXXXX 100644 | ||
23 | --- a/hw/intc/gicv3_internal.h | ||
24 | +++ b/hw/intc/gicv3_internal.h | ||
25 | @@ -XXX,XX +XXX,XX @@ FIELD(MAPC, RDBASE, 16, 32) | ||
26 | #define ITTADDR_MASK MAKE_64BIT_MASK(ITTADDR_SHIFT, ITTADDR_LENGTH) | ||
27 | #define SIZE_MASK 0x1f | ||
28 | |||
29 | +/* MAPI command fields */ | ||
30 | +#define EVENTID_MASK ((1ULL << 32) - 1) | ||
31 | + | ||
32 | +/* MAPTI command fields */ | ||
33 | +#define pINTID_SHIFT 32 | ||
34 | +#define pINTID_MASK MAKE_64BIT_MASK(32, 32) | ||
35 | + | ||
36 | #define DEVID_SHIFT 32 | ||
37 | #define DEVID_MASK MAKE_64BIT_MASK(32, 32) | ||
38 | |||
39 | @@ -XXX,XX +XXX,XX @@ FIELD(MAPC, RDBASE, 16, 32) | ||
40 | * Values: | vPEID | ICID | | ||
41 | */ | ||
42 | #define ITS_ITT_ENTRY_SIZE 0xC | ||
43 | +#define ITE_ENTRY_INTTYPE_SHIFT 1 | ||
44 | +#define ITE_ENTRY_INTID_SHIFT 2 | ||
45 | +#define ITE_ENTRY_INTID_MASK MAKE_64BIT_MASK(2, 24) | ||
46 | +#define ITE_ENTRY_INTSP_SHIFT 26 | ||
47 | +#define ITE_ENTRY_ICID_MASK MAKE_64BIT_MASK(0, 16) | ||
48 | |||
49 | /* 16 bits EventId */ | ||
50 | #define ITS_IDBITS GICD_TYPER_IDBITS | ||
51 | diff --git a/include/hw/intc/arm_gicv3_common.h b/include/hw/intc/arm_gicv3_common.h | ||
52 | index XXXXXXX..XXXXXXX 100644 | ||
53 | --- a/include/hw/intc/arm_gicv3_common.h | ||
54 | +++ b/include/hw/intc/arm_gicv3_common.h | ||
55 | @@ -XXX,XX +XXX,XX @@ | ||
56 | #define GICV3_MAXIRQ 1020 | ||
57 | #define GICV3_MAXSPI (GICV3_MAXIRQ - GIC_INTERNAL) | ||
58 | |||
59 | +#define GICV3_LPI_INTID_START 8192 | ||
60 | + | ||
61 | #define GICV3_REDIST_SIZE 0x20000 | ||
62 | |||
63 | /* Number of SGI target-list bits */ | ||
64 | diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c | ||
65 | index XXXXXXX..XXXXXXX 100644 | ||
66 | --- a/hw/intc/arm_gicv3_its.c | ||
67 | +++ b/hw/intc/arm_gicv3_its.c | ||
68 | @@ -XXX,XX +XXX,XX @@ struct GICv3ITSClass { | ||
69 | void (*parent_reset)(DeviceState *dev); | ||
70 | }; | ||
71 | |||
72 | +/* | ||
73 | + * This is an internal enum used to distinguish between LPI triggered | ||
74 | + * via command queue and LPI triggered via gits_translater write. | ||
75 | + */ | ||
76 | +typedef enum ItsCmdType { | ||
77 | + NONE = 0, /* internal indication for GITS_TRANSLATER write */ | ||
78 | + CLEAR = 1, | ||
79 | + DISCARD = 2, | ||
80 | + INT = 3, | ||
81 | +} ItsCmdType; | ||
82 | + | ||
83 | +typedef struct { | ||
84 | + uint32_t iteh; | ||
85 | + uint64_t itel; | ||
86 | +} IteEntry; | ||
87 | + | ||
88 | static uint64_t baser_base_addr(uint64_t value, uint32_t page_sz) | ||
89 | { | ||
90 | uint64_t result = 0; | ||
91 | @@ -XXX,XX +XXX,XX @@ static uint64_t baser_base_addr(uint64_t value, uint32_t page_sz) | ||
92 | return result; | ||
93 | } | ||
94 | |||
95 | +static bool get_cte(GICv3ITSState *s, uint16_t icid, uint64_t *cte, | ||
96 | + MemTxResult *res) | ||
97 | +{ | ||
98 | + AddressSpace *as = &s->gicv3->dma_as; | ||
99 | + uint64_t l2t_addr; | ||
100 | + uint64_t value; | ||
101 | + bool valid_l2t; | ||
102 | + uint32_t l2t_id; | ||
103 | + uint32_t max_l2_entries; | ||
104 | + | ||
105 | + if (s->ct.indirect) { | ||
106 | + l2t_id = icid / (s->ct.page_sz / L1TABLE_ENTRY_SIZE); | ||
107 | + | ||
108 | + value = address_space_ldq_le(as, | ||
109 | + s->ct.base_addr + | ||
110 | + (l2t_id * L1TABLE_ENTRY_SIZE), | ||
111 | + MEMTXATTRS_UNSPECIFIED, res); | ||
112 | + | ||
113 | + if (*res == MEMTX_OK) { | ||
114 | + valid_l2t = (value & L2_TABLE_VALID_MASK) != 0; | ||
115 | + | ||
116 | + if (valid_l2t) { | ||
117 | + max_l2_entries = s->ct.page_sz / s->ct.entry_sz; | ||
118 | + | ||
119 | + l2t_addr = value & ((1ULL << 51) - 1); | ||
120 | + | ||
121 | + *cte = address_space_ldq_le(as, l2t_addr + | ||
122 | + ((icid % max_l2_entries) * GITS_CTE_SIZE), | ||
123 | + MEMTXATTRS_UNSPECIFIED, res); | ||
124 | + } | ||
125 | + } | ||
126 | + } else { | ||
127 | + /* Flat level table */ | ||
128 | + *cte = address_space_ldq_le(as, s->ct.base_addr + | ||
129 | + (icid * GITS_CTE_SIZE), | ||
130 | + MEMTXATTRS_UNSPECIFIED, res); | ||
131 | + } | ||
132 | + | ||
133 | + return (*cte & TABLE_ENTRY_VALID_MASK) != 0; | ||
134 | +} | ||
135 | + | ||
136 | +static bool update_ite(GICv3ITSState *s, uint32_t eventid, uint64_t dte, | ||
137 | + IteEntry ite) | ||
138 | +{ | ||
139 | + AddressSpace *as = &s->gicv3->dma_as; | ||
140 | + uint64_t itt_addr; | ||
141 | + MemTxResult res = MEMTX_OK; | ||
142 | + | ||
143 | + itt_addr = (dte & GITS_DTE_ITTADDR_MASK) >> GITS_DTE_ITTADDR_SHIFT; | ||
144 | + itt_addr <<= ITTADDR_SHIFT; /* 256 byte aligned */ | ||
145 | + | ||
146 | + address_space_stq_le(as, itt_addr + (eventid * (sizeof(uint64_t) + | ||
147 | + sizeof(uint32_t))), ite.itel, MEMTXATTRS_UNSPECIFIED, | ||
148 | + &res); | ||
149 | + | ||
150 | + if (res == MEMTX_OK) { | ||
151 | + address_space_stl_le(as, itt_addr + (eventid * (sizeof(uint64_t) + | ||
152 | + sizeof(uint32_t))) + sizeof(uint32_t), ite.iteh, | ||
153 | + MEMTXATTRS_UNSPECIFIED, &res); | ||
154 | + } | ||
155 | + if (res != MEMTX_OK) { | ||
156 | + return false; | ||
157 | + } else { | ||
158 | + return true; | ||
159 | + } | ||
160 | +} | ||
161 | + | ||
162 | +static bool get_ite(GICv3ITSState *s, uint32_t eventid, uint64_t dte, | ||
163 | + uint16_t *icid, uint32_t *pIntid, MemTxResult *res) | ||
164 | +{ | ||
165 | + AddressSpace *as = &s->gicv3->dma_as; | ||
166 | + uint64_t itt_addr; | ||
167 | + bool status = false; | ||
168 | + IteEntry ite = {}; | ||
169 | + | ||
170 | + itt_addr = (dte & GITS_DTE_ITTADDR_MASK) >> GITS_DTE_ITTADDR_SHIFT; | ||
171 | + itt_addr <<= ITTADDR_SHIFT; /* 256 byte aligned */ | ||
172 | + | ||
173 | + ite.itel = address_space_ldq_le(as, itt_addr + | ||
174 | + (eventid * (sizeof(uint64_t) + | ||
175 | + sizeof(uint32_t))), MEMTXATTRS_UNSPECIFIED, | ||
176 | + res); | ||
177 | + | ||
178 | + if (*res == MEMTX_OK) { | ||
179 | + ite.iteh = address_space_ldl_le(as, itt_addr + | ||
180 | + (eventid * (sizeof(uint64_t) + | ||
181 | + sizeof(uint32_t))) + sizeof(uint32_t), | ||
182 | + MEMTXATTRS_UNSPECIFIED, res); | ||
183 | + | ||
184 | + if (*res == MEMTX_OK) { | ||
185 | + if (ite.itel & TABLE_ENTRY_VALID_MASK) { | ||
186 | + if ((ite.itel >> ITE_ENTRY_INTTYPE_SHIFT) & | ||
187 | + GITS_TYPE_PHYSICAL) { | ||
188 | + *pIntid = (ite.itel & ITE_ENTRY_INTID_MASK) >> | ||
189 | + ITE_ENTRY_INTID_SHIFT; | ||
190 | + *icid = ite.iteh & ITE_ENTRY_ICID_MASK; | ||
191 | + status = true; | ||
192 | + } | ||
193 | + } | ||
194 | + } | ||
195 | + } | ||
196 | + return status; | ||
197 | +} | ||
198 | + | ||
199 | +static uint64_t get_dte(GICv3ITSState *s, uint32_t devid, MemTxResult *res) | ||
200 | +{ | ||
201 | + AddressSpace *as = &s->gicv3->dma_as; | ||
202 | + uint64_t l2t_addr; | ||
203 | + uint64_t value; | ||
204 | + bool valid_l2t; | ||
205 | + uint32_t l2t_id; | ||
206 | + uint32_t max_l2_entries; | ||
207 | + | ||
208 | + if (s->dt.indirect) { | ||
209 | + l2t_id = devid / (s->dt.page_sz / L1TABLE_ENTRY_SIZE); | ||
210 | + | ||
211 | + value = address_space_ldq_le(as, | ||
212 | + s->dt.base_addr + | ||
213 | + (l2t_id * L1TABLE_ENTRY_SIZE), | ||
214 | + MEMTXATTRS_UNSPECIFIED, res); | ||
215 | + | ||
216 | + if (*res == MEMTX_OK) { | ||
217 | + valid_l2t = (value & L2_TABLE_VALID_MASK) != 0; | ||
218 | + | ||
219 | + if (valid_l2t) { | ||
220 | + max_l2_entries = s->dt.page_sz / s->dt.entry_sz; | ||
221 | + | ||
222 | + l2t_addr = value & ((1ULL << 51) - 1); | ||
223 | + | ||
224 | + value = address_space_ldq_le(as, l2t_addr + | ||
225 | + ((devid % max_l2_entries) * GITS_DTE_SIZE), | ||
226 | + MEMTXATTRS_UNSPECIFIED, res); | ||
227 | + } | ||
228 | + } | ||
229 | + } else { | ||
230 | + /* Flat level table */ | ||
231 | + value = address_space_ldq_le(as, s->dt.base_addr + | ||
232 | + (devid * GITS_DTE_SIZE), | ||
233 | + MEMTXATTRS_UNSPECIFIED, res); | ||
234 | + } | ||
235 | + | ||
236 | + return value; | ||
237 | +} | ||
238 | + | ||
239 | +/* | ||
240 | + * This function handles the processing of following commands based on | ||
241 | + * the ItsCmdType parameter passed:- | ||
242 | + * 1. triggering of lpi interrupt translation via ITS INT command | ||
243 | + * 2. triggering of lpi interrupt translation via gits_translater register | ||
244 | + * 3. handling of ITS CLEAR command | ||
245 | + * 4. handling of ITS DISCARD command | ||
246 | + */ | ||
247 | +static bool process_its_cmd(GICv3ITSState *s, uint64_t value, uint32_t offset, | ||
248 | + ItsCmdType cmd) | ||
249 | +{ | ||
250 | + AddressSpace *as = &s->gicv3->dma_as; | ||
251 | + uint32_t devid, eventid; | ||
252 | + MemTxResult res = MEMTX_OK; | ||
253 | + bool dte_valid; | ||
254 | + uint64_t dte = 0; | ||
255 | + uint32_t max_eventid; | ||
256 | + uint16_t icid = 0; | ||
257 | + uint32_t pIntid = 0; | ||
258 | + bool ite_valid = false; | ||
259 | + uint64_t cte = 0; | ||
260 | + bool cte_valid = false; | ||
261 | + bool result = false; | ||
262 | + | ||
263 | + if (cmd == NONE) { | ||
264 | + devid = offset; | ||
265 | + } else { | ||
266 | + devid = ((value & DEVID_MASK) >> DEVID_SHIFT); | ||
267 | + | ||
268 | + offset += NUM_BYTES_IN_DW; | ||
269 | + value = address_space_ldq_le(as, s->cq.base_addr + offset, | ||
270 | + MEMTXATTRS_UNSPECIFIED, &res); | ||
271 | + } | ||
272 | + | ||
273 | + if (res != MEMTX_OK) { | ||
274 | + return result; | ||
275 | + } | ||
276 | + | ||
277 | + eventid = (value & EVENTID_MASK); | ||
278 | + | ||
279 | + dte = get_dte(s, devid, &res); | ||
280 | + | ||
281 | + if (res != MEMTX_OK) { | ||
282 | + return result; | ||
283 | + } | ||
284 | + dte_valid = dte & TABLE_ENTRY_VALID_MASK; | ||
285 | + | ||
286 | + if (dte_valid) { | ||
287 | + max_eventid = (1UL << (((dte >> 1U) & SIZE_MASK) + 1)); | ||
288 | + | ||
289 | + ite_valid = get_ite(s, eventid, dte, &icid, &pIntid, &res); | ||
290 | + | ||
291 | + if (res != MEMTX_OK) { | ||
292 | + return result; | ||
293 | + } | ||
294 | + | ||
295 | + if (ite_valid) { | ||
296 | + cte_valid = get_cte(s, icid, &cte, &res); | ||
297 | + } | ||
298 | + | ||
299 | + if (res != MEMTX_OK) { | ||
300 | + return result; | ||
301 | + } | ||
302 | + } | ||
303 | + | ||
304 | + if ((devid > s->dt.maxids.max_devids) || !dte_valid || !ite_valid || | ||
305 | + !cte_valid || (eventid > max_eventid)) { | ||
306 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
307 | + "%s: invalid command attributes " | ||
308 | + "devid %d or eventid %d or invalid dte %d or" | ||
309 | + "invalid cte %d or invalid ite %d\n", | ||
310 | + __func__, devid, eventid, dte_valid, cte_valid, | ||
311 | + ite_valid); | ||
312 | + /* | ||
313 | + * in this implementation, in case of error | ||
314 | + * we ignore this command and move onto the next | ||
315 | + * command in the queue | ||
316 | + */ | ||
317 | + } else { | ||
318 | + /* | ||
319 | + * Current implementation only supports rdbase == procnum | ||
320 | + * Hence rdbase physical address is ignored | ||
321 | + */ | ||
322 | + if (cmd == DISCARD) { | ||
323 | + IteEntry ite = {}; | ||
324 | + /* remove mapping from interrupt translation table */ | ||
325 | + result = update_ite(s, eventid, dte, ite); | ||
326 | + } | ||
327 | + } | ||
328 | + | ||
329 | + return result; | ||
330 | +} | ||
331 | + | ||
332 | +static bool process_mapti(GICv3ITSState *s, uint64_t value, uint32_t offset, | ||
333 | + bool ignore_pInt) | ||
334 | +{ | ||
335 | + AddressSpace *as = &s->gicv3->dma_as; | ||
336 | + uint32_t devid, eventid; | ||
337 | + uint32_t pIntid = 0; | ||
338 | + uint32_t max_eventid, max_Intid; | ||
339 | + bool dte_valid; | ||
340 | + MemTxResult res = MEMTX_OK; | ||
341 | + uint16_t icid = 0; | ||
342 | + uint64_t dte = 0; | ||
343 | + IteEntry ite; | ||
344 | + uint32_t int_spurious = INTID_SPURIOUS; | ||
345 | + bool result = false; | ||
346 | + | ||
347 | + devid = ((value & DEVID_MASK) >> DEVID_SHIFT); | ||
348 | + offset += NUM_BYTES_IN_DW; | ||
349 | + value = address_space_ldq_le(as, s->cq.base_addr + offset, | ||
350 | + MEMTXATTRS_UNSPECIFIED, &res); | ||
351 | + | ||
352 | + if (res != MEMTX_OK) { | ||
353 | + return result; | ||
354 | + } | ||
355 | + | ||
356 | + eventid = (value & EVENTID_MASK); | ||
357 | + | ||
358 | + if (!ignore_pInt) { | ||
359 | + pIntid = ((value & pINTID_MASK) >> pINTID_SHIFT); | ||
360 | + } | ||
361 | + | ||
362 | + offset += NUM_BYTES_IN_DW; | ||
363 | + value = address_space_ldq_le(as, s->cq.base_addr + offset, | ||
364 | + MEMTXATTRS_UNSPECIFIED, &res); | ||
365 | + | ||
366 | + if (res != MEMTX_OK) { | ||
367 | + return result; | ||
368 | + } | ||
369 | + | ||
370 | + icid = value & ICID_MASK; | ||
371 | + | ||
372 | + dte = get_dte(s, devid, &res); | ||
373 | + | ||
374 | + if (res != MEMTX_OK) { | ||
375 | + return result; | ||
376 | + } | ||
377 | + dte_valid = dte & TABLE_ENTRY_VALID_MASK; | ||
378 | + | ||
379 | + max_eventid = (1UL << (((dte >> 1U) & SIZE_MASK) + 1)); | ||
380 | + | ||
381 | + if (!ignore_pInt) { | ||
382 | + max_Intid = (1ULL << (GICD_TYPER_IDBITS + 1)) - 1; | ||
383 | + } | ||
384 | + | ||
385 | + if ((devid > s->dt.maxids.max_devids) || (icid > s->ct.maxids.max_collids) | ||
386 | + || !dte_valid || (eventid > max_eventid) || | ||
387 | + (!ignore_pInt && (((pIntid < GICV3_LPI_INTID_START) || | ||
388 | + (pIntid > max_Intid)) && (pIntid != INTID_SPURIOUS)))) { | ||
389 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
390 | + "%s: invalid command attributes " | ||
391 | + "devid %d or icid %d or eventid %d or pIntid %d or" | ||
392 | + "unmapped dte %d\n", __func__, devid, icid, eventid, | ||
393 | + pIntid, dte_valid); | ||
394 | + /* | ||
395 | + * in this implementation, in case of error | ||
396 | + * we ignore this command and move onto the next | ||
397 | + * command in the queue | ||
398 | + */ | ||
399 | + } else { | ||
400 | + /* add ite entry to interrupt translation table */ | ||
401 | + ite.itel = (dte_valid & TABLE_ENTRY_VALID_MASK) | | ||
402 | + (GITS_TYPE_PHYSICAL << ITE_ENTRY_INTTYPE_SHIFT); | ||
403 | + | ||
404 | + if (ignore_pInt) { | ||
405 | + ite.itel |= (eventid << ITE_ENTRY_INTID_SHIFT); | ||
406 | + } else { | ||
407 | + ite.itel |= (pIntid << ITE_ENTRY_INTID_SHIFT); | ||
408 | + } | ||
409 | + ite.itel |= (int_spurious << ITE_ENTRY_INTSP_SHIFT); | ||
410 | + ite.iteh = icid; | ||
411 | + | ||
412 | + result = update_ite(s, eventid, dte, ite); | ||
413 | + } | ||
414 | + | ||
415 | + return result; | ||
416 | +} | ||
417 | + | ||
418 | static bool update_cte(GICv3ITSState *s, uint16_t icid, bool valid, | ||
419 | uint64_t rdbase) | ||
420 | { | ||
421 | @@ -XXX,XX +XXX,XX @@ static void process_cmdq(GICv3ITSState *s) | ||
422 | |||
423 | switch (cmd) { | ||
424 | case GITS_CMD_INT: | ||
425 | + res = process_its_cmd(s, data, cq_offset, INT); | ||
426 | break; | ||
427 | case GITS_CMD_CLEAR: | ||
428 | + res = process_its_cmd(s, data, cq_offset, CLEAR); | ||
429 | break; | ||
430 | case GITS_CMD_SYNC: | ||
431 | /* | ||
432 | @@ -XXX,XX +XXX,XX @@ static void process_cmdq(GICv3ITSState *s) | ||
433 | result = process_mapc(s, cq_offset); | ||
434 | break; | ||
435 | case GITS_CMD_MAPTI: | ||
436 | + result = process_mapti(s, data, cq_offset, false); | ||
437 | break; | ||
438 | case GITS_CMD_MAPI: | ||
439 | + result = process_mapti(s, data, cq_offset, true); | ||
440 | break; | ||
441 | case GITS_CMD_DISCARD: | ||
442 | + result = process_its_cmd(s, data, cq_offset, DISCARD); | ||
443 | break; | ||
444 | case GITS_CMD_INV: | ||
445 | case GITS_CMD_INVALL: | ||
446 | @@ -XXX,XX +XXX,XX @@ static MemTxResult gicv3_its_translation_write(void *opaque, hwaddr offset, | ||
447 | uint64_t data, unsigned size, | ||
448 | MemTxAttrs attrs) | ||
449 | { | ||
450 | - return MEMTX_OK; | ||
451 | + GICv3ITSState *s = (GICv3ITSState *)opaque; | ||
452 | + bool result = true; | ||
453 | + uint32_t devid = 0; | ||
454 | + | ||
455 | + switch (offset) { | ||
456 | + case GITS_TRANSLATER: | ||
457 | + if (s->ctlr & ITS_CTLR_ENABLED) { | ||
458 | + devid = attrs.requester_id; | ||
459 | + result = process_its_cmd(s, data, devid, NONE); | ||
460 | + } | ||
461 | + break; | ||
462 | + default: | ||
463 | + break; | ||
464 | + } | ||
465 | + | ||
466 | + if (result) { | ||
467 | + return MEMTX_OK; | ||
468 | + } else { | ||
469 | + return MEMTX_ERROR; | ||
470 | + } | ||
471 | } | ||
472 | |||
473 | static bool its_writel(GICv3ITSState *s, hwaddr offset, | ||
474 | -- | ||
475 | 2.20.1 | ||
476 | |||
477 | diff view generated by jsdifflib |
1 | From: Andrey Smirnov <andrew.smirnov@gmail.com> | 1 | From: Shashi Mallela <shashi.mallela@linaro.org> |
---|---|---|---|
2 | 2 | ||
3 | Code of imx_update() is slightly confusing since the "flags" variable | 3 | Added properties to enable ITS feature and define qemu system |
4 | doesn't really corespond to anything in real hardware and server as a | 4 | address space memory in gicv3 common,setup distributor and |
5 | kitchensink accumulating events normally reported via USR1 and USR2 | 5 | redistributor registers to indicate LPI support. |
6 | registers. | ||
7 | 6 | ||
8 | Change the code to explicitly evaluate state of interrupts reported | 7 | Signed-off-by: Shashi Mallela <shashi.mallela@linaro.org> |
9 | via USR1 and USR2 against corresponding masking bits and use the to | ||
10 | detemine if IRQ line should be asserted or not. | ||
11 | |||
12 | NOTE: Check for UTS1_TXEMPTY being set has been dropped for two | ||
13 | reasons: | ||
14 | |||
15 | 1. Emulation code implements a single character FIFO, so this flag | ||
16 | will always be set since characters are trasmitted as a part of | ||
17 | the code emulating "push" into the FIFO | ||
18 | |||
19 | 2. imx_update() is really just a function doing ORing and maksing | ||
20 | of reported events, so checking for UTS1_TXEMPTY should happen, | ||
21 | if it's ever really needed should probably happen outside of | ||
22 | it. | ||
23 | |||
24 | Cc: qemu-devel@nongnu.org | ||
25 | Cc: qemu-arm@nongnu.org | ||
26 | Cc: Bill Paul <wpaul@windriver.com> | ||
27 | Cc: Peter Maydell <peter.maydell@linaro.org> | ||
28 | Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> | ||
29 | Message-id: 20180315191141.6789-1-andrew.smirnov@gmail.com | ||
30 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | 8 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> |
9 | Tested-by: Neil Armstrong <narmstrong@baylibre.com> | ||
10 | Message-id: 20210910143951.92242-6-shashi.mallela@linaro.org | ||
31 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 11 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
32 | --- | 12 | --- |
33 | hw/char/imx_serial.c | 24 ++++++++++++++++-------- | 13 | hw/intc/gicv3_internal.h | 2 ++ |
34 | 1 file changed, 16 insertions(+), 8 deletions(-) | 14 | include/hw/intc/arm_gicv3_common.h | 1 + |
15 | hw/intc/arm_gicv3_common.c | 12 ++++++++++++ | ||
16 | hw/intc/arm_gicv3_dist.c | 5 ++++- | ||
17 | hw/intc/arm_gicv3_redist.c | 12 +++++++++--- | ||
18 | 5 files changed, 28 insertions(+), 4 deletions(-) | ||
35 | 19 | ||
36 | diff --git a/hw/char/imx_serial.c b/hw/char/imx_serial.c | 20 | diff --git a/hw/intc/gicv3_internal.h b/hw/intc/gicv3_internal.h |
37 | index XXXXXXX..XXXXXXX 100644 | 21 | index XXXXXXX..XXXXXXX 100644 |
38 | --- a/hw/char/imx_serial.c | 22 | --- a/hw/intc/gicv3_internal.h |
39 | +++ b/hw/char/imx_serial.c | 23 | +++ b/hw/intc/gicv3_internal.h |
40 | @@ -XXX,XX +XXX,XX @@ static const VMStateDescription vmstate_imx_serial = { | 24 | @@ -XXX,XX +XXX,XX @@ |
41 | 25 | #define GICD_CTLR_E1NWF (1U << 7) | |
42 | static void imx_update(IMXSerialState *s) | 26 | #define GICD_CTLR_RWP (1U << 31) |
43 | { | 27 | |
44 | - uint32_t flags; | 28 | +#define GICD_TYPER_LPIS_SHIFT 17 |
45 | + uint32_t usr1; | 29 | + |
46 | + uint32_t usr2; | 30 | /* 16 bits EventId */ |
47 | + uint32_t mask; | 31 | #define GICD_TYPER_IDBITS 0xf |
48 | 32 | ||
49 | - flags = (s->usr1 & s->ucr1) & (USR1_TRDY|USR1_RRDY); | 33 | diff --git a/include/hw/intc/arm_gicv3_common.h b/include/hw/intc/arm_gicv3_common.h |
50 | - if (s->ucr1 & UCR1_TXMPTYEN) { | 34 | index XXXXXXX..XXXXXXX 100644 |
51 | - flags |= (s->uts1 & UTS1_TXEMPTY); | 35 | --- a/include/hw/intc/arm_gicv3_common.h |
52 | - } else { | 36 | +++ b/include/hw/intc/arm_gicv3_common.h |
53 | - flags &= ~USR1_TRDY; | 37 | @@ -XXX,XX +XXX,XX @@ struct GICv3State { |
54 | - } | 38 | uint32_t num_cpu; |
55 | + /* | 39 | uint32_t num_irq; |
56 | + * Lucky for us TRDY and RRDY has the same offset in both USR1 and | 40 | uint32_t revision; |
57 | + * UCR1, so we can get away with something as simple as the | 41 | + bool lpi_enable; |
58 | + * following: | 42 | bool security_extn; |
59 | + */ | 43 | bool irq_reset_nonsecure; |
60 | + usr1 = s->usr1 & s->ucr1 & (USR1_TRDY | USR1_RRDY); | 44 | bool gicd_no_migration_shift_bug; |
61 | + /* | 45 | diff --git a/hw/intc/arm_gicv3_common.c b/hw/intc/arm_gicv3_common.c |
62 | + * Bits that we want in USR2 are not as conveniently laid out, | 46 | index XXXXXXX..XXXXXXX 100644 |
63 | + * unfortunately. | 47 | --- a/hw/intc/arm_gicv3_common.c |
64 | + */ | 48 | +++ b/hw/intc/arm_gicv3_common.c |
65 | + mask = (s->ucr1 & UCR1_TXMPTYEN) ? USR2_TXFE : 0; | 49 | @@ -XXX,XX +XXX,XX @@ static void arm_gicv3_common_realize(DeviceState *dev, Error **errp) |
66 | + usr2 = s->usr2 & mask; | 50 | return; |
67 | 51 | } | |
68 | - qemu_set_irq(s->irq, !!flags); | 52 | |
69 | + qemu_set_irq(s->irq, usr1 || usr2); | 53 | + if (s->lpi_enable && !s->dma) { |
54 | + error_setg(errp, "Redist-ITS: Guest 'sysmem' reference link not set"); | ||
55 | + return; | ||
56 | + } | ||
57 | + | ||
58 | s->cpu = g_new0(GICv3CPUState, s->num_cpu); | ||
59 | |||
60 | for (i = 0; i < s->num_cpu; i++) { | ||
61 | @@ -XXX,XX +XXX,XX @@ static void arm_gicv3_common_realize(DeviceState *dev, Error **errp) | ||
62 | (1 << 24) | | ||
63 | (i << 8) | | ||
64 | (last << 4); | ||
65 | + | ||
66 | + if (s->lpi_enable) { | ||
67 | + s->cpu[i].gicr_typer |= GICR_TYPER_PLPIS; | ||
68 | + } | ||
69 | } | ||
70 | } | 70 | } |
71 | 71 | ||
72 | static void imx_serial_reset(IMXSerialState *s) | 72 | @@ -XXX,XX +XXX,XX @@ static Property arm_gicv3_common_properties[] = { |
73 | DEFINE_PROP_UINT32("num-cpu", GICv3State, num_cpu, 1), | ||
74 | DEFINE_PROP_UINT32("num-irq", GICv3State, num_irq, 32), | ||
75 | DEFINE_PROP_UINT32("revision", GICv3State, revision, 3), | ||
76 | + DEFINE_PROP_BOOL("has-lpi", GICv3State, lpi_enable, 0), | ||
77 | DEFINE_PROP_BOOL("has-security-extensions", GICv3State, security_extn, 0), | ||
78 | DEFINE_PROP_ARRAY("redist-region-count", GICv3State, nb_redist_regions, | ||
79 | redist_region_count, qdev_prop_uint32, uint32_t), | ||
80 | + DEFINE_PROP_LINK("sysmem", GICv3State, dma, TYPE_MEMORY_REGION, | ||
81 | + MemoryRegion *), | ||
82 | DEFINE_PROP_END_OF_LIST(), | ||
83 | }; | ||
84 | |||
85 | diff --git a/hw/intc/arm_gicv3_dist.c b/hw/intc/arm_gicv3_dist.c | ||
86 | index XXXXXXX..XXXXXXX 100644 | ||
87 | --- a/hw/intc/arm_gicv3_dist.c | ||
88 | +++ b/hw/intc/arm_gicv3_dist.c | ||
89 | @@ -XXX,XX +XXX,XX @@ static bool gicd_readl(GICv3State *s, hwaddr offset, | ||
90 | * A3V == 1 (non-zero values of Affinity level 3 supported) | ||
91 | * IDbits == 0xf (we support 16-bit interrupt identifiers) | ||
92 | * DVIS == 0 (Direct virtual LPI injection not supported) | ||
93 | - * LPIS == 0 (LPIs not supported) | ||
94 | + * LPIS == 1 (LPIs are supported if affinity routing is enabled) | ||
95 | + * num_LPIs == 0b00000 (bits [15:11],Number of LPIs as indicated | ||
96 | + * by GICD_TYPER.IDbits) | ||
97 | * MBIS == 0 (message-based SPIs not supported) | ||
98 | * SecurityExtn == 1 if security extns supported | ||
99 | * CPUNumber == 0 since for us ARE is always 1 | ||
100 | @@ -XXX,XX +XXX,XX @@ static bool gicd_readl(GICv3State *s, hwaddr offset, | ||
101 | bool sec_extn = !(s->gicd_ctlr & GICD_CTLR_DS); | ||
102 | |||
103 | *data = (1 << 25) | (1 << 24) | (sec_extn << 10) | | ||
104 | + (s->lpi_enable << GICD_TYPER_LPIS_SHIFT) | | ||
105 | (0xf << 19) | itlinesnumber; | ||
106 | return true; | ||
107 | } | ||
108 | diff --git a/hw/intc/arm_gicv3_redist.c b/hw/intc/arm_gicv3_redist.c | ||
109 | index XXXXXXX..XXXXXXX 100644 | ||
110 | --- a/hw/intc/arm_gicv3_redist.c | ||
111 | +++ b/hw/intc/arm_gicv3_redist.c | ||
112 | @@ -XXX,XX +XXX,XX @@ static MemTxResult gicr_writel(GICv3CPUState *cs, hwaddr offset, | ||
113 | case GICR_CTLR: | ||
114 | /* For our implementation, GICR_TYPER.DPGS is 0 and so all | ||
115 | * the DPG bits are RAZ/WI. We don't do anything asynchronously, | ||
116 | - * so UWP and RWP are RAZ/WI. And GICR_TYPER.LPIS is 0 (we don't | ||
117 | - * implement LPIs) so Enable_LPIs is RES0. So there are no writable | ||
118 | - * bits for us. | ||
119 | + * so UWP and RWP are RAZ/WI. GICR_TYPER.LPIS is 1 (we | ||
120 | + * implement LPIs) so Enable_LPIs is programmable. | ||
121 | */ | ||
122 | + if (cs->gicr_typer & GICR_TYPER_PLPIS) { | ||
123 | + if (value & GICR_CTLR_ENABLE_LPIS) { | ||
124 | + cs->gicr_ctlr |= GICR_CTLR_ENABLE_LPIS; | ||
125 | + } else { | ||
126 | + cs->gicr_ctlr &= ~GICR_CTLR_ENABLE_LPIS; | ||
127 | + } | ||
128 | + } | ||
129 | return MEMTX_OK; | ||
130 | case GICR_STATUSR: | ||
131 | /* RAZ/WI for our implementation */ | ||
73 | -- | 132 | -- |
74 | 2.16.2 | 133 | 2.20.1 |
75 | 134 | ||
76 | 135 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | 1 | From: Shashi Mallela <shashi.mallela@linaro.org> | |
2 | |||
3 | Implemented lpi processing at redistributor to get lpi config info | ||
4 | from lpi configuration table,determine priority,set pending state in | ||
5 | lpi pending table and forward the lpi to cpuif.Added logic to invoke | ||
6 | redistributor lpi processing with translated LPI which set/clear LPI | ||
7 | from ITS device as part of ITS INT,CLEAR,DISCARD command and | ||
8 | GITS_TRANSLATER processing. | ||
9 | |||
10 | Signed-off-by: Shashi Mallela <shashi.mallela@linaro.org> | ||
11 | Tested-by: Neil Armstrong <narmstrong@baylibre.com> | ||
12 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
13 | Message-id: 20210910143951.92242-7-shashi.mallela@linaro.org | ||
14 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
15 | --- | ||
16 | hw/intc/gicv3_internal.h | 9 ++ | ||
17 | include/hw/intc/arm_gicv3_common.h | 7 ++ | ||
18 | hw/intc/arm_gicv3.c | 14 +++ | ||
19 | hw/intc/arm_gicv3_common.c | 1 + | ||
20 | hw/intc/arm_gicv3_cpuif.c | 7 +- | ||
21 | hw/intc/arm_gicv3_its.c | 23 +++++ | ||
22 | hw/intc/arm_gicv3_redist.c | 141 +++++++++++++++++++++++++++++ | ||
23 | 7 files changed, 200 insertions(+), 2 deletions(-) | ||
24 | |||
25 | diff --git a/hw/intc/gicv3_internal.h b/hw/intc/gicv3_internal.h | ||
26 | index XXXXXXX..XXXXXXX 100644 | ||
27 | --- a/hw/intc/gicv3_internal.h | ||
28 | +++ b/hw/intc/gicv3_internal.h | ||
29 | @@ -XXX,XX +XXX,XX @@ FIELD(GICR_PENDBASER, PHYADDR, 16, 36) | ||
30 | FIELD(GICR_PENDBASER, OUTERCACHE, 56, 3) | ||
31 | FIELD(GICR_PENDBASER, PTZ, 62, 1) | ||
32 | |||
33 | +#define GICR_PROPBASER_IDBITS_THRESHOLD 0xd | ||
34 | + | ||
35 | #define ICC_CTLR_EL1_CBPR (1U << 0) | ||
36 | #define ICC_CTLR_EL1_EOIMODE (1U << 1) | ||
37 | #define ICC_CTLR_EL1_PMHE (1U << 6) | ||
38 | @@ -XXX,XX +XXX,XX @@ FIELD(GITS_TYPER, CIL, 36, 1) | ||
39 | |||
40 | #define L1TABLE_ENTRY_SIZE 8 | ||
41 | |||
42 | +#define LPI_CTE_ENABLED TABLE_ENTRY_VALID_MASK | ||
43 | +#define LPI_PRIORITY_MASK 0xfc | ||
44 | + | ||
45 | #define GITS_CMDQ_ENTRY_SIZE 32 | ||
46 | #define NUM_BYTES_IN_DW 8 | ||
47 | |||
48 | @@ -XXX,XX +XXX,XX @@ FIELD(MAPC, RDBASE, 16, 32) | ||
49 | * Valid = 1 bit,RDBase = 36 bits(considering max RDBASE) | ||
50 | */ | ||
51 | #define GITS_CTE_SIZE (0x8ULL) | ||
52 | +#define GITS_CTE_RDBASE_PROCNUM_MASK MAKE_64BIT_MASK(1, RDBASE_PROCNUM_LENGTH) | ||
53 | |||
54 | /* Special interrupt IDs */ | ||
55 | #define INTID_SECURE 1020 | ||
56 | @@ -XXX,XX +XXX,XX @@ MemTxResult gicv3_redist_write(void *opaque, hwaddr offset, uint64_t data, | ||
57 | unsigned size, MemTxAttrs attrs); | ||
58 | void gicv3_dist_set_irq(GICv3State *s, int irq, int level); | ||
59 | void gicv3_redist_set_irq(GICv3CPUState *cs, int irq, int level); | ||
60 | +void gicv3_redist_process_lpi(GICv3CPUState *cs, int irq, int level); | ||
61 | +void gicv3_redist_lpi_pending(GICv3CPUState *cs, int irq, int level); | ||
62 | +void gicv3_redist_update_lpi(GICv3CPUState *cs); | ||
63 | void gicv3_redist_send_sgi(GICv3CPUState *cs, int grp, int irq, bool ns); | ||
64 | void gicv3_init_cpuif(GICv3State *s); | ||
65 | |||
66 | diff --git a/include/hw/intc/arm_gicv3_common.h b/include/hw/intc/arm_gicv3_common.h | ||
67 | index XXXXXXX..XXXXXXX 100644 | ||
68 | --- a/include/hw/intc/arm_gicv3_common.h | ||
69 | +++ b/include/hw/intc/arm_gicv3_common.h | ||
70 | @@ -XXX,XX +XXX,XX @@ struct GICv3CPUState { | ||
71 | * real state above; it doesn't need to be migrated. | ||
72 | */ | ||
73 | PendingIrq hppi; | ||
74 | + | ||
75 | + /* | ||
76 | + * Cached information recalculated from LPI tables | ||
77 | + * in guest memory | ||
78 | + */ | ||
79 | + PendingIrq hpplpi; | ||
80 | + | ||
81 | /* This is temporary working state, to avoid a malloc in gicv3_update() */ | ||
82 | bool seenbetter; | ||
83 | }; | ||
84 | diff --git a/hw/intc/arm_gicv3.c b/hw/intc/arm_gicv3.c | ||
85 | index XXXXXXX..XXXXXXX 100644 | ||
86 | --- a/hw/intc/arm_gicv3.c | ||
87 | +++ b/hw/intc/arm_gicv3.c | ||
88 | @@ -XXX,XX +XXX,XX @@ static void gicv3_redist_update_noirqset(GICv3CPUState *cs) | ||
89 | cs->hppi.grp = gicv3_irq_group(cs->gic, cs, cs->hppi.irq); | ||
90 | } | ||
91 | |||
92 | + if ((cs->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) && cs->gic->lpi_enable && | ||
93 | + (cs->hpplpi.prio != 0xff)) { | ||
94 | + if (irqbetter(cs, cs->hpplpi.irq, cs->hpplpi.prio)) { | ||
95 | + cs->hppi.irq = cs->hpplpi.irq; | ||
96 | + cs->hppi.prio = cs->hpplpi.prio; | ||
97 | + cs->hppi.grp = cs->hpplpi.grp; | ||
98 | + seenbetter = true; | ||
99 | + } | ||
100 | + } | ||
101 | + | ||
102 | /* If the best interrupt we just found would preempt whatever | ||
103 | * was the previous best interrupt before this update, then | ||
104 | * we know it's definitely the best one now. | ||
105 | @@ -XXX,XX +XXX,XX @@ static void gicv3_set_irq(void *opaque, int irq, int level) | ||
106 | |||
107 | static void arm_gicv3_post_load(GICv3State *s) | ||
108 | { | ||
109 | + int i; | ||
110 | /* Recalculate our cached idea of the current highest priority | ||
111 | * pending interrupt, but don't set IRQ or FIQ lines. | ||
112 | */ | ||
113 | + for (i = 0; i < s->num_cpu; i++) { | ||
114 | + gicv3_redist_update_lpi(&s->cpu[i]); | ||
115 | + } | ||
116 | gicv3_full_update_noirqset(s); | ||
117 | /* Repopulate the cache of GICv3CPUState pointers for target CPUs */ | ||
118 | gicv3_cache_all_target_cpustates(s); | ||
119 | diff --git a/hw/intc/arm_gicv3_common.c b/hw/intc/arm_gicv3_common.c | ||
120 | index XXXXXXX..XXXXXXX 100644 | ||
121 | --- a/hw/intc/arm_gicv3_common.c | ||
122 | +++ b/hw/intc/arm_gicv3_common.c | ||
123 | @@ -XXX,XX +XXX,XX @@ static void arm_gicv3_common_reset(DeviceState *dev) | ||
124 | memset(cs->gicr_ipriorityr, 0, sizeof(cs->gicr_ipriorityr)); | ||
125 | |||
126 | cs->hppi.prio = 0xff; | ||
127 | + cs->hpplpi.prio = 0xff; | ||
128 | |||
129 | /* State in the CPU interface must *not* be reset here, because it | ||
130 | * is part of the CPU's reset domain, not the GIC device's. | ||
131 | diff --git a/hw/intc/arm_gicv3_cpuif.c b/hw/intc/arm_gicv3_cpuif.c | ||
132 | index XXXXXXX..XXXXXXX 100644 | ||
133 | --- a/hw/intc/arm_gicv3_cpuif.c | ||
134 | +++ b/hw/intc/arm_gicv3_cpuif.c | ||
135 | @@ -XXX,XX +XXX,XX @@ static void icc_activate_irq(GICv3CPUState *cs, int irq) | ||
136 | cs->gicr_iactiver0 = deposit32(cs->gicr_iactiver0, irq, 1, 1); | ||
137 | cs->gicr_ipendr0 = deposit32(cs->gicr_ipendr0, irq, 1, 0); | ||
138 | gicv3_redist_update(cs); | ||
139 | - } else { | ||
140 | + } else if (irq < GICV3_LPI_INTID_START) { | ||
141 | gicv3_gicd_active_set(cs->gic, irq); | ||
142 | gicv3_gicd_pending_clear(cs->gic, irq); | ||
143 | gicv3_update(cs->gic, irq, 1); | ||
144 | + } else { | ||
145 | + gicv3_redist_lpi_pending(cs, irq, 0); | ||
146 | } | ||
147 | } | ||
148 | |||
149 | @@ -XXX,XX +XXX,XX @@ static void icc_eoir_write(CPUARMState *env, const ARMCPRegInfo *ri, | ||
150 | trace_gicv3_icc_eoir_write(is_eoir0 ? 0 : 1, | ||
151 | gicv3_redist_affid(cs), value); | ||
152 | |||
153 | - if (irq >= cs->gic->num_irq) { | ||
154 | + if ((irq >= cs->gic->num_irq) && | ||
155 | + !(cs->gic->lpi_enable && (irq >= GICV3_LPI_INTID_START))) { | ||
156 | /* This handles two cases: | ||
157 | * 1. If software writes the ID of a spurious interrupt [ie 1020-1023] | ||
158 | * to the GICC_EOIR, the GIC ignores that write. | ||
159 | diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c | ||
160 | index XXXXXXX..XXXXXXX 100644 | ||
161 | --- a/hw/intc/arm_gicv3_its.c | ||
162 | +++ b/hw/intc/arm_gicv3_its.c | ||
163 | @@ -XXX,XX +XXX,XX @@ static bool process_its_cmd(GICv3ITSState *s, uint64_t value, uint32_t offset, | ||
164 | uint64_t cte = 0; | ||
165 | bool cte_valid = false; | ||
166 | bool result = false; | ||
167 | + uint64_t rdbase; | ||
168 | |||
169 | if (cmd == NONE) { | ||
170 | devid = offset; | ||
171 | @@ -XXX,XX +XXX,XX @@ static bool process_its_cmd(GICv3ITSState *s, uint64_t value, uint32_t offset, | ||
172 | * Current implementation only supports rdbase == procnum | ||
173 | * Hence rdbase physical address is ignored | ||
174 | */ | ||
175 | + rdbase = (cte & GITS_CTE_RDBASE_PROCNUM_MASK) >> 1U; | ||
176 | + | ||
177 | + if (rdbase > s->gicv3->num_cpu) { | ||
178 | + return result; | ||
179 | + } | ||
180 | + | ||
181 | + if ((cmd == CLEAR) || (cmd == DISCARD)) { | ||
182 | + gicv3_redist_process_lpi(&s->gicv3->cpu[rdbase], pIntid, 0); | ||
183 | + } else { | ||
184 | + gicv3_redist_process_lpi(&s->gicv3->cpu[rdbase], pIntid, 1); | ||
185 | + } | ||
186 | + | ||
187 | if (cmd == DISCARD) { | ||
188 | IteEntry ite = {}; | ||
189 | /* remove mapping from interrupt translation table */ | ||
190 | @@ -XXX,XX +XXX,XX @@ static void process_cmdq(GICv3ITSState *s) | ||
191 | MemTxResult res = MEMTX_OK; | ||
192 | bool result = true; | ||
193 | uint8_t cmd; | ||
194 | + int i; | ||
195 | |||
196 | if (!(s->ctlr & ITS_CTLR_ENABLED)) { | ||
197 | return; | ||
198 | @@ -XXX,XX +XXX,XX @@ static void process_cmdq(GICv3ITSState *s) | ||
199 | break; | ||
200 | case GITS_CMD_INV: | ||
201 | case GITS_CMD_INVALL: | ||
202 | + /* | ||
203 | + * Current implementation doesn't cache any ITS tables, | ||
204 | + * but the calculated lpi priority information. We only | ||
205 | + * need to trigger lpi priority re-calculation to be in | ||
206 | + * sync with LPI config table or pending table changes. | ||
207 | + */ | ||
208 | + for (i = 0; i < s->gicv3->num_cpu; i++) { | ||
209 | + gicv3_redist_update_lpi(&s->gicv3->cpu[i]); | ||
210 | + } | ||
211 | break; | ||
212 | default: | ||
213 | break; | ||
214 | diff --git a/hw/intc/arm_gicv3_redist.c b/hw/intc/arm_gicv3_redist.c | ||
215 | index XXXXXXX..XXXXXXX 100644 | ||
216 | --- a/hw/intc/arm_gicv3_redist.c | ||
217 | +++ b/hw/intc/arm_gicv3_redist.c | ||
218 | @@ -XXX,XX +XXX,XX @@ static MemTxResult gicr_writel(GICv3CPUState *cs, hwaddr offset, | ||
219 | if (cs->gicr_typer & GICR_TYPER_PLPIS) { | ||
220 | if (value & GICR_CTLR_ENABLE_LPIS) { | ||
221 | cs->gicr_ctlr |= GICR_CTLR_ENABLE_LPIS; | ||
222 | + /* Check for any pending interr in pending table */ | ||
223 | + gicv3_redist_update_lpi(cs); | ||
224 | + gicv3_redist_update(cs); | ||
225 | } else { | ||
226 | cs->gicr_ctlr &= ~GICR_CTLR_ENABLE_LPIS; | ||
227 | } | ||
228 | @@ -XXX,XX +XXX,XX @@ MemTxResult gicv3_redist_write(void *opaque, hwaddr offset, uint64_t data, | ||
229 | return r; | ||
230 | } | ||
231 | |||
232 | +static void gicv3_redist_check_lpi_priority(GICv3CPUState *cs, int irq) | ||
233 | +{ | ||
234 | + AddressSpace *as = &cs->gic->dma_as; | ||
235 | + uint64_t lpict_baddr; | ||
236 | + uint8_t lpite; | ||
237 | + uint8_t prio; | ||
238 | + | ||
239 | + lpict_baddr = cs->gicr_propbaser & R_GICR_PROPBASER_PHYADDR_MASK; | ||
240 | + | ||
241 | + address_space_read(as, lpict_baddr + ((irq - GICV3_LPI_INTID_START) * | ||
242 | + sizeof(lpite)), MEMTXATTRS_UNSPECIFIED, &lpite, | ||
243 | + sizeof(lpite)); | ||
244 | + | ||
245 | + if (!(lpite & LPI_CTE_ENABLED)) { | ||
246 | + return; | ||
247 | + } | ||
248 | + | ||
249 | + if (cs->gic->gicd_ctlr & GICD_CTLR_DS) { | ||
250 | + prio = lpite & LPI_PRIORITY_MASK; | ||
251 | + } else { | ||
252 | + prio = ((lpite & LPI_PRIORITY_MASK) >> 1) | 0x80; | ||
253 | + } | ||
254 | + | ||
255 | + if ((prio < cs->hpplpi.prio) || | ||
256 | + ((prio == cs->hpplpi.prio) && (irq <= cs->hpplpi.irq))) { | ||
257 | + cs->hpplpi.irq = irq; | ||
258 | + cs->hpplpi.prio = prio; | ||
259 | + /* LPIs are always non-secure Grp1 interrupts */ | ||
260 | + cs->hpplpi.grp = GICV3_G1NS; | ||
261 | + } | ||
262 | +} | ||
263 | + | ||
264 | +void gicv3_redist_update_lpi(GICv3CPUState *cs) | ||
265 | +{ | ||
266 | + /* | ||
267 | + * This function scans the LPI pending table and for each pending | ||
268 | + * LPI, reads the corresponding entry from LPI configuration table | ||
269 | + * to extract the priority info and determine if the current LPI | ||
270 | + * priority is lower than the last computed high priority lpi interrupt. | ||
271 | + * If yes, replace current LPI as the new high priority lpi interrupt. | ||
272 | + */ | ||
273 | + AddressSpace *as = &cs->gic->dma_as; | ||
274 | + uint64_t lpipt_baddr; | ||
275 | + uint32_t pendt_size = 0; | ||
276 | + uint8_t pend; | ||
277 | + int i, bit; | ||
278 | + uint64_t idbits; | ||
279 | + | ||
280 | + idbits = MIN(FIELD_EX64(cs->gicr_propbaser, GICR_PROPBASER, IDBITS), | ||
281 | + GICD_TYPER_IDBITS); | ||
282 | + | ||
283 | + if (!(cs->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) || !cs->gicr_propbaser || | ||
284 | + !cs->gicr_pendbaser) { | ||
285 | + return; | ||
286 | + } | ||
287 | + | ||
288 | + cs->hpplpi.prio = 0xff; | ||
289 | + | ||
290 | + lpipt_baddr = cs->gicr_pendbaser & R_GICR_PENDBASER_PHYADDR_MASK; | ||
291 | + | ||
292 | + /* Determine the highest priority pending interrupt among LPIs */ | ||
293 | + pendt_size = (1ULL << (idbits + 1)); | ||
294 | + | ||
295 | + for (i = GICV3_LPI_INTID_START / 8; i < pendt_size / 8; i++) { | ||
296 | + address_space_read(as, lpipt_baddr + i, MEMTXATTRS_UNSPECIFIED, &pend, | ||
297 | + sizeof(pend)); | ||
298 | + | ||
299 | + while (pend) { | ||
300 | + bit = ctz32(pend); | ||
301 | + gicv3_redist_check_lpi_priority(cs, i * 8 + bit); | ||
302 | + pend &= ~(1 << bit); | ||
303 | + } | ||
304 | + } | ||
305 | +} | ||
306 | + | ||
307 | +void gicv3_redist_lpi_pending(GICv3CPUState *cs, int irq, int level) | ||
308 | +{ | ||
309 | + /* | ||
310 | + * This function updates the pending bit in lpi pending table for | ||
311 | + * the irq being activated or deactivated. | ||
312 | + */ | ||
313 | + AddressSpace *as = &cs->gic->dma_as; | ||
314 | + uint64_t lpipt_baddr; | ||
315 | + bool ispend = false; | ||
316 | + uint8_t pend; | ||
317 | + | ||
318 | + /* | ||
319 | + * get the bit value corresponding to this irq in the | ||
320 | + * lpi pending table | ||
321 | + */ | ||
322 | + lpipt_baddr = cs->gicr_pendbaser & R_GICR_PENDBASER_PHYADDR_MASK; | ||
323 | + | ||
324 | + address_space_read(as, lpipt_baddr + ((irq / 8) * sizeof(pend)), | ||
325 | + MEMTXATTRS_UNSPECIFIED, &pend, sizeof(pend)); | ||
326 | + | ||
327 | + ispend = extract32(pend, irq % 8, 1); | ||
328 | + | ||
329 | + /* no change in the value of pending bit, return */ | ||
330 | + if (ispend == level) { | ||
331 | + return; | ||
332 | + } | ||
333 | + pend = deposit32(pend, irq % 8, 1, level ? 1 : 0); | ||
334 | + | ||
335 | + address_space_write(as, lpipt_baddr + ((irq / 8) * sizeof(pend)), | ||
336 | + MEMTXATTRS_UNSPECIFIED, &pend, sizeof(pend)); | ||
337 | + | ||
338 | + /* | ||
339 | + * check if this LPI is better than the current hpplpi, if yes | ||
340 | + * just set hpplpi.prio and .irq without doing a full rescan | ||
341 | + */ | ||
342 | + if (level) { | ||
343 | + gicv3_redist_check_lpi_priority(cs, irq); | ||
344 | + } else { | ||
345 | + if (irq == cs->hpplpi.irq) { | ||
346 | + gicv3_redist_update_lpi(cs); | ||
347 | + } | ||
348 | + } | ||
349 | +} | ||
350 | + | ||
351 | +void gicv3_redist_process_lpi(GICv3CPUState *cs, int irq, int level) | ||
352 | +{ | ||
353 | + uint64_t idbits; | ||
354 | + | ||
355 | + idbits = MIN(FIELD_EX64(cs->gicr_propbaser, GICR_PROPBASER, IDBITS), | ||
356 | + GICD_TYPER_IDBITS); | ||
357 | + | ||
358 | + if (!(cs->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) || !cs->gicr_propbaser || | ||
359 | + !cs->gicr_pendbaser || (irq > (1ULL << (idbits + 1)) - 1) || | ||
360 | + irq < GICV3_LPI_INTID_START) { | ||
361 | + return; | ||
362 | + } | ||
363 | + | ||
364 | + /* set/clear the pending bit for this irq */ | ||
365 | + gicv3_redist_lpi_pending(cs, irq, level); | ||
366 | + | ||
367 | + gicv3_redist_update(cs); | ||
368 | +} | ||
369 | + | ||
370 | void gicv3_redist_set_irq(GICv3CPUState *cs, int irq, int level) | ||
371 | { | ||
372 | /* Update redistributor state for a change in an external PPI input line */ | ||
373 | -- | ||
374 | 2.20.1 | ||
375 | |||
376 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Shashi Mallela <shashi.mallela@linaro.org> | ||
1 | 2 | ||
3 | Added expected IORT files applicable with latest GICv3 | ||
4 | ITS changes.Temporarily differences in these files are | ||
5 | okay. | ||
6 | |||
7 | Signed-off-by: Shashi Mallela <shashi.mallela@linaro.org> | ||
8 | Acked-by: Igor Mammedov <imammedo@redhat.com> | ||
9 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
10 | Message-id: 20210910143951.92242-8-shashi.mallela@linaro.org | ||
11 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
12 | --- | ||
13 | tests/qtest/bios-tables-test-allowed-diff.h | 4 ++++ | ||
14 | tests/data/acpi/virt/IORT | 0 | ||
15 | tests/data/acpi/virt/IORT.memhp | 0 | ||
16 | tests/data/acpi/virt/IORT.numamem | 0 | ||
17 | tests/data/acpi/virt/IORT.pxb | 0 | ||
18 | 5 files changed, 4 insertions(+) | ||
19 | create mode 100644 tests/data/acpi/virt/IORT | ||
20 | create mode 100644 tests/data/acpi/virt/IORT.memhp | ||
21 | create mode 100644 tests/data/acpi/virt/IORT.numamem | ||
22 | create mode 100644 tests/data/acpi/virt/IORT.pxb | ||
23 | |||
24 | diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h | ||
25 | index XXXXXXX..XXXXXXX 100644 | ||
26 | --- a/tests/qtest/bios-tables-test-allowed-diff.h | ||
27 | +++ b/tests/qtest/bios-tables-test-allowed-diff.h | ||
28 | @@ -1 +1,5 @@ | ||
29 | /* List of comma-separated changed AML files to ignore */ | ||
30 | +"tests/data/acpi/virt/IORT", | ||
31 | +"tests/data/acpi/virt/IORT.memhp", | ||
32 | +"tests/data/acpi/virt/IORT.numamem", | ||
33 | +"tests/data/acpi/virt/IORT.pxb", | ||
34 | diff --git a/tests/data/acpi/virt/IORT b/tests/data/acpi/virt/IORT | ||
35 | new file mode 100644 | ||
36 | index XXXXXXX..XXXXXXX | ||
37 | diff --git a/tests/data/acpi/virt/IORT.memhp b/tests/data/acpi/virt/IORT.memhp | ||
38 | new file mode 100644 | ||
39 | index XXXXXXX..XXXXXXX | ||
40 | diff --git a/tests/data/acpi/virt/IORT.numamem b/tests/data/acpi/virt/IORT.numamem | ||
41 | new file mode 100644 | ||
42 | index XXXXXXX..XXXXXXX | ||
43 | diff --git a/tests/data/acpi/virt/IORT.pxb b/tests/data/acpi/virt/IORT.pxb | ||
44 | new file mode 100644 | ||
45 | index XXXXXXX..XXXXXXX | ||
46 | -- | ||
47 | 2.20.1 | ||
48 | |||
49 | diff view generated by jsdifflib |
1 | From: Wei Huang <wei@redhat.com> | 1 | From: Shashi Mallela <shashi.mallela@linaro.org> |
---|---|---|---|
2 | 2 | ||
3 | For guest kernel that supports KASLR, the load address can change every | 3 | Included creation of ITS as part of virt platform GIC |
4 | time when guest VM runs. To find the physical base address correctly, | 4 | initialization. This Emulated ITS model now co-exists with kvm |
5 | current QEMU dump searches VMCOREINFO for the string "NUMBER(phys_base)=". | 5 | ITS and is enabled in absence of kvm irq kernel support in a |
6 | However this string pattern is only available on x86_64. AArch64 uses a | 6 | platform. |
7 | different field, called "NUMBER(PHYS_OFFSET)=". This patch makes sure | ||
8 | QEMU dump uses the correct string on AArch64. | ||
9 | 7 | ||
10 | Signed-off-by: Wei Huang <wei@redhat.com> | 8 | Signed-off-by: Shashi Mallela <shashi.mallela@linaro.org> |
11 | Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> | 9 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> |
12 | Message-id: 1520615003-20869-1-git-send-email-wei@redhat.com | 10 | Message-id: 20210910143951.92242-9-shashi.mallela@linaro.org |
13 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 11 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
14 | --- | 12 | --- |
15 | dump.c | 14 +++++++++++--- | 13 | include/hw/arm/virt.h | 2 ++ |
16 | 1 file changed, 11 insertions(+), 3 deletions(-) | 14 | target/arm/kvm_arm.h | 4 ++-- |
15 | hw/arm/virt.c | 29 +++++++++++++++++++++++++++-- | ||
16 | 3 files changed, 31 insertions(+), 4 deletions(-) | ||
17 | 17 | ||
18 | diff --git a/dump.c b/dump.c | 18 | diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h |
19 | index XXXXXXX..XXXXXXX 100644 | 19 | index XXXXXXX..XXXXXXX 100644 |
20 | --- a/dump.c | 20 | --- a/include/hw/arm/virt.h |
21 | +++ b/dump.c | 21 | +++ b/include/hw/arm/virt.h |
22 | @@ -XXX,XX +XXX,XX @@ static void vmcoreinfo_update_phys_base(DumpState *s) | 22 | @@ -XXX,XX +XXX,XX @@ struct VirtMachineClass { |
23 | 23 | MachineClass parent; | |
24 | lines = g_strsplit((char *)vmci, "\n", -1); | 24 | bool disallow_affinity_adjustment; |
25 | for (i = 0; lines[i]; i++) { | 25 | bool no_its; |
26 | - if (g_str_has_prefix(lines[i], "NUMBER(phys_base)=")) { | 26 | + bool no_tcg_its; |
27 | - if (qemu_strtou64(lines[i] + 18, NULL, 16, | 27 | bool no_pmu; |
28 | + const char *prefix = NULL; | 28 | bool claim_edge_triggered_timers; |
29 | bool smbios_old_sys_ver; | ||
30 | @@ -XXX,XX +XXX,XX @@ struct VirtMachineState { | ||
31 | bool highmem; | ||
32 | bool highmem_ecam; | ||
33 | bool its; | ||
34 | + bool tcg_its; | ||
35 | bool virt; | ||
36 | bool ras; | ||
37 | bool mte; | ||
38 | diff --git a/target/arm/kvm_arm.h b/target/arm/kvm_arm.h | ||
39 | index XXXXXXX..XXXXXXX 100644 | ||
40 | --- a/target/arm/kvm_arm.h | ||
41 | +++ b/target/arm/kvm_arm.h | ||
42 | @@ -XXX,XX +XXX,XX @@ static inline const char *its_class_name(void) | ||
43 | /* KVM implementation requires this capability */ | ||
44 | return kvm_direct_msi_enabled() ? "arm-its-kvm" : NULL; | ||
45 | } else { | ||
46 | - /* Software emulation is not implemented yet */ | ||
47 | - return NULL; | ||
48 | + /* Software emulation based model */ | ||
49 | + return "arm-gicv3-its"; | ||
50 | } | ||
51 | } | ||
52 | |||
53 | diff --git a/hw/arm/virt.c b/hw/arm/virt.c | ||
54 | index XXXXXXX..XXXXXXX 100644 | ||
55 | --- a/hw/arm/virt.c | ||
56 | +++ b/hw/arm/virt.c | ||
57 | @@ -XXX,XX +XXX,XX @@ static void create_its(VirtMachineState *vms) | ||
58 | const char *itsclass = its_class_name(); | ||
59 | DeviceState *dev; | ||
60 | |||
61 | + if (!strcmp(itsclass, "arm-gicv3-its")) { | ||
62 | + if (!vms->tcg_its) { | ||
63 | + itsclass = NULL; | ||
64 | + } | ||
65 | + } | ||
29 | + | 66 | + |
30 | + if (s->dump_info.d_machine == EM_X86_64) { | 67 | if (!itsclass) { |
31 | + prefix = "NUMBER(phys_base)="; | 68 | /* Do nothing if not supported */ |
32 | + } else if (s->dump_info.d_machine == EM_AARCH64) { | 69 | return; |
33 | + prefix = "NUMBER(PHYS_OFFSET)="; | 70 | @@ -XXX,XX +XXX,XX @@ static void create_v2m(VirtMachineState *vms) |
71 | vms->msi_controller = VIRT_MSI_CTRL_GICV2M; | ||
72 | } | ||
73 | |||
74 | -static void create_gic(VirtMachineState *vms) | ||
75 | +static void create_gic(VirtMachineState *vms, MemoryRegion *mem) | ||
76 | { | ||
77 | MachineState *ms = MACHINE(vms); | ||
78 | /* We create a standalone GIC */ | ||
79 | @@ -XXX,XX +XXX,XX @@ static void create_gic(VirtMachineState *vms) | ||
80 | nb_redist_regions); | ||
81 | qdev_prop_set_uint32(vms->gic, "redist-region-count[0]", redist0_count); | ||
82 | |||
83 | + if (!kvm_irqchip_in_kernel()) { | ||
84 | + if (vms->tcg_its) { | ||
85 | + object_property_set_link(OBJECT(vms->gic), "sysmem", | ||
86 | + OBJECT(mem), &error_fatal); | ||
87 | + qdev_prop_set_bit(vms->gic, "has-lpi", true); | ||
88 | + } | ||
34 | + } | 89 | + } |
35 | + | 90 | + |
36 | + if (prefix && g_str_has_prefix(lines[i], prefix)) { | 91 | if (nb_redist_regions == 2) { |
37 | + if (qemu_strtou64(lines[i] + strlen(prefix), NULL, 16, | 92 | uint32_t redist1_capacity = |
38 | &phys_base) < 0) { | 93 | vms->memmap[VIRT_HIGH_GIC_REDIST2].size / GICV3_REDIST_SIZE; |
39 | - warn_report("Failed to read NUMBER(phys_base)="); | 94 | @@ -XXX,XX +XXX,XX @@ static void machvirt_init(MachineState *machine) |
40 | + warn_report("Failed to read %s", prefix); | 95 | |
41 | } else { | 96 | virt_flash_fdt(vms, sysmem, secure_sysmem ?: sysmem); |
42 | s->dump_info.phys_base = phys_base; | 97 | |
43 | } | 98 | - create_gic(vms); |
99 | + create_gic(vms, sysmem); | ||
100 | |||
101 | virt_cpu_post_init(vms, sysmem); | ||
102 | |||
103 | @@ -XXX,XX +XXX,XX @@ static void virt_instance_init(Object *obj) | ||
104 | } else { | ||
105 | /* Default allows ITS instantiation */ | ||
106 | vms->its = true; | ||
107 | + | ||
108 | + if (vmc->no_tcg_its) { | ||
109 | + vms->tcg_its = false; | ||
110 | + } else { | ||
111 | + vms->tcg_its = true; | ||
112 | + } | ||
113 | } | ||
114 | |||
115 | /* Default disallows iommu instantiation */ | ||
116 | @@ -XXX,XX +XXX,XX @@ DEFINE_VIRT_MACHINE_AS_LATEST(6, 2) | ||
117 | |||
118 | static void virt_machine_6_1_options(MachineClass *mc) | ||
119 | { | ||
120 | + VirtMachineClass *vmc = VIRT_MACHINE_CLASS(OBJECT_CLASS(mc)); | ||
121 | + | ||
122 | virt_machine_6_2_options(mc); | ||
123 | compat_props_add(mc->compat_props, hw_compat_6_1, hw_compat_6_1_len); | ||
124 | + | ||
125 | + /* qemu ITS was introduced with 6.2 */ | ||
126 | + vmc->no_tcg_its = true; | ||
127 | } | ||
128 | DEFINE_VIRT_MACHINE(6, 1) | ||
129 | |||
44 | -- | 130 | -- |
45 | 2.16.2 | 131 | 2.20.1 |
46 | 132 | ||
47 | 133 | diff view generated by jsdifflib |
1 | From: Guenter Roeck <linux@roeck-us.net> | 1 | From: Shashi Mallela <shashi.mallela@linaro.org> |
---|---|---|---|
2 | 2 | ||
3 | The sabrelite machine model used by qemu-system-arm is based on the | 3 | Updated expected IORT files applicable with latest GICv3 |
4 | Freescale/NXP i.MX6Q processor. This SoC has an on-board ethernet | 4 | ITS changes. |
5 | controller which is supported in QEMU using the imx_fec.c module | ||
6 | (actually called imx.enet for this model.) | ||
7 | 5 | ||
8 | The include/hw/arm/fsm-imx6.h file defines the interrupt vectors for the | 6 | Full diff of new file disassembly: |
9 | imx.enet device like this: | ||
10 | 7 | ||
11 | #define FSL_IMX6_ENET_MAC_1588_IRQ 118 | 8 | /* |
12 | #define FSL_IMX6_ENET_MAC_IRQ 119 | 9 | * Intel ACPI Component Architecture |
10 | * AML/ASL+ Disassembler version 20180629 (64-bit version) | ||
11 | * Copyright (c) 2000 - 2018 Intel Corporation | ||
12 | * | ||
13 | * Disassembly of tests/data/acpi/virt/IORT.pxb, Tue Jun 29 17:35:38 2021 | ||
14 | * | ||
15 | * ACPI Data Table [IORT] | ||
16 | * | ||
17 | * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue | ||
18 | */ | ||
13 | 19 | ||
14 | According to https://www.nxp.com/docs/en/reference-manual/IMX6DQRM.pdf, | 20 | [000h 0000 4] Signature : "IORT" [IO Remapping Table] |
15 | page 225, in Table 3-1. ARM Cortex A9 domain interrupt summary, | 21 | [004h 0004 4] Table Length : 0000007C |
16 | interrupts are as follows. | 22 | [008h 0008 1] Revision : 00 |
23 | [009h 0009 1] Checksum : 07 | ||
24 | [00Ah 0010 6] Oem ID : "BOCHS " | ||
25 | [010h 0016 8] Oem Table ID : "BXPC " | ||
26 | [018h 0024 4] Oem Revision : 00000001 | ||
27 | [01Ch 0028 4] Asl Compiler ID : "BXPC" | ||
28 | [020h 0032 4] Asl Compiler Revision : 00000001 | ||
17 | 29 | ||
18 | 150 ENET MAC 0 IRQ | 30 | [024h 0036 4] Node Count : 00000002 |
19 | 151 ENET MAC 0 1588 Timer interrupt | 31 | [028h 0040 4] Node Offset : 00000030 |
32 | [02Ch 0044 4] Reserved : 00000000 | ||
20 | 33 | ||
21 | where | 34 | [030h 0048 1] Type : 00 |
35 | [031h 0049 2] Length : 0018 | ||
36 | [033h 0051 1] Revision : 00 | ||
37 | [034h 0052 4] Reserved : 00000000 | ||
38 | [038h 0056 4] Mapping Count : 00000000 | ||
39 | [03Ch 0060 4] Mapping Offset : 00000000 | ||
22 | 40 | ||
23 | 150 - 32 == 118 | 41 | [040h 0064 4] ItsCount : 00000001 |
24 | 151 - 32 == 119 | 42 | [044h 0068 4] Identifiers : 00000000 |
25 | 43 | ||
26 | In other words, the vector definitions in the fsl-imx6.h file are reversed. | 44 | [048h 0072 1] Type : 02 |
45 | [049h 0073 2] Length : 0034 | ||
46 | [04Bh 0075 1] Revision : 00 | ||
47 | [04Ch 0076 4] Reserved : 00000000 | ||
48 | [050h 0080 4] Mapping Count : 00000001 | ||
49 | [054h 0084 4] Mapping Offset : 00000020 | ||
27 | 50 | ||
28 | Fixing the interrupts alone causes problems with older Linux kernels: | 51 | [058h 0088 8] Memory Properties : [IORT Memory Access Properties] |
29 | The Ethernet interface will fail to probe with Linux v4.9 and earlier. | 52 | [058h 0088 4] Cache Coherency : 00000001 |
30 | Linux v4.1 and earlier will crash due to a bug in Ethernet driver probe | 53 | [05Ch 0092 1] Hints (decoded below) : 00 |
31 | error handling. This is a Linux kernel problem, not a qemu problem: | 54 | Transient : 0 |
32 | the Linux kernel only worked by accident since it requested both interrupts. | 55 | Write Allocate : 0 |
56 | Read Allocate : 0 | ||
57 | Override : 0 | ||
58 | [05Dh 0093 2] Reserved : 0000 | ||
59 | [05Fh 0095 1] Memory Flags (decoded below) : 03 | ||
60 | Coherency : 1 | ||
61 | Device Attribute : 1 | ||
62 | [060h 0096 4] ATS Attribute : 00000000 | ||
63 | [064h 0100 4] PCI Segment Number : 00000000 | ||
64 | [068h 0104 1] Memory Size Limit : 00 | ||
65 | [069h 0105 3] Reserved : 000000 | ||
33 | 66 | ||
34 | For backward compatibility, generate the Ethernet interrupt on both interrupt | 67 | [068h 0104 4] Input base : 00000000 |
35 | lines. This was shown to work from all Linux kernel releases starting with | 68 | [06Ch 0108 4] ID Count : 0000FFFF |
36 | v3.16. | 69 | [070h 0112 4] Output Base : 00000000 |
70 | [074h 0116 4] Output Reference : 00000030 | ||
71 | [078h 0120 4] Flags (decoded below) : 00000000 | ||
72 | Single Mapping : 0 | ||
37 | 73 | ||
38 | Link: https://bugs.launchpad.net/qemu/+bug/1753309 | 74 | Raw Table Data: Length 124 (0x7C) |
39 | Signed-off-by: Guenter Roeck <linux@roeck-us.net> | 75 | |
40 | Message-id: 1520723090-22130-1-git-send-email-linux@roeck-us.net | 76 | 0000: 49 4F 52 54 7C 00 00 00 00 07 42 4F 43 48 53 20 // IORT|.....BOCHS |
77 | 0010: 42 58 50 43 20 20 20 20 01 00 00 00 42 58 50 43 // BXPC ....BXPC | ||
78 | 0020: 01 00 00 00 02 00 00 00 30 00 00 00 00 00 00 00 // ........0....... | ||
79 | 0030: 00 18 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // ................ | ||
80 | 0040: 01 00 00 00 00 00 00 00 02 34 00 00 00 00 00 00 // .........4...... | ||
81 | 0050: 01 00 00 00 20 00 00 00 01 00 00 00 00 00 00 03 // .... ........... | ||
82 | 0060: 00 00 00 00 00 00 00 00 00 00 00 00 FF FF 00 00 // ................ | ||
83 | 0070: 00 00 00 00 30 00 00 00 00 00 00 00 // ....0....... | ||
84 | |||
85 | Signed-off-by: Shashi Mallela <shashi.mallela@linaro.org> | ||
86 | Acked-by: Igor Mammedov <imammedo@redhat.com> | ||
41 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | 87 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> |
88 | Message-id: 20210910143951.92242-10-shashi.mallela@linaro.org | ||
42 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 89 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
43 | --- | 90 | --- |
44 | include/hw/arm/fsl-imx6.h | 4 ++-- | 91 | tests/qtest/bios-tables-test-allowed-diff.h | 4 ---- |
45 | hw/net/imx_fec.c | 28 +++++++++++++++++++++++++++- | 92 | tests/data/acpi/virt/IORT | Bin 0 -> 124 bytes |
46 | 2 files changed, 29 insertions(+), 3 deletions(-) | 93 | tests/data/acpi/virt/IORT.memhp | Bin 0 -> 124 bytes |
94 | tests/data/acpi/virt/IORT.numamem | Bin 0 -> 124 bytes | ||
95 | tests/data/acpi/virt/IORT.pxb | Bin 0 -> 124 bytes | ||
96 | 5 files changed, 4 deletions(-) | ||
47 | 97 | ||
48 | diff --git a/include/hw/arm/fsl-imx6.h b/include/hw/arm/fsl-imx6.h | 98 | diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h |
49 | index XXXXXXX..XXXXXXX 100644 | 99 | index XXXXXXX..XXXXXXX 100644 |
50 | --- a/include/hw/arm/fsl-imx6.h | 100 | --- a/tests/qtest/bios-tables-test-allowed-diff.h |
51 | +++ b/include/hw/arm/fsl-imx6.h | 101 | +++ b/tests/qtest/bios-tables-test-allowed-diff.h |
52 | @@ -XXX,XX +XXX,XX @@ typedef struct FslIMX6State { | 102 | @@ -1,5 +1 @@ |
53 | #define FSL_IMX6_HDMI_MASTER_IRQ 115 | 103 | /* List of comma-separated changed AML files to ignore */ |
54 | #define FSL_IMX6_HDMI_CEC_IRQ 116 | 104 | -"tests/data/acpi/virt/IORT", |
55 | #define FSL_IMX6_MLB150_LOW_IRQ 117 | 105 | -"tests/data/acpi/virt/IORT.memhp", |
56 | -#define FSL_IMX6_ENET_MAC_1588_IRQ 118 | 106 | -"tests/data/acpi/virt/IORT.numamem", |
57 | -#define FSL_IMX6_ENET_MAC_IRQ 119 | 107 | -"tests/data/acpi/virt/IORT.pxb", |
58 | +#define FSL_IMX6_ENET_MAC_IRQ 118 | 108 | diff --git a/tests/data/acpi/virt/IORT b/tests/data/acpi/virt/IORT |
59 | +#define FSL_IMX6_ENET_MAC_1588_IRQ 119 | ||
60 | #define FSL_IMX6_PCIE1_IRQ 120 | ||
61 | #define FSL_IMX6_PCIE2_IRQ 121 | ||
62 | #define FSL_IMX6_PCIE3_IRQ 122 | ||
63 | diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c | ||
64 | index XXXXXXX..XXXXXXX 100644 | 109 | index XXXXXXX..XXXXXXX 100644 |
65 | --- a/hw/net/imx_fec.c | 110 | GIT binary patch |
66 | +++ b/hw/net/imx_fec.c | 111 | literal 124 |
67 | @@ -XXX,XX +XXX,XX @@ static void imx_enet_write_bd(IMXENETBufDesc *bd, dma_addr_t addr) | 112 | zcmebD4+^Pa00MR=e`k+i1*eDrX9XZ&1PX!JAesq?4S*O7Bw!2(4Uz`|CKCt^;wu0# |
68 | 113 | QRGb+i3L*dhhtM#y0PN=p0RR91 | |
69 | static void imx_eth_update(IMXFECState *s) | 114 | |
70 | { | 115 | literal 0 |
71 | - if (s->regs[ENET_EIR] & s->regs[ENET_EIMR] & ENET_INT_TS_TIMER) { | 116 | HcmV?d00001 |
72 | + /* | 117 | |
73 | + * Previous versions of qemu had the ENET_INT_MAC and ENET_INT_TS_TIMER | 118 | diff --git a/tests/data/acpi/virt/IORT.memhp b/tests/data/acpi/virt/IORT.memhp |
74 | + * interrupts swapped. This worked with older versions of Linux (4.14 | 119 | index XXXXXXX..XXXXXXX 100644 |
75 | + * and older) since Linux associated both interrupt lines with Ethernet | 120 | GIT binary patch |
76 | + * MAC interrupts. Specifically, | 121 | literal 124 |
77 | + * - Linux 4.15 and later have separate interrupt handlers for the MAC and | 122 | zcmebD4+^Pa00MR=e`k+i1*eDrX9XZ&1PX!JAesq?4S*O7Bw!2(4Uz`|CKCt^;wu0# |
78 | + * timer interrupts. Those versions of Linux fail with versions of QEMU | 123 | QRGb+i3L*dhhtM#y0PN=p0RR91 |
79 | + * with swapped interrupt assignments. | 124 | |
80 | + * - In linux 4.14, both interrupt lines were registered with the Ethernet | 125 | literal 0 |
81 | + * MAC interrupt handler. As a result, all versions of qemu happen to | 126 | HcmV?d00001 |
82 | + * work, though that is accidental. | 127 | |
83 | + * - In Linux 4.9 and older, the timer interrupt was registered directly | 128 | diff --git a/tests/data/acpi/virt/IORT.numamem b/tests/data/acpi/virt/IORT.numamem |
84 | + * with the Ethernet MAC interrupt handler. The MAC interrupt was | 129 | index XXXXXXX..XXXXXXX 100644 |
85 | + * redirected to a GPIO interrupt to work around erratum ERR006687. | 130 | GIT binary patch |
86 | + * This was implemented using the SOC's IOMUX block. In qemu, this GPIO | 131 | literal 124 |
87 | + * interrupt never fired since IOMUX is currently not supported in qemu. | 132 | zcmebD4+^Pa00MR=e`k+i1*eDrX9XZ&1PX!JAesq?4S*O7Bw!2(4Uz`|CKCt^;wu0# |
88 | + * Linux instead received MAC interrupts on the timer interrupt. | 133 | QRGb+i3L*dhhtM#y0PN=p0RR91 |
89 | + * As a result, qemu versions with the swapped interrupt assignment work, | 134 | |
90 | + * albeit accidentally, but qemu versions with the correct interrupt | 135 | literal 0 |
91 | + * assignment fail. | 136 | HcmV?d00001 |
92 | + * | 137 | |
93 | + * To ensure that all versions of Linux work, generate ENET_INT_MAC | 138 | diff --git a/tests/data/acpi/virt/IORT.pxb b/tests/data/acpi/virt/IORT.pxb |
94 | + * interrrupts on both interrupt lines. This should be changed if and when | 139 | index XXXXXXX..XXXXXXX 100644 |
95 | + * qemu supports IOMUX. | 140 | GIT binary patch |
96 | + */ | 141 | literal 124 |
97 | + if (s->regs[ENET_EIR] & s->regs[ENET_EIMR] & | 142 | zcmebD4+^Pa00MR=e`k+i1*eDrX9XZ&1PX!JAesq?4S*O7Bw!2(4Uz`|CKCt^;wu0# |
98 | + (ENET_INT_MAC | ENET_INT_TS_TIMER)) { | 143 | QRGb+i3L*dhhtM#y0PN=p0RR91 |
99 | qemu_set_irq(s->irq[1], 1); | 144 | |
100 | } else { | 145 | literal 0 |
101 | qemu_set_irq(s->irq[1], 0); | 146 | HcmV?d00001 |
147 | |||
102 | -- | 148 | -- |
103 | 2.16.2 | 149 | 2.20.1 |
104 | 150 | ||
105 | 151 | diff view generated by jsdifflib |
1 | If we're directly booting a Linux kernel and the CPU supports both | 1 | In v8A, the PSTATE.IL bit is set for various kinds of illegal |
---|---|---|---|
2 | EL3 and EL2, we start the kernel in EL2, as it expects. We must also | 2 | exception return or mode-change attempts. We already set PSTATE.IL |
3 | set the SCR_EL3.HCE bit in this situation, so that the HVC | 3 | (or its AArch32 equivalent CPSR.IL) in all those cases, but we |
4 | instruction is enabled rather than UNDEFing. Otherwise at least some | 4 | weren't implementing the part of the behaviour where attempting to |
5 | kernels will panic when trying to initialize KVM in the guest. | 5 | execute an instruction with PSTATE.IL takes an immediate exception |
6 | with an appropriate syndrome value. | ||
7 | |||
8 | Add a new TB flags bit tracking PSTATE.IL/CPSR.IL, and generate code | ||
9 | to take an exception instead of whatever the instruction would have | ||
10 | been. | ||
11 | |||
12 | PSTATE.IL and CPSR.IL change only on exception entry, attempted | ||
13 | exception exit, and various AArch32 mode changes via cpsr_write(). | ||
14 | These places generally already rebuild the hflags, so the only place | ||
15 | we need an extra rebuild_hflags call is in the illegal-return | ||
16 | codepath of the AArch64 exception_return helper. | ||
6 | 17 | ||
7 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 18 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
8 | Message-id: 20180313153458.26822-4-peter.maydell@linaro.org | 19 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> |
20 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> | ||
21 | Message-id: 20210821195958.41312-2-richard.henderson@linaro.org | ||
22 | Message-Id: <20210817162118.24319-1-peter.maydell@linaro.org> | ||
23 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> | ||
24 | [rth: Added missing returns; set IL bit in syndrome] | ||
25 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
9 | --- | 26 | --- |
10 | hw/arm/boot.c | 5 +++++ | 27 | target/arm/cpu.h | 1 + |
11 | 1 file changed, 5 insertions(+) | 28 | target/arm/syndrome.h | 5 +++++ |
29 | target/arm/translate.h | 2 ++ | ||
30 | target/arm/helper-a64.c | 1 + | ||
31 | target/arm/helper.c | 8 ++++++++ | ||
32 | target/arm/translate-a64.c | 11 +++++++++++ | ||
33 | target/arm/translate.c | 21 +++++++++++++++++++++ | ||
34 | 7 files changed, 49 insertions(+) | ||
12 | 35 | ||
13 | diff --git a/hw/arm/boot.c b/hw/arm/boot.c | 36 | diff --git a/target/arm/cpu.h b/target/arm/cpu.h |
14 | index XXXXXXX..XXXXXXX 100644 | 37 | index XXXXXXX..XXXXXXX 100644 |
15 | --- a/hw/arm/boot.c | 38 | --- a/target/arm/cpu.h |
16 | +++ b/hw/arm/boot.c | 39 | +++ b/target/arm/cpu.h |
17 | @@ -XXX,XX +XXX,XX @@ static void do_cpu_reset(void *opaque) | 40 | @@ -XXX,XX +XXX,XX @@ FIELD(TBFLAG_ANY, FPEXC_EL, 8, 2) |
18 | assert(!info->secure_board_setup); | 41 | FIELD(TBFLAG_ANY, DEBUG_TARGET_EL, 10, 2) |
19 | } | 42 | /* Memory operations require alignment: SCTLR_ELx.A or CCR.UNALIGN_TRP */ |
20 | 43 | FIELD(TBFLAG_ANY, ALIGN_MEM, 12, 1) | |
21 | + if (arm_feature(env, ARM_FEATURE_EL2)) { | 44 | +FIELD(TBFLAG_ANY, PSTATE__IL, 13, 1) |
22 | + /* If we have EL2 then Linux expects the HVC insn to work */ | 45 | |
23 | + env->cp15.scr_el3 |= SCR_HCE; | 46 | /* |
24 | + } | 47 | * Bit usage when in AArch32 state, both A- and M-profile. |
48 | diff --git a/target/arm/syndrome.h b/target/arm/syndrome.h | ||
49 | index XXXXXXX..XXXXXXX 100644 | ||
50 | --- a/target/arm/syndrome.h | ||
51 | +++ b/target/arm/syndrome.h | ||
52 | @@ -XXX,XX +XXX,XX @@ static inline uint32_t syn_wfx(int cv, int cond, int ti, bool is_16bit) | ||
53 | (cv << 24) | (cond << 20) | ti; | ||
54 | } | ||
55 | |||
56 | +static inline uint32_t syn_illegalstate(void) | ||
57 | +{ | ||
58 | + return (EC_ILLEGALSTATE << ARM_EL_EC_SHIFT) | ARM_EL_IL; | ||
59 | +} | ||
25 | + | 60 | + |
26 | /* Set to non-secure if not a secure boot */ | 61 | #endif /* TARGET_ARM_SYNDROME_H */ |
27 | if (!info->secure_boot && | 62 | diff --git a/target/arm/translate.h b/target/arm/translate.h |
28 | (cs != first_cpu || !info->secure_board_setup)) { | 63 | index XXXXXXX..XXXXXXX 100644 |
64 | --- a/target/arm/translate.h | ||
65 | +++ b/target/arm/translate.h | ||
66 | @@ -XXX,XX +XXX,XX @@ typedef struct DisasContext { | ||
67 | bool hstr_active; | ||
68 | /* True if memory operations require alignment */ | ||
69 | bool align_mem; | ||
70 | + /* True if PSTATE.IL is set */ | ||
71 | + bool pstate_il; | ||
72 | /* | ||
73 | * >= 0, a copy of PSTATE.BTYPE, which will be 0 without v8.5-BTI. | ||
74 | * < 0, set by the current instruction. | ||
75 | diff --git a/target/arm/helper-a64.c b/target/arm/helper-a64.c | ||
76 | index XXXXXXX..XXXXXXX 100644 | ||
77 | --- a/target/arm/helper-a64.c | ||
78 | +++ b/target/arm/helper-a64.c | ||
79 | @@ -XXX,XX +XXX,XX @@ illegal_return: | ||
80 | if (!arm_singlestep_active(env)) { | ||
81 | env->pstate &= ~PSTATE_SS; | ||
82 | } | ||
83 | + helper_rebuild_hflags_a64(env, cur_el); | ||
84 | qemu_log_mask(LOG_GUEST_ERROR, "Illegal exception return at EL%d: " | ||
85 | "resuming execution at 0x%" PRIx64 "\n", cur_el, env->pc); | ||
86 | } | ||
87 | diff --git a/target/arm/helper.c b/target/arm/helper.c | ||
88 | index XXXXXXX..XXXXXXX 100644 | ||
89 | --- a/target/arm/helper.c | ||
90 | +++ b/target/arm/helper.c | ||
91 | @@ -XXX,XX +XXX,XX @@ static CPUARMTBFlags rebuild_hflags_a32(CPUARMState *env, int fp_el, | ||
92 | DP_TBFLAG_A32(flags, HSTR_ACTIVE, 1); | ||
93 | } | ||
94 | |||
95 | + if (env->uncached_cpsr & CPSR_IL) { | ||
96 | + DP_TBFLAG_ANY(flags, PSTATE__IL, 1); | ||
97 | + } | ||
98 | + | ||
99 | return rebuild_hflags_common_32(env, fp_el, mmu_idx, flags); | ||
100 | } | ||
101 | |||
102 | @@ -XXX,XX +XXX,XX @@ static CPUARMTBFlags rebuild_hflags_a64(CPUARMState *env, int el, int fp_el, | ||
103 | } | ||
104 | } | ||
105 | |||
106 | + if (env->pstate & PSTATE_IL) { | ||
107 | + DP_TBFLAG_ANY(flags, PSTATE__IL, 1); | ||
108 | + } | ||
109 | + | ||
110 | if (cpu_isar_feature(aa64_mte, env_archcpu(env))) { | ||
111 | /* | ||
112 | * Set MTE_ACTIVE if any access may be Checked, and leave clear | ||
113 | diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c | ||
114 | index XXXXXXX..XXXXXXX 100644 | ||
115 | --- a/target/arm/translate-a64.c | ||
116 | +++ b/target/arm/translate-a64.c | ||
117 | @@ -XXX,XX +XXX,XX @@ static void disas_a64_insn(CPUARMState *env, DisasContext *s) | ||
118 | s->fp_access_checked = false; | ||
119 | s->sve_access_checked = false; | ||
120 | |||
121 | + if (s->pstate_il) { | ||
122 | + /* | ||
123 | + * Illegal execution state. This has priority over BTI | ||
124 | + * exceptions, but comes after instruction abort exceptions. | ||
125 | + */ | ||
126 | + gen_exception_insn(s, s->pc_curr, EXCP_UDEF, | ||
127 | + syn_illegalstate(), default_exception_el(s)); | ||
128 | + return; | ||
129 | + } | ||
130 | + | ||
131 | if (dc_isar_feature(aa64_bti, s)) { | ||
132 | if (s->base.num_insns == 1) { | ||
133 | /* | ||
134 | @@ -XXX,XX +XXX,XX @@ static void aarch64_tr_init_disas_context(DisasContextBase *dcbase, | ||
135 | #endif | ||
136 | dc->fp_excp_el = EX_TBFLAG_ANY(tb_flags, FPEXC_EL); | ||
137 | dc->align_mem = EX_TBFLAG_ANY(tb_flags, ALIGN_MEM); | ||
138 | + dc->pstate_il = EX_TBFLAG_ANY(tb_flags, PSTATE__IL); | ||
139 | dc->sve_excp_el = EX_TBFLAG_A64(tb_flags, SVEEXC_EL); | ||
140 | dc->sve_len = (EX_TBFLAG_A64(tb_flags, ZCR_LEN) + 1) * 16; | ||
141 | dc->pauth_active = EX_TBFLAG_A64(tb_flags, PAUTH_ACTIVE); | ||
142 | diff --git a/target/arm/translate.c b/target/arm/translate.c | ||
143 | index XXXXXXX..XXXXXXX 100644 | ||
144 | --- a/target/arm/translate.c | ||
145 | +++ b/target/arm/translate.c | ||
146 | @@ -XXX,XX +XXX,XX @@ static void disas_arm_insn(DisasContext *s, unsigned int insn) | ||
147 | return; | ||
148 | } | ||
149 | |||
150 | + if (s->pstate_il) { | ||
151 | + /* | ||
152 | + * Illegal execution state. This has priority over BTI | ||
153 | + * exceptions, but comes after instruction abort exceptions. | ||
154 | + */ | ||
155 | + gen_exception_insn(s, s->pc_curr, EXCP_UDEF, | ||
156 | + syn_illegalstate(), default_exception_el(s)); | ||
157 | + return; | ||
158 | + } | ||
159 | + | ||
160 | if (cond == 0xf) { | ||
161 | /* In ARMv3 and v4 the NV condition is UNPREDICTABLE; we | ||
162 | * choose to UNDEF. In ARMv5 and above the space is used | ||
163 | @@ -XXX,XX +XXX,XX @@ static void arm_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cs) | ||
164 | #endif | ||
165 | dc->fp_excp_el = EX_TBFLAG_ANY(tb_flags, FPEXC_EL); | ||
166 | dc->align_mem = EX_TBFLAG_ANY(tb_flags, ALIGN_MEM); | ||
167 | + dc->pstate_il = EX_TBFLAG_ANY(tb_flags, PSTATE__IL); | ||
168 | |||
169 | if (arm_feature(env, ARM_FEATURE_M)) { | ||
170 | dc->vfp_enabled = 1; | ||
171 | @@ -XXX,XX +XXX,XX @@ static void thumb_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu) | ||
172 | } | ||
173 | dc->insn = insn; | ||
174 | |||
175 | + if (dc->pstate_il) { | ||
176 | + /* | ||
177 | + * Illegal execution state. This has priority over BTI | ||
178 | + * exceptions, but comes after instruction abort exceptions. | ||
179 | + */ | ||
180 | + gen_exception_insn(dc, dc->pc_curr, EXCP_UDEF, | ||
181 | + syn_illegalstate(), default_exception_el(dc)); | ||
182 | + return; | ||
183 | + } | ||
184 | + | ||
185 | if (dc->eci) { | ||
186 | /* | ||
187 | * For M-profile continuable instructions, ECI/ICI handling | ||
29 | -- | 188 | -- |
30 | 2.16.2 | 189 | 2.20.1 |
31 | 190 | ||
32 | 191 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | 1 | From: Richard Henderson <richard.henderson@linaro.org> | |
2 | |||
3 | It is confusing to have different exits from translation | ||
4 | for various conditions in separate functions. | ||
5 | |||
6 | Merge disas_a64_insn into its only caller. Standardize | ||
7 | on the "s" name for the DisasContext, as the code from | ||
8 | disas_a64_insn had more instances. | ||
9 | |||
10 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
11 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
12 | Message-id: 20210821195958.41312-3-richard.henderson@linaro.org | ||
13 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
14 | --- | ||
15 | target/arm/translate-a64.c | 224 ++++++++++++++++++------------------- | ||
16 | 1 file changed, 109 insertions(+), 115 deletions(-) | ||
17 | |||
18 | diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c | ||
19 | index XXXXXXX..XXXXXXX 100644 | ||
20 | --- a/target/arm/translate-a64.c | ||
21 | +++ b/target/arm/translate-a64.c | ||
22 | @@ -XXX,XX +XXX,XX @@ static bool btype_destination_ok(uint32_t insn, bool bt, int btype) | ||
23 | return false; | ||
24 | } | ||
25 | |||
26 | -/* C3.1 A64 instruction index by encoding */ | ||
27 | -static void disas_a64_insn(CPUARMState *env, DisasContext *s) | ||
28 | -{ | ||
29 | - uint32_t insn; | ||
30 | - | ||
31 | - s->pc_curr = s->base.pc_next; | ||
32 | - insn = arm_ldl_code(env, s->base.pc_next, s->sctlr_b); | ||
33 | - s->insn = insn; | ||
34 | - s->base.pc_next += 4; | ||
35 | - | ||
36 | - s->fp_access_checked = false; | ||
37 | - s->sve_access_checked = false; | ||
38 | - | ||
39 | - if (s->pstate_il) { | ||
40 | - /* | ||
41 | - * Illegal execution state. This has priority over BTI | ||
42 | - * exceptions, but comes after instruction abort exceptions. | ||
43 | - */ | ||
44 | - gen_exception_insn(s, s->pc_curr, EXCP_UDEF, | ||
45 | - syn_illegalstate(), default_exception_el(s)); | ||
46 | - return; | ||
47 | - } | ||
48 | - | ||
49 | - if (dc_isar_feature(aa64_bti, s)) { | ||
50 | - if (s->base.num_insns == 1) { | ||
51 | - /* | ||
52 | - * At the first insn of the TB, compute s->guarded_page. | ||
53 | - * We delayed computing this until successfully reading | ||
54 | - * the first insn of the TB, above. This (mostly) ensures | ||
55 | - * that the softmmu tlb entry has been populated, and the | ||
56 | - * page table GP bit is available. | ||
57 | - * | ||
58 | - * Note that we need to compute this even if btype == 0, | ||
59 | - * because this value is used for BR instructions later | ||
60 | - * where ENV is not available. | ||
61 | - */ | ||
62 | - s->guarded_page = is_guarded_page(env, s); | ||
63 | - | ||
64 | - /* First insn can have btype set to non-zero. */ | ||
65 | - tcg_debug_assert(s->btype >= 0); | ||
66 | - | ||
67 | - /* | ||
68 | - * Note that the Branch Target Exception has fairly high | ||
69 | - * priority -- below debugging exceptions but above most | ||
70 | - * everything else. This allows us to handle this now | ||
71 | - * instead of waiting until the insn is otherwise decoded. | ||
72 | - */ | ||
73 | - if (s->btype != 0 | ||
74 | - && s->guarded_page | ||
75 | - && !btype_destination_ok(insn, s->bt, s->btype)) { | ||
76 | - gen_exception_insn(s, s->pc_curr, EXCP_UDEF, | ||
77 | - syn_btitrap(s->btype), | ||
78 | - default_exception_el(s)); | ||
79 | - return; | ||
80 | - } | ||
81 | - } else { | ||
82 | - /* Not the first insn: btype must be 0. */ | ||
83 | - tcg_debug_assert(s->btype == 0); | ||
84 | - } | ||
85 | - } | ||
86 | - | ||
87 | - switch (extract32(insn, 25, 4)) { | ||
88 | - case 0x0: case 0x1: case 0x3: /* UNALLOCATED */ | ||
89 | - unallocated_encoding(s); | ||
90 | - break; | ||
91 | - case 0x2: | ||
92 | - if (!dc_isar_feature(aa64_sve, s) || !disas_sve(s, insn)) { | ||
93 | - unallocated_encoding(s); | ||
94 | - } | ||
95 | - break; | ||
96 | - case 0x8: case 0x9: /* Data processing - immediate */ | ||
97 | - disas_data_proc_imm(s, insn); | ||
98 | - break; | ||
99 | - case 0xa: case 0xb: /* Branch, exception generation and system insns */ | ||
100 | - disas_b_exc_sys(s, insn); | ||
101 | - break; | ||
102 | - case 0x4: | ||
103 | - case 0x6: | ||
104 | - case 0xc: | ||
105 | - case 0xe: /* Loads and stores */ | ||
106 | - disas_ldst(s, insn); | ||
107 | - break; | ||
108 | - case 0x5: | ||
109 | - case 0xd: /* Data processing - register */ | ||
110 | - disas_data_proc_reg(s, insn); | ||
111 | - break; | ||
112 | - case 0x7: | ||
113 | - case 0xf: /* Data processing - SIMD and floating point */ | ||
114 | - disas_data_proc_simd_fp(s, insn); | ||
115 | - break; | ||
116 | - default: | ||
117 | - assert(FALSE); /* all 15 cases should be handled above */ | ||
118 | - break; | ||
119 | - } | ||
120 | - | ||
121 | - /* if we allocated any temporaries, free them here */ | ||
122 | - free_tmp_a64(s); | ||
123 | - | ||
124 | - /* | ||
125 | - * After execution of most insns, btype is reset to 0. | ||
126 | - * Note that we set btype == -1 when the insn sets btype. | ||
127 | - */ | ||
128 | - if (s->btype > 0 && s->base.is_jmp != DISAS_NORETURN) { | ||
129 | - reset_btype(s); | ||
130 | - } | ||
131 | -} | ||
132 | - | ||
133 | static void aarch64_tr_init_disas_context(DisasContextBase *dcbase, | ||
134 | CPUState *cpu) | ||
135 | { | ||
136 | @@ -XXX,XX +XXX,XX @@ static void aarch64_tr_insn_start(DisasContextBase *dcbase, CPUState *cpu) | ||
137 | |||
138 | static void aarch64_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu) | ||
139 | { | ||
140 | - DisasContext *dc = container_of(dcbase, DisasContext, base); | ||
141 | + DisasContext *s = container_of(dcbase, DisasContext, base); | ||
142 | CPUARMState *env = cpu->env_ptr; | ||
143 | + uint32_t insn; | ||
144 | |||
145 | - if (dc->ss_active && !dc->pstate_ss) { | ||
146 | + if (s->ss_active && !s->pstate_ss) { | ||
147 | /* Singlestep state is Active-pending. | ||
148 | * If we're in this state at the start of a TB then either | ||
149 | * a) we just took an exception to an EL which is being debugged | ||
150 | @@ -XXX,XX +XXX,XX @@ static void aarch64_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu) | ||
151 | * "did not step an insn" case, and so the syndrome ISV and EX | ||
152 | * bits should be zero. | ||
153 | */ | ||
154 | - assert(dc->base.num_insns == 1); | ||
155 | - gen_swstep_exception(dc, 0, 0); | ||
156 | - dc->base.is_jmp = DISAS_NORETURN; | ||
157 | - } else { | ||
158 | - disas_a64_insn(env, dc); | ||
159 | + assert(s->base.num_insns == 1); | ||
160 | + gen_swstep_exception(s, 0, 0); | ||
161 | + s->base.is_jmp = DISAS_NORETURN; | ||
162 | + return; | ||
163 | } | ||
164 | |||
165 | - translator_loop_temp_check(&dc->base); | ||
166 | + s->pc_curr = s->base.pc_next; | ||
167 | + insn = arm_ldl_code(env, s->base.pc_next, s->sctlr_b); | ||
168 | + s->insn = insn; | ||
169 | + s->base.pc_next += 4; | ||
170 | + | ||
171 | + s->fp_access_checked = false; | ||
172 | + s->sve_access_checked = false; | ||
173 | + | ||
174 | + if (s->pstate_il) { | ||
175 | + /* | ||
176 | + * Illegal execution state. This has priority over BTI | ||
177 | + * exceptions, but comes after instruction abort exceptions. | ||
178 | + */ | ||
179 | + gen_exception_insn(s, s->pc_curr, EXCP_UDEF, | ||
180 | + syn_illegalstate(), default_exception_el(s)); | ||
181 | + return; | ||
182 | + } | ||
183 | + | ||
184 | + if (dc_isar_feature(aa64_bti, s)) { | ||
185 | + if (s->base.num_insns == 1) { | ||
186 | + /* | ||
187 | + * At the first insn of the TB, compute s->guarded_page. | ||
188 | + * We delayed computing this until successfully reading | ||
189 | + * the first insn of the TB, above. This (mostly) ensures | ||
190 | + * that the softmmu tlb entry has been populated, and the | ||
191 | + * page table GP bit is available. | ||
192 | + * | ||
193 | + * Note that we need to compute this even if btype == 0, | ||
194 | + * because this value is used for BR instructions later | ||
195 | + * where ENV is not available. | ||
196 | + */ | ||
197 | + s->guarded_page = is_guarded_page(env, s); | ||
198 | + | ||
199 | + /* First insn can have btype set to non-zero. */ | ||
200 | + tcg_debug_assert(s->btype >= 0); | ||
201 | + | ||
202 | + /* | ||
203 | + * Note that the Branch Target Exception has fairly high | ||
204 | + * priority -- below debugging exceptions but above most | ||
205 | + * everything else. This allows us to handle this now | ||
206 | + * instead of waiting until the insn is otherwise decoded. | ||
207 | + */ | ||
208 | + if (s->btype != 0 | ||
209 | + && s->guarded_page | ||
210 | + && !btype_destination_ok(insn, s->bt, s->btype)) { | ||
211 | + gen_exception_insn(s, s->pc_curr, EXCP_UDEF, | ||
212 | + syn_btitrap(s->btype), | ||
213 | + default_exception_el(s)); | ||
214 | + return; | ||
215 | + } | ||
216 | + } else { | ||
217 | + /* Not the first insn: btype must be 0. */ | ||
218 | + tcg_debug_assert(s->btype == 0); | ||
219 | + } | ||
220 | + } | ||
221 | + | ||
222 | + switch (extract32(insn, 25, 4)) { | ||
223 | + case 0x0: case 0x1: case 0x3: /* UNALLOCATED */ | ||
224 | + unallocated_encoding(s); | ||
225 | + break; | ||
226 | + case 0x2: | ||
227 | + if (!dc_isar_feature(aa64_sve, s) || !disas_sve(s, insn)) { | ||
228 | + unallocated_encoding(s); | ||
229 | + } | ||
230 | + break; | ||
231 | + case 0x8: case 0x9: /* Data processing - immediate */ | ||
232 | + disas_data_proc_imm(s, insn); | ||
233 | + break; | ||
234 | + case 0xa: case 0xb: /* Branch, exception generation and system insns */ | ||
235 | + disas_b_exc_sys(s, insn); | ||
236 | + break; | ||
237 | + case 0x4: | ||
238 | + case 0x6: | ||
239 | + case 0xc: | ||
240 | + case 0xe: /* Loads and stores */ | ||
241 | + disas_ldst(s, insn); | ||
242 | + break; | ||
243 | + case 0x5: | ||
244 | + case 0xd: /* Data processing - register */ | ||
245 | + disas_data_proc_reg(s, insn); | ||
246 | + break; | ||
247 | + case 0x7: | ||
248 | + case 0xf: /* Data processing - SIMD and floating point */ | ||
249 | + disas_data_proc_simd_fp(s, insn); | ||
250 | + break; | ||
251 | + default: | ||
252 | + assert(FALSE); /* all 15 cases should be handled above */ | ||
253 | + break; | ||
254 | + } | ||
255 | + | ||
256 | + /* if we allocated any temporaries, free them here */ | ||
257 | + free_tmp_a64(s); | ||
258 | + | ||
259 | + /* | ||
260 | + * After execution of most insns, btype is reset to 0. | ||
261 | + * Note that we set btype == -1 when the insn sets btype. | ||
262 | + */ | ||
263 | + if (s->btype > 0 && s->base.is_jmp != DISAS_NORETURN) { | ||
264 | + reset_btype(s); | ||
265 | + } | ||
266 | + | ||
267 | + translator_loop_temp_check(&s->base); | ||
268 | } | ||
269 | |||
270 | static void aarch64_tr_tb_stop(DisasContextBase *dcbase, CPUState *cpu) | ||
271 | -- | ||
272 | 2.20.1 | ||
273 | |||
274 | diff view generated by jsdifflib |
1 | The raspi3 has AArch64 CPUs, which means that our smpboot | 1 | By default, QEMU will allow devices to be plugged into a bus up to |
---|---|---|---|
2 | code for keeping the secondary CPUs in a pen needs to have | 2 | the bus class's device count limit. If the user creates a device on |
3 | a version for A64 as well as A32. Without this, the | 3 | the command line or via the monitor and doesn't explicitly specify |
4 | secondary CPUs go into an infinite loop of taking undefined | 4 | the bus to plug it in, QEMU will plug it into the first non-full bus |
5 | instruction exceptions. | 5 | that it finds. |
6 | |||
7 | This is fine in most cases, but some machines have multiple buses of | ||
8 | a given type, some of which are dedicated to on-board devices and | ||
9 | some of which have an externally exposed connector for user-pluggable | ||
10 | devices. One example is I2C buses. | ||
11 | |||
12 | Provide a new function qbus_mark_full() so that a machine model can | ||
13 | mark this kind of "internal only" bus as 'full' after it has created | ||
14 | all the devices that should be plugged into that bus. The "find a | ||
15 | non-full bus" algorithm will then skip the internal-only bus when | ||
16 | looking for a place to plug in user-created devices. | ||
6 | 17 | ||
7 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 18 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
8 | Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | 19 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> |
9 | Message-id: 20180313153458.26822-10-peter.maydell@linaro.org | 20 | Message-id: 20210903151435.22379-2-peter.maydell@linaro.org |
10 | --- | 21 | --- |
11 | hw/arm/raspi.c | 41 ++++++++++++++++++++++++++++++++++++++++- | 22 | include/hw/qdev-core.h | 24 ++++++++++++++++++++++++ |
12 | 1 file changed, 40 insertions(+), 1 deletion(-) | 23 | softmmu/qdev-monitor.c | 7 ++++++- |
24 | 2 files changed, 30 insertions(+), 1 deletion(-) | ||
13 | 25 | ||
14 | diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c | 26 | diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h |
15 | index XXXXXXX..XXXXXXX 100644 | 27 | index XXXXXXX..XXXXXXX 100644 |
16 | --- a/hw/arm/raspi.c | 28 | --- a/include/hw/qdev-core.h |
17 | +++ b/hw/arm/raspi.c | 29 | +++ b/include/hw/qdev-core.h |
18 | @@ -XXX,XX +XXX,XX @@ | 30 | @@ -XXX,XX +XXX,XX @@ struct BusState { |
19 | #define BOARDSETUP_ADDR (MVBAR_ADDR + 0x20) /* board setup code */ | 31 | HotplugHandler *hotplug_handler; |
20 | #define FIRMWARE_ADDR_2 0x8000 /* Pi 2 loads kernel.img here by default */ | 32 | int max_index; |
21 | #define FIRMWARE_ADDR_3 0x80000 /* Pi 3 loads kernel.img here by default */ | 33 | bool realized; |
22 | +#define SPINTABLE_ADDR 0xd8 /* Pi 3 bootloader spintable */ | 34 | + bool full; |
23 | 35 | int num_children; | |
24 | /* Table of Linux board IDs for different Pi versions */ | 36 | |
25 | static const int raspi_boardid[] = {[1] = 0xc42, [2] = 0xc43, [3] = 0xc44}; | 37 | /* |
26 | @@ -XXX,XX +XXX,XX @@ static void write_smpboot(ARMCPU *cpu, const struct arm_boot_info *info) | 38 | @@ -XXX,XX +XXX,XX @@ static inline bool qbus_is_hotpluggable(BusState *bus) |
27 | info->smp_loader_start); | 39 | return bus->hotplug_handler; |
28 | } | 40 | } |
29 | 41 | ||
30 | +static void write_smpboot64(ARMCPU *cpu, const struct arm_boot_info *info) | 42 | +/** |
43 | + * qbus_mark_full: Mark this bus as full, so no more devices can be attached | ||
44 | + * @bus: Bus to mark as full | ||
45 | + * | ||
46 | + * By default, QEMU will allow devices to be plugged into a bus up | ||
47 | + * to the bus class's device count limit. Calling this function | ||
48 | + * marks a particular bus as full, so that no more devices can be | ||
49 | + * plugged into it. In particular this means that the bus will not | ||
50 | + * be considered as a candidate for plugging in devices created by | ||
51 | + * the user on the commandline or via the monitor. | ||
52 | + * If a machine has multiple buses of a given type, such as I2C, | ||
53 | + * where some of those buses in the real hardware are used only for | ||
54 | + * internal devices and some are exposed via expansion ports, you | ||
55 | + * can use this function to mark the internal-only buses as full | ||
56 | + * after you have created all their internal devices. Then user | ||
57 | + * created devices will appear on the expansion-port bus where | ||
58 | + * guest software expects them. | ||
59 | + */ | ||
60 | +static inline void qbus_mark_full(BusState *bus) | ||
31 | +{ | 61 | +{ |
32 | + /* Unlike the AArch32 version we don't need to call the board setup hook. | 62 | + bus->full = true; |
33 | + * The mechanism for doing the spin-table is also entirely different. | ||
34 | + * We must have four 64-bit fields at absolute addresses | ||
35 | + * 0xd8, 0xe0, 0xe8, 0xf0 in RAM, which are the flag variables for | ||
36 | + * our CPUs, and which we must ensure are zero initialized before | ||
37 | + * the primary CPU goes into the kernel. We put these variables inside | ||
38 | + * a rom blob, so that the reset for ROM contents zeroes them for us. | ||
39 | + */ | ||
40 | + static const uint32_t smpboot[] = { | ||
41 | + 0xd2801b05, /* mov x5, 0xd8 */ | ||
42 | + 0xd53800a6, /* mrs x6, mpidr_el1 */ | ||
43 | + 0x924004c6, /* and x6, x6, #0x3 */ | ||
44 | + 0xd503205f, /* spin: wfe */ | ||
45 | + 0xf86678a4, /* ldr x4, [x5,x6,lsl #3] */ | ||
46 | + 0xb4ffffc4, /* cbz x4, spin */ | ||
47 | + 0xd2800000, /* mov x0, #0x0 */ | ||
48 | + 0xd2800001, /* mov x1, #0x0 */ | ||
49 | + 0xd2800002, /* mov x2, #0x0 */ | ||
50 | + 0xd2800003, /* mov x3, #0x0 */ | ||
51 | + 0xd61f0080, /* br x4 */ | ||
52 | + }; | ||
53 | + | ||
54 | + static const uint64_t spintables[] = { | ||
55 | + 0, 0, 0, 0 | ||
56 | + }; | ||
57 | + | ||
58 | + rom_add_blob_fixed("raspi_smpboot", smpboot, sizeof(smpboot), | ||
59 | + info->smp_loader_start); | ||
60 | + rom_add_blob_fixed("raspi_spintables", spintables, sizeof(spintables), | ||
61 | + SPINTABLE_ADDR); | ||
62 | +} | 63 | +} |
63 | + | 64 | + |
64 | static void write_board_setup(ARMCPU *cpu, const struct arm_boot_info *info) | 65 | void device_listener_register(DeviceListener *listener); |
66 | void device_listener_unregister(DeviceListener *listener); | ||
67 | |||
68 | diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c | ||
69 | index XXXXXXX..XXXXXXX 100644 | ||
70 | --- a/softmmu/qdev-monitor.c | ||
71 | +++ b/softmmu/qdev-monitor.c | ||
72 | @@ -XXX,XX +XXX,XX @@ static DeviceState *qbus_find_dev(BusState *bus, char *elem) | ||
73 | |||
74 | static inline bool qbus_is_full(BusState *bus) | ||
65 | { | 75 | { |
66 | arm_write_secure_board_setup_dummy_smc(cpu, info, MVBAR_ADDR); | 76 | - BusClass *bus_class = BUS_GET_CLASS(bus); |
67 | @@ -XXX,XX +XXX,XX @@ static void setup_boot(MachineState *machine, int version, size_t ram_size) | 77 | + BusClass *bus_class; |
68 | /* Pi2 and Pi3 requires SMP setup */ | 78 | + |
69 | if (version >= 2) { | 79 | + if (bus->full) { |
70 | binfo.smp_loader_start = SMPBOOT_ADDR; | 80 | + return true; |
71 | - binfo.write_secondary_boot = write_smpboot; | 81 | + } |
72 | + if (version == 2) { | 82 | + bus_class = BUS_GET_CLASS(bus); |
73 | + binfo.write_secondary_boot = write_smpboot; | 83 | return bus_class->max_dev && bus->num_children >= bus_class->max_dev; |
74 | + } else { | 84 | } |
75 | + binfo.write_secondary_boot = write_smpboot64; | ||
76 | + } | ||
77 | binfo.secondary_cpu_reset_hook = reset_secondary; | ||
78 | } | ||
79 | 85 | ||
80 | -- | 86 | -- |
81 | 2.16.2 | 87 | 2.20.1 |
82 | 88 | ||
83 | 89 | diff view generated by jsdifflib |
1 | The TypeInfo and state struct for bcm2386 disagree about what the | 1 | The mps2-tz boards use a data-driven structure to create the devices |
---|---|---|---|
2 | parent class is -- the TypeInfo says it's TYPE_SYS_BUS_DEVICE, | 2 | that sit behind peripheral protection controllers. Currently the |
3 | but the BCM2386State struct only defines the parent_obj field | 3 | functions which create these devices are passed an 'opaque' pointer |
4 | as DeviceState. This would have caused problems if anything | 4 | which is always the address within the machine struct of the device |
5 | actually tried to treat the object as a TYPE_SYS_BUS_DEVICE. | 5 | to create, and some "all devices need this" information like irqs and |
6 | Fix the TypeInfo to use TYPE_DEVICE as the parent, since we don't | 6 | addresses. |
7 | need any of the additional functionality TYPE_SYS_BUS_DEVICE | 7 | |
8 | provides. | 8 | If a specific device needs more information than this, it is |
9 | currently not possible to pass that through from the PPCInfo | ||
10 | data structure. Add support for passing an extra data parameter, | ||
11 | so that we can more flexibly handle the needs of specific | ||
12 | device types. To provide some type-safety we make this extra | ||
13 | parameter a pointer to a union (which initially has no members). | ||
14 | |||
15 | In particular, we would like to be able to indicate which of the | ||
16 | i2c controllers are for on-board devices only and which are | ||
17 | connected to the external 'shield' expansion port; a subsequent | ||
18 | patch will use this mechanism for that purpose. | ||
9 | 19 | ||
10 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 20 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
11 | Reviewed-by: Andrew Baumann <Andrew.Baumann@microsoft.com> | 21 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> |
12 | Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | 22 | Message-id: 20210903151435.22379-3-peter.maydell@linaro.org |
13 | Message-id: 20180313153458.26822-5-peter.maydell@linaro.org | ||
14 | --- | 23 | --- |
15 | hw/arm/bcm2836.c | 2 +- | 24 | hw/arm/mps2-tz.c | 35 ++++++++++++++++++++++------------- |
16 | 1 file changed, 1 insertion(+), 1 deletion(-) | 25 | 1 file changed, 22 insertions(+), 13 deletions(-) |
17 | 26 | ||
18 | diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c | 27 | diff --git a/hw/arm/mps2-tz.c b/hw/arm/mps2-tz.c |
19 | index XXXXXXX..XXXXXXX 100644 | 28 | index XXXXXXX..XXXXXXX 100644 |
20 | --- a/hw/arm/bcm2836.c | 29 | --- a/hw/arm/mps2-tz.c |
21 | +++ b/hw/arm/bcm2836.c | 30 | +++ b/hw/arm/mps2-tz.c |
22 | @@ -XXX,XX +XXX,XX @@ static void bcm2836_class_init(ObjectClass *oc, void *data) | 31 | @@ -XXX,XX +XXX,XX @@ static qemu_irq get_sse_irq_in(MPS2TZMachineState *mms, int irqno) |
23 | 32 | } | |
24 | static const TypeInfo bcm2836_type_info = { | 33 | } |
25 | .name = TYPE_BCM2836, | 34 | |
26 | - .parent = TYPE_SYS_BUS_DEVICE, | 35 | +/* Union describing the device-specific extra data we pass to the devfn. */ |
27 | + .parent = TYPE_DEVICE, | 36 | +typedef union PPCExtraData { |
28 | .instance_size = sizeof(BCM2836State), | 37 | +} PPCExtraData; |
29 | .instance_init = bcm2836_init, | 38 | + |
30 | .class_init = bcm2836_class_init, | 39 | /* Most of the devices in the AN505 FPGA image sit behind |
40 | * Peripheral Protection Controllers. These data structures | ||
41 | * define the layout of which devices sit behind which PPCs. | ||
42 | @@ -XXX,XX +XXX,XX @@ static qemu_irq get_sse_irq_in(MPS2TZMachineState *mms, int irqno) | ||
43 | */ | ||
44 | typedef MemoryRegion *MakeDevFn(MPS2TZMachineState *mms, void *opaque, | ||
45 | const char *name, hwaddr size, | ||
46 | - const int *irqs); | ||
47 | + const int *irqs, | ||
48 | + const PPCExtraData *extradata); | ||
49 | |||
50 | typedef struct PPCPortInfo { | ||
51 | const char *name; | ||
52 | @@ -XXX,XX +XXX,XX @@ typedef struct PPCPortInfo { | ||
53 | hwaddr addr; | ||
54 | hwaddr size; | ||
55 | int irqs[3]; /* currently no device needs more IRQ lines than this */ | ||
56 | + PPCExtraData extradata; /* to pass device-specific info to the devfn */ | ||
57 | } PPCPortInfo; | ||
58 | |||
59 | typedef struct PPCInfo { | ||
60 | @@ -XXX,XX +XXX,XX @@ typedef struct PPCInfo { | ||
61 | static MemoryRegion *make_unimp_dev(MPS2TZMachineState *mms, | ||
62 | void *opaque, | ||
63 | const char *name, hwaddr size, | ||
64 | - const int *irqs) | ||
65 | + const int *irqs, | ||
66 | + const PPCExtraData *extradata) | ||
67 | { | ||
68 | /* Initialize, configure and realize a TYPE_UNIMPLEMENTED_DEVICE, | ||
69 | * and return a pointer to its MemoryRegion. | ||
70 | @@ -XXX,XX +XXX,XX @@ static MemoryRegion *make_unimp_dev(MPS2TZMachineState *mms, | ||
71 | |||
72 | static MemoryRegion *make_uart(MPS2TZMachineState *mms, void *opaque, | ||
73 | const char *name, hwaddr size, | ||
74 | - const int *irqs) | ||
75 | + const int *irqs, const PPCExtraData *extradata) | ||
76 | { | ||
77 | /* The irq[] array is tx, rx, combined, in that order */ | ||
78 | MPS2TZMachineClass *mmc = MPS2TZ_MACHINE_GET_CLASS(mms); | ||
79 | @@ -XXX,XX +XXX,XX @@ static MemoryRegion *make_uart(MPS2TZMachineState *mms, void *opaque, | ||
80 | |||
81 | static MemoryRegion *make_scc(MPS2TZMachineState *mms, void *opaque, | ||
82 | const char *name, hwaddr size, | ||
83 | - const int *irqs) | ||
84 | + const int *irqs, const PPCExtraData *extradata) | ||
85 | { | ||
86 | MPS2SCC *scc = opaque; | ||
87 | DeviceState *sccdev; | ||
88 | @@ -XXX,XX +XXX,XX @@ static MemoryRegion *make_scc(MPS2TZMachineState *mms, void *opaque, | ||
89 | |||
90 | static MemoryRegion *make_fpgaio(MPS2TZMachineState *mms, void *opaque, | ||
91 | const char *name, hwaddr size, | ||
92 | - const int *irqs) | ||
93 | + const int *irqs, const PPCExtraData *extradata) | ||
94 | { | ||
95 | MPS2FPGAIO *fpgaio = opaque; | ||
96 | MPS2TZMachineClass *mmc = MPS2TZ_MACHINE_GET_CLASS(mms); | ||
97 | @@ -XXX,XX +XXX,XX @@ static MemoryRegion *make_fpgaio(MPS2TZMachineState *mms, void *opaque, | ||
98 | |||
99 | static MemoryRegion *make_eth_dev(MPS2TZMachineState *mms, void *opaque, | ||
100 | const char *name, hwaddr size, | ||
101 | - const int *irqs) | ||
102 | + const int *irqs, | ||
103 | + const PPCExtraData *extradata) | ||
104 | { | ||
105 | SysBusDevice *s; | ||
106 | NICInfo *nd = &nd_table[0]; | ||
107 | @@ -XXX,XX +XXX,XX @@ static MemoryRegion *make_eth_dev(MPS2TZMachineState *mms, void *opaque, | ||
108 | |||
109 | static MemoryRegion *make_eth_usb(MPS2TZMachineState *mms, void *opaque, | ||
110 | const char *name, hwaddr size, | ||
111 | - const int *irqs) | ||
112 | + const int *irqs, | ||
113 | + const PPCExtraData *extradata) | ||
114 | { | ||
115 | /* | ||
116 | * The AN524 makes the ethernet and USB share a PPC port. | ||
117 | @@ -XXX,XX +XXX,XX @@ static MemoryRegion *make_eth_usb(MPS2TZMachineState *mms, void *opaque, | ||
118 | |||
119 | static MemoryRegion *make_mpc(MPS2TZMachineState *mms, void *opaque, | ||
120 | const char *name, hwaddr size, | ||
121 | - const int *irqs) | ||
122 | + const int *irqs, const PPCExtraData *extradata) | ||
123 | { | ||
124 | TZMPC *mpc = opaque; | ||
125 | int i = mpc - &mms->mpc[0]; | ||
126 | @@ -XXX,XX +XXX,XX @@ static void remap_irq_fn(void *opaque, int n, int level) | ||
127 | |||
128 | static MemoryRegion *make_dma(MPS2TZMachineState *mms, void *opaque, | ||
129 | const char *name, hwaddr size, | ||
130 | - const int *irqs) | ||
131 | + const int *irqs, const PPCExtraData *extradata) | ||
132 | { | ||
133 | /* The irq[] array is DMACINTR, DMACINTERR, DMACINTTC, in that order */ | ||
134 | PL080State *dma = opaque; | ||
135 | @@ -XXX,XX +XXX,XX @@ static MemoryRegion *make_dma(MPS2TZMachineState *mms, void *opaque, | ||
136 | |||
137 | static MemoryRegion *make_spi(MPS2TZMachineState *mms, void *opaque, | ||
138 | const char *name, hwaddr size, | ||
139 | - const int *irqs) | ||
140 | + const int *irqs, const PPCExtraData *extradata) | ||
141 | { | ||
142 | /* | ||
143 | * The AN505 has five PL022 SPI controllers. | ||
144 | @@ -XXX,XX +XXX,XX @@ static MemoryRegion *make_spi(MPS2TZMachineState *mms, void *opaque, | ||
145 | |||
146 | static MemoryRegion *make_i2c(MPS2TZMachineState *mms, void *opaque, | ||
147 | const char *name, hwaddr size, | ||
148 | - const int *irqs) | ||
149 | + const int *irqs, const PPCExtraData *extradata) | ||
150 | { | ||
151 | ArmSbconI2CState *i2c = opaque; | ||
152 | SysBusDevice *s; | ||
153 | @@ -XXX,XX +XXX,XX @@ static MemoryRegion *make_i2c(MPS2TZMachineState *mms, void *opaque, | ||
154 | |||
155 | static MemoryRegion *make_rtc(MPS2TZMachineState *mms, void *opaque, | ||
156 | const char *name, hwaddr size, | ||
157 | - const int *irqs) | ||
158 | + const int *irqs, const PPCExtraData *extradata) | ||
159 | { | ||
160 | PL031State *pl031 = opaque; | ||
161 | SysBusDevice *s; | ||
162 | @@ -XXX,XX +XXX,XX @@ static void mps2tz_common_init(MachineState *machine) | ||
163 | } | ||
164 | |||
165 | mr = pinfo->devfn(mms, pinfo->opaque, pinfo->name, pinfo->size, | ||
166 | - pinfo->irqs); | ||
167 | + pinfo->irqs, &pinfo->extradata); | ||
168 | portname = g_strdup_printf("port[%d]", port); | ||
169 | object_property_set_link(OBJECT(ppc), portname, OBJECT(mr), | ||
170 | &error_fatal); | ||
31 | -- | 171 | -- |
32 | 2.16.2 | 172 | 2.20.1 |
33 | 173 | ||
34 | 174 | diff view generated by jsdifflib |
1 | Add some assertions that if we're about to boot an AArch64 kernel, | 1 | The various MPS2 boards have multiple I2C buses: typically a bus |
---|---|---|---|
2 | the board code has not mistakenly set either secure_boot or | 2 | dedicated to the audio configuration, one for the LCD touchscreen |
3 | secure_board_setup. It doesn't make sense to set secure_boot, | 3 | controller, one for a DDR4 EEPROM, and two which are connected to the |
4 | because all AArch64 kernels must be booted in non-secure mode. | 4 | external Shield expansion connector. Mark the buses which are used |
5 | 5 | only for board-internal devices as 'full' so that if the user creates | |
6 | It might in theory make sense to set secure_board_setup, but | 6 | i2c devices on the commandline without specifying a bus name then |
7 | we don't currently support that, because only the AArch32 | 7 | they will be connected to the I2C controller used for the Shield |
8 | bootloader[] code calls this hook; bootloader_aarch64[] does not. | 8 | connector, where guest software will expect them. |
9 | Since we don't have a current need for this functionality, just | ||
10 | assert that we don't try to use it. If it's needed we'll add | ||
11 | it later. | ||
12 | 9 | ||
13 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 10 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
14 | Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | 11 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> |
15 | Message-id: 20180313153458.26822-3-peter.maydell@linaro.org | 12 | Message-id: 20210903151435.22379-4-peter.maydell@linaro.org |
16 | --- | 13 | --- |
17 | hw/arm/boot.c | 7 +++++++ | 14 | hw/arm/mps2-tz.c | 57 ++++++++++++++++++++++++++++++++++++------------ |
18 | 1 file changed, 7 insertions(+) | 15 | 1 file changed, 43 insertions(+), 14 deletions(-) |
19 | 16 | ||
20 | diff --git a/hw/arm/boot.c b/hw/arm/boot.c | 17 | diff --git a/hw/arm/mps2-tz.c b/hw/arm/mps2-tz.c |
21 | index XXXXXXX..XXXXXXX 100644 | 18 | index XXXXXXX..XXXXXXX 100644 |
22 | --- a/hw/arm/boot.c | 19 | --- a/hw/arm/mps2-tz.c |
23 | +++ b/hw/arm/boot.c | 20 | +++ b/hw/arm/mps2-tz.c |
24 | @@ -XXX,XX +XXX,XX @@ static void do_cpu_reset(void *opaque) | 21 | @@ -XXX,XX +XXX,XX @@ static qemu_irq get_sse_irq_in(MPS2TZMachineState *mms, int irqno) |
25 | } else { | 22 | |
26 | env->pstate = PSTATE_MODE_EL1h; | 23 | /* Union describing the device-specific extra data we pass to the devfn. */ |
27 | } | 24 | typedef union PPCExtraData { |
28 | + /* AArch64 kernels never boot in secure mode */ | 25 | + bool i2c_internal; |
29 | + assert(!info->secure_boot); | 26 | } PPCExtraData; |
30 | + /* This hook is only supported for AArch32 currently: | 27 | |
31 | + * bootloader_aarch64[] will not call the hook, and | 28 | /* Most of the devices in the AN505 FPGA image sit behind |
32 | + * the code above has already dropped us into EL2 or EL1. | 29 | @@ -XXX,XX +XXX,XX @@ static MemoryRegion *make_i2c(MPS2TZMachineState *mms, void *opaque, |
33 | + */ | 30 | object_initialize_child(OBJECT(mms), name, i2c, TYPE_ARM_SBCON_I2C); |
34 | + assert(!info->secure_board_setup); | 31 | s = SYS_BUS_DEVICE(i2c); |
35 | } | 32 | sysbus_realize(s, &error_fatal); |
36 | 33 | + | |
37 | /* Set to non-secure if not a secure boot */ | 34 | + /* |
35 | + * If this is an internal-use-only i2c bus, mark it full | ||
36 | + * so that user-created i2c devices are not plugged into it. | ||
37 | + * If we implement models of any on-board i2c devices that | ||
38 | + * plug in to one of the internal-use-only buses, then we will | ||
39 | + * need to create and plugging those in here before we mark the | ||
40 | + * bus as full. | ||
41 | + */ | ||
42 | + if (extradata->i2c_internal) { | ||
43 | + BusState *qbus = qdev_get_child_bus(DEVICE(i2c), "i2c"); | ||
44 | + qbus_mark_full(qbus); | ||
45 | + } | ||
46 | + | ||
47 | return sysbus_mmio_get_region(s, 0); | ||
48 | } | ||
49 | |||
50 | @@ -XXX,XX +XXX,XX @@ static void mps2tz_common_init(MachineState *machine) | ||
51 | { "uart2", make_uart, &mms->uart[2], 0x40202000, 0x1000, { 36, 37, 44 } }, | ||
52 | { "uart3", make_uart, &mms->uart[3], 0x40203000, 0x1000, { 38, 39, 45 } }, | ||
53 | { "uart4", make_uart, &mms->uart[4], 0x40204000, 0x1000, { 40, 41, 46 } }, | ||
54 | - { "i2c0", make_i2c, &mms->i2c[0], 0x40207000, 0x1000 }, | ||
55 | - { "i2c1", make_i2c, &mms->i2c[1], 0x40208000, 0x1000 }, | ||
56 | - { "i2c2", make_i2c, &mms->i2c[2], 0x4020c000, 0x1000 }, | ||
57 | - { "i2c3", make_i2c, &mms->i2c[3], 0x4020d000, 0x1000 }, | ||
58 | + { "i2c0", make_i2c, &mms->i2c[0], 0x40207000, 0x1000, {}, | ||
59 | + { .i2c_internal = true /* touchscreen */ } }, | ||
60 | + { "i2c1", make_i2c, &mms->i2c[1], 0x40208000, 0x1000, {}, | ||
61 | + { .i2c_internal = true /* audio conf */ } }, | ||
62 | + { "i2c2", make_i2c, &mms->i2c[2], 0x4020c000, 0x1000, {}, | ||
63 | + { .i2c_internal = false /* shield 0 */ } }, | ||
64 | + { "i2c3", make_i2c, &mms->i2c[3], 0x4020d000, 0x1000, {}, | ||
65 | + { .i2c_internal = false /* shield 1 */ } }, | ||
66 | }, | ||
67 | }, { | ||
68 | .name = "apb_ppcexp2", | ||
69 | @@ -XXX,XX +XXX,XX @@ static void mps2tz_common_init(MachineState *machine) | ||
70 | }, { | ||
71 | .name = "apb_ppcexp1", | ||
72 | .ports = { | ||
73 | - { "i2c0", make_i2c, &mms->i2c[0], 0x41200000, 0x1000 }, | ||
74 | - { "i2c1", make_i2c, &mms->i2c[1], 0x41201000, 0x1000 }, | ||
75 | + { "i2c0", make_i2c, &mms->i2c[0], 0x41200000, 0x1000, {}, | ||
76 | + { .i2c_internal = true /* touchscreen */ } }, | ||
77 | + { "i2c1", make_i2c, &mms->i2c[1], 0x41201000, 0x1000, {}, | ||
78 | + { .i2c_internal = true /* audio conf */ } }, | ||
79 | { "spi0", make_spi, &mms->spi[0], 0x41202000, 0x1000, { 52 } }, | ||
80 | { "spi1", make_spi, &mms->spi[1], 0x41203000, 0x1000, { 53 } }, | ||
81 | { "spi2", make_spi, &mms->spi[2], 0x41204000, 0x1000, { 54 } }, | ||
82 | - { "i2c2", make_i2c, &mms->i2c[2], 0x41205000, 0x1000 }, | ||
83 | - { "i2c3", make_i2c, &mms->i2c[3], 0x41206000, 0x1000 }, | ||
84 | + { "i2c2", make_i2c, &mms->i2c[2], 0x41205000, 0x1000, {}, | ||
85 | + { .i2c_internal = false /* shield 0 */ } }, | ||
86 | + { "i2c3", make_i2c, &mms->i2c[3], 0x41206000, 0x1000, {}, | ||
87 | + { .i2c_internal = false /* shield 1 */ } }, | ||
88 | { /* port 7 reserved */ }, | ||
89 | - { "i2c4", make_i2c, &mms->i2c[4], 0x41208000, 0x1000 }, | ||
90 | + { "i2c4", make_i2c, &mms->i2c[4], 0x41208000, 0x1000, {}, | ||
91 | + { .i2c_internal = true /* DDR4 EEPROM */ } }, | ||
92 | }, | ||
93 | }, { | ||
94 | .name = "apb_ppcexp2", | ||
95 | @@ -XXX,XX +XXX,XX @@ static void mps2tz_common_init(MachineState *machine) | ||
96 | }, { | ||
97 | .name = "apb_ppcexp1", | ||
98 | .ports = { | ||
99 | - { "i2c0", make_i2c, &mms->i2c[0], 0x49200000, 0x1000 }, | ||
100 | - { "i2c1", make_i2c, &mms->i2c[1], 0x49201000, 0x1000 }, | ||
101 | + { "i2c0", make_i2c, &mms->i2c[0], 0x49200000, 0x1000, {}, | ||
102 | + { .i2c_internal = true /* touchscreen */ } }, | ||
103 | + { "i2c1", make_i2c, &mms->i2c[1], 0x49201000, 0x1000, {}, | ||
104 | + { .i2c_internal = true /* audio conf */ } }, | ||
105 | { "spi0", make_spi, &mms->spi[0], 0x49202000, 0x1000, { 53 } }, | ||
106 | { "spi1", make_spi, &mms->spi[1], 0x49203000, 0x1000, { 54 } }, | ||
107 | { "spi2", make_spi, &mms->spi[2], 0x49204000, 0x1000, { 55 } }, | ||
108 | - { "i2c2", make_i2c, &mms->i2c[2], 0x49205000, 0x1000 }, | ||
109 | - { "i2c3", make_i2c, &mms->i2c[3], 0x49206000, 0x1000 }, | ||
110 | + { "i2c2", make_i2c, &mms->i2c[2], 0x49205000, 0x1000, {}, | ||
111 | + { .i2c_internal = false /* shield 0 */ } }, | ||
112 | + { "i2c3", make_i2c, &mms->i2c[3], 0x49206000, 0x1000, {}, | ||
113 | + { .i2c_internal = false /* shield 1 */ } }, | ||
114 | { /* port 7 reserved */ }, | ||
115 | - { "i2c4", make_i2c, &mms->i2c[4], 0x49208000, 0x1000 }, | ||
116 | + { "i2c4", make_i2c, &mms->i2c[4], 0x49208000, 0x1000, {}, | ||
117 | + { .i2c_internal = true /* DDR4 EEPROM */ } }, | ||
118 | }, | ||
119 | }, { | ||
120 | .name = "apb_ppcexp2", | ||
38 | -- | 121 | -- |
39 | 2.16.2 | 122 | 2.20.1 |
40 | 123 | ||
41 | 124 | diff view generated by jsdifflib |
1 | For the rpi1 and 2 we want to boot the Linux kernel via some | 1 | The various MPS2 boards implemented in mps2.c have multiple I2C |
---|---|---|---|
2 | custom setup code that makes sure that the SMC instruction | 2 | buses: a bus dedicated to the audio configuration, one for the LCD |
3 | acts as a no-op, because it's used for cache maintenance. | 3 | touchscreen controller, and two which are connected to the external |
4 | The rpi3 boots AArch64 kernels, which don't need SMC for | 4 | Shield expansion connector. Mark the buses which are used only for |
5 | cache maintenance and always expect to be booted non-secure. | 5 | board-internal devices as 'full' so that if the user creates i2c |
6 | Don't fill in the aarch32-specific parts of the binfo struct. | 6 | devices on the commandline without specifying a bus name then they |
7 | will be connected to the I2C controller used for the Shield | ||
8 | connector, where guest software will expect them. | ||
7 | 9 | ||
8 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 10 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
9 | Reviewed-by: Andrew Baumann <Andrew.Baumann@microsoft.com> | 11 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> |
10 | Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | 12 | Message-id: 20210903151435.22379-5-peter.maydell@linaro.org |
11 | Message-id: 20180313153458.26822-2-peter.maydell@linaro.org | ||
12 | --- | 13 | --- |
13 | hw/arm/raspi.c | 17 +++++++++++++---- | 14 | hw/arm/mps2.c | 12 +++++++++++- |
14 | 1 file changed, 13 insertions(+), 4 deletions(-) | 15 | 1 file changed, 11 insertions(+), 1 deletion(-) |
15 | 16 | ||
16 | diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c | 17 | diff --git a/hw/arm/mps2.c b/hw/arm/mps2.c |
17 | index XXXXXXX..XXXXXXX 100644 | 18 | index XXXXXXX..XXXXXXX 100644 |
18 | --- a/hw/arm/raspi.c | 19 | --- a/hw/arm/mps2.c |
19 | +++ b/hw/arm/raspi.c | 20 | +++ b/hw/arm/mps2.c |
20 | @@ -XXX,XX +XXX,XX @@ static void setup_boot(MachineState *machine, int version, size_t ram_size) | 21 | @@ -XXX,XX +XXX,XX @@ static void mps2_common_init(MachineState *machine) |
21 | binfo.board_id = raspi_boardid[version]; | 22 | 0x40023000, /* Audio */ |
22 | binfo.ram_size = ram_size; | 23 | 0x40029000, /* Shield0 */ |
23 | binfo.nb_cpus = smp_cpus; | 24 | 0x4002a000}; /* Shield1 */ |
24 | - binfo.board_setup_addr = BOARDSETUP_ADDR; | 25 | - sysbus_create_simple(TYPE_ARM_SBCON_I2C, i2cbase[i], NULL); |
25 | - binfo.write_board_setup = write_board_setup; | 26 | + DeviceState *dev; |
26 | - binfo.secure_board_setup = true; | ||
27 | - binfo.secure_boot = true; | ||
28 | + | 27 | + |
29 | + if (version <= 2) { | 28 | + dev = sysbus_create_simple(TYPE_ARM_SBCON_I2C, i2cbase[i], NULL); |
30 | + /* The rpi1 and 2 require some custom setup code to run in Secure | 29 | + if (i < 2) { |
31 | + * mode before booting a kernel (to set up the SMC vectors so | 30 | + /* |
32 | + * that we get a no-op SMC; this is used by Linux to call the | 31 | + * internal-only bus: mark it full to avoid user-created |
33 | + * firmware for some cache maintenance operations. | 32 | + * i2c devices being plugged into it. |
34 | + * The rpi3 doesn't need this. | 33 | + */ |
35 | + */ | 34 | + BusState *qbus = qdev_get_child_bus(dev, "i2c"); |
36 | + binfo.board_setup_addr = BOARDSETUP_ADDR; | 35 | + qbus_mark_full(qbus); |
37 | + binfo.write_board_setup = write_board_setup; | 36 | + } |
38 | + binfo.secure_board_setup = true; | 37 | } |
39 | + binfo.secure_boot = true; | 38 | create_unimplemented_device("i2s", 0x40024000, 0x400); |
40 | + } | 39 | |
41 | |||
42 | /* Pi2 and Pi3 requires SMP setup */ | ||
43 | if (version >= 2) { | ||
44 | -- | 40 | -- |
45 | 2.16.2 | 41 | 2.20.1 |
46 | 42 | ||
47 | 43 | diff view generated by jsdifflib |