replay: finish record/replay before closing the disks

[Qemu-devel] [PATCH] replay: finish record/replay before closing the disks

Pavel Dovgalyuk posted 1 patch 7 years, 7 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180319092505.20283.81523.stgit@pasha-VirtualBox

Test checkpatch passed

Test docker-build@min-glib passed

Test docker-mingw@fedora passed

Test docker-quick@centos6 passed

Test s390x passed

replay/replay.c |    2 ++
vl.c            |    1 +
2 files changed, 3 insertions(+)

Expand all Fold all

[Qemu-devel] [PATCH] replay: finish record/replay before closing the disks

Posted by Pavel Dovgalyuk 7 years, 7 months ago

After recent updates block devices cannot be closed on qemu exit.
This happens due to the block request polling when replay is not finished.
Therefore now we stop execution recording before closing the block devices.

Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
---
 replay/replay.c |    2 ++
 vl.c            |    1 +
 2 files changed, 3 insertions(+)

diff --git a/replay/replay.c b/replay/replay.c
index 8228261..58a986f 100644
--- a/replay/replay.c
+++ b/replay/replay.c
@@ -366,6 +366,8 @@ void replay_finish(void)
     g_free(replay_snapshot);
     replay_snapshot = NULL;
 
+    replay_mode = REPLAY_MODE_NONE;
+
     replay_finish_events();
 }
 
diff --git a/vl.c b/vl.c
index e8bebda..f4d9153 100644
--- a/vl.c
+++ b/vl.c
@@ -4733,6 +4733,7 @@ int main(int argc, char **argv, char **envp)
 
     /* No more vcpu or device emulation activity beyond this point */
     vm_shutdown();
+    replay_finish();
 
     bdrv_close_all();

Re: [Qemu-devel] [PATCH] replay: finish record/replay before closing the disks

Posted by Paolo Bonzini 7 years, 7 months ago

On 19/03/2018 10:25, Pavel Dovgalyuk wrote:
> After recent updates block devices cannot be closed on qemu exit.
> This happens due to the block request polling when replay is not finished.
> Therefore now we stop execution recording before closing the block devices.
> 
> Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
> ---
>  replay/replay.c |    2 ++
>  vl.c            |    1 +
>  2 files changed, 3 insertions(+)
> 
> diff --git a/replay/replay.c b/replay/replay.c
> index 8228261..58a986f 100644
> --- a/replay/replay.c
> +++ b/replay/replay.c
> @@ -366,6 +366,8 @@ void replay_finish(void)
>      g_free(replay_snapshot);
>      replay_snapshot = NULL;
>  
> +    replay_mode = REPLAY_MODE_NONE;
> +
>      replay_finish_events();
>  }
>  
> diff --git a/vl.c b/vl.c
> index e8bebda..f4d9153 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4733,6 +4733,7 @@ int main(int argc, char **argv, char **envp)
>  
>      /* No more vcpu or device emulation activity beyond this point */
>      vm_shutdown();
> +    replay_finish();
>  
>      bdrv_close_all();
>  
> 

Queued, thanks.

Paolo