[v3] slirp: Add query-usernet QMP command

[Qemu-devel] [PATCH for-2.13 v3 0/2] slirp: Add query-usernet QMP command

Fam Zheng posted 2 patches 7 years, 7 months ago

Diff against v1 v2 v4 v5 v6
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180316062822.15425-1-famz@redhat.com

Test checkpatch passed

Test docker-build@min-glib passed

Test docker-mingw@fedora passed

Test docker-quick@centos6 passed

Test s390x passed

There is a newer version of this series

net/slirp.c        |  26 +++++++
qapi/net.json      | 201 +++++++++++++++++++++++++++++++++++++++++++++++++++++
slirp/libslirp.h   |   2 +
slirp/misc.c       | 156 +++++++++++++++++++++++++++++------------
slirp/tcp.h        |  15 ----
tests/vm/basevm.py |  14 ++--
6 files changed, 347 insertions(+), 67 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH for-2.13 v3 0/2] slirp: Add query-usernet QMP command

Posted by Fam Zheng 7 years, 7 months ago

v3: - Add Eric's rev-by to patch 2.
    - Address Eric's comments on patch 1:
      * Fix spell/grammar: "programmed", "awaiting".
      * Fix include "qapi/qapi-commands-net.h".
      * Underscores to dashes.
      * "Since 2.13" now.

v2: Fix compiler error. [patchew]

The command is a counterpart of HMP "info usernet" and is at least very useful
for the VM tests. So add it.

Fam Zheng (2):
  slirp: Add "query-usernet" QMP command
  tests: Use query-usernet instead of 'info usernet'

 net/slirp.c        |  26 +++++++
 qapi/net.json      | 201 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 slirp/libslirp.h   |   2 +
 slirp/misc.c       | 156 +++++++++++++++++++++++++++++------------
 slirp/tcp.h        |  15 ----
 tests/vm/basevm.py |  14 ++--
 6 files changed, 347 insertions(+), 67 deletions(-)

-- 
2.14.3

Re: [Qemu-devel] [PATCH for-2.13 v3 0/2] slirp: Add query-usernet QMP command

Posted by Jason Wang 7 years, 7 months ago


On 2018年03月16日 14:28, Fam Zheng wrote:
> v3: - Add Eric's rev-by to patch 2.
>      - Address Eric's comments on patch 1:
>        * Fix spell/grammar: "programmed", "awaiting".
>        * Fix include "qapi/qapi-commands-net.h".
>        * Underscores to dashes.
>        * "Since 2.13" now.
>
> v2: Fix compiler error. [patchew]
>
> The command is a counterpart of HMP "info usernet" and is at least very useful
> for the VM tests. So add it.
>
> Fam Zheng (2):
>    slirp: Add "query-usernet" QMP command
>    tests: Use query-usernet instead of 'info usernet'
>
>   net/slirp.c        |  26 +++++++
>   qapi/net.json      | 201 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>   slirp/libslirp.h   |   2 +
>   slirp/misc.c       | 156 +++++++++++++++++++++++++++++------------
>   slirp/tcp.h        |  15 ----
>   tests/vm/basevm.py |  14 ++--
>   6 files changed, 347 insertions(+), 67 deletions(-)
>

Hi Samuel:

Does this looks good for you? I believe it's better to be merged through 
your tree.

Thanks