[Qemu-devel] [PULL 00/69] Misc patches for QEMU soft freeze

Paolo Bonzini posted 69 patches 7 years, 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180313224719.4954-1-pbonzini@redhat.com
Test checkpatch failed
Test docker-build@min-glib passed
Test docker-mingw@fedora passed
Test docker-quick@centos6 passed
Test s390x passed
MAINTAINERS                        |  20 ++-
Makefile                           |  23 +--
accel/tcg/cpu-exec.c               |   5 +-
accel/tcg/translate-all.c          |  18 ++-
bsd-user/main.c                    |   2 +-
chardev/char-mux.c                 |  33 +++-
chardev/char-socket.c              | 137 ++++++++++++-----
chardev/char.c                     |  43 ++----
configure                          |  44 +++++-
cpus.c                             |  24 ++-
default-configs/alpha-softmmu.mak  |   5 +
default-configs/i386-softmmu.mak   |   2 +
default-configs/x86_64-softmmu.mak |   2 +
docs/devel/atomics.txt             |  57 +++----
docs/replay.txt                    | 163 +++++++++++++++++---
hw/alpha/dp264.c                   |  13 +-
hw/arm/highbank.c                  |   1 -
hw/arm/msf2-soc.c                  |   1 -
hw/arm/realview.c                  |   1 -
hw/arm/tosa.c                      |   1 -
hw/char/Makefile.objs              |   1 +
hw/char/parallel-isa.c             |  36 +++++
hw/char/parallel.c                 |   2 +-
hw/dma/i82374.c                    |   3 +-
hw/dma/i8257.c                     |   4 +-
hw/i386/Makefile.objs              |   4 +-
hw/i386/pc.c                       |  86 ++++++-----
hw/i386/pc_piix.c                  |   7 +-
hw/i386/pc_q35.c                   |   8 +-
hw/i386/vmmouse.c                  |   1 +
hw/i386/vmport.c                   |   1 +
hw/ide/ahci-allwinner.c            |   1 -
hw/ide/cmd646.c                    |   1 -
hw/ide/ich.c                       |   1 -
hw/ide/isa.c                       |   1 -
hw/ide/microdrive.c                |   1 -
hw/ide/mmio.c                      |   1 -
hw/input/pckbd.c                   |   2 +-
hw/isa/Makefile.objs               |   1 +
hw/isa/isa-bus.c                   |  26 ----
hw/isa/isa-superio.c               | 214 ++++++++++++++++++++++++++
hw/isa/pc87312.c                   | 178 ++++++++++-----------
hw/isa/smc37c669-superio.c         | 115 ++++++++++++++
hw/isa/trace-events                |  10 +-
hw/isa/vt82c686.c                  |  22 ++-
hw/mips/mips_fulong2e.c            |  86 +++++------
hw/mips/mips_jazz.c                |  13 +-
hw/mips/mips_malta.c               |  48 +++---
hw/mips/mips_r4k.c                 |   3 +-
hw/pci/pci.c                       |  61 ++++----
hw/ppc/e500.c                      |   2 +-
hw/ppc/mac_newworld.c              |   1 -
hw/ppc/mac_oldworld.c              |   1 -
hw/ppc/prep.c                      |   7 +-
hw/scsi/esp.c                      |  12 +-
hw/scsi/mptendian.c                |   1 -
hw/scsi/scsi-bus.c                 |   2 +-
hw/scsi/scsi-disk.c                |  17 +-
hw/sd/core.c                       |   1 -
hw/sparc/sun4m.c                   |   5 -
hw/sparc64/sun4u.c                 |   6 +-
hw/tricore/tricore_testboard.c     |   2 -
hw/unicore32/puv3.c                |   1 +
include/chardev/char-mux.h         |   2 -
include/chardev/char.h             |   2 +
include/hw/char/parallel.h         |  14 ++
include/hw/{isa => dma}/i8257.h    |   6 +
include/hw/i386/pc.h               |  20 +--
include/hw/input/i8042.h           |  24 +++
include/hw/isa/isa.h               |   2 -
include/hw/isa/pc87312.h           |  24 +--
include/hw/isa/superio.h           |  60 ++++++++
include/hw/isa/vt82c686.h          |   4 +-
include/hw/scsi/esp.h              |  10 +-
include/qemu/rcu.h                 |  16 +-
include/qemu/sys_membarrier.h      |  27 ++++
include/qemu/timer.h               |  14 ++
include/qom/object.h               |  11 ++
include/sysemu/replay.h            |  16 ++
include/sysemu/sysemu.h            |   2 +
linux-user/main.c                  |   2 +-
migration/savevm.c                 |  13 ++
qdev-monitor.c                     |   9 +-
qemu-doc.texi                      |  44 ++++--
qemu-img.c                         |   2 +-
qemu-io.c                          |   2 +-
qemu-nbd.c                         |   2 +-
qga/main.c                         |   2 +-
qom/object.c                       |  13 ++
replay/replay-audio.c              |  14 +-
replay/replay-char.c               |  21 +--
replay/replay-events.c             |  75 +++++----
replay/replay-internal.c           |  43 +++++-
replay/replay-internal.h           |  17 +-
replay/replay-snapshot.c           |  12 ++
replay/replay-time.c               |  10 +-
replay/replay.c                    |  58 ++++---
scripts/checkpatch.pl              |   3 +-
scripts/replay-dump.py             | 308 +++++++++++++++++++++++++++++++++++++
scsi/qemu-pr-helper.c              |   2 +-
stubs/machine-init-done.c          |   2 +
stubs/replay.c                     |   8 +
target/alpha/cpu.c                 |  15 +-
target/hppa/cpu.c                  |  15 +-
target/lm32/cpu.c                  |  15 +-
target/sh4/cpu.c                   |  15 +-
target/tricore/helper.c            |   2 +-
tests/rcutorture.c                 |   4 -
tests/test-char.c                  |   1 -
tests/virtio-scsi-test.c           |   6 +
ui/cocoa.m                         |   2 +-
util/Makefile.objs                 |   1 +
util/main-loop.c                   |  15 +-
util/qemu-timer.c                  |  12 ++
util/rcu.c                         |  15 +-
util/sys_membarrier.c              |  50 ++++++
vl.c                               |   7 +-
117 files changed, 1953 insertions(+), 729 deletions(-)
create mode 100644 hw/char/parallel-isa.c
create mode 100644 hw/isa/isa-superio.c
create mode 100644 hw/isa/smc37c669-superio.c
create mode 100644 include/hw/char/parallel.h
rename include/hw/{isa => dma}/i8257.h (86%)
create mode 100644 include/hw/input/i8042.h
create mode 100644 include/hw/isa/superio.h
create mode 100644 include/qemu/sys_membarrier.h
create mode 100755 scripts/replay-dump.py
create mode 100644 util/sys_membarrier.c
[Qemu-devel] [PULL 00/69] Misc patches for QEMU soft freeze
Posted by Paolo Bonzini 7 years, 9 months ago
Not sure why this didn't make it to the list yesterday---most likely I
didn't remove --dry-run...  Now I understand why everybody was waiting
for my pull request.

The following changes since commit 819fd4699c7b36d574292bcbd8bc25e9d716c84b:

  Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20180309a' into staging (2018-03-12 13:21:53 +0000)

are available in the Git repository at:

  git://github.com/bonzini/qemu.git tags/for-upstream

for you to fetch changes up to 0790f86861079b1932679d0f011e431aaf4ee9e2:

  tcg: fix cpu_io_recompile (2018-03-12 17:10:38 +0100)

----------------------------------------------------------------
* Record-replay lockstep execution, log dumper and fixes (Alex, Pavel)
* SCSI fix to pass maximum transfer size (Daniel Barboza)
* chardev fixes and improved iothread support (Daniel Berrangé, Peter)
* checkpatch tweak (Eric)
* make help tweak (Marc-André)
* make more PCI NICs available with -net or -nic (myself)
* change default q35 NIC to e1000e (myself)
* SCSI support for NDOB bit (myself)
* membarrier system call support (myself)
* SuperIO refactoring (Philippe)
* miscellaneous cleanups and fixes (Thomas)

----------------------------------------------------------------
Alex Bennée (5):
      replay/replay.c: bump REPLAY_VERSION again
      replay/replay-internal.c: track holding of replay_lock
      replay: make locking visible outside replay code
      replay: push replay_mutex_lock up the call tree
      scripts/replay-dump.py: replay log dumper

Daniel Henrique Barboza (1):
      scsi-disk.c: consider bl->max_transfer in INQUIRY emulation

Daniel P. Berrangé (1):
      chardev: fix handling of EAGAIN for TCP chardev

Eric Blake (1):
      checkpatch: Exempt long URLs

Marc-André Lureau (1):
      build-sys: make help could have 'modules' target

Paolo Bonzini (11):
      qom: introduce object_class_get_list_sorted
      net: allow using any PCI NICs in -net or -nic
      q35: change default NIC to e1000e
      qemu-doc: update deprecation section to use -nic and -netdev hubport
      scsi: support NDOB (no data-out buffer) for WRITE SAME commands
      hw/i386: make IOMMUs configurable via default-configs/
      rcutorture: remove synchronize_rcu from readers
      docs: document atomic_load_acquire and atomic_store_release
      rcu: make memory barriers more explicit
      membarrier: introduce qemu/sys_membarrier.h
      membarrier: add --enable-membarrier

Pavel Dovgalyuk (13):
      cpu-exec: fix exception_index handling
      replay: fix processing async events
      replay: fixed replay_enable_events
      replay: fix save/load vm for non-empty queue
      replay: added replay log format description
      replay: save prior value of the host clock
      replay: don't destroy mutex at exit
      replay: check return values of fwrite
      replay: avoid recursive call of checkpoints
      replay: don't process async events when warping the clock
      replay: save vmstate of the asynchronous events
      replay: update documentation
      tcg: fix cpu_io_recompile

Peter Xu (7):
      vl: export machine_init_done
      chardev: update net listener gcontext
      chardev: allow telnet gsource to switch gcontext
      chardev: introduce chr_machine_done hook
      chardev: use chardev's gcontext for async connect
      chardev: tcp: postpone async connection setup
      chardev: tcp: let TLS run on chardev context

Philippe Mathieu-Daudé (25):
      hw/isa: Move parallel_hds_isa_init() to hw/char/parallel-isa.c
      hw/dma/i8257: Rename DMA_init() to i8257_dma_init()
      hw/input/i8042: Extract declarations from i386/pc.h into input/i8042.h
      MAINTAINERS: Fix the PC87312 include path
      hw/isa/pc87312: Rename the device type as TYPE_PC87312_SUPERIO
      hw/isa/pc87312: Use uint16_t for the ISA I/O base address
      hw/isa/pc87312: Use 'unsigned int' for the irq value
      hw/isa/superio: Add a Super I/O template based on the PC87312 device
      hw/isa/pc87312: Inherit from the abstract TYPE_ISA_SUPERIO
      hw/isa/superio: Factor out the parallel code from pc87312.c
      hw/isa/superio: Factor out the serial code from pc87312.c
      hw/isa/superio: Factor out the floppy disc controller code from pc87312.c
      hw/isa/superio: Add a keyboard/mouse controller (8042)
      hw/isa/superio: Factor out the IDE code from pc87312.c
      hw/mips/malta: Code movement
      hw/isa/superio: Factor out the FDC37M817 Super I/O from mips_malta.c
      hw/mips/mips_fulong2e: Factor out vt82c686b_southbridge_init()
      hw/isa/vt82c686: Rename vt82c686b_init() -> vt82c686b_isa_init()
      hw/isa/vt82c686: Add the TYPE_VT82C686B_SUPERIO
      MAINTAINERS: Add entries for the VT82C686B Super I/O
      MAINTAINERS: Split the Alpha TCG/machine section
      hw/isa/superio: Add the SMC FDC37C669 Super I/O
      hw/alpha/dp264: Add the ISA DMA controller
      hw/alpha/dp264: Use the TYPE_SMC37C669_SUPERIO
      hw/i386/pc: Factor out the superio code

Thomas Huth (4):
      qemu-doc: Add the paragraph about the -no-frame deprecation again
      hw: Do not include "sysemu/block-backend.h" if it is not necessary
      Polish the version strings containing the package version
      hw/mips/jazz: Fix implicit creation of "-drive if=scsi" devices

 MAINTAINERS                        |  20 ++-
 Makefile                           |  23 +--
 accel/tcg/cpu-exec.c               |   5 +-
 accel/tcg/translate-all.c          |  18 ++-
 bsd-user/main.c                    |   2 +-
 chardev/char-mux.c                 |  33 +++-
 chardev/char-socket.c              | 137 ++++++++++++-----
 chardev/char.c                     |  43 ++----
 configure                          |  44 +++++-
 cpus.c                             |  24 ++-
 default-configs/alpha-softmmu.mak  |   5 +
 default-configs/i386-softmmu.mak   |   2 +
 default-configs/x86_64-softmmu.mak |   2 +
 docs/devel/atomics.txt             |  57 +++----
 docs/replay.txt                    | 163 +++++++++++++++++---
 hw/alpha/dp264.c                   |  13 +-
 hw/arm/highbank.c                  |   1 -
 hw/arm/msf2-soc.c                  |   1 -
 hw/arm/realview.c                  |   1 -
 hw/arm/tosa.c                      |   1 -
 hw/char/Makefile.objs              |   1 +
 hw/char/parallel-isa.c             |  36 +++++
 hw/char/parallel.c                 |   2 +-
 hw/dma/i82374.c                    |   3 +-
 hw/dma/i8257.c                     |   4 +-
 hw/i386/Makefile.objs              |   4 +-
 hw/i386/pc.c                       |  86 ++++++-----
 hw/i386/pc_piix.c                  |   7 +-
 hw/i386/pc_q35.c                   |   8 +-
 hw/i386/vmmouse.c                  |   1 +
 hw/i386/vmport.c                   |   1 +
 hw/ide/ahci-allwinner.c            |   1 -
 hw/ide/cmd646.c                    |   1 -
 hw/ide/ich.c                       |   1 -
 hw/ide/isa.c                       |   1 -
 hw/ide/microdrive.c                |   1 -
 hw/ide/mmio.c                      |   1 -
 hw/input/pckbd.c                   |   2 +-
 hw/isa/Makefile.objs               |   1 +
 hw/isa/isa-bus.c                   |  26 ----
 hw/isa/isa-superio.c               | 214 ++++++++++++++++++++++++++
 hw/isa/pc87312.c                   | 178 ++++++++++-----------
 hw/isa/smc37c669-superio.c         | 115 ++++++++++++++
 hw/isa/trace-events                |  10 +-
 hw/isa/vt82c686.c                  |  22 ++-
 hw/mips/mips_fulong2e.c            |  86 +++++------
 hw/mips/mips_jazz.c                |  13 +-
 hw/mips/mips_malta.c               |  48 +++---
 hw/mips/mips_r4k.c                 |   3 +-
 hw/pci/pci.c                       |  61 ++++----
 hw/ppc/e500.c                      |   2 +-
 hw/ppc/mac_newworld.c              |   1 -
 hw/ppc/mac_oldworld.c              |   1 -
 hw/ppc/prep.c                      |   7 +-
 hw/scsi/esp.c                      |  12 +-
 hw/scsi/mptendian.c                |   1 -
 hw/scsi/scsi-bus.c                 |   2 +-
 hw/scsi/scsi-disk.c                |  17 +-
 hw/sd/core.c                       |   1 -
 hw/sparc/sun4m.c                   |   5 -
 hw/sparc64/sun4u.c                 |   6 +-
 hw/tricore/tricore_testboard.c     |   2 -
 hw/unicore32/puv3.c                |   1 +
 include/chardev/char-mux.h         |   2 -
 include/chardev/char.h             |   2 +
 include/hw/char/parallel.h         |  14 ++
 include/hw/{isa => dma}/i8257.h    |   6 +
 include/hw/i386/pc.h               |  20 +--
 include/hw/input/i8042.h           |  24 +++
 include/hw/isa/isa.h               |   2 -
 include/hw/isa/pc87312.h           |  24 +--
 include/hw/isa/superio.h           |  60 ++++++++
 include/hw/isa/vt82c686.h          |   4 +-
 include/hw/scsi/esp.h              |  10 +-
 include/qemu/rcu.h                 |  16 +-
 include/qemu/sys_membarrier.h      |  27 ++++
 include/qemu/timer.h               |  14 ++
 include/qom/object.h               |  11 ++
 include/sysemu/replay.h            |  16 ++
 include/sysemu/sysemu.h            |   2 +
 linux-user/main.c                  |   2 +-
 migration/savevm.c                 |  13 ++
 qdev-monitor.c                     |   9 +-
 qemu-doc.texi                      |  44 ++++--
 qemu-img.c                         |   2 +-
 qemu-io.c                          |   2 +-
 qemu-nbd.c                         |   2 +-
 qga/main.c                         |   2 +-
 qom/object.c                       |  13 ++
 replay/replay-audio.c              |  14 +-
 replay/replay-char.c               |  21 +--
 replay/replay-events.c             |  75 +++++----
 replay/replay-internal.c           |  43 +++++-
 replay/replay-internal.h           |  17 +-
 replay/replay-snapshot.c           |  12 ++
 replay/replay-time.c               |  10 +-
 replay/replay.c                    |  58 ++++---
 scripts/checkpatch.pl              |   3 +-
 scripts/replay-dump.py             | 308 +++++++++++++++++++++++++++++++++++++
 scsi/qemu-pr-helper.c              |   2 +-
 stubs/machine-init-done.c          |   2 +
 stubs/replay.c                     |   8 +
 target/alpha/cpu.c                 |  15 +-
 target/hppa/cpu.c                  |  15 +-
 target/lm32/cpu.c                  |  15 +-
 target/sh4/cpu.c                   |  15 +-
 target/tricore/helper.c            |   2 +-
 tests/rcutorture.c                 |   4 -
 tests/test-char.c                  |   1 -
 tests/virtio-scsi-test.c           |   6 +
 ui/cocoa.m                         |   2 +-
 util/Makefile.objs                 |   1 +
 util/main-loop.c                   |  15 +-
 util/qemu-timer.c                  |  12 ++
 util/rcu.c                         |  15 +-
 util/sys_membarrier.c              |  50 ++++++
 vl.c                               |   7 +-
 117 files changed, 1953 insertions(+), 729 deletions(-)
 create mode 100644 hw/char/parallel-isa.c
 create mode 100644 hw/isa/isa-superio.c
 create mode 100644 hw/isa/smc37c669-superio.c
 create mode 100644 include/hw/char/parallel.h
 rename include/hw/{isa => dma}/i8257.h (86%)
 create mode 100644 include/hw/input/i8042.h
 create mode 100644 include/hw/isa/superio.h
 create mode 100644 include/qemu/sys_membarrier.h
 create mode 100755 scripts/replay-dump.py
 create mode 100644 util/sys_membarrier.c
-- 
2.14.3


Re: [Qemu-devel] [PULL 00/69] Misc patches for QEMU soft freeze
Posted by no-reply@patchew.org 7 years, 9 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180313224719.4954-1-pbonzini@redhat.com
Subject: [Qemu-devel] [PULL 00/69] Misc patches for QEMU soft freeze

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20180313224719.4954-1-pbonzini@redhat.com -> patchew/20180313224719.4954-1-pbonzini@redhat.com
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
Switched to a new branch 'test'
20b2d41547 tcg: fix cpu_io_recompile
c46131d9ac replay: update documentation
ebbeee6c00 replay: save vmstate of the asynchronous events
6a1d180135 replay: don't process async events when warping the clock
d878031ce3 scripts/replay-dump.py: replay log dumper
fa49388d29 replay: avoid recursive call of checkpoints
8425f8a33b replay: check return values of fwrite
0c4cf018d7 replay: push replay_mutex_lock up the call tree
eedffef5df replay: don't destroy mutex at exit
a4649842a9 replay: make locking visible outside replay code
1570edbbd5 replay/replay-internal.c: track holding of replay_lock
e6d2f97e40 replay/replay.c: bump REPLAY_VERSION again
c0d71df05c replay: save prior value of the host clock
a7c57184b1 replay: added replay log format description
39eaf489fd replay: fix save/load vm for non-empty queue
980235a32e replay: fixed replay_enable_events
a846c03323 replay: fix processing async events
9f1d12928e cpu-exec: fix exception_index handling
1d6e886906 hw/i386/pc: Factor out the superio code
e24291717f hw/alpha/dp264: Use the TYPE_SMC37C669_SUPERIO
1c75546a89 hw/alpha/dp264: Add the ISA DMA controller
8ccab0e5cc hw/isa/superio: Add the SMC FDC37C669 Super I/O
0638def1b5 MAINTAINERS: Split the Alpha TCG/machine section
fc68e597c6 MAINTAINERS: Add entries for the VT82C686B Super I/O
354da50497 hw/isa/vt82c686: Add the TYPE_VT82C686B_SUPERIO
66ca3f335d hw/isa/vt82c686: Rename vt82c686b_init() -> vt82c686b_isa_init()
112b337ef0 hw/mips/mips_fulong2e: Factor out vt82c686b_southbridge_init()
547f28856f hw/isa/superio: Factor out the FDC37M817 Super I/O from mips_malta.c
048338438b hw/mips/malta: Code movement
898bc44d9f hw/isa/superio: Factor out the IDE code from pc87312.c
649c8ee02e hw/isa/superio: Add a keyboard/mouse controller (8042)
2f0ca2c71c hw/isa/superio: Factor out the floppy disc controller code from pc87312.c
84a2f1940f hw/isa/superio: Factor out the serial code from pc87312.c
744cf074a8 hw/isa/superio: Factor out the parallel code from pc87312.c
3ecb08902c hw/isa/pc87312: Inherit from the abstract TYPE_ISA_SUPERIO
3ad09fdf2c hw/isa/superio: Add a Super I/O template based on the PC87312 device
06a0adcfd8 hw/isa/pc87312: Use 'unsigned int' for the irq value
5479558c92 hw/isa/pc87312: Use uint16_t for the ISA I/O base address
1ca2ae2991 hw/isa/pc87312: Rename the device type as TYPE_PC87312_SUPERIO
25e755167f MAINTAINERS: Fix the PC87312 include path
f829b02d47 hw/input/i8042: Extract declarations from i386/pc.h into input/i8042.h
5e6c657232 hw/dma/i8257: Rename DMA_init() to i8257_dma_init()
922053d83d hw/isa: Move parallel_hds_isa_init() to hw/char/parallel-isa.c
18e14e69b7 membarrier: add --enable-membarrier
136b6f0343 membarrier: introduce qemu/sys_membarrier.h
7be9740f48 rcu: make memory barriers more explicit
9f4445960c docs: document atomic_load_acquire and atomic_store_release
f14149cb0a rcutorture: remove synchronize_rcu from readers
71d22958d8 hw/mips/jazz: Fix implicit creation of "-drive if=scsi" devices
5cd7037170 Polish the version strings containing the package version
0a13467c66 hw/i386: make IOMMUs configurable via default-configs/
4eec1790b5 scsi: support NDOB (no data-out buffer) for WRITE SAME commands
a5dd7aaf89 chardev: tcp: let TLS run on chardev context
0058402907 chardev: tcp: postpone async connection setup
189e98e5db chardev: use chardev's gcontext for async connect
6c6f38627f chardev: introduce chr_machine_done hook
498f244334 chardev: allow telnet gsource to switch gcontext
eee9ff412a chardev: update net listener gcontext
0fdbf8e1ce chardev: fix handling of EAGAIN for TCP chardev
a7967d2420 vl: export machine_init_done
1d2d7c57f1 checkpatch: Exempt long URLs
835403d319 hw: Do not include "sysemu/block-backend.h" if it is not necessary
b1502c478e build-sys: make help could have 'modules' target
b3b603a323 qemu-doc: Add the paragraph about the -no-frame deprecation again
90b5bafeb0 qemu-doc: update deprecation section to use -nic and -netdev hubport
94c73e33f5 scsi-disk.c: consider bl->max_transfer in INQUIRY emulation
9b1a0208b6 q35: change default NIC to e1000e
eb3ed01f15 net: allow using any PCI NICs in -net or -nic
91df7b715e qom: introduce object_class_get_list_sorted

=== OUTPUT BEGIN ===
Checking PATCH 1/69: qom: introduce object_class_get_list_sorted...
WARNING: line over 80 characters
#83: FILE: qom/object.c:903:
+    return g_slist_sort(object_class_get_list(implements_type, include_abstract),

total: 0 errors, 1 warnings, 173 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/69: net: allow using any PCI NICs in -net or -nic...
Checking PATCH 3/69: q35: change default NIC to e1000e...
Checking PATCH 4/69: scsi-disk.c: consider bl->max_transfer in INQUIRY emulation...
Checking PATCH 5/69: qemu-doc: update deprecation section to use -nic and -netdev hubport...
Checking PATCH 6/69: qemu-doc: Add the paragraph about the -no-frame deprecation again...
Checking PATCH 7/69: build-sys: make help could have 'modules' target...
Checking PATCH 8/69: hw: Do not include "sysemu/block-backend.h" if it is not necessary...
Checking PATCH 9/69: checkpatch: Exempt long URLs...
Checking PATCH 10/69: vl: export machine_init_done...
Checking PATCH 11/69: chardev: fix handling of EAGAIN for TCP chardev...
Checking PATCH 12/69: chardev: update net listener gcontext...
Checking PATCH 13/69: chardev: allow telnet gsource to switch gcontext...
Checking PATCH 14/69: chardev: introduce chr_machine_done hook...
Checking PATCH 15/69: chardev: use chardev's gcontext for async connect...
Checking PATCH 16/69: chardev: tcp: postpone async connection setup...
Checking PATCH 17/69: chardev: tcp: let TLS run on chardev context...
Checking PATCH 18/69: scsi: support NDOB (no data-out buffer) for WRITE SAME commands...
WARNING: line over 80 characters
#59: FILE: tests/virtio-scsi-test.c:232:
+        virtio_scsi_do_command(vs, write_same_cdb_ndob, NULL, 0, NULL, 0, NULL));

total: 0 errors, 1 warnings, 34 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 19/69: hw/i386: make IOMMUs configurable via default-configs/...
Checking PATCH 20/69: Polish the version strings containing the package version...
Checking PATCH 21/69: hw/mips/jazz: Fix implicit creation of "-drive if=scsi" devices...
Checking PATCH 22/69: rcutorture: remove synchronize_rcu from readers...
Checking PATCH 23/69: docs: document atomic_load_acquire and atomic_store_release...
Checking PATCH 24/69: rcu: make memory barriers more explicit...
Checking PATCH 25/69: membarrier: introduce qemu/sys_membarrier.h...
ERROR: memory barrier without comment
#70: FILE: include/qemu/sys_membarrier.h:14:
+#define smp_mb_global()            smp_mb()

ERROR: memory barrier without comment
#71: FILE: include/qemu/sys_membarrier.h:15:
+#define smp_mb_placeholder()       smp_mb()

total: 2 errors, 0 warnings, 77 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 26/69: membarrier: add --enable-membarrier...
WARNING: line over 80 characters
#192: FILE: util/sys_membarrier.c:45:
+        error_report("This QEMU binary requires MEMBARRIER_CMD_SHARED support.");

total: 0 errors, 1 warnings, 154 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 27/69: hw/isa: Move parallel_hds_isa_init() to hw/char/parallel-isa.c...
Checking PATCH 28/69: hw/dma/i8257: Rename DMA_init() to i8257_dma_init()...
Checking PATCH 29/69: hw/input/i8042: Extract declarations from i386/pc.h into input/i8042.h...
Checking PATCH 30/69: MAINTAINERS: Fix the PC87312 include path...
Checking PATCH 31/69: hw/isa/pc87312: Rename the device type as TYPE_PC87312_SUPERIO...
Checking PATCH 32/69: hw/isa/pc87312: Use uint16_t for the ISA I/O base address...
Checking PATCH 33/69: hw/isa/pc87312: Use 'unsigned int' for the irq value...
Checking PATCH 34/69: hw/isa/superio: Add a Super I/O template based on the PC87312 device...
Checking PATCH 35/69: hw/isa/pc87312: Inherit from the abstract TYPE_ISA_SUPERIO...
Checking PATCH 36/69: hw/isa/superio: Factor out the parallel code from pc87312.c...
Checking PATCH 37/69: hw/isa/superio: Factor out the serial code from pc87312.c...
Checking PATCH 38/69: hw/isa/superio: Factor out the floppy disc controller code from pc87312.c...
Checking PATCH 39/69: hw/isa/superio: Add a keyboard/mouse controller (8042)...
Checking PATCH 40/69: hw/isa/superio: Factor out the IDE code from pc87312.c...
Checking PATCH 41/69: hw/mips/malta: Code movement...
Checking PATCH 42/69: hw/isa/superio: Factor out the FDC37M817 Super I/O from mips_malta.c...
Checking PATCH 43/69: hw/mips/mips_fulong2e: Factor out vt82c686b_southbridge_init()...
Checking PATCH 44/69: hw/isa/vt82c686: Rename vt82c686b_init() -> vt82c686b_isa_init()...
Checking PATCH 45/69: hw/isa/vt82c686: Add the TYPE_VT82C686B_SUPERIO...
Checking PATCH 46/69: MAINTAINERS: Add entries for the VT82C686B Super I/O...
Checking PATCH 47/69: MAINTAINERS: Split the Alpha TCG/machine section...
Checking PATCH 48/69: hw/isa/superio: Add the SMC FDC37C669 Super I/O...
Checking PATCH 49/69: hw/alpha/dp264: Add the ISA DMA controller...
Checking PATCH 50/69: hw/alpha/dp264: Use the TYPE_SMC37C669_SUPERIO...
Checking PATCH 51/69: hw/i386/pc: Factor out the superio code...
Checking PATCH 52/69: cpu-exec: fix exception_index handling...
Checking PATCH 53/69: replay: fix processing async events...
Checking PATCH 54/69: replay: fixed replay_enable_events...
Checking PATCH 55/69: replay: fix save/load vm for non-empty queue...
Checking PATCH 56/69: replay: added replay log format description...
Checking PATCH 57/69: replay: save prior value of the host clock...
Checking PATCH 58/69: replay/replay.c: bump REPLAY_VERSION again...
Checking PATCH 59/69: replay/replay-internal.c: track holding of replay_lock...
Checking PATCH 60/69: replay: make locking visible outside replay code...
Checking PATCH 61/69: replay: don't destroy mutex at exit...
Checking PATCH 62/69: replay: push replay_mutex_lock up the call tree...
Checking PATCH 63/69: replay: check return values of fwrite...
Checking PATCH 64/69: replay: avoid recursive call of checkpoints...
Checking PATCH 65/69: scripts/replay-dump.py: replay log dumper...
Checking PATCH 66/69: replay: don't process async events when warping the clock...
Checking PATCH 67/69: replay: save vmstate of the asynchronous events...
Checking PATCH 68/69: replay: update documentation...
Checking PATCH 69/69: tcg: fix cpu_io_recompile...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Re: [Qemu-devel] [PULL 00/69] Misc patches for QEMU soft freeze
Posted by Peter Xu 7 years, 9 months ago
On Tue, Mar 13, 2018 at 05:15:41PM -0700, no-reply@patchew.org wrote:

[...]

> Your patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> Checking PATCH 2/69: net: allow using any PCI NICs in -net or -nic...
> Checking PATCH 3/69: q35: change default NIC to e1000e...
> Checking PATCH 4/69: scsi-disk.c: consider bl->max_transfer in INQUIRY emulation...
> Checking PATCH 5/69: qemu-doc: update deprecation section to use -nic and -netdev hubport...
> Checking PATCH 6/69: qemu-doc: Add the paragraph about the -no-frame deprecation again...
> Checking PATCH 7/69: build-sys: make help could have 'modules' target...
> Checking PATCH 8/69: hw: Do not include "sysemu/block-backend.h" if it is not necessary...
> Checking PATCH 9/69: checkpatch: Exempt long URLs...
> Checking PATCH 10/69: vl: export machine_init_done...
> Checking PATCH 11/69: chardev: fix handling of EAGAIN for TCP chardev...
> Checking PATCH 12/69: chardev: update net listener gcontext...
> Checking PATCH 13/69: chardev: allow telnet gsource to switch gcontext...
> Checking PATCH 14/69: chardev: introduce chr_machine_done hook...
> Checking PATCH 15/69: chardev: use chardev's gcontext for async connect...
> Checking PATCH 16/69: chardev: tcp: postpone async connection setup...
> Checking PATCH 17/69: chardev: tcp: let TLS run on chardev context...

It seems that Dan's last patch is still missing in the pull
request:

http://patchwork.ozlabs.org/patch/883155/

I hope the monitor-oob series can survive the qtests even without that
single patch...

Thanks,

-- 
Peter Xu

Re: [Qemu-devel] [PULL 00/69] Misc patches for QEMU soft freeze
Posted by Paolo Bonzini 7 years, 9 months ago
On 14/03/2018 04:35, Peter Xu wrote:
> On Tue, Mar 13, 2018 at 05:15:41PM -0700, no-reply@patchew.org wrote:
> 
> [...]
> 
>> Your patch has style problems, please review.  If any of these errors
>> are false positives report them to the maintainer, see
>> CHECKPATCH in MAINTAINERS.
>> Checking PATCH 2/69: net: allow using any PCI NICs in -net or -nic...
>> Checking PATCH 3/69: q35: change default NIC to e1000e...
>> Checking PATCH 4/69: scsi-disk.c: consider bl->max_transfer in INQUIRY emulation...
>> Checking PATCH 5/69: qemu-doc: update deprecation section to use -nic and -netdev hubport...
>> Checking PATCH 6/69: qemu-doc: Add the paragraph about the -no-frame deprecation again...
>> Checking PATCH 7/69: build-sys: make help could have 'modules' target...
>> Checking PATCH 8/69: hw: Do not include "sysemu/block-backend.h" if it is not necessary...
>> Checking PATCH 9/69: checkpatch: Exempt long URLs...
>> Checking PATCH 10/69: vl: export machine_init_done...
>> Checking PATCH 11/69: chardev: fix handling of EAGAIN for TCP chardev...
>> Checking PATCH 12/69: chardev: update net listener gcontext...
>> Checking PATCH 13/69: chardev: allow telnet gsource to switch gcontext...
>> Checking PATCH 14/69: chardev: introduce chr_machine_done hook...
>> Checking PATCH 15/69: chardev: use chardev's gcontext for async connect...
>> Checking PATCH 16/69: chardev: tcp: postpone async connection setup...
>> Checking PATCH 17/69: chardev: tcp: let TLS run on chardev context...
> 
> It seems that Dan's last patch is still missing in the pull
> request:
> 
> http://patchwork.ozlabs.org/patch/883155/

Yes, this is a pull request I prepared last Monday and forgot to send.
I'll send that out separately, it's a bugfix so it can be submitted
after soft freeze.

Paolo


Re: [Qemu-devel] [PULL 00/69] Misc patches for QEMU soft freeze
Posted by Eric Blake 7 years, 9 months ago
On 03/14/2018 05:12 AM, Paolo Bonzini wrote:

>>> Checking PATCH 16/69: chardev: tcp: postpone async connection setup...
>>> Checking PATCH 17/69: chardev: tcp: let TLS run on chardev context...
>>
>> It seems that Dan's last patch is still missing in the pull
>> request:
>>
>> http://patchwork.ozlabs.org/patch/883155/
> 
> Yes, this is a pull request I prepared last Monday and forgot to send.
> I'll send that out separately, it's a bugfix so it can be submitted
> after soft freeze.

Or, since my pre-freeze QAPI pull request needs a v2, I can include it 
there, if I have an ACK or R-b by Paolo.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PULL 00/69] Misc patches for QEMU soft freeze
Posted by Peter Xu 7 years, 9 months ago
On Wed, Mar 14, 2018 at 06:30:33AM -0500, Eric Blake wrote:
> On 03/14/2018 05:12 AM, Paolo Bonzini wrote:
> 
> > > > Checking PATCH 16/69: chardev: tcp: postpone async connection setup...
> > > > Checking PATCH 17/69: chardev: tcp: let TLS run on chardev context...
> > > 
> > > It seems that Dan's last patch is still missing in the pull
> > > request:
> > > 
> > > http://patchwork.ozlabs.org/patch/883155/
> > 
> > Yes, this is a pull request I prepared last Monday and forgot to send.
> > I'll send that out separately, it's a bugfix so it can be submitted
> > after soft freeze.
> 
> Or, since my pre-freeze QAPI pull request needs a v2, I can include it
> there, if I have an ACK or R-b by Paolo.

Yeah, both would work for me. I'll just leave the decision to you
maintainers.

Anyways, my thanks to both of you on your help!

-- 
Peter Xu

Re: [Qemu-devel] [PULL 00/69] Misc patches for QEMU soft freeze
Posted by Paolo Bonzini 7 years, 9 months ago
On 14/03/2018 12:30, Eric Blake wrote:
> On 03/14/2018 05:12 AM, Paolo Bonzini wrote:
> 
>>>> Checking PATCH 16/69: chardev: tcp: postpone async connection setup...
>>>> Checking PATCH 17/69: chardev: tcp: let TLS run on chardev context...
>>>
>>> It seems that Dan's last patch is still missing in the pull
>>> request:
>>>
>>> http://patchwork.ozlabs.org/patch/883155/
>>
>> Yes, this is a pull request I prepared last Monday and forgot to send.
>> I'll send that out separately, it's a bugfix so it can be submitted
>> after soft freeze.
> 
> Or, since my pre-freeze QAPI pull request needs a v2, I can include it
> there, if I have an ACK or R-b by Paolo.

Sure, go ahead and include it!

Paolo

Re: [Qemu-devel] [PULL 00/69] Misc patches for QEMU soft freeze
Posted by Peter Maydell 7 years, 9 months ago
On 13 March 2018 at 22:46, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Not sure why this didn't make it to the list yesterday---most likely I
> didn't remove --dry-run...  Now I understand why everybody was waiting
> for my pull request.
>
> The following changes since commit 819fd4699c7b36d574292bcbd8bc25e9d716c84b:
>
>   Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20180309a' into staging (2018-03-12 13:21:53 +0000)
>
> are available in the Git repository at:
>
>   git://github.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to 0790f86861079b1932679d0f011e431aaf4ee9e2:
>
>   tcg: fix cpu_io_recompile (2018-03-12 17:10:38 +0100)
>
> ----------------------------------------------------------------
> * Record-replay lockstep execution, log dumper and fixes (Alex, Pavel)
> * SCSI fix to pass maximum transfer size (Daniel Barboza)
> * chardev fixes and improved iothread support (Daniel Berrangé, Peter)
> * checkpatch tweak (Eric)
> * make help tweak (Marc-André)
> * make more PCI NICs available with -net or -nic (myself)
> * change default q35 NIC to e1000e (myself)
> * SCSI support for NDOB bit (myself)
> * membarrier system call support (myself)
> * SuperIO refactoring (Philippe)
> * miscellaneous cleanups and fixes (Thomas)
>

Applied, thanks.

-- PMM