[Qemu-devel] [PULL 00/18] Linux user for 2.12 patches

Laurent Vivier posted 18 patches 28 weeks ago
Failed in applying to current master (apply log)
Test checkpatch failed
Test docker-build@min-glib passed
Test docker-mingw@fedora passed
Test docker-quick@centos6 passed
Test s390x passed
include/exec/cpu-all.h                |   6 +-
include/exec/cpu_ldst.h               |  16 +-
linux-user/elfload.c                  | 168 ++++++---------
linux-user/main.c                     |  99 +--------
linux-user/mmap.c                     |  43 ++--
linux-user/qemu.h                     |   6 +-
linux-user/signal.c                   |  32 +--
linux-user/syscall.c                  |  18 +-
linux-user/syscall_defs.h             |  47 ++---
linux-user/unicore32/syscall_nr.h     | 371 ----------------------------------
linux-user/unicore32/target_cpu.h     |  27 ---
linux-user/unicore32/target_elf.h     |  14 --
linux-user/unicore32/target_signal.h  |  30 ---
linux-user/unicore32/target_structs.h |  58 ------
linux-user/unicore32/target_syscall.h |  62 ------
linux-user/unicore32/termbits.h       |   2 -
scripts/qemu-binfmt-conf.sh           |  37 ++--
17 files changed, 161 insertions(+), 875 deletions(-)
delete mode 100644 linux-user/unicore32/syscall_nr.h
delete mode 100644 linux-user/unicore32/target_cpu.h
delete mode 100644 linux-user/unicore32/target_elf.h
delete mode 100644 linux-user/unicore32/target_signal.h
delete mode 100644 linux-user/unicore32/target_structs.h
delete mode 100644 linux-user/unicore32/target_syscall.h
delete mode 100644 linux-user/unicore32/termbits.h

[Qemu-devel] [PULL 00/18] Linux user for 2.12 patches

Posted by Laurent Vivier 28 weeks ago
The following changes since commit b39b61e410022f96ceb53d4381d25cba5126ac44:

  memory: fix flatview_access_valid RCU read lock/unlock imbalance (2018-03-09 15:55:20 +0000)

are available in the Git repository at:

  git://github.com/vivier/qemu.git tags/linux-user-for-2.12-pull-request

for you to fetch changes up to 8c17d862b3cefed23a62c4e09d4b3f1f04a38631:

  linux-user: init_guest_space: Add a comment about search strategy (2018-03-13 15:04:01 +0100)

----------------------------------------------------------------

----------------------------------------------------------------

Laurent Vivier (1):
  linux-user: allows to use "--systemd ALL" with qemu-binfmt-conf.sh

Luke Shumaker (9):
  linux-user: Use #if to only call validate_guest_space for 32-bit ARM
    target
  linux-user: Rename validate_guest_space => init_guest_commpage
  linux-user: init_guest_space: Clean up if we can't initialize the
    commpage
  linux-user: init_guest_space: Correctly handle guest_start in commpage
    initialization
  linux-user: init_guest_space: Clarify page alignment logic
  linux-user: init_guest_commpage: Add a comment about size check
  linux-user: init_guest_space: Clean up control flow a bit
  linux-user: init_guest_space: Don't try to align if we'll reject it
  linux-user: init_guest_space: Add a comment about search strategy

Max Filippov (5):
  linux-user: fix mmap/munmap/mprotect/mremap/shmat
  linux-user: fix assertion in shmdt
  linux-user: fix target_mprotect/target_munmap error return values
  linux-user: drop unused target_msync function
  qemu-binfmt-conf.sh: add qemu-xtensa

Peter Maydell (2):
  linux-user: Drop unicore32 code
  linux-user: Remove the unused "not implemented" signal handling stubs

Shea Levy (1):
  linux-user: Support f_flags in statfs when available.

 include/exec/cpu-all.h                |   6 +-
 include/exec/cpu_ldst.h               |  16 +-
 linux-user/elfload.c                  | 168 ++++++---------
 linux-user/main.c                     |  99 +--------
 linux-user/mmap.c                     |  43 ++--
 linux-user/qemu.h                     |   6 +-
 linux-user/signal.c                   |  32 +--
 linux-user/syscall.c                  |  18 +-
 linux-user/syscall_defs.h             |  47 ++---
 linux-user/unicore32/syscall_nr.h     | 371 ----------------------------------
 linux-user/unicore32/target_cpu.h     |  27 ---
 linux-user/unicore32/target_elf.h     |  14 --
 linux-user/unicore32/target_signal.h  |  30 ---
 linux-user/unicore32/target_structs.h |  58 ------
 linux-user/unicore32/target_syscall.h |  62 ------
 linux-user/unicore32/termbits.h       |   2 -
 scripts/qemu-binfmt-conf.sh           |  37 ++--
 17 files changed, 161 insertions(+), 875 deletions(-)
 delete mode 100644 linux-user/unicore32/syscall_nr.h
 delete mode 100644 linux-user/unicore32/target_cpu.h
 delete mode 100644 linux-user/unicore32/target_elf.h
 delete mode 100644 linux-user/unicore32/target_signal.h
 delete mode 100644 linux-user/unicore32/target_structs.h
 delete mode 100644 linux-user/unicore32/target_syscall.h
 delete mode 100644 linux-user/unicore32/termbits.h

-- 
2.14.3


Re: [Qemu-devel] [PULL 00/18] Linux user for 2.12 patches

Posted by no-reply@patchew.org 28 weeks ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180313173355.4468-1-laurent@vivier.eu
Subject: [Qemu-devel] [PULL 00/18] Linux user for 2.12 patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20180313173355.4468-1-laurent@vivier.eu -> patchew/20180313173355.4468-1-laurent@vivier.eu
 t [tag update]            patchew/cover.1520952419.git.berto@igalia.com -> patchew/cover.1520952419.git.berto@igalia.com
Switched to a new branch 'test'
8632a757c2 linux-user: init_guest_space: Add a comment about search strategy
ba6b6b2c88 linux-user: init_guest_space: Don't try to align if we'll reject it
28c11cb5f4 linux-user: init_guest_space: Clean up control flow a bit
07bb6931a7 linux-user: init_guest_commpage: Add a comment about size check
861df567d3 linux-user: init_guest_space: Clarify page alignment logic
122cb68f59 linux-user: init_guest_space: Correctly handle guest_start in commpage initialization
5300fd1f33 linux-user: init_guest_space: Clean up if we can't initialize the commpage
e2363e1081 linux-user: Rename validate_guest_space => init_guest_commpage
8d0f3a270b linux-user: Use #if to only call validate_guest_space for 32-bit ARM target
f56dd5f653 qemu-binfmt-conf.sh: add qemu-xtensa
f15bd1b0d6 linux-user: drop unused target_msync function
aabcc316af linux-user: fix target_mprotect/target_munmap error return values
cf497a7694 linux-user: fix assertion in shmdt
b2cf1df32c linux-user: fix mmap/munmap/mprotect/mremap/shmat
5e5ec53930 linux-user: Support f_flags in statfs when available.
a80208de3f linux-user: allows to use "--systemd ALL" with qemu-binfmt-conf.sh
f0f44061ce linux-user: Remove the unused "not implemented" signal handling stubs
9b371941f0 linux-user: Drop unicore32 code

=== OUTPUT BEGIN ===
Checking PATCH 1/18: linux-user: Drop unicore32 code...
Checking PATCH 2/18: linux-user: Remove the unused "not implemented" signal handling stubs...
Checking PATCH 3/18: linux-user: allows to use "--systemd ALL" with qemu-binfmt-conf.sh...
Checking PATCH 4/18: linux-user: Support f_flags in statfs when available....
ERROR: code indent should never use tabs
#57: FILE: linux-user/syscall_defs.h:2216:
+^Iint32_t^I^I^If_flags;$

ERROR: code indent should never use tabs
#58: FILE: linux-user/syscall_defs.h:2217:
+^Iint32_t^I^I^If_spare[5];$

ERROR: code indent should never use tabs
#67: FILE: linux-user/syscall_defs.h:2233:
+^Iabi_long^I^If_flags;$

ERROR: code indent should never use tabs
#68: FILE: linux-user/syscall_defs.h:2234:
+^Iabi_long^I^If_spare[5];$

ERROR: code indent should never use tabs
#77: FILE: linux-user/syscall_defs.h:2250:
+^Iuint32_t^If_flags;$

ERROR: code indent should never use tabs
#78: FILE: linux-user/syscall_defs.h:2251:
+^Iuint32_t^If_spare[5];$

ERROR: code indent should never use tabs
#87: FILE: linux-user/syscall_defs.h:2267:
+^Iabi_long f_flags;$

ERROR: code indent should never use tabs
#88: FILE: linux-user/syscall_defs.h:2268:
+^Iabi_long f_spare[4];$

ERROR: code indent should never use tabs
#97: FILE: linux-user/syscall_defs.h:2282:
+^Iabi_long f_flags;$

ERROR: code indent should never use tabs
#98: FILE: linux-user/syscall_defs.h:2283:
+^Iabi_long f_spare[4];$

ERROR: code indent should never use tabs
#128: FILE: linux-user/syscall_defs.h:2328:
+^Iuint32_t f_flags;$

ERROR: code indent should never use tabs
#129: FILE: linux-user/syscall_defs.h:2329:
+^Iuint32_t f_spare[4];$

ERROR: code indent should never use tabs
#138: FILE: linux-user/syscall_defs.h:2343:
+^Iuint32_t f_flags;$

ERROR: code indent should never use tabs
#139: FILE: linux-user/syscall_defs.h:2344:
+^Iuint32_t f_spare[4];$

total: 14 errors, 0 warnings, 112 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/18: linux-user: fix mmap/munmap/mprotect/mremap/shmat...
Checking PATCH 6/18: linux-user: fix assertion in shmdt...
Checking PATCH 7/18: linux-user: fix target_mprotect/target_munmap error return values...
Checking PATCH 8/18: linux-user: drop unused target_msync function...
Checking PATCH 9/18: qemu-binfmt-conf.sh: add qemu-xtensa...
WARNING: line over 80 characters
#38: FILE: scripts/qemu-binfmt-conf.sh:111:
+xtensa_magic='\x7fELF\x01\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x5e\x00'

ERROR: line over 90 characters
#39: FILE: scripts/qemu-binfmt-conf.sh:112:
+xtensa_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'

WARNING: line over 80 characters
#42: FILE: scripts/qemu-binfmt-conf.sh:115:
+xtensaeb_magic='\x7fELF\x01\x02\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x5e'

ERROR: line over 90 characters
#43: FILE: scripts/qemu-binfmt-conf.sh:116:
+xtensaeb_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff'

total: 2 errors, 2 warnings, 26 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 10/18: linux-user: Use #if to only call validate_guest_space for 32-bit ARM target...
Checking PATCH 11/18: linux-user: Rename validate_guest_space => init_guest_commpage...
Checking PATCH 12/18: linux-user: init_guest_space: Clean up if we can't initialize the commpage...
Checking PATCH 13/18: linux-user: init_guest_space: Correctly handle guest_start in commpage initialization...
Checking PATCH 14/18: linux-user: init_guest_space: Clarify page alignment logic...
Checking PATCH 15/18: linux-user: init_guest_commpage: Add a comment about size check...
Checking PATCH 16/18: linux-user: init_guest_space: Clean up control flow a bit...
Checking PATCH 17/18: linux-user: init_guest_space: Don't try to align if we'll reject it...
Checking PATCH 18/18: linux-user: init_guest_space: Add a comment about search strategy...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org

Re: [Qemu-devel] [PULL 00/18] Linux user for 2.12 patches

Posted by Peter Maydell 27 weeks ago
On 13 March 2018 at 17:33, Laurent Vivier <laurent@vivier.eu> wrote:
> The following changes since commit b39b61e410022f96ceb53d4381d25cba5126ac44:
>
>   memory: fix flatview_access_valid RCU read lock/unlock imbalance (2018-03-09 15:55:20 +0000)
>
> are available in the Git repository at:
>
>   git://github.com/vivier/qemu.git tags/linux-user-for-2.12-pull-request
>
> for you to fetch changes up to 8c17d862b3cefed23a62c4e09d4b3f1f04a38631:
>
>   linux-user: init_guest_space: Add a comment about search strategy (2018-03-13 15:04:01 +0100)
>
> ----------------------------------------------------------------
>
> ----------------------------------------------------------------
>
> Laurent Vivier (1):
>   linux-user: allows to use "--systemd ALL" with qemu-binfmt-conf.sh
>
> Luke Shumaker (9):
>   linux-user: Use #if to only call validate_guest_space for 32-bit ARM
>     target
>   linux-user: Rename validate_guest_space => init_guest_commpage
>   linux-user: init_guest_space: Clean up if we can't initialize the
>     commpage
>   linux-user: init_guest_space: Correctly handle guest_start in commpage
>     initialization
>   linux-user: init_guest_space: Clarify page alignment logic
>   linux-user: init_guest_commpage: Add a comment about size check
>   linux-user: init_guest_space: Clean up control flow a bit
>   linux-user: init_guest_space: Don't try to align if we'll reject it
>   linux-user: init_guest_space: Add a comment about search strategy
>
> Max Filippov (5):
>   linux-user: fix mmap/munmap/mprotect/mremap/shmat
>   linux-user: fix assertion in shmdt
>   linux-user: fix target_mprotect/target_munmap error return values
>   linux-user: drop unused target_msync function
>   qemu-binfmt-conf.sh: add qemu-xtensa
>
> Peter Maydell (2):
>   linux-user: Drop unicore32 code
>   linux-user: Remove the unused "not implemented" signal handling stubs
>
> Shea Levy (1):
>   linux-user: Support f_flags in statfs when available.

Applied, thanks.

-- PMM