This series implements the .bdrv_co_create callback for luks, adds an
image creation test for it and contains some bonus fixes for bugs that
the test triggered.

v2:
- Use QCryptoBlockCreateOptionsLUKS as the base type for
  BlockdevCreateOptionsLUKS [Dan]
- Use INT64_MAX instead of UINT64_MAX as the maximum image size [Eric]
- Use iter_time=10 in tests where the creation succeeds [Dan]


Kevin Wolf (6):
  luks: Separate image file creation from formatting
  luks: Create block_crypto_co_create_generic()
  luks: Support .bdrv_co_create
  luks: Turn invalid assertion into check
  luks: Catch integer overflow for huge sizes
  qemu-iotests: Test luks QMP image creation

 qapi/block-core.json         |  17 +++-
 block/crypto.c               | 150 ++++++++++++++++++++++---------
 tests/qemu-iotests/209       | 210 +++++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/209.out   | 136 ++++++++++++++++++++++++++++
 tests/qemu-iotests/common.rc |   2 +-
 tests/qemu-iotests/group     |   1 +
 6 files changed, 472 insertions(+), 44 deletions(-)
 create mode 100755 tests/qemu-iotests/209
 create mode 100644 tests/qemu-iotests/209.out

-- 
2.13.6

Am 12.03.2018 um 16:02 hat Kevin Wolf geschrieben:
> This series implements the .bdrv_co_create callback for luks, adds an
> image creation test for it and contains some bonus fixes for bugs that
> the test triggered.
> 
> v2:
> - Use QCryptoBlockCreateOptionsLUKS as the base type for
>   BlockdevCreateOptionsLUKS [Dan]
> - Use INT64_MAX instead of UINT64_MAX as the maximum image size [Eric]
> - Use iter_time=10 in tests where the creation succeeds [Dan]

Thanks for the review, applied to the block branch now.

Kevin

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180312150218.1314-1-kwolf@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/6] luks: Implement .bdrv_co_create

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
21707c7252 qemu-iotests: Test luks QMP image creation
c3cce1168f luks: Catch integer overflow for huge sizes
bee065e0ba luks: Turn invalid assertion into check
b9d31479f8 luks: Support .bdrv_co_create
2dc9f95b59 luks: Create block_crypto_co_create_generic()
26821e37e9 luks: Separate image file creation from formatting

=== OUTPUT BEGIN ===
Checking PATCH 1/6: luks: Separate image file creation from formatting...
Checking PATCH 2/6: luks: Create block_crypto_co_create_generic()...
Checking PATCH 3/6: luks: Support .bdrv_co_create...
Checking PATCH 4/6: luks: Turn invalid assertion into check...
ERROR: suspect code indent for conditional statements (4, 7)
#31: FILE: block/crypto.c:522:
+    if (offset > len) {
+       return -EIO;

total: 1 errors, 0 warnings, 11 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/6: luks: Catch integer overflow for huge sizes...
Checking PATCH 6/6: qemu-iotests: Test luks QMP image creation...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org