[Qemu-devel] [PATCH v6 0/2] block latency histogram

Vladimir Sementsov-Ogievskiy posted 2 patches 6 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180309165212.97144-1-vsementsov@virtuozzo.com
Test checkpatch passed
Test docker-build@min-glib passed
Test docker-mingw@fedora passed
Test docker-quick@centos6 passed
Test ppcbe passed
Test ppcle passed
Test s390x passed
qapi/block-core.json       | 111 ++++++++++++++++++++++++++++++++++++++++++++-
include/block/accounting.h |  35 ++++++++++++++
block/accounting.c         |  91 +++++++++++++++++++++++++++++++++++++
block/qapi.c               |  41 +++++++++++++++++
blockdev.c                 |  43 ++++++++++++++++++
5 files changed, 320 insertions(+), 1 deletion(-)
[Qemu-devel] [PATCH v6 0/2] block latency histogram
Posted by Vladimir Sementsov-Ogievskiy 6 years, 1 month ago
v6:

Use correct header qapi/qapi-builtin-types.h, to fix build again.
Sorry for spam =(


v5:

Revert to v3 and just add qapi-types.h header.


v4:

Move block_latency_histogram_set from block/accounting.c to
blockdev.c, as it uses qapi type uint64List and this fact breaks
build.


v3:

- semantics, naming and wording changed a lot
- x prefixes added to new qapi names
- bug fixed about calculation of new_size (new_nbins now)
- drop g_renew
- in _clear() set nbinst to zero too

v2:

01: add block_latency_histogram_clear()
02: fix spelling (sorry =()
    some rewordings
    remove histogram if latency parameter unspecified

Vladimir Sementsov-Ogievskiy (2):
  block/accounting: introduce latency histogram
  qapi: add block latency histogram interface

 qapi/block-core.json       | 111 ++++++++++++++++++++++++++++++++++++++++++++-
 include/block/accounting.h |  35 ++++++++++++++
 block/accounting.c         |  91 +++++++++++++++++++++++++++++++++++++
 block/qapi.c               |  41 +++++++++++++++++
 blockdev.c                 |  43 ++++++++++++++++++
 5 files changed, 320 insertions(+), 1 deletion(-)

-- 
2.11.1


Re: [Qemu-devel] [PATCH v6 0/2] block latency histogram
Posted by Eric Blake 6 years, 1 month ago
On 03/09/2018 10:52 AM, Vladimir Sementsov-Ogievskiy wrote:
> v6:
> 
> Use correct header qapi/qapi-builtin-types.h, to fix build again.
> Sorry for spam =(
> 
> 

> Vladimir Sementsov-Ogievskiy (2):
>    block/accounting: introduce latency histogram
>    qapi: add block latency histogram interface

This touches both block and QAPI, but I've gone ahead and queued it on 
the QAPI tree.  Not much time left if you want to drop the x- prefix and 
make this interface officially supported for 2.12.  Queued:

git://repo.or.cz/qemu/ericb.git qapi
http://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/qapi

I'll send a PULL request for my QAPI tree as my first act on Monday.

> 
>   qapi/block-core.json       | 111 ++++++++++++++++++++++++++++++++++++++++++++-
>   include/block/accounting.h |  35 ++++++++++++++
>   block/accounting.c         |  91 +++++++++++++++++++++++++++++++++++++
>   block/qapi.c               |  41 +++++++++++++++++
>   blockdev.c                 |  43 ++++++++++++++++++
>   5 files changed, 320 insertions(+), 1 deletion(-)
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH v6 0/2] block latency histogram
Posted by Stefan Hajnoczi 6 years, 1 month ago
On Fri, Mar 09, 2018 at 07:52:10PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> v6:
> 
> Use correct header qapi/qapi-builtin-types.h, to fix build again.
> Sorry for spam =(
> 
> 
> v5:
> 
> Revert to v3 and just add qapi-types.h header.
> 
> 
> v4:
> 
> Move block_latency_histogram_set from block/accounting.c to
> blockdev.c, as it uses qapi type uint64List and this fact breaks
> build.
> 
> 
> v3:
> 
> - semantics, naming and wording changed a lot
> - x prefixes added to new qapi names
> - bug fixed about calculation of new_size (new_nbins now)
> - drop g_renew
> - in _clear() set nbinst to zero too
> 
> v2:
> 
> 01: add block_latency_histogram_clear()
> 02: fix spelling (sorry =()
>     some rewordings
>     remove histogram if latency parameter unspecified
> 
> Vladimir Sementsov-Ogievskiy (2):
>   block/accounting: introduce latency histogram
>   qapi: add block latency histogram interface
> 
>  qapi/block-core.json       | 111 ++++++++++++++++++++++++++++++++++++++++++++-
>  include/block/accounting.h |  35 ++++++++++++++
>  block/accounting.c         |  91 +++++++++++++++++++++++++++++++++++++
>  block/qapi.c               |  41 +++++++++++++++++
>  blockdev.c                 |  43 ++++++++++++++++++
>  5 files changed, 320 insertions(+), 1 deletion(-)
> 
> -- 
> 2.11.1
> 
> 

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>