SDCard: improve tracing, support UHS-I

[Qemu-devel] [PATCH 0/8] SDCard: improve tracing, support UHS-I

Posted by Philippe Mathieu-Daudé 6 years, 1 month ago

This series contains the leftover patches from these 2 series:
- SDCard: housekeeping, add tracing (part 4)
- SDCard: bugfixes, support UHS-I (part 5)
with Peter Maydell comments addressed.

I misunderstood the 2.12 train deadline, but better to have the series
standing in the list rather than forgot it.

Philippe Mathieu-Daudé (8):
  sdcard: Do not trace CMD55, except when we already expect an ACMD
  sdcard: Display command name when tracing CMD/ACMD
  sdcard: Display which protocol is used when tracing (SD or SPI)
  sdcard: Add the Tuning Command (CMD19)
  sdcard: Implement the UHS-I SWITCH_FUNCTION entries (Spec v3)
  sdcard: Add a 'uhs' property, update the OCR register ACCEPT_SWITCH_1V8 bit
  sdhci: Fix a typo in comment
  MAINTAINERS: Add entries for SD (SDHCI, SDBus, SDCard)

 hw/sd/sdmmc-internal.h |  20 +++++
 hw/sd/sd.c             | 208 ++++++++++++++++++++++++++++++++++++++++++-------
 hw/sd/sdhci.c          |   4 +-
 hw/sd/sdmmc-internal.c |  72 +++++++++++++++++
 hw/sd/Makefile.objs    |   2 +-
 hw/sd/trace-events     |   9 ++-
 MAINTAINERS            |   8 ++
 7 files changed, 288 insertions(+), 35 deletions(-)
 create mode 100644 hw/sd/sdmmc-internal.c

-- 
2.16.2

Re: [Qemu-devel] [PATCH 0/8] SDCard: improve tracing, support UHS-I

Posted by Peter Maydell 6 years, 1 month ago

On 9 March 2018 at 15:36, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> This series contains the leftover patches from these 2 series:
> - SDCard: housekeeping, add tracing (part 4)
> - SDCard: bugfixes, support UHS-I (part 5)
> with Peter Maydell comments addressed.
>
> I misunderstood the 2.12 train deadline, but better to have the series
> standing in the list rather than forgot it.
>
> Philippe Mathieu-Daudé (8):
>   sdcard: Do not trace CMD55, except when we already expect an ACMD
>   sdcard: Display command name when tracing CMD/ACMD
>   sdcard: Display which protocol is used when tracing (SD or SPI)
>   sdcard: Add the Tuning Command (CMD19)
>   sdcard: Implement the UHS-I SWITCH_FUNCTION entries (Spec v3)
>   sdcard: Add a 'uhs' property, update the OCR register ACCEPT_SWITCH_1V8 bit
>   sdhci: Fix a typo in comment
>   MAINTAINERS: Add entries for SD (SDHCI, SDBus, SDCard)

Thanks. I've applied patches 1-4, 7 and 8 to target-arm.next, so
they will make 2.12. Patches 5 and 6 I had review comments on.

(We may be able to call 5/6 bugfix patches and get them into 2.12;
depends on timing.)

thanks
-- PMM

Re: [Qemu-devel] [PATCH 0/8] SDCard: improve tracing, support UHS-I

Posted by Philippe Mathieu-Daudé 6 years, 1 month ago

On 03/09/2018 06:08 PM, Peter Maydell wrote:
> On 9 March 2018 at 15:36, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>> This series contains the leftover patches from these 2 series:
>> - SDCard: housekeeping, add tracing (part 4)
>> - SDCard: bugfixes, support UHS-I (part 5)
>> with Peter Maydell comments addressed.
>>
>> I misunderstood the 2.12 train deadline, but better to have the series
>> standing in the list rather than forgot it.
>>
>> Philippe Mathieu-Daudé (8):
>>   sdcard: Do not trace CMD55, except when we already expect an ACMD
>>   sdcard: Display command name when tracing CMD/ACMD
>>   sdcard: Display which protocol is used when tracing (SD or SPI)
>>   sdcard: Add the Tuning Command (CMD19)
>>   sdcard: Implement the UHS-I SWITCH_FUNCTION entries (Spec v3)
>>   sdcard: Add a 'uhs' property, update the OCR register ACCEPT_SWITCH_1V8 bit
>>   sdhci: Fix a typo in comment
>>   MAINTAINERS: Add entries for SD (SDHCI, SDBus, SDCard)
> 
> Thanks. I've applied patches 1-4, 7 and 8 to target-arm.next, so
> they will make 2.12. Patches 5 and 6 I had review comments on.

Thanks \o/

> 
> (We may be able to call 5/6 bugfix patches and get them into 2.12;
> depends on timing.)

I'll do my best, the "misc" pull didn't hit the list yet :)

Phil.