[Qemu-devel] [PATCH v3 0/6] qio: general non-default GMainContext support

Peter Xu posted 6 patches 7 years, 7 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180305064324.9238-1-peterx@redhat.com
Test checkpatch passed
Test docker-build@min-glib passed
Test docker-mingw@fedora passed
Test docker-quick@centos6 passed
Test ppcbe passed
Test ppcle passed
Test s390x passed
chardev/char-socket.c          |  5 ++--
include/io/channel-socket.h    | 15 ++++++++---
include/io/channel-tls.h       |  5 +++-
include/io/channel.h           | 44 ++++++++++++++++++++++++++++++++
include/io/net-listener.h      | 22 ++++++++++++++--
include/io/task.h              |  7 +++--
io/channel-socket.c            | 18 ++++++++-----
io/channel-tls.c               | 45 ++++++++++++++++++++++++--------
io/channel.c                   | 40 ++++++++++++++++++++++++-----
io/dns-resolver.c              |  3 ++-
io/net-listener.c              | 58 ++++++++++++++++++++++++++----------------
io/task.c                      | 22 +++++++++++++---
migration/socket.c             |  3 ++-
migration/tls.c                |  2 ++
nbd/client.c                   |  1 +
nbd/server.c                   |  1 +
tests/test-io-channel-socket.c |  4 +--
tests/test-io-channel-tls.c    |  2 ++
tests/test-io-task.c           |  2 ++
ui/vnc-auth-vencrypt.c         |  1 +
ui/vnc-ws.c                    |  1 +
21 files changed, 239 insertions(+), 62 deletions(-)
[Qemu-devel] [PATCH v3 0/6] qio: general non-default GMainContext support
Posted by Peter Xu 7 years, 7 months ago
V1: http://lists.nongnu.org/archive/html/qemu-devel/2018-02/msg06972.html
V2: http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg00016.html

From this version, I'll split the old series into two: one QIO series
and one CHARDEV series.  This is the QIO part.

Hopefully I have addressed every comments in v2.  Please shoot if I
missed any of them.  Thanks,

v3:
- add r-bs
- move the migration patch out of the series [Dan]
- in comments, mention "%NULL" case for contexts [Paolo]
- do similar thing to listen_async and dgram_async to allow context
  parameter [Dan]
- cache TCPChardevTelnetInit properly in telnet patch, and fixes
  around that new change in the patch [Paolo]
- drop patch 5 [Dan]
- drop the helper tcp_chr_net_listener_setup() [Dan]

v2:
- collect r-bs
- qio_channel_add_watch_full() should still return the same thing as
  the old one, and introduced qio_channel_add_watch_full() to return a
  GSource pointer. [Dan]
- Fix commit message on RDMA. It's using QIO, but still, I am not
  touching it.  [Dan]
- use qio_net_listener_set_client_func_full() directly, and avoid
  introducing new API. [Dan]

Please review.  Thanks.

Peter Xu (6):
  qio: rename qio_task_thread_result
  qio: introduce qio_channel_add_watch_{full|source}
  qio: store gsources for net listeners
  qio: non-default context for threaded qtask
  qio: non-default context for async conn
  qio: non-default context for TLS handshake

 chardev/char-socket.c          |  5 ++--
 include/io/channel-socket.h    | 15 ++++++++---
 include/io/channel-tls.h       |  5 +++-
 include/io/channel.h           | 44 ++++++++++++++++++++++++++++++++
 include/io/net-listener.h      | 22 ++++++++++++++--
 include/io/task.h              |  7 +++--
 io/channel-socket.c            | 18 ++++++++-----
 io/channel-tls.c               | 45 ++++++++++++++++++++++++--------
 io/channel.c                   | 40 ++++++++++++++++++++++++-----
 io/dns-resolver.c              |  3 ++-
 io/net-listener.c              | 58 ++++++++++++++++++++++++++----------------
 io/task.c                      | 22 +++++++++++++---
 migration/socket.c             |  3 ++-
 migration/tls.c                |  2 ++
 nbd/client.c                   |  1 +
 nbd/server.c                   |  1 +
 tests/test-io-channel-socket.c |  4 +--
 tests/test-io-channel-tls.c    |  2 ++
 tests/test-io-task.c           |  2 ++
 ui/vnc-auth-vencrypt.c         |  1 +
 ui/vnc-ws.c                    |  1 +
 21 files changed, 239 insertions(+), 62 deletions(-)

-- 
2.14.3


Re: [Qemu-devel] [PATCH v3 0/6] qio: general non-default GMainContext support
Posted by Daniel P. Berrangé 7 years, 7 months ago
On Mon, Mar 05, 2018 at 02:43:18PM +0800, Peter Xu wrote:
> V1: http://lists.nongnu.org/archive/html/qemu-devel/2018-02/msg06972.html
> V2: http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg00016.html
> 
> From this version, I'll split the old series into two: one QIO series
> and one CHARDEV series.  This is the QIO part.
> 
> Hopefully I have addressed every comments in v2.  Please shoot if I
> missed any of them.  Thanks,

Thanks, I'm queuing this series and will send a pull req for it
assuming it passes the usual tests.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [Qemu-devel] [PATCH v3 0/6] qio: general non-default GMainContext support
Posted by Peter Xu 7 years, 7 months ago
On Tue, Mar 06, 2018 at 10:29:47AM +0000, Daniel P. Berrangé wrote:
> On Mon, Mar 05, 2018 at 02:43:18PM +0800, Peter Xu wrote:
> > V1: http://lists.nongnu.org/archive/html/qemu-devel/2018-02/msg06972.html
> > V2: http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg00016.html
> > 
> > From this version, I'll split the old series into two: one QIO series
> > and one CHARDEV series.  This is the QIO part.
> > 
> > Hopefully I have addressed every comments in v2.  Please shoot if I
> > missed any of them.  Thanks,
> 
> Thanks, I'm queuing this series and will send a pull req for it
> assuming it passes the usual tests.

That'll be great.  Thanks, Dan.

-- 
Peter Xu