v2:
 * Tackle the .ioeventfd_stop() vs vq handler race by removing the ioeventfd
   from a BH in the IOThread [Fam]

There are several race conditions in virtio-blk/virtio-scsi dataplane code.
This patch series addresses them, see the commit description for details on the
individual cases.

Stefan Hajnoczi (4):
  block: add aio_wait_bh_oneshot()
  virtio-blk: fix race between .ioeventfd_stop() and vq handler
  virtio-scsi: fix race between .ioeventfd_stop() and vq handler
  vl: introduce vm_shutdown()

 include/block/aio-wait.h        | 13 +++++++++++++
 include/sysemu/iothread.h       |  1 -
 include/sysemu/sysemu.h         |  1 +
 cpus.c                          | 16 +++++++++++++---
 hw/block/dataplane/virtio-blk.c | 24 +++++++++++++++++-------
 hw/scsi/virtio-scsi-dataplane.c |  9 +++++----
 iothread.c                      | 31 -------------------------------
 util/aio-wait.c                 | 31 +++++++++++++++++++++++++++++++
 vl.c                            | 13 +++----------
 9 files changed, 83 insertions(+), 56 deletions(-)

-- 
2.14.3

On Wed, 02/28 18:19, Stefan Hajnoczi wrote:
> v2:
>  * Tackle the .ioeventfd_stop() vs vq handler race by removing the ioeventfd
>    from a BH in the IOThread [Fam]
> 
> There are several race conditions in virtio-blk/virtio-scsi dataplane code.
> This patch series addresses them, see the commit description for details on the
> individual cases.

This doesn't apply to master. Which branch is it based off?

Fam

On Thu, Mar 01, 2018 at 09:15:17AM +0800, Fam Zheng wrote:
> On Wed, 02/28 18:19, Stefan Hajnoczi wrote:
> > v2:
> >  * Tackle the .ioeventfd_stop() vs vq handler race by removing the ioeventfd
> >    from a BH in the IOThread [Fam]
> > 
> > There are several race conditions in virtio-blk/virtio-scsi dataplane code.
> > This patch series addresses them, see the commit description for details on the
> > individual cases.
> 
> This doesn't apply to master. Which branch is it based off?

Sorry, I was going to look up the Based-on: syntax and then forgot.  I'm
not sure where it's documented, here is a guess at how it works:

Based-on: "[PATCH v3 0/5] block: fix blk_aio_*() segfault when blk->root == NULL" <20180216165015.30715-1-stefanha@redhat.com>

On Thu, 03/01 14:54, Stefan Hajnoczi wrote:
> On Thu, Mar 01, 2018 at 09:15:17AM +0800, Fam Zheng wrote:
> > On Wed, 02/28 18:19, Stefan Hajnoczi wrote:
> > > v2:
> > >  * Tackle the .ioeventfd_stop() vs vq handler race by removing the ioeventfd
> > >    from a BH in the IOThread [Fam]
> > > 
> > > There are several race conditions in virtio-blk/virtio-scsi dataplane code.
> > > This patch series addresses them, see the commit description for details on the
> > > individual cases.
> > 
> > This doesn't apply to master. Which branch is it based off?
> 
> Sorry, I was going to look up the Based-on: syntax and then forgot.  I'm
> not sure where it's documented, here is a guess at how it works:
> 
> Based-on: "[PATCH v3 0/5] block: fix blk_aio_*() segfault when blk->root == NULL" <20180216165015.30715-1-stefanha@redhat.com>

Sorry for the poor documentation of Patchew, we should improve the situation
soon:

Based-on: <20180216165015.30715-1-stefanha@redhat.com>
([PATCH v3 0/5] block: fix blk_aio_*() segfault when blk->root == NULL)

(Only the "Based-on:" line matters)

Fam

On Fri, Mar 02, 2018 at 08:58:26AM +0800, Fam Zheng wrote:
> On Thu, 03/01 14:54, Stefan Hajnoczi wrote:
> > On Thu, Mar 01, 2018 at 09:15:17AM +0800, Fam Zheng wrote:
> > > On Wed, 02/28 18:19, Stefan Hajnoczi wrote:
> > > > v2:
> > > >  * Tackle the .ioeventfd_stop() vs vq handler race by removing the ioeventfd
> > > >    from a BH in the IOThread [Fam]
> > > > 
> > > > There are several race conditions in virtio-blk/virtio-scsi dataplane code.
> > > > This patch series addresses them, see the commit description for details on the
> > > > individual cases.
> > > 
> > > This doesn't apply to master. Which branch is it based off?
> > 
> > Sorry, I was going to look up the Based-on: syntax and then forgot.  I'm
> > not sure where it's documented, here is a guess at how it works:
> > 
> > Based-on: "[PATCH v3 0/5] block: fix blk_aio_*() segfault when blk->root == NULL" <20180216165015.30715-1-stefanha@redhat.com>
> 
> Sorry for the poor documentation of Patchew, we should improve the situation
> soon:

It would be nice if the patchew.org front page linked to a guide for
patch authors that documents available features.

Stefan