[Qemu-devel] [PATCH v6 0/9] vfio: add display support

Gerd Hoffmann posted 9 patches 7 years, 7 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180228123110.6507-1-kraxel@redhat.com
Test checkpatch failed
Test docker-build@min-glib passed
Test docker-mingw@fedora passed
Test docker-quick@centos6 passed
Test ppcbe passed
Test ppcle passed
Test s390x passed
There is a newer version of this series
hw/vfio/pci.h                                      |   5 +
include/hw/vfio/vfio-common.h                      |  22 ++
include/standard-headers/drm/drm_fourcc.h          | 411 +++++++++++++++++++++
include/standard-headers/linux/input-event-codes.h |   1 +
include/standard-headers/linux/input.h             |  11 +
include/standard-headers/linux/pci_regs.h          |  30 +-
include/standard-headers/linux/virtio_net.h        |  13 +
include/ui/console.h                               |   2 +
include/ui/qemu-pixman.h                           |   5 +
linux-headers/asm-powerpc/kvm.h                    |   2 +
linux-headers/asm-powerpc/unistd.h                 |   3 +
linux-headers/asm-s390/unistd.h                    | 401 +-------------------
linux-headers/asm-s390/unistd_32.h                 | 364 ++++++++++++++++++
linux-headers/asm-s390/unistd_64.h                 | 331 +++++++++++++++++
linux-headers/asm-x86/kvm_para.h                   |   4 +
linux-headers/linux/kvm.h                          |  90 +++++
linux-headers/linux/psci.h                         |   3 +
linux-headers/linux/vfio.h                         |  72 ++++
hw/display/vga-pci.c                               |   9 +
hw/vfio/common.c                                   |   7 +
hw/vfio/display.c                                  | 330 +++++++++++++++++
hw/vfio/pci.c                                      |  10 +
ui/console.c                                       |  78 +++-
ui/qemu-pixman.c                                   |  22 ++
hw/vfio/Makefile.objs                              |   2 +-
scripts/update-linux-headers.sh                    |   7 +
ui/trace-events                                    |   2 +
27 files changed, 1820 insertions(+), 417 deletions(-)
create mode 100644 include/standard-headers/drm/drm_fourcc.h
create mode 100644 linux-headers/asm-s390/unistd_32.h
create mode 100644 linux-headers/asm-s390/unistd_64.h
create mode 100644 hw/vfio/display.c
[Qemu-devel] [PATCH v6 0/9] vfio: add display support
Posted by Gerd Hoffmann 7 years, 7 months ago
This series adds support for a vgpu display to the qemu vfio code.

v6:
 - add support for hotplugging QemuConsoles.
 - drop vfio-pci-display device, re-add OnOffAuto display property.
 - add proper cleanup in finalize.

v5:
 - rebase to latest master
 - drop DeviceState->hotpluggable patch, use separate vfio-pci-display
   device instead so we can use DeviceClass->hotpluggable.
 - add vfio dma-buf patch.  Right now this can be tested with '-display
   egl-headless' only.  gtk and spice support is almost ready for merge
   and should follow soon.

cheers,
  Gerd

Gerd Hoffmann (9):
  linux-headers: update to 4.16-rc1
  standard-headers: add drm/drm_fourcc.h
  ui/pixman: add qemu_drm_format_to_pixman()
  console: minimal hotplug suport
  secondary-vga: properly close QemuConsole on unplug
  vfio/common: cleanup in vfio_region_finalize
  vfio/display: core & wireup
  vfio/display: adding region support
  vfio/display: adding dmabuf support

 hw/vfio/pci.h                                      |   5 +
 include/hw/vfio/vfio-common.h                      |  22 ++
 include/standard-headers/drm/drm_fourcc.h          | 411 +++++++++++++++++++++
 include/standard-headers/linux/input-event-codes.h |   1 +
 include/standard-headers/linux/input.h             |  11 +
 include/standard-headers/linux/pci_regs.h          |  30 +-
 include/standard-headers/linux/virtio_net.h        |  13 +
 include/ui/console.h                               |   2 +
 include/ui/qemu-pixman.h                           |   5 +
 linux-headers/asm-powerpc/kvm.h                    |   2 +
 linux-headers/asm-powerpc/unistd.h                 |   3 +
 linux-headers/asm-s390/unistd.h                    | 401 +-------------------
 linux-headers/asm-s390/unistd_32.h                 | 364 ++++++++++++++++++
 linux-headers/asm-s390/unistd_64.h                 | 331 +++++++++++++++++
 linux-headers/asm-x86/kvm_para.h                   |   4 +
 linux-headers/linux/kvm.h                          |  90 +++++
 linux-headers/linux/psci.h                         |   3 +
 linux-headers/linux/vfio.h                         |  72 ++++
 hw/display/vga-pci.c                               |   9 +
 hw/vfio/common.c                                   |   7 +
 hw/vfio/display.c                                  | 330 +++++++++++++++++
 hw/vfio/pci.c                                      |  10 +
 ui/console.c                                       |  78 +++-
 ui/qemu-pixman.c                                   |  22 ++
 hw/vfio/Makefile.objs                              |   2 +-
 scripts/update-linux-headers.sh                    |   7 +
 ui/trace-events                                    |   2 +
 27 files changed, 1820 insertions(+), 417 deletions(-)
 create mode 100644 include/standard-headers/drm/drm_fourcc.h
 create mode 100644 linux-headers/asm-s390/unistd_32.h
 create mode 100644 linux-headers/asm-s390/unistd_64.h
 create mode 100644 hw/vfio/display.c

-- 
2.9.3


Re: [Qemu-devel] [PATCH v6 0/9] vfio: add display support
Posted by no-reply@patchew.org 7 years, 7 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180228123110.6507-1-kraxel@redhat.com
Subject: [Qemu-devel] [PATCH v6 0/9] vfio: add display support

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20180228123110.6507-1-kraxel@redhat.com -> patchew/20180228123110.6507-1-kraxel@redhat.com
Switched to a new branch 'test'
2add6e2941 vfio/display: adding dmabuf support
ccdf41d292 vfio/display: adding region support
7e70abdfa2 vfio/display: core & wireup
9cdbeaf2bb vfio/common: cleanup in vfio_region_finalize
fb7b8d32f4 secondary-vga: properly close QemuConsole on unplug
75167c77d3 console: minimal hotplug suport
c7f1ec9989 ui/pixman: add qemu_drm_format_to_pixman()
3967270521 standard-headers: add drm/drm_fourcc.h
49efb2b198 linux-headers: update to 4.16-rc1

=== OUTPUT BEGIN ===
Checking PATCH 1/9: linux-headers: update to 4.16-rc1...
Checking PATCH 2/9: standard-headers: add drm/drm_fourcc.h...
WARNING: line over 80 characters
#453: FILE: scripts/update-linux-headers.sh:158:
+cp_portable "$tmpdir/include/drm/drm_fourcc.h" "$output/include/standard-headers/drm"

total: 0 errors, 1 warnings, 433 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/9: ui/pixman: add qemu_drm_format_to_pixman()...
Checking PATCH 4/9: console: minimal hotplug suport...
WARNING: line over 80 characters
#82: FILE: ui/console.c:1879:
+        s->ui_timer = timer_new_ms(QEMU_CLOCK_REALTIME, dpy_set_ui_info_timer, s);

total: 0 errors, 1 warnings, 132 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/9: secondary-vga: properly close QemuConsole on unplug...
Checking PATCH 6/9: vfio/common: cleanup in vfio_region_finalize...
Checking PATCH 7/9: vfio/display: core & wireup...
Checking PATCH 8/9: vfio/display: adding region support...
ERROR: braces {} are necessary for all arms of this statement
#143: FILE: hw/vfio/display.c:162:
+    if (!vdev->dpy)
[...]

total: 1 errors, 0 warnings, 153 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 9/9: vfio/display: adding dmabuf support...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org