[Qemu-devel] [PATCH] linux-user: Report AArch64 FP16 support via hwcap bits

Peter Maydell posted 1 patch 7 years, 7 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180227183958.15167-1-peter.maydell@linaro.org
Test checkpatch passed
Test docker-build@min-glib passed
Test docker-mingw@fedora passed
Test docker-quick@centos6 passed
Test ppcbe passed
Test ppcle passed
Test s390x passed
linux-user/elfload.c | 2 ++
1 file changed, 2 insertions(+)
[Qemu-devel] [PATCH] linux-user: Report AArch64 FP16 support via hwcap bits
Posted by Peter Maydell 7 years, 7 months ago
Set the appropriate Linux hwcap bits to tell the guest binary if we
have implemented half-precision floating point support.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
This is intended to go after Alex's FP16 stuff since it
uses the ARM_FEATURE_V8_FP16 bit that defines.
There is as yet no kernel definition of an AArch32 hwcap
bit to report FP16.

Based-on: <20180227143852.11175-1-alex.bennee@linaro.org>

 linux-user/elfload.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 8bb9a2c3e8..80f1b32fbe 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -551,6 +551,8 @@ static uint32_t get_elf_hwcap(void)
     GET_FEATURE(ARM_FEATURE_V8_SM3, ARM_HWCAP_A64_SM3);
     GET_FEATURE(ARM_FEATURE_V8_SM4, ARM_HWCAP_A64_SM4);
     GET_FEATURE(ARM_FEATURE_V8_SHA512, ARM_HWCAP_A64_SHA512);
+    GET_FEATURE(ARM_FEATURE_V8_FP16,
+                ARM_HWCAP_A64_FPHP | ARM_HWCAP_A64_ASIMDHP);
 #undef GET_FEATURE
 
     return hwcaps;
-- 
2.16.2


Re: [Qemu-devel] [PATCH] linux-user: Report AArch64 FP16 support via hwcap bits
Posted by Richard Henderson 7 years, 7 months ago
On 02/27/2018 10:39 AM, Peter Maydell wrote:
> Set the appropriate Linux hwcap bits to tell the guest binary if we
> have implemented half-precision floating point support.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> This is intended to go after Alex's FP16 stuff since it
> uses the ARM_FEATURE_V8_FP16 bit that defines.
> There is as yet no kernel definition of an AArch32 hwcap
> bit to report FP16.
> 
> Based-on: <20180227143852.11175-1-alex.bennee@linaro.org>
> 
>  linux-user/elfload.c | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~