The following changes since commit 0a773d55ac76c5aa89ed9187a3bc5af8c5c2a6d0:

  maintainers: Add myself as a OpenBSD maintainer (2018-02-23 12:05:07 +0000)

are available in the git repository at:

  git://git.kraxel.org/qemu tags/ui-20180227-pull-request

for you to fetch changes up to 8742dcaf7bcfa1ef8720f34dab984f153c87c9f3:

  curses: build as ui module (2018-02-26 15:10:12 +0100)

----------------------------------------------------------------
ui: add & use display registry, build some UIs as module.

----------------------------------------------------------------

Gerd Hoffmann (12):
  console: add qemu display registry, add gtk
  sdl: switch over to new display registry
  cocoa: switch over to new display registry
  curses: switch over to new display registry
  egl-headless: switch over to new display registry
  console: add and use qemu_display_find_default
  console: add ui module loading support
  configure: add X11 vars to config-host.mak
  configure: opengl doesn't depend on x11
  sdl: build as ui module
  gtk: build as ui module
  curses: build as ui module

 configure             | 29 +++++++++++---------
 Makefile.objs         |  1 +
 include/qemu/module.h |  1 +
 include/ui/console.h  | 75 ++++++++-------------------------------------------
 ui/console.c          | 59 ++++++++++++++++++++++++++++++++++++++++
 ui/curses.c           | 14 +++++++++-
 ui/egl-headless.c     | 20 +++++++++++++-
 ui/gtk.c              | 17 ++++++++++--
 ui/sdl.c              | 24 +++++++++--------
 ui/sdl2.c             | 17 ++++++++++--
 vl.c                  | 74 ++++++++------------------------------------------
 ui/Makefile.objs      | 31 +++++++++++++--------
 ui/cocoa.m            | 14 +++++++++-
 13 files changed, 208 insertions(+), 168 deletions(-)

-- 
2.9.3

On 27 February 2018 at 08:07, Gerd Hoffmann <kraxel@redhat.com> wrote:
> The following changes since commit 0a773d55ac76c5aa89ed9187a3bc5af8c5c2a6d0:
>
>   maintainers: Add myself as a OpenBSD maintainer (2018-02-23 12:05:07 +0000)
>
> are available in the git repository at:
>
>   git://git.kraxel.org/qemu tags/ui-20180227-pull-request
>
> for you to fetch changes up to 8742dcaf7bcfa1ef8720f34dab984f153c87c9f3:
>
>   curses: build as ui module (2018-02-26 15:10:12 +0100)
>
> ----------------------------------------------------------------
> ui: add & use display registry, build some UIs as module.
>
> ----------------------------------------------------------------

Hi. This failed to build on my OpenBSD test box:

  CC      qga/guest-agent-command-state.o
In file included from /home/qemu/include/qemu/osdep.h:30:0,
                 from /home/qemu/qga/guest-agent-command-state.c:12:
./config-host.h:29:0: warning: "CONFIG_SDL" redefined
 #define CONFIG_SDL m
 ^
./config-host.h:17:0: note: this is the location of the previous definition
 #define CONFIG_SDL 1
 ^

(warning repeated for pretty much every object file)

and then linking of the final executables failed with

../audio/audio.o:(.data.rel.ro+0x0): undefined reference to `sdl_audio_driver'

thanks
-- PMM

  Hi,

> Hi. This failed to build on my OpenBSD test box:
> 
>   CC      qga/guest-agent-command-state.o
> In file included from /home/qemu/include/qemu/osdep.h:30:0,
>                  from /home/qemu/qga/guest-agent-command-state.c:12:
> ./config-host.h:29:0: warning: "CONFIG_SDL" redefined
>  #define CONFIG_SDL m
>  ^
> ./config-host.h:17:0: note: this is the location of the previous definition
>  #define CONFIG_SDL 1
>  ^
> 
> (warning repeated for pretty much every object file)
> 
> and then linking of the final executables failed with
> 
> ../audio/audio.o:(.data.rel.ro+0x0): undefined reference to `sdl_audio_driver'

Oh, right, there is sdl audio, completely forgot about that ...

(this probably triggers on openbsd because sdl audio is the default
there).

I think modularizing SDL isn't that easy then.
Can you just drop the "sdl: build as ui module" patch?

cheers,
  Gerd

On 28 February 2018 at 06:26, Gerd Hoffmann <kraxel@redhat.com> wrote:
>   Hi,
>
>> Hi. This failed to build on my OpenBSD test box:
>>
>>   CC      qga/guest-agent-command-state.o
>> In file included from /home/qemu/include/qemu/osdep.h:30:0,
>>                  from /home/qemu/qga/guest-agent-command-state.c:12:
>> ./config-host.h:29:0: warning: "CONFIG_SDL" redefined
>>  #define CONFIG_SDL m
>>  ^
>> ./config-host.h:17:0: note: this is the location of the previous definition
>>  #define CONFIG_SDL 1
>>  ^
>>
>> (warning repeated for pretty much every object file)
>>
>> and then linking of the final executables failed with
>>
>> ../audio/audio.o:(.data.rel.ro+0x0): undefined reference to `sdl_audio_driver'
>
> Oh, right, there is sdl audio, completely forgot about that ...
>
> (this probably triggers on openbsd because sdl audio is the default
> there).
>
> I think modularizing SDL isn't that easy then.
> Can you just drop the "sdl: build as ui module" patch?

I can't drop patches from signed pull requests -- you need
to respin it.

thanks
-- PMM

> > I think modularizing SDL isn't that easy then.
> > Can you just drop the "sdl: build as ui module" patch?
> 
> I can't drop patches from signed pull requests -- you need
> to respin it.

Ah, right, that would invalidate the signature.  Pull resent.

cheers,
  Gerd