s390x/sclp: remove duplicate MAX_AVAIL_SLOTS define

[Qemu-devel] [PATCH] s390x/sclp: remove duplicate MAX_AVAIL_SLOTS define

Cornelia Huck posted 1 patch 7 years, 8 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180223095406.18251-1-cohuck@redhat.com

Test checkpatch passed

Test docker-build@min-glib passed

Test docker-mingw@fedora passed

Test docker-quick@centos6 passed

Test ppcbe passed

Test ppcle passed

Test s390x passed

include/hw/s390x/sclp.h | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] s390x/sclp: remove duplicate MAX_AVAIL_SLOTS define

Posted by Cornelia Huck 7 years, 8 months ago

It's already defined in cpu.h (to the same value) and not used in
the sclp code.

Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 include/hw/s390x/sclp.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h
index 476cbf78f2..f9db243484 100644
--- a/include/hw/s390x/sclp.h
+++ b/include/hw/s390x/sclp.h
@@ -35,7 +35,6 @@
 #define SCLP_FC_ASSIGN_ATTACH_READ_STOR         0xE00000000000ULL
 #define SCLP_STARTING_SUBINCREMENT_ID           0x10001
 #define SCLP_INCREMENT_UNIT                     0x10000
-#define MAX_AVAIL_SLOTS                         32
 #define MAX_STORAGE_INCREMENTS                  1020
 
 /* CPU hotplug SCLP codes */
-- 
2.13.6

Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x/sclp: remove duplicate MAX_AVAIL_SLOTS define

Posted by Christian Borntraeger 7 years, 8 months ago


On 02/23/2018 10:54 AM, Cornelia Huck wrote:
> It's already defined in cpu.h (to the same value) and not used in
> the sclp code.
> 
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
>  include/hw/s390x/sclp.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h
> index 476cbf78f2..f9db243484 100644
> --- a/include/hw/s390x/sclp.h
> +++ b/include/hw/s390x/sclp.h
> @@ -35,7 +35,6 @@
>  #define SCLP_FC_ASSIGN_ATTACH_READ_STOR         0xE00000000000ULL
>  #define SCLP_STARTING_SUBINCREMENT_ID           0x10001
>  #define SCLP_INCREMENT_UNIT                     0x10000
> -#define MAX_AVAIL_SLOTS                         32
>  #define MAX_STORAGE_INCREMENTS                  1020
> 
>  /* CPU hotplug SCLP codes */
> 
Do we need this define and s390_get_memslot_count at all after removing
the hotplug code?

Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x/sclp: remove duplicate MAX_AVAIL_SLOTS define

Posted by Cornelia Huck 7 years, 8 months ago

On Fri, 23 Feb 2018 11:02:15 +0100
Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> On 02/23/2018 10:54 AM, Cornelia Huck wrote:
> > It's already defined in cpu.h (to the same value) and not used in
> > the sclp code.
> > 
> > Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> > ---
> >  include/hw/s390x/sclp.h | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h
> > index 476cbf78f2..f9db243484 100644
> > --- a/include/hw/s390x/sclp.h
> > +++ b/include/hw/s390x/sclp.h
> > @@ -35,7 +35,6 @@
> >  #define SCLP_FC_ASSIGN_ATTACH_READ_STOR         0xE00000000000ULL
> >  #define SCLP_STARTING_SUBINCREMENT_ID           0x10001
> >  #define SCLP_INCREMENT_UNIT                     0x10000
> > -#define MAX_AVAIL_SLOTS                         32
> >  #define MAX_STORAGE_INCREMENTS                  1020
> > 
> >  /* CPU hotplug SCLP codes */
> >   
> Do we need this define and s390_get_memslot_count at all after removing
> the hotplug code?
> 

Indeed. Let's kill it with fire :)